From mboxrd@z Thu Jan 1 00:00:00 1970 From: Russell King - ARM Linux Subject: Re: [PATCH v3 03/10] drm/imx: atomic phase 1: Use transitional atomic CRTC and plane helpers Date: Sat, 13 Aug 2016 11:45:31 +0100 Message-ID: <20160813104531.GA4844@n2100.armlinux.org.uk> References: <1467618039-7457-1-git-send-email-gnuiyl@gmail.com> <1467618039-7457-4-git-send-email-gnuiyl@gmail.com> <20160813101154.GA3864@n2100.armlinux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:3201:214:fdff:fe10:1be6]) by gabe.freedesktop.org (Postfix) with ESMTPS id EE0D66E0DE for ; Sat, 13 Aug 2016 10:45:40 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20160813101154.GA3864@n2100.armlinux.org.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Liu Ying Cc: Daniel Vetter , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gU2F0LCBBdWcgMTMsIDIwMTYgYXQgMTE6MTE6NTRBTSArMDEwMCwgUnVzc2VsbCBLaW5nIC0g QVJNIExpbnV4IHdyb3RlOgo+IE9uIE1vbiwgSnVsIDA0LCAyMDE2IGF0IDAzOjQwOjMyUE0gKzA4 MDAsIExpdSBZaW5nIHdyb3RlOgo+ID4gVXNlIHRoZSBkcm1fcGxhbmVfaGVscGVyX3VwZGF0ZS9k aXNhYmxlKCkgYW5kIGRybV9oZWxwZXJfY3J0Y19tb2RlX3NldCgpCj4gPiB0cmFuc2l0aW9uYWwg YXRvbWljIGhlbHBlcnMuICBUaGUgY3J0Yy0+bW9kZV9zZXRfbm9mYiBjYWxsYmFjayBpcyBhZGRl ZAo+ID4gc28gdGhhdCB0aGUgcHJpbWFyeSBwbGFuZSBpcyBubyBsb25nZXIgdGllZCB0byB0aGUg Q1JUQy4gIENoZWNrL3VwZGF0ZQo+ID4gbG9naWNzIGFyZSBzZXBhcmF0ZWQgdG8gbWFrZSBzdXJl IGNydGMtPm1vZGVfc2V0X25vZmIgYW5kIHBsYW5lLT5hdG9taWNfdXBkYXRlCj4gPiBhcmUgYWx3 YXlzIHN1Y2Nlc3NmdWwuICBBbHNvLCBzb21lIG5lY2Vzc2FyeSBsb2dpY3MgYXJlIHR3ZWFrZWQg Zm9yIGEgc21vb3RoCj4gPiB0cmFuc2l0aW9uLgo+ID4gCj4gPiBTaWduZWQtb2ZmLWJ5OiBMaXUg WWluZyA8Z251aXlsQGdtYWlsLmNvbT4KPiAKPiBUaGlzIHBhdGNoIGNhdXNlcyBhIHJlZ3Jlc3Np b24gd2l0aCBteSB4b3JnIGRkeCBkcml2ZXI6Cj4gCj4gWyAgICAyOS44NTBdIChFRSkgYXJtYWRh KDApOiBbZHJtXSBmYWlsZWQgdG8gc2V0IG1vZGUgb24gY3J0YyAyNDogSW52YWxpZCBhcmd1bWVu dAo+IAo+IEknbSBub3Qgc3VyZSB3aHkgKHlldCkuCgpIaSwKCkVuYWJsaW5nIERSTSBkZWJ1Z2dp bmcgZG9lc24ndCBzZWVtIHRvIHByb3ZpZGUgbXVjaCBpbiB0aGUgd2F5IG9mIGNsdWVzOgoKW2Ry bTpkcm1faW9jdGxdIHBpZD0xMDE1LCBkZXY9MHhlMjAwLCBhdXRoPTEsIERSTV9JT0NUTF9NT0RF X1NFVENSVEMKW2RybTpkcm1fbW9kZV9zZXRjcnRjXSBbQ1JUQzoyNDpjcnRjLTBdCltkcm06ZHJt X21vZGVfc2V0Y3J0Y10gW0NPTk5FQ1RPUjozNDpIRE1JLUEtMV0KW2RybTpkcm1fY3J0Y19oZWxw ZXJfc2V0X2NvbmZpZ10KW2RybTpkcm1fY3J0Y19oZWxwZXJfc2V0X2NvbmZpZ10gW0NSVEM6MjQ6 Y3J0Yy0wXSBbRkI6NDhdICNjb25uZWN0b3JzPTEgKHggeSkgKDAgMCkKW2RybTpkcm1fY3J0Y19o ZWxwZXJfc2V0X2NvbmZpZ10gW0NPTk5FQ1RPUjozNDpIRE1JLUEtMV0gdG8gW0NSVEM6MjQ6Y3J0 Yy0wXQpbZHJtOmRybV9jcnRjX2hlbHBlcl9zZXRfY29uZmlnXSBhdHRlbXB0aW5nIHRvIHNldCBt b2RlIGZyb20gdXNlcnNwYWNlCltkcm06ZHJtX21vZGVfZGVidWdfcHJpbnRtb2RlbGluZV0gTW9k ZWxpbmUgNDk6IjE5MjB4MTA4MCIgMCAxNDg1MDAgMTkyMCAyNDQ4IDI0OTIgMjY0MCAxMDgwIDEw ODQgMTA4OSAxMTI1IDB4MCAweDUKW2RybTpkcm1fY3J0Y19oZWxwZXJfc2V0X21vZGVdIFtDUlRD OjI0OmNydGMtMF0KW2RybTpkcm1fdmJsYW5rX29mZl0gY3J0YyAwLCB2YmxhbmsgZW5hYmxlZCAw LCBpbm1vZGVzZXQgMApbZHJtOmRybV91cGRhdGVfdmJsYW5rX2NvdW50XSB1cGRhdGluZyB2Ymxh bmsgY291bnQgb24gY3J0YyAwOiBjdXJyZW50PTIsIGRpZmY9MCwgaHc9MCBod19sYXN0PTAKW2Ry bTpkcm1fbW9kZV9vYmplY3RfcmVmZXJlbmNlXSBPQkogSUQ6IDUxICgxKQpbZHJtOmRybV9tb2Rl X29iamVjdF91bnJlZmVyZW5jZV0gT0JKIElEOiA1MSAoMikKW2RybTpkcm1fYXRvbWljX3NldF9t b2RlX2Zvcl9jcnRjXSBTZXQgW01PREU6MTkyMHgxMDgwXSBmb3IgQ1JUQyBzdGF0ZSBlZDgxZWUw MApbZHJtOmRybV9tb2RlX29iamVjdF9yZWZlcmVuY2VdIE9CSiBJRDogNDcgKDMpCltkcm06ZHJt X21vZGVfb2JqZWN0X3VucmVmZXJlbmNlXSBPQkogSUQ6IDQ3ICg0KQpbZHJtOmRybV9tb2RlX29i amVjdF9yZWZlcmVuY2VdIE9CSiBJRDogNDggKDIpCltkcm06ZHJtX2F0b21pY19zZXRfZmJfZm9y X3BsYW5lXSBTZXQgW0ZCOjQ4XSBmb3IgcGxhbmUgc3RhdGUgZWQ2MzJkMDAKW2RybTpkcm1fbW9k ZV9vYmplY3RfdW5yZWZlcmVuY2VdIE9CSiBJRDogNDggKDMpCltkcm06ZHJtX21vZGVfb2JqZWN0 X3VucmVmZXJlbmNlXSBPQkogSUQ6IDUxICgxKQpbZHJtOmRybV9jcnRjX2hlbHBlcl9zZXRfY29u ZmlnXSAqRVJST1IqIGZhaWxlZCB0byBzZXQgbW9kZSBvbiBbQ1JUQzoyNDpjcnRjLTBdCltkcm06 ZHJtX2NydGNfaGVscGVyX3NldF9tb2RlXSBbQ1JUQzoyNDpjcnRjLTBdCltkcm06ZHJtX21vZGVf b2JqZWN0X3JlZmVyZW5jZV0gT0JKIElEOiA1MiAoMSkKW2RybTpkcm1fbW9kZV9vYmplY3RfdW5y ZWZlcmVuY2VdIE9CSiBJRDogNTIgKDIpCltkcm06ZHJtX2F0b21pY19zZXRfbW9kZV9mb3JfY3J0 Y10gU2V0IFtNT0RFOjE5MjB4MTA4MF0gZm9yIENSVEMgc3RhdGUgZWQ4MWY2MDAKW2RybTpkcm1f bW9kZV9vYmplY3RfcmVmZXJlbmNlXSBPQkogSUQ6IDQ3ICgzKQpbZHJtOmRybV9tb2RlX29iamVj dF91bnJlZmVyZW5jZV0gT0JKIElEOiA0NyAoNCkKW2RybTpkcm1fbW9kZV9vYmplY3RfcmVmZXJl bmNlXSBPQkogSUQ6IDQ3ICgzKQpbZHJtOmRybV9hdG9taWNfc2V0X2ZiX2Zvcl9wbGFuZV0gU2V0 IFtGQjo0N10gZm9yIHBsYW5lIHN0YXRlIGVkNjMyZDAwCltkcm06ZHJtX21vZGVfb2JqZWN0X3Vu cmVmZXJlbmNlXSBPQkogSUQ6IDQ3ICg0KQpbZHJtOmRybV9tb2RlX29iamVjdF91bnJlZmVyZW5j ZV0gT0JKIElEOiA1MiAoMSkKW2RybTpkcm1fY3J0Y19oZWxwZXJfc2V0X21vZGVdIFtFTkNPREVS OjMzOlRNRFMtMzNdIHNldCBbTU9ERTo0NjoxOTIweDEwODBdCltkcm06ZHJtX3ZibGFua19vbl0g Y3J0YyAwLCB2YmxhbmsgZW5hYmxlZCAwLCBpbm1vZGVzZXQgMQpbZHJtOmRybV9jYWxjX3RpbWVz dGFtcGluZ19jb25zdGFudHNdIGNydGMgMjQ6IGh3bW9kZTogaHRvdGFsIDI2NDAsIHZ0b3RhbCAx MTI1LCB2ZGlzcGxheSAxMDgwCltkcm06ZHJtX2NhbGNfdGltZXN0YW1waW5nX2NvbnN0YW50c10g Y3J0YyAyNDogY2xvY2sgMTQ4NTAwIGtIeiBmcmFtZWR1ciAyMDAwMDAwMCBsaW5lZHVyIDE3Nzc3 Cltkcm06ZHJtX21vZGVfb2JqZWN0X3JlZmVyZW5jZV0gT0JKIElEOiA0NyAoMykKW2RybTpkcm1f bW9kZV9vYmplY3RfdW5yZWZlcmVuY2VdIE9CSiBJRDogNDcgKDQpCltkcm06ZHJtX21vZGVfb2Jq ZWN0X3VucmVmZXJlbmNlXSBPQkogSUQ6IDQ4ICgyKQpbZHJtOmRybV9tb2RlX29iamVjdF91bnJl ZmVyZW5jZV0gT0JKIElEOiAzNCAoNCkKW2RybTpkcm1faW9jdGxdIHJldCA9IC0yMgoKV2l0aCBh IGJpdCBtb3JlIGRlYnVnZ2luZywgdGhpcyBpcyB3aGF0J3MgZmFpbGluZzoKCmlwdV9wbGFuZV9h dG9taWNfY2hlY2s6NDQyOiBmYWlsCltkcm06ZHJtX2NydGNfaGVscGVyX3NldF9jb25maWddICpF UlJPUiogZmFpbGVkIHRvIHNldCBtb2RlIG9uIFtDUlRDOjI0OmNydGMtMF0KCiAgICAgICAgaWYg KG9sZF9mYiAmJiAoc3RhdGUtPnNyY193ICE9IG9sZF9zdGF0ZS0+c3JjX3cgfHwKICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgc3RhdGUtPnNyY19oICE9IG9sZF9zdGF0ZS0+c3JjX2ggfHwK ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZmItPnBpeGVsX2Zvcm1hdCAhPSBvbGRfZmIt PnBpeGVsX2Zvcm1hdCkpIHsKICAgICAgICAgICAgICAgIHByaW50aygiJXM6JWQ6IGZhaWxcbiIs IF9fZnVuY19fLCBfX0xJTkVfXyk7CiAgICAgICAgICAgICAgICByZXR1cm4gLUVJTlZBTDsKICAg ICAgICB9CgpUaGlzIHRlc3QgaXMgc3R1cGlkIGFzIGl0IHN0YW5kcyAtIGl0IG1lYW5zIHdlIGNh biBfbmV2ZXJfIGNoYW5nZSB0aGUKZm9ybWF0IG9yIHNpemUgb2YgX2FueV8gcGxhbmUsIHNvbWV0 aGluZyB0aGF0IHRoZSBvbGQgY29kZSBhbGxvd2VkOgoKLSAgICAgICBpZiAoaXB1X3BsYW5lLT5l bmFibGVkKSB7Ci0gICAgICAgICAgICAgICBpZiAoc3JjX3cgIT0gaXB1X3BsYW5lLT53IHx8IHNy Y19oICE9IGlwdV9wbGFuZS0+aCB8fAotICAgICAgICAgICAgICAgICAgIGZiLT5waXhlbF9mb3Jt YXQgIT0gaXB1X3BsYW5lLT5iYXNlLmZiLT5waXhlbF9mb3JtYXQpCi0gICAgICAgICAgICAgICAg ICAgICAgIHJldHVybiAtRUlOVkFMOwoKVGhpcyB1c2VkIHRvIHdvcmsgYmVjYXVzZSB3ZSdkIGNh bGwgaXB1X2NydGNfcHJlcGFyZSgpLT5pcHVfZmJfZGlzYWJsZSgpCmJlZm9yZSB0aGUgbW9kZSBz ZXQsIHdoaWNoIHdvdWxkIGNsZWFyIGlwdV9wbGFuZS0+ZW5hYmxlZCwgY2F1c2luZyB0aGlzCnRl c3QgdG8gYmUgc2tpcHBlZC4gIEhvd2V2ZXIsIGluIHRoZSBuZXcgY29kZSwgd2UgbWVyZWx5IHRl c3QgZm9yIHRoZQpwcmVzZW5jZSBvZiB0aGUgcHJldmlvdXMgZnJhbWVidWZmZXIsIHdoaWNoIGlz IHJlYWxseSBub3QgdGhlIHNhbWUgdGhpbmcKYXQgYWxsLgoKVGhlIG9sZCBmdW5jdGlvbmFsaXR5 IG5lZWRzIHRvIGJlIHJlc3RvcmVkIGJlY2F1c2Ugc2lnbmlmaWNhbnRseQpjaGFuZ2luZyB0aGUg ZGlzcGxheWVkIG1vZGUgaXMgc29tZXRoaW5nIHdoaWNoIG11c3QgYmUgc3VwcG9ydGVkIHdpdGgK SERNSS4KClRoYW5rcy4KCi0tIApSTUsncyBQYXRjaCBzeXN0ZW06IGh0dHA6Ly93d3cuYXJtbGlu dXgub3JnLnVrL2RldmVsb3Blci9wYXRjaGVzLwpGVFRDIGJyb2FkYmFuZCBmb3IgMC44bWlsZSBs aW5lOiBjdXJyZW50bHkgYXQgOS42TWJwcyBkb3duIDQwMGticHMgdXAKYWNjb3JkaW5nIHRvIHNw ZWVkdGVzdC5uZXQuCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9y ZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZl bAo=