From mboxrd@z Thu Jan 1 00:00:00 1970 From: Russell King - ARM Linux Subject: Re: [PATCH v3 03/10] drm/imx: atomic phase 1: Use transitional atomic CRTC and plane helpers Date: Sat, 13 Aug 2016 12:29:47 +0100 Message-ID: <20160813112947.GA6718@n2100.armlinux.org.uk> References: <1467618039-7457-1-git-send-email-gnuiyl@gmail.com> <1467618039-7457-4-git-send-email-gnuiyl@gmail.com> <20160813101154.GA3864@n2100.armlinux.org.uk> <20160813104531.GA4844@n2100.armlinux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:3201:214:fdff:fe10:1be6]) by gabe.freedesktop.org (Postfix) with ESMTPS id 464BC6E011 for ; Sat, 13 Aug 2016 11:29:56 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20160813104531.GA4844@n2100.armlinux.org.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Liu Ying Cc: Daniel Vetter , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gU2F0LCBBdWcgMTMsIDIwMTYgYXQgMTE6NDU6MzFBTSArMDEwMCwgUnVzc2VsbCBLaW5nIC0g QVJNIExpbnV4IHdyb3RlOgo+IE9uIFNhdCwgQXVnIDEzLCAyMDE2IGF0IDExOjExOjU0QU0gKzAx MDAsIFJ1c3NlbGwgS2luZyAtIEFSTSBMaW51eCB3cm90ZToKPiA+IE9uIE1vbiwgSnVsIDA0LCAy MDE2IGF0IDAzOjQwOjMyUE0gKzA4MDAsIExpdSBZaW5nIHdyb3RlOgo+ID4gPiBVc2UgdGhlIGRy bV9wbGFuZV9oZWxwZXJfdXBkYXRlL2Rpc2FibGUoKSBhbmQgZHJtX2hlbHBlcl9jcnRjX21vZGVf c2V0KCkKPiA+ID4gdHJhbnNpdGlvbmFsIGF0b21pYyBoZWxwZXJzLiAgVGhlIGNydGMtPm1vZGVf c2V0X25vZmIgY2FsbGJhY2sgaXMgYWRkZWQKPiA+ID4gc28gdGhhdCB0aGUgcHJpbWFyeSBwbGFu ZSBpcyBubyBsb25nZXIgdGllZCB0byB0aGUgQ1JUQy4gIENoZWNrL3VwZGF0ZQo+ID4gPiBsb2dp Y3MgYXJlIHNlcGFyYXRlZCB0byBtYWtlIHN1cmUgY3J0Yy0+bW9kZV9zZXRfbm9mYiBhbmQgcGxh bmUtPmF0b21pY191cGRhdGUKPiA+ID4gYXJlIGFsd2F5cyBzdWNjZXNzZnVsLiAgQWxzbywgc29t ZSBuZWNlc3NhcnkgbG9naWNzIGFyZSB0d2Vha2VkIGZvciBhIHNtb290aAo+ID4gPiB0cmFuc2l0 aW9uLgo+ID4gPiAKPiA+ID4gU2lnbmVkLW9mZi1ieTogTGl1IFlpbmcgPGdudWl5bEBnbWFpbC5j b20+Cj4gPiAKPiA+IFRoaXMgcGF0Y2ggY2F1c2VzIGEgcmVncmVzc2lvbiB3aXRoIG15IHhvcmcg ZGR4IGRyaXZlcjoKPiA+IAo+ID4gWyAgICAyOS44NTBdIChFRSkgYXJtYWRhKDApOiBbZHJtXSBm YWlsZWQgdG8gc2V0IG1vZGUgb24gY3J0YyAyNDogSW52YWxpZCBhcmd1bWVudAo+ID4gCj4gPiBJ J20gbm90IHN1cmUgd2h5ICh5ZXQpLgo+IAo+IEhpLAo+IAo+IEVuYWJsaW5nIERSTSBkZWJ1Z2dp bmcgZG9lc24ndCBzZWVtIHRvIHByb3ZpZGUgbXVjaCBpbiB0aGUgd2F5IG9mIGNsdWVzOgo+IAo+ IFtkcm06ZHJtX2lvY3RsXSBwaWQ9MTAxNSwgZGV2PTB4ZTIwMCwgYXV0aD0xLCBEUk1fSU9DVExf TU9ERV9TRVRDUlRDCj4gW2RybTpkcm1fbW9kZV9zZXRjcnRjXSBbQ1JUQzoyNDpjcnRjLTBdCj4g W2RybTpkcm1fbW9kZV9zZXRjcnRjXSBbQ09OTkVDVE9SOjM0OkhETUktQS0xXQo+IFtkcm06ZHJt X2NydGNfaGVscGVyX3NldF9jb25maWddCj4gW2RybTpkcm1fY3J0Y19oZWxwZXJfc2V0X2NvbmZp Z10gW0NSVEM6MjQ6Y3J0Yy0wXSBbRkI6NDhdICNjb25uZWN0b3JzPTEgKHggeSkgKDAgMCkKPiBb ZHJtOmRybV9jcnRjX2hlbHBlcl9zZXRfY29uZmlnXSBbQ09OTkVDVE9SOjM0OkhETUktQS0xXSB0 byBbQ1JUQzoyNDpjcnRjLTBdCj4gW2RybTpkcm1fY3J0Y19oZWxwZXJfc2V0X2NvbmZpZ10gYXR0 ZW1wdGluZyB0byBzZXQgbW9kZSBmcm9tIHVzZXJzcGFjZQo+IFtkcm06ZHJtX21vZGVfZGVidWdf cHJpbnRtb2RlbGluZV0gTW9kZWxpbmUgNDk6IjE5MjB4MTA4MCIgMCAxNDg1MDAgMTkyMCAyNDQ4 IDI0OTIgMjY0MCAxMDgwIDEwODQgMTA4OSAxMTI1IDB4MCAweDUKPiBbZHJtOmRybV9jcnRjX2hl bHBlcl9zZXRfbW9kZV0gW0NSVEM6MjQ6Y3J0Yy0wXQo+IFtkcm06ZHJtX3ZibGFua19vZmZdIGNy dGMgMCwgdmJsYW5rIGVuYWJsZWQgMCwgaW5tb2Rlc2V0IDAKPiBbZHJtOmRybV91cGRhdGVfdmJs YW5rX2NvdW50XSB1cGRhdGluZyB2YmxhbmsgY291bnQgb24gY3J0YyAwOiBjdXJyZW50PTIsIGRp ZmY9MCwgaHc9MCBod19sYXN0PTAKPiBbZHJtOmRybV9tb2RlX29iamVjdF9yZWZlcmVuY2VdIE9C SiBJRDogNTEgKDEpCj4gW2RybTpkcm1fbW9kZV9vYmplY3RfdW5yZWZlcmVuY2VdIE9CSiBJRDog NTEgKDIpCj4gW2RybTpkcm1fYXRvbWljX3NldF9tb2RlX2Zvcl9jcnRjXSBTZXQgW01PREU6MTky MHgxMDgwXSBmb3IgQ1JUQyBzdGF0ZSBlZDgxZWUwMAo+IFtkcm06ZHJtX21vZGVfb2JqZWN0X3Jl ZmVyZW5jZV0gT0JKIElEOiA0NyAoMykKPiBbZHJtOmRybV9tb2RlX29iamVjdF91bnJlZmVyZW5j ZV0gT0JKIElEOiA0NyAoNCkKPiBbZHJtOmRybV9tb2RlX29iamVjdF9yZWZlcmVuY2VdIE9CSiBJ RDogNDggKDIpCj4gW2RybTpkcm1fYXRvbWljX3NldF9mYl9mb3JfcGxhbmVdIFNldCBbRkI6NDhd IGZvciBwbGFuZSBzdGF0ZSBlZDYzMmQwMAo+IFtkcm06ZHJtX21vZGVfb2JqZWN0X3VucmVmZXJl bmNlXSBPQkogSUQ6IDQ4ICgzKQo+IFtkcm06ZHJtX21vZGVfb2JqZWN0X3VucmVmZXJlbmNlXSBP QkogSUQ6IDUxICgxKQo+IFtkcm06ZHJtX2NydGNfaGVscGVyX3NldF9jb25maWddICpFUlJPUiog ZmFpbGVkIHRvIHNldCBtb2RlIG9uIFtDUlRDOjI0OmNydGMtMF0KPiBbZHJtOmRybV9jcnRjX2hl bHBlcl9zZXRfbW9kZV0gW0NSVEM6MjQ6Y3J0Yy0wXQo+IFtkcm06ZHJtX21vZGVfb2JqZWN0X3Jl ZmVyZW5jZV0gT0JKIElEOiA1MiAoMSkKPiBbZHJtOmRybV9tb2RlX29iamVjdF91bnJlZmVyZW5j ZV0gT0JKIElEOiA1MiAoMikKPiBbZHJtOmRybV9hdG9taWNfc2V0X21vZGVfZm9yX2NydGNdIFNl dCBbTU9ERToxOTIweDEwODBdIGZvciBDUlRDIHN0YXRlIGVkODFmNjAwCj4gW2RybTpkcm1fbW9k ZV9vYmplY3RfcmVmZXJlbmNlXSBPQkogSUQ6IDQ3ICgzKQo+IFtkcm06ZHJtX21vZGVfb2JqZWN0 X3VucmVmZXJlbmNlXSBPQkogSUQ6IDQ3ICg0KQo+IFtkcm06ZHJtX21vZGVfb2JqZWN0X3JlZmVy ZW5jZV0gT0JKIElEOiA0NyAoMykKPiBbZHJtOmRybV9hdG9taWNfc2V0X2ZiX2Zvcl9wbGFuZV0g U2V0IFtGQjo0N10gZm9yIHBsYW5lIHN0YXRlIGVkNjMyZDAwCj4gW2RybTpkcm1fbW9kZV9vYmpl Y3RfdW5yZWZlcmVuY2VdIE9CSiBJRDogNDcgKDQpCj4gW2RybTpkcm1fbW9kZV9vYmplY3RfdW5y ZWZlcmVuY2VdIE9CSiBJRDogNTIgKDEpCj4gW2RybTpkcm1fY3J0Y19oZWxwZXJfc2V0X21vZGVd IFtFTkNPREVSOjMzOlRNRFMtMzNdIHNldCBbTU9ERTo0NjoxOTIweDEwODBdCj4gW2RybTpkcm1f dmJsYW5rX29uXSBjcnRjIDAsIHZibGFuayBlbmFibGVkIDAsIGlubW9kZXNldCAxCj4gW2RybTpk cm1fY2FsY190aW1lc3RhbXBpbmdfY29uc3RhbnRzXSBjcnRjIDI0OiBod21vZGU6IGh0b3RhbCAy NjQwLCB2dG90YWwgMTEyNSwgdmRpc3BsYXkgMTA4MAo+IFtkcm06ZHJtX2NhbGNfdGltZXN0YW1w aW5nX2NvbnN0YW50c10gY3J0YyAyNDogY2xvY2sgMTQ4NTAwIGtIeiBmcmFtZWR1ciAyMDAwMDAw MCBsaW5lZHVyIDE3Nzc3Cj4gW2RybTpkcm1fbW9kZV9vYmplY3RfcmVmZXJlbmNlXSBPQkogSUQ6 IDQ3ICgzKQo+IFtkcm06ZHJtX21vZGVfb2JqZWN0X3VucmVmZXJlbmNlXSBPQkogSUQ6IDQ3ICg0 KQo+IFtkcm06ZHJtX21vZGVfb2JqZWN0X3VucmVmZXJlbmNlXSBPQkogSUQ6IDQ4ICgyKQo+IFtk cm06ZHJtX21vZGVfb2JqZWN0X3VucmVmZXJlbmNlXSBPQkogSUQ6IDM0ICg0KQo+IFtkcm06ZHJt X2lvY3RsXSByZXQgPSAtMjIKPiAKPiBXaXRoIGEgYml0IG1vcmUgZGVidWdnaW5nLCB0aGlzIGlz IHdoYXQncyBmYWlsaW5nOgo+IAo+IGlwdV9wbGFuZV9hdG9taWNfY2hlY2s6NDQyOiBmYWlsCj4g W2RybTpkcm1fY3J0Y19oZWxwZXJfc2V0X2NvbmZpZ10gKkVSUk9SKiBmYWlsZWQgdG8gc2V0IG1v ZGUgb24gW0NSVEM6MjQ6Y3J0Yy0wXQo+IAo+ICAgICAgICAgaWYgKG9sZF9mYiAmJiAoc3RhdGUt PnNyY193ICE9IG9sZF9zdGF0ZS0+c3JjX3cgfHwKPiAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICBzdGF0ZS0+c3JjX2ggIT0gb2xkX3N0YXRlLT5zcmNfaCB8fAo+ICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIGZiLT5waXhlbF9mb3JtYXQgIT0gb2xkX2ZiLT5waXhlbF9mb3JtYXQp KSB7Cj4gICAgICAgICAgICAgICAgIHByaW50aygiJXM6JWQ6IGZhaWxcbiIsIF9fZnVuY19fLCBf X0xJTkVfXyk7Cj4gICAgICAgICAgICAgICAgIHJldHVybiAtRUlOVkFMOwo+ICAgICAgICAgfQo+ IAo+IFRoaXMgdGVzdCBpcyBzdHVwaWQgYXMgaXQgc3RhbmRzIC0gaXQgbWVhbnMgd2UgY2FuIF9u ZXZlcl8gY2hhbmdlIHRoZQo+IGZvcm1hdCBvciBzaXplIG9mIF9hbnlfIHBsYW5lLCBzb21ldGhp bmcgdGhhdCB0aGUgb2xkIGNvZGUgYWxsb3dlZDoKPiAKPiAtICAgICAgIGlmIChpcHVfcGxhbmUt PmVuYWJsZWQpIHsKPiAtICAgICAgICAgICAgICAgaWYgKHNyY193ICE9IGlwdV9wbGFuZS0+dyB8 fCBzcmNfaCAhPSBpcHVfcGxhbmUtPmggfHwKPiAtICAgICAgICAgICAgICAgICAgIGZiLT5waXhl bF9mb3JtYXQgIT0gaXB1X3BsYW5lLT5iYXNlLmZiLT5waXhlbF9mb3JtYXQpCj4gLSAgICAgICAg ICAgICAgICAgICAgICAgcmV0dXJuIC1FSU5WQUw7Cj4gCj4gVGhpcyB1c2VkIHRvIHdvcmsgYmVj YXVzZSB3ZSdkIGNhbGwgaXB1X2NydGNfcHJlcGFyZSgpLT5pcHVfZmJfZGlzYWJsZSgpCj4gYmVm b3JlIHRoZSBtb2RlIHNldCwgd2hpY2ggd291bGQgY2xlYXIgaXB1X3BsYW5lLT5lbmFibGVkLCBj YXVzaW5nIHRoaXMKPiB0ZXN0IHRvIGJlIHNraXBwZWQuICBIb3dldmVyLCBpbiB0aGUgbmV3IGNv ZGUsIHdlIG1lcmVseSB0ZXN0IGZvciB0aGUKPiBwcmVzZW5jZSBvZiB0aGUgcHJldmlvdXMgZnJh bWVidWZmZXIsIHdoaWNoIGlzIHJlYWxseSBub3QgdGhlIHNhbWUgdGhpbmcKPiBhdCBhbGwuCj4g Cj4gVGhlIG9sZCBmdW5jdGlvbmFsaXR5IG5lZWRzIHRvIGJlIHJlc3RvcmVkIGJlY2F1c2Ugc2ln bmlmaWNhbnRseQo+IGNoYW5naW5nIHRoZSBkaXNwbGF5ZWQgbW9kZSBpcyBzb21ldGhpbmcgd2hp Y2ggbXVzdCBiZSBzdXBwb3J0ZWQgd2l0aAo+IEhETUkuCgpCeXBhc3NpbmcgdGhlIGFib3ZlIGNo ZWNrIGFsc28gc2hvd3MgdGhhdDoKCiAgICAgICAgaWYgKG9sZF9mYiAmJiBmYi0+cGl0Y2hlc1sw XSAhPSBvbGRfZmItPnBpdGNoZXNbMF0pIHsKICAgICAgICAgICAgICAgIHByaW50aygiJXM6JWQ6 IGZhaWxcbiIsIF9fZnVuY19fLCBfX0xJTkVfXyk7CiAgICAgICAgICAgICAgICByZXR1cm4gLUVJ TlZBTDsKICAgICAgICB9CgphbHNvIGZhaWxzLiAgRGlzYWJsaW5nIHRoaXMgYXMgd2VsbCByZXN1 bHRzIGluIGxvc3Mgb2Ygc3luYyBvbiB0aGUKSERNSSBkaXNwbGF5LCBhbHRob3VnaCB0aGUgbW9k ZSBzZXQgbm93IHN1Y2NlZWRzLgoKVGhlIG1vcmUgSSB0aGluayBhYm91dCB0aGlzLCB0aGUgbW9y ZSBJIGNvbWUgdG8gb25lIG9mIHR3byBwb3NzaWJsZQpjb25jbHVzaW9uczoKCjEuIFRoZXNlIGNo ZWNrcyB3ZXJlIG5vdCBhcHByb3ByaWF0ZSB3aXRoIHRoZSBvbGQgY29kZSBhcyB3ZSB3ZXJlCiAg IGFsd2F5cyBkaXNhYmxpbmcgdGhlIGRpc3BsYXkgY2hhbm5lbCBwcmlvciB0byBtYWtpbmcgY2hh bmdlcy4KCiAgIFdlIG5lZWQgYXRvbWljIG1vZGUgc2V0IHRvIHdvcmsgaW4gZXhhY3RseSB0aGUg c2FtZSB3YXkgYXMgdGhlCiAgIHByZXZpb3VzIGNvZGU6IGFzIGEgc2VyaWVzIG9mIGRpc2FibGUt bW9kaWZ5LWVuYWJsZSBzZXQgb2Ygc3RlcHMsCiAgIHNvIHRoYXQgd2UgZG9uJ3QgbmVlZCB0aGVz ZSByZXN0cmljdGl2ZSBhbmQgcmVncmVzc2lvbiBjYXVzaW5nCiAgIGNoZWNrcy4KCm9yCgoyLiBp bXgtZHJtIGhhcyB0aGVzZSBwYXJ0aWN1bGFyIHJlc3RyaWN0aW9ucyB3aGljaCBtYWtlIGl0IGlu YXBwcm9wcmlhdGUKICAgdG8gYmUgY29udmVydGVkIHRvIGF0b21pYyBtb2RlIHNldCwgYXMgd2Ug YWx3YXlzIG5lZWQgdG8gZ28gdGhyb3VnaAogICBhIGRpc2FibGUtbW9kaWZ5LWVuYWJsZSBzZXJp ZXMgb2Ygc3RlcHMgLSB3aGljaCBtZWFucyB0aGUgYXRvbWljCiAgIG1vZGUgc2V0IGNoYW5nZXMg Zm9yIGlteC1kcm0gbmVlZCB0byBiZSByZXZlcnRlZCBiYWNrIHRvIHRoaXMgcGF0Y2guCgpJJ20g cHJldHR5IHN1cmUgKDIpIGRvZXNuJ3QgcmVhbGx5IGFwcGx5LCBiZWNhdXNlIEkgc2VlIG5vIHJl YXNvbiB3aHkKd2UgY2FuJ3QgZGlzYWJsZSB0aGUgZGlzcGxheSBjaGFubmVsIHdoaWxlIHdlIHJl Y29uZmlndXJlIGl0LiAgVGhhdCwKdG8gbWUsIHNlZW1zIHRvIGJlIGFuIGVudGlyZWx5IHJlYXNv bmFibGUgdGhpbmcgdG8gZG8uCgotLSAKUk1LJ3MgUGF0Y2ggc3lzdGVtOiBodHRwOi8vd3d3LmFy bWxpbnV4Lm9yZy51ay9kZXZlbG9wZXIvcGF0Y2hlcy8KRlRUQyBicm9hZGJhbmQgZm9yIDAuOG1p bGUgbGluZTogY3VycmVudGx5IGF0IDkuNk1icHMgZG93biA0MDBrYnBzIHVwCmFjY29yZGluZyB0 byBzcGVlZHRlc3QubmV0LgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3Rv cC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmkt ZGV2ZWwK