From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH v3 03/10] drm/imx: atomic phase 1: Use transitional atomic CRTC and plane helpers Date: Sun, 14 Aug 2016 11:44:14 +0200 Message-ID: <20160814094413.GX6232@phenom.ffwll.local> References: <1467618039-7457-1-git-send-email-gnuiyl@gmail.com> <1467618039-7457-4-git-send-email-gnuiyl@gmail.com> <20160813101154.GA3864@n2100.armlinux.org.uk> <20160813104531.GA4844@n2100.armlinux.org.uk> <20160813112947.GA6718@n2100.armlinux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-x243.google.com (mail-wm0-x243.google.com [IPv6:2a00:1450:400c:c09::243]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2C4A96E05B for ; Sun, 14 Aug 2016 09:44:18 +0000 (UTC) Received: by mail-wm0-x243.google.com with SMTP id i138so5765415wmf.3 for ; Sun, 14 Aug 2016 02:44:18 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20160813112947.GA6718@n2100.armlinux.org.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Russell King - ARM Linux Cc: dri-devel@lists.freedesktop.org, Daniel Vetter List-Id: dri-devel@lists.freedesktop.org T24gU2F0LCBBdWcgMTMsIDIwMTYgYXQgMTI6Mjk6NDdQTSArMDEwMCwgUnVzc2VsbCBLaW5nIC0g QVJNIExpbnV4IHdyb3RlOgo+IE9uIFNhdCwgQXVnIDEzLCAyMDE2IGF0IDExOjQ1OjMxQU0gKzAx MDAsIFJ1c3NlbGwgS2luZyAtIEFSTSBMaW51eCB3cm90ZToKPiA+IE9uIFNhdCwgQXVnIDEzLCAy MDE2IGF0IDExOjExOjU0QU0gKzAxMDAsIFJ1c3NlbGwgS2luZyAtIEFSTSBMaW51eCB3cm90ZToK PiA+ID4gT24gTW9uLCBKdWwgMDQsIDIwMTYgYXQgMDM6NDA6MzJQTSArMDgwMCwgTGl1IFlpbmcg d3JvdGU6Cj4gPiA+ID4gVXNlIHRoZSBkcm1fcGxhbmVfaGVscGVyX3VwZGF0ZS9kaXNhYmxlKCkg YW5kIGRybV9oZWxwZXJfY3J0Y19tb2RlX3NldCgpCj4gPiA+ID4gdHJhbnNpdGlvbmFsIGF0b21p YyBoZWxwZXJzLiAgVGhlIGNydGMtPm1vZGVfc2V0X25vZmIgY2FsbGJhY2sgaXMgYWRkZWQKPiA+ ID4gPiBzbyB0aGF0IHRoZSBwcmltYXJ5IHBsYW5lIGlzIG5vIGxvbmdlciB0aWVkIHRvIHRoZSBD UlRDLiAgQ2hlY2svdXBkYXRlCj4gPiA+ID4gbG9naWNzIGFyZSBzZXBhcmF0ZWQgdG8gbWFrZSBz dXJlIGNydGMtPm1vZGVfc2V0X25vZmIgYW5kIHBsYW5lLT5hdG9taWNfdXBkYXRlCj4gPiA+ID4g YXJlIGFsd2F5cyBzdWNjZXNzZnVsLiAgQWxzbywgc29tZSBuZWNlc3NhcnkgbG9naWNzIGFyZSB0 d2Vha2VkIGZvciBhIHNtb290aAo+ID4gPiA+IHRyYW5zaXRpb24uCj4gPiA+ID4gCj4gPiA+ID4g U2lnbmVkLW9mZi1ieTogTGl1IFlpbmcgPGdudWl5bEBnbWFpbC5jb20+Cj4gPiA+IAo+ID4gPiBU aGlzIHBhdGNoIGNhdXNlcyBhIHJlZ3Jlc3Npb24gd2l0aCBteSB4b3JnIGRkeCBkcml2ZXI6Cj4g PiA+IAo+ID4gPiBbICAgIDI5Ljg1MF0gKEVFKSBhcm1hZGEoMCk6IFtkcm1dIGZhaWxlZCB0byBz ZXQgbW9kZSBvbiBjcnRjIDI0OiBJbnZhbGlkIGFyZ3VtZW50Cj4gPiA+IAo+ID4gPiBJJ20gbm90 IHN1cmUgd2h5ICh5ZXQpLgo+ID4gCj4gPiBIaSwKPiA+IAo+ID4gRW5hYmxpbmcgRFJNIGRlYnVn Z2luZyBkb2Vzbid0IHNlZW0gdG8gcHJvdmlkZSBtdWNoIGluIHRoZSB3YXkgb2YgY2x1ZXM6Cj4g PiAKPiA+IFtkcm06ZHJtX2lvY3RsXSBwaWQ9MTAxNSwgZGV2PTB4ZTIwMCwgYXV0aD0xLCBEUk1f SU9DVExfTU9ERV9TRVRDUlRDCj4gPiBbZHJtOmRybV9tb2RlX3NldGNydGNdIFtDUlRDOjI0OmNy dGMtMF0KPiA+IFtkcm06ZHJtX21vZGVfc2V0Y3J0Y10gW0NPTk5FQ1RPUjozNDpIRE1JLUEtMV0K PiA+IFtkcm06ZHJtX2NydGNfaGVscGVyX3NldF9jb25maWddCj4gPiBbZHJtOmRybV9jcnRjX2hl bHBlcl9zZXRfY29uZmlnXSBbQ1JUQzoyNDpjcnRjLTBdIFtGQjo0OF0gI2Nvbm5lY3RvcnM9MSAo eCB5KSAoMCAwKQo+ID4gW2RybTpkcm1fY3J0Y19oZWxwZXJfc2V0X2NvbmZpZ10gW0NPTk5FQ1RP UjozNDpIRE1JLUEtMV0gdG8gW0NSVEM6MjQ6Y3J0Yy0wXQo+ID4gW2RybTpkcm1fY3J0Y19oZWxw ZXJfc2V0X2NvbmZpZ10gYXR0ZW1wdGluZyB0byBzZXQgbW9kZSBmcm9tIHVzZXJzcGFjZQo+ID4g W2RybTpkcm1fbW9kZV9kZWJ1Z19wcmludG1vZGVsaW5lXSBNb2RlbGluZSA0OToiMTkyMHgxMDgw IiAwIDE0ODUwMCAxOTIwIDI0NDggMjQ5MiAyNjQwIDEwODAgMTA4NCAxMDg5IDExMjUgMHgwIDB4 NQo+ID4gW2RybTpkcm1fY3J0Y19oZWxwZXJfc2V0X21vZGVdIFtDUlRDOjI0OmNydGMtMF0KPiA+ IFtkcm06ZHJtX3ZibGFua19vZmZdIGNydGMgMCwgdmJsYW5rIGVuYWJsZWQgMCwgaW5tb2Rlc2V0 IDAKPiA+IFtkcm06ZHJtX3VwZGF0ZV92YmxhbmtfY291bnRdIHVwZGF0aW5nIHZibGFuayBjb3Vu dCBvbiBjcnRjIDA6IGN1cnJlbnQ9MiwgZGlmZj0wLCBodz0wIGh3X2xhc3Q9MAo+ID4gW2RybTpk cm1fbW9kZV9vYmplY3RfcmVmZXJlbmNlXSBPQkogSUQ6IDUxICgxKQo+ID4gW2RybTpkcm1fbW9k ZV9vYmplY3RfdW5yZWZlcmVuY2VdIE9CSiBJRDogNTEgKDIpCj4gPiBbZHJtOmRybV9hdG9taWNf c2V0X21vZGVfZm9yX2NydGNdIFNldCBbTU9ERToxOTIweDEwODBdIGZvciBDUlRDIHN0YXRlIGVk ODFlZTAwCj4gPiBbZHJtOmRybV9tb2RlX29iamVjdF9yZWZlcmVuY2VdIE9CSiBJRDogNDcgKDMp Cj4gPiBbZHJtOmRybV9tb2RlX29iamVjdF91bnJlZmVyZW5jZV0gT0JKIElEOiA0NyAoNCkKPiA+ IFtkcm06ZHJtX21vZGVfb2JqZWN0X3JlZmVyZW5jZV0gT0JKIElEOiA0OCAoMikKPiA+IFtkcm06 ZHJtX2F0b21pY19zZXRfZmJfZm9yX3BsYW5lXSBTZXQgW0ZCOjQ4XSBmb3IgcGxhbmUgc3RhdGUg ZWQ2MzJkMDAKPiA+IFtkcm06ZHJtX21vZGVfb2JqZWN0X3VucmVmZXJlbmNlXSBPQkogSUQ6IDQ4 ICgzKQo+ID4gW2RybTpkcm1fbW9kZV9vYmplY3RfdW5yZWZlcmVuY2VdIE9CSiBJRDogNTEgKDEp Cj4gPiBbZHJtOmRybV9jcnRjX2hlbHBlcl9zZXRfY29uZmlnXSAqRVJST1IqIGZhaWxlZCB0byBz ZXQgbW9kZSBvbiBbQ1JUQzoyNDpjcnRjLTBdCj4gPiBbZHJtOmRybV9jcnRjX2hlbHBlcl9zZXRf bW9kZV0gW0NSVEM6MjQ6Y3J0Yy0wXQo+ID4gW2RybTpkcm1fbW9kZV9vYmplY3RfcmVmZXJlbmNl XSBPQkogSUQ6IDUyICgxKQo+ID4gW2RybTpkcm1fbW9kZV9vYmplY3RfdW5yZWZlcmVuY2VdIE9C SiBJRDogNTIgKDIpCj4gPiBbZHJtOmRybV9hdG9taWNfc2V0X21vZGVfZm9yX2NydGNdIFNldCBb TU9ERToxOTIweDEwODBdIGZvciBDUlRDIHN0YXRlIGVkODFmNjAwCj4gPiBbZHJtOmRybV9tb2Rl X29iamVjdF9yZWZlcmVuY2VdIE9CSiBJRDogNDcgKDMpCj4gPiBbZHJtOmRybV9tb2RlX29iamVj dF91bnJlZmVyZW5jZV0gT0JKIElEOiA0NyAoNCkKPiA+IFtkcm06ZHJtX21vZGVfb2JqZWN0X3Jl ZmVyZW5jZV0gT0JKIElEOiA0NyAoMykKPiA+IFtkcm06ZHJtX2F0b21pY19zZXRfZmJfZm9yX3Bs YW5lXSBTZXQgW0ZCOjQ3XSBmb3IgcGxhbmUgc3RhdGUgZWQ2MzJkMDAKPiA+IFtkcm06ZHJtX21v ZGVfb2JqZWN0X3VucmVmZXJlbmNlXSBPQkogSUQ6IDQ3ICg0KQo+ID4gW2RybTpkcm1fbW9kZV9v YmplY3RfdW5yZWZlcmVuY2VdIE9CSiBJRDogNTIgKDEpCj4gPiBbZHJtOmRybV9jcnRjX2hlbHBl cl9zZXRfbW9kZV0gW0VOQ09ERVI6MzM6VE1EUy0zM10gc2V0IFtNT0RFOjQ2OjE5MjB4MTA4MF0K PiA+IFtkcm06ZHJtX3ZibGFua19vbl0gY3J0YyAwLCB2YmxhbmsgZW5hYmxlZCAwLCBpbm1vZGVz ZXQgMQo+ID4gW2RybTpkcm1fY2FsY190aW1lc3RhbXBpbmdfY29uc3RhbnRzXSBjcnRjIDI0OiBo d21vZGU6IGh0b3RhbCAyNjQwLCB2dG90YWwgMTEyNSwgdmRpc3BsYXkgMTA4MAo+ID4gW2RybTpk cm1fY2FsY190aW1lc3RhbXBpbmdfY29uc3RhbnRzXSBjcnRjIDI0OiBjbG9jayAxNDg1MDAga0h6 IGZyYW1lZHVyIDIwMDAwMDAwIGxpbmVkdXIgMTc3NzcKPiA+IFtkcm06ZHJtX21vZGVfb2JqZWN0 X3JlZmVyZW5jZV0gT0JKIElEOiA0NyAoMykKPiA+IFtkcm06ZHJtX21vZGVfb2JqZWN0X3VucmVm ZXJlbmNlXSBPQkogSUQ6IDQ3ICg0KQo+ID4gW2RybTpkcm1fbW9kZV9vYmplY3RfdW5yZWZlcmVu Y2VdIE9CSiBJRDogNDggKDIpCj4gPiBbZHJtOmRybV9tb2RlX29iamVjdF91bnJlZmVyZW5jZV0g T0JKIElEOiAzNCAoNCkKPiA+IFtkcm06ZHJtX2lvY3RsXSByZXQgPSAtMjIKPiA+IAo+ID4gV2l0 aCBhIGJpdCBtb3JlIGRlYnVnZ2luZywgdGhpcyBpcyB3aGF0J3MgZmFpbGluZzoKPiA+IAo+ID4g aXB1X3BsYW5lX2F0b21pY19jaGVjazo0NDI6IGZhaWwKPiA+IFtkcm06ZHJtX2NydGNfaGVscGVy X3NldF9jb25maWddICpFUlJPUiogZmFpbGVkIHRvIHNldCBtb2RlIG9uIFtDUlRDOjI0OmNydGMt MF0KPiA+IAo+ID4gICAgICAgICBpZiAob2xkX2ZiICYmIChzdGF0ZS0+c3JjX3cgIT0gb2xkX3N0 YXRlLT5zcmNfdyB8fAo+ID4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgc3RhdGUtPnNy Y19oICE9IG9sZF9zdGF0ZS0+c3JjX2ggfHwKPiA+ICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIGZiLT5waXhlbF9mb3JtYXQgIT0gb2xkX2ZiLT5waXhlbF9mb3JtYXQpKSB7Cj4gPiAgICAg ICAgICAgICAgICAgcHJpbnRrKCIlczolZDogZmFpbFxuIiwgX19mdW5jX18sIF9fTElORV9fKTsK PiA+ICAgICAgICAgICAgICAgICByZXR1cm4gLUVJTlZBTDsKPiA+ICAgICAgICAgfQo+ID4gCj4g PiBUaGlzIHRlc3QgaXMgc3R1cGlkIGFzIGl0IHN0YW5kcyAtIGl0IG1lYW5zIHdlIGNhbiBfbmV2 ZXJfIGNoYW5nZSB0aGUKPiA+IGZvcm1hdCBvciBzaXplIG9mIF9hbnlfIHBsYW5lLCBzb21ldGhp bmcgdGhhdCB0aGUgb2xkIGNvZGUgYWxsb3dlZDoKPiA+IAo+ID4gLSAgICAgICBpZiAoaXB1X3Bs YW5lLT5lbmFibGVkKSB7Cj4gPiAtICAgICAgICAgICAgICAgaWYgKHNyY193ICE9IGlwdV9wbGFu ZS0+dyB8fCBzcmNfaCAhPSBpcHVfcGxhbmUtPmggfHwKPiA+IC0gICAgICAgICAgICAgICAgICAg ZmItPnBpeGVsX2Zvcm1hdCAhPSBpcHVfcGxhbmUtPmJhc2UuZmItPnBpeGVsX2Zvcm1hdCkKPiA+ IC0gICAgICAgICAgICAgICAgICAgICAgIHJldHVybiAtRUlOVkFMOwo+ID4gCj4gPiBUaGlzIHVz ZWQgdG8gd29yayBiZWNhdXNlIHdlJ2QgY2FsbCBpcHVfY3J0Y19wcmVwYXJlKCktPmlwdV9mYl9k aXNhYmxlKCkKPiA+IGJlZm9yZSB0aGUgbW9kZSBzZXQsIHdoaWNoIHdvdWxkIGNsZWFyIGlwdV9w bGFuZS0+ZW5hYmxlZCwgY2F1c2luZyB0aGlzCj4gPiB0ZXN0IHRvIGJlIHNraXBwZWQuICBIb3dl dmVyLCBpbiB0aGUgbmV3IGNvZGUsIHdlIG1lcmVseSB0ZXN0IGZvciB0aGUKPiA+IHByZXNlbmNl IG9mIHRoZSBwcmV2aW91cyBmcmFtZWJ1ZmZlciwgd2hpY2ggaXMgcmVhbGx5IG5vdCB0aGUgc2Ft ZSB0aGluZwo+ID4gYXQgYWxsLgo+ID4gCj4gPiBUaGUgb2xkIGZ1bmN0aW9uYWxpdHkgbmVlZHMg dG8gYmUgcmVzdG9yZWQgYmVjYXVzZSBzaWduaWZpY2FudGx5Cj4gPiBjaGFuZ2luZyB0aGUgZGlz cGxheWVkIG1vZGUgaXMgc29tZXRoaW5nIHdoaWNoIG11c3QgYmUgc3VwcG9ydGVkIHdpdGgKPiA+ IEhETUkuCj4gCj4gQnlwYXNzaW5nIHRoZSBhYm92ZSBjaGVjayBhbHNvIHNob3dzIHRoYXQ6Cj4g Cj4gICAgICAgICBpZiAob2xkX2ZiICYmIGZiLT5waXRjaGVzWzBdICE9IG9sZF9mYi0+cGl0Y2hl c1swXSkgewo+ICAgICAgICAgICAgICAgICBwcmludGsoIiVzOiVkOiBmYWlsXG4iLCBfX2Z1bmNf XywgX19MSU5FX18pOwo+ICAgICAgICAgICAgICAgICByZXR1cm4gLUVJTlZBTDsKPiAgICAgICAg IH0KPiAKPiBhbHNvIGZhaWxzLiAgRGlzYWJsaW5nIHRoaXMgYXMgd2VsbCByZXN1bHRzIGluIGxv c3Mgb2Ygc3luYyBvbiB0aGUKPiBIRE1JIGRpc3BsYXksIGFsdGhvdWdoIHRoZSBtb2RlIHNldCBu b3cgc3VjY2VlZHMuCj4gCj4gVGhlIG1vcmUgSSB0aGluayBhYm91dCB0aGlzLCB0aGUgbW9yZSBJ IGNvbWUgdG8gb25lIG9mIHR3byBwb3NzaWJsZQo+IGNvbmNsdXNpb25zOgo+IAo+IDEuIFRoZXNl IGNoZWNrcyB3ZXJlIG5vdCBhcHByb3ByaWF0ZSB3aXRoIHRoZSBvbGQgY29kZSBhcyB3ZSB3ZXJl Cj4gICAgYWx3YXlzIGRpc2FibGluZyB0aGUgZGlzcGxheSBjaGFubmVsIHByaW9yIHRvIG1ha2lu ZyBjaGFuZ2VzLgo+IAo+ICAgIFdlIG5lZWQgYXRvbWljIG1vZGUgc2V0IHRvIHdvcmsgaW4gZXhh Y3RseSB0aGUgc2FtZSB3YXkgYXMgdGhlCj4gICAgcHJldmlvdXMgY29kZTogYXMgYSBzZXJpZXMg b2YgZGlzYWJsZS1tb2RpZnktZW5hYmxlIHNldCBvZiBzdGVwcywKPiAgICBzbyB0aGF0IHdlIGRv bid0IG5lZWQgdGhlc2UgcmVzdHJpY3RpdmUgYW5kIHJlZ3Jlc3Npb24gY2F1c2luZwo+ICAgIGNo ZWNrcy4KPiAKPiBvcgo+IAo+IDIuIGlteC1kcm0gaGFzIHRoZXNlIHBhcnRpY3VsYXIgcmVzdHJp Y3Rpb25zIHdoaWNoIG1ha2UgaXQgaW5hcHByb3ByaWF0ZQo+ICAgIHRvIGJlIGNvbnZlcnRlZCB0 byBhdG9taWMgbW9kZSBzZXQsIGFzIHdlIGFsd2F5cyBuZWVkIHRvIGdvIHRocm91Z2gKPiAgICBh IGRpc2FibGUtbW9kaWZ5LWVuYWJsZSBzZXJpZXMgb2Ygc3RlcHMgLSB3aGljaCBtZWFucyB0aGUg YXRvbWljCj4gICAgbW9kZSBzZXQgY2hhbmdlcyBmb3IgaW14LWRybSBuZWVkIHRvIGJlIHJldmVy dGVkIGJhY2sgdG8gdGhpcyBwYXRjaC4KPiAKPiBJJ20gcHJldHR5IHN1cmUgKDIpIGRvZXNuJ3Qg cmVhbGx5IGFwcGx5LCBiZWNhdXNlIEkgc2VlIG5vIHJlYXNvbiB3aHkKPiB3ZSBjYW4ndCBkaXNh YmxlIHRoZSBkaXNwbGF5IGNoYW5uZWwgd2hpbGUgd2UgcmVjb25maWd1cmUgaXQuICBUaGF0LAo+ IHRvIG1lLCBzZWVtcyB0byBiZSBhbiBlbnRpcmVseSByZWFzb25hYmxlIHRoaW5nIHRvIGRvLgoK QWxyZWFkeSBkZGlzY3Vzc2VkIHRoaXMgYXQgbGVuZ2h0IG9uIGlyYyB3aXRoIFBldGVyIFNlbm5h LiBJZiB5b3UgaGF2ZQpwbGFuZSB1cGRhdGUgcmVzdHJpY3Rpb25zIHdoZXJlIHlvdSBuZWVkIHRv IGN5Y2xlIHRoZSBjcnRjIGNvbXBsZXRlbHksCnRoZSByaWdodCB0aGluZyB0byBkbyBpcyB0byBz ZXQgY3J0Y19zdGF0ZS0+bW9kZV9jaGFuZ2VkIGluc3RlYWQgb2YgcmV0dXJuCi1FSU5WQUwuIFRo ZSBoZWxwZXIvY29yZSB3aWxsIHRoZW4gY29udmVydCB0aGF0IGludG8gYW4gRUlOVkFMIGlmCnVz ZXJzcGFjZSBkb2Vzbid0IHNldCBBTExPV19NT0RFU0VULiBBbmQgc2luY2UgdGhlIGhlbHBlciBm dW5jdGlvbiB0byBtYXAKc2V0X2NvbmZpZyB0byBhdG9taWMgZG9lcyB0aGlzLCBpdCBzaG91bGQg YWxsIGp1c3Qgd29yay4KCk5vdGU6IFRoZXJlJ3MgYWJvdXQgMyBzdWNoIGNvbmRpdGlvbnMgaW4g aW14JyBhdG9taWNfY2hlY2sgZnVuY3Rpb24gd2hpY2gKbmVlZHMgdGhpcyBjaGFuZ2UuCi1EYW5p ZWwKLS0gCkRhbmllbCBWZXR0ZXIKU29mdHdhcmUgRW5naW5lZXIsIEludGVsIENvcnBvcmF0aW9u Cmh0dHA6Ly9ibG9nLmZmd2xsLmNoCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVk ZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZv L2RyaS1kZXZlbAo=