From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 2/2] drm/msm: protect against faults from copy_from_user() in submit ioctl Date: Tue, 23 Aug 2016 08:03:06 +0200 Message-ID: <20160823060306.GK24290@phenom.ffwll.local> References: <1471894685-20199-1-git-send-email-robdclark@gmail.com> <1471894685-20199-2-git-send-email-robdclark@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-x244.google.com (mail-wm0-x244.google.com [IPv6:2a00:1450:400c:c09::244]) by gabe.freedesktop.org (Postfix) with ESMTPS id 885D86E270 for ; Tue, 23 Aug 2016 06:03:10 +0000 (UTC) Received: by mail-wm0-x244.google.com with SMTP id i138so16459401wmf.3 for ; Mon, 22 Aug 2016 23:03:10 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1471894685-20199-2-git-send-email-robdclark@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Rob Clark Cc: stable@vger.kernel.org, dri-devel@lists.freedesktop.org, Vaishali Thakkar , freedreno@lists.freedesktop.org, Al Viro List-Id: dri-devel@lists.freedesktop.org T24gTW9uLCBBdWcgMjIsIDIwMTYgYXQgMDM6Mzg6MDVQTSAtMDQwMCwgUm9iIENsYXJrIHdyb3Rl Ogo+IEFuIGV2aWwgdXNlcnNwYWNlIGNvdWxkIHRyeSB0byBjYXVzZSBkZWFkbG9jayBieSBwYXNz aW5nIGFuIHVuZmF1bHRlZC1pbgo+IEdFTSBibyBhcyBzdWJtaXQtPmJvcyAob3Igc3VibWl0LT5j bWRzKSB0YWJsZS4gIFdoaWNoIHdpbGwgdHJpZ2dlcgo+IG1zbV9nZW1fZmF1bHQoKSB3aGlsZSB3 ZSBhbHJlYWR5IGhvbGQgc3RydWN0X211dGV4LiAgU2VlOgo+IAo+IGh0dHBzOi8vZ2l0aHViLmNv bS9mcmVlZHJlbm8vbXNtdGVzdC9ibG9iL21hc3Rlci9ldmlsc3VibWl0dGVzdC5jCj4gCj4gQ2M6 IHN0YWJsZUB2Z2VyLmtlcm5lbC5vcmcKPiBTaWduZWQtb2ZmLWJ5OiBSb2IgQ2xhcmsgPHJvYmRj bGFya0BnbWFpbC5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9tc20vbXNtX2Rydi5oICAg ICAgICB8IDYgKysrKysrCj4gIGRyaXZlcnMvZ3B1L2RybS9tc20vbXNtX2dlbS5jICAgICAgICB8 IDkgKysrKysrKysrCj4gIGRyaXZlcnMvZ3B1L2RybS9tc20vbXNtX2dlbV9zdWJtaXQuYyB8IDMg KysrCj4gIDMgZmlsZXMgY2hhbmdlZCwgMTggaW5zZXJ0aW9ucygrKQo+IAo+IGRpZmYgLS1naXQg YS9kcml2ZXJzL2dwdS9kcm0vbXNtL21zbV9kcnYuaCBiL2RyaXZlcnMvZ3B1L2RybS9tc20vbXNt X2Rydi5oCj4gaW5kZXggYTM1YzFiNi4uOTU3ODAxZSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dw dS9kcm0vbXNtL21zbV9kcnYuaAo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9tc20vbXNtX2Rydi5o Cj4gQEAgLTE1Nyw2ICsxNTcsMTIgQEAgc3RydWN0IG1zbV9kcm1fcHJpdmF0ZSB7Cj4gIAlzdHJ1 Y3Qgc2hyaW5rZXIgc2hyaW5rZXI7Cj4gIAo+ICAJc3RydWN0IG1zbV92YmxhbmtfY3RybCB2Ymxh bmtfY3RybDsKPiArCj4gKwkvKiB0YXNrIGhvbGRpbmcgc3RydWN0X211dGV4Li4gY3VycmVudGx5 IG9ubHkgdXNlZCBpbiBzdWJtaXQgcGF0aAo+ICsJICogdG8gZGV0ZWN0IGFuZCByZWplY3QgZmF1 bHRzIGZyb20gY29weV9mcm9tX3VzZXIoKSBmb3Igc3VibWl0Cj4gKwkgKiBpb2N0bC4KPiArCSAq Lwo+ICsJc3RydWN0IHRhc2tfc3RydWN0ICpzdHJ1Y3RfbXV0ZXhfdGFzazsKPiAgfTsKPiAgCj4g IHN0cnVjdCBtc21fZm9ybWF0IHsKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL21zbS9t c21fZ2VtLmMgYi9kcml2ZXJzL2dwdS9kcm0vbXNtL21zbV9nZW0uYwo+IGluZGV4IDhkZmRlZWMu LmY2Yjg5NDUgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL21zbS9tc21fZ2VtLmMKPiAr KysgYi9kcml2ZXJzL2dwdS9kcm0vbXNtL21zbV9nZW0uYwo+IEBAIC0xOTYsMTEgKzE5NiwyMCBA QCBpbnQgbXNtX2dlbV9mYXVsdChzdHJ1Y3Qgdm1fYXJlYV9zdHJ1Y3QgKnZtYSwgc3RydWN0IHZt X2ZhdWx0ICp2bWYpCj4gIHsKPiAgCXN0cnVjdCBkcm1fZ2VtX29iamVjdCAqb2JqID0gdm1hLT52 bV9wcml2YXRlX2RhdGE7Cj4gIAlzdHJ1Y3QgZHJtX2RldmljZSAqZGV2ID0gb2JqLT5kZXY7Cj4g KwlzdHJ1Y3QgbXNtX2RybV9wcml2YXRlICpwcml2ID0gZGV2LT5kZXZfcHJpdmF0ZTsKPiAgCXN0 cnVjdCBwYWdlICoqcGFnZXM7Cj4gIAl1bnNpZ25lZCBsb25nIHBmbjsKPiAgCXBnb2ZmX3QgcGdv ZmY7Cj4gIAlpbnQgcmV0Owo+ICAKPiArCS8qIFRoaXMgc2hvdWxkIG9ubHkgaGFwcGVuIGlmIHVz ZXJzcGFjZSB0cmllcyB0byBwYXNzIGEgbW1hcCdkCj4gKwkgKiBidXQgdW5mYXVsdGVkIGdlbSBi byB2YWRkciBpbnRvIHN1Ym1pdCBpb2N0bCwgdHJpZ2dlcmluZwo+ICsJICogYSBwYWdlIGZhdWx0 IHdoaWxlIHN0cnVjdF9tdXRleCBpcyBhbHJlYWR5IGhlbGQuICBUaGlzIGlzCj4gKwkgKiBub3Qg YSB2YWxpZCB1c2UtY2FzZSBzbyBqdXN0IGJhaWwuCj4gKwkgKi8KPiArCWlmIChwcml2LT5zdHJ1 Y3RfbXV0ZXhfdGFzayA9PSBjdXJyZW50KQoKUkVBRF9PTkNFIGhlcmUgSSB0aGluay4gT3RoZXJ3 aXNlIHNob3VsZCBhdCBsZWFzdCB3b3JrLCB0aG91Z2ggSSBzdGlsbAp0aGluayBpdCdzIHNsb3Bw eSA7LSkKLURhbmllbAoKPiArCQlyZXR1cm4gVk1fRkFVTFRfU0lHQlVTOwo+ICsKPiAgCS8qIE1h a2Ugc3VyZSB3ZSBkb24ndCBwYXJhbGxlbCB1cGRhdGUgb24gYSBmYXVsdCwgbm9yIG1vdmUgb3Ig cmVtb3ZlCj4gIAkgKiBzb21ldGhpbmcgZnJvbSBiZW5lYXRoIG91ciBmZWV0Cj4gIAkgKi8KPiBk aWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL21zbS9tc21fZ2VtX3N1Ym1pdC5jIGIvZHJpdmVy cy9ncHUvZHJtL21zbS9tc21fZ2VtX3N1Ym1pdC5jCj4gaW5kZXggMDNkNGNlMi4uMGJlNTdhOSAx MDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vbXNtL21zbV9nZW1fc3VibWl0LmMKPiArKysg Yi9kcml2ZXJzL2dwdS9kcm0vbXNtL21zbV9nZW1fc3VibWl0LmMKPiBAQCAtNDI2LDYgKzQyNiw4 IEBAIGludCBtc21faW9jdGxfZ2VtX3N1Ym1pdChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LCB2b2lk ICpkYXRhLAo+ICAJaWYgKHJldCkKPiAgCQlyZXR1cm4gcmV0Owo+ICAKPiArCXByaXYtPnN0cnVj dF9tdXRleF90YXNrID0gY3VycmVudDsKPiArCj4gIAlpZiAoYXJncy0+ZmxhZ3MgJiBNU01fU1VC TUlUX0ZFTkNFX0ZEX09VVCkgewo+ICAJCW91dF9mZW5jZV9mZCA9IGdldF91bnVzZWRfZmRfZmxh Z3MoT19DTE9FWEVDKTsKPiAgCQlpZiAob3V0X2ZlbmNlX2ZkIDwgMCkgewo+IEBAIC01NDksNiAr NTUxLDcgQEAgb3V0Ogo+ICBvdXRfdW5sb2NrOgo+ICAJaWYgKHJldCAmJiAob3V0X2ZlbmNlX2Zk ID49IDApKQo+ICAJCXB1dF91bnVzZWRfZmQob3V0X2ZlbmNlX2ZkKTsKPiArCXByaXYtPnN0cnVj dF9tdXRleF90YXNrID0gTlVMTDsKPiAgCW11dGV4X3VubG9jaygmZGV2LT5zdHJ1Y3RfbXV0ZXgp Owo+ICAJcmV0dXJuIHJldDsKPiAgfQo+IC0tIAo+IDIuNy40Cj4gCgotLSAKRGFuaWVsIFZldHRl cgpTb2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9yYXRpb24KaHR0cDovL2Jsb2cuZmZ3bGwu Y2gKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRl dmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8v bGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==