dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Karl Beldan <kbeldan@baylibre.com>
To: dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org
Cc: Karl Beldan <karl.beldan+oss@gmail.com>,
	Kevin Hilman <khilman@baylibre.com>, Sekhar Nori <nsekhar@ti.com>,
	Jyri Sarha <jsarha@ti.com>,
	Tomi Valkeinen <tomi.valkeinen@ti.com>,
	Karl Beldan <kbeldan@baylibre.com>
Subject: [PATCH 2/3] drm/tilcdc: Enable EOF interrupts for v1 LCDC
Date: Tue, 23 Aug 2016 12:57:00 +0000	[thread overview]
Message-ID: <20160823125701.25700-3-kbeldan@baylibre.com> (raw)
In-Reply-To: <20160823125701.25700-1-kbeldan@baylibre.com>

This got accidentally dropped in the fixed commit and is required for
the driver to properly work on the rev1 IP, such as found on the LCDK.

Fixes: 2b2080d7e9ae ("drm/tilcdc: Get rid of complex ping-pong mechanism")
Signed-off-by: Karl Beldan <kbeldan@baylibre.com>
---
 drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/tilcdc/tilcdc_crtc.c b/drivers/gpu/drm/tilcdc/tilcdc_crtc.c
index 89d6916..163f111 100644
--- a/drivers/gpu/drm/tilcdc/tilcdc_crtc.c
+++ b/drivers/gpu/drm/tilcdc/tilcdc_crtc.c
@@ -98,6 +98,8 @@ static void tilcdc_crtc_enable_irqs(struct drm_device *dev)
 	if (priv->rev == 1) {
 		tilcdc_set(dev, LCDC_RASTER_CTRL_REG,
 			LCDC_V1_UNDERFLOW_INT_ENA);
+		tilcdc_set(dev, LCDC_DMA_CTRL_REG,
+			LCDC_V1_END_OF_FRAME_INT_ENA);
 	} else {
 		tilcdc_write(dev, LCDC_INT_ENABLE_SET_REG,
 			LCDC_V2_UNDERFLOW_INT_ENA |
-- 
2.9.2

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  parent reply	other threads:[~2016-08-23 12:57 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-23 12:56 [PATCH 0/3] drm/tilcdc: Some fixes for LCDC rev1 Karl Beldan
2016-08-23 12:56 ` [PATCH 1/3] drm/tilcdc: Adjust the FB_CEILING address Karl Beldan
2016-08-23 12:57 ` Karl Beldan [this message]
2016-08-23 12:57 ` [PATCH 3/3] drm/tilcdc: Advertise the DRM_FORMATs according to the IP revision Karl Beldan
2016-08-23 16:24 ` [PATCH 0/3] drm/tilcdc: Some fixes for LCDC rev1 Jyri Sarha
2016-08-26 16:54   ` Karl Beldan
2016-08-31 22:11   ` Kevin Hilman
2016-09-02 12:29     ` Jyri Sarha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160823125701.25700-3-kbeldan@baylibre.com \
    --to=kbeldan@baylibre.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jsarha@ti.com \
    --cc=karl.beldan+oss@gmail.com \
    --cc=khilman@baylibre.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=nsekhar@ti.com \
    --cc=tomi.valkeinen@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox