From: Thierry Reding <thierry.reding@gmail.com>
To: Vinay Simha <simhavcs@gmail.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
"open list:DRM PANEL DRIVERS" <dri-devel@lists.freedesktop.org>,
Rob Herring <robh+dt@kernel.org>,
Archit Taneja <archit.taneja@gmail.com>
Subject: Re: [RESEND] [PATCH v2 2/4] dt-bindings: Add jdi lt070me05000 panel bindings
Date: Wed, 24 Aug 2016 14:35:34 +0200 [thread overview]
Message-ID: <20160824123534.GB3714@ulmo.ba.sec> (raw)
In-Reply-To: <CAGWqDJ6HuoHP5ygEG-SWUhaUqOjnzTCZb=xyO_pu8xXXHnq5Aw@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 806 bytes --]
On Wed, Aug 24, 2016 at 05:53:00PM +0530, Vinay Simha wrote:
> if we do not set the polarity to 8mA, panel will have gibberish display.
> (information to set 8mA is available only in
> nexus7-msm-flo-3.4-lollipop-release_dsi kernel nx7 release)
>
> i will add this
> reset-gpios = <&tlmm_pinmux 54 GPIO_ACTIVE_LOW>;
I don't think that will work with the current driver, because the GPIO
subsystem will automatically invert the value for you. Currently the
panel driver sets the GPIO value to 0 to assert the reset. With the
GPIO_ACTIVE_LOW flag you'd end up setting the actual level of the GPIO
to high, which is going to deassert. So I think if you make the above
change (which I think is the right thing to do), you'll also have to
update the driver to use high-active logic.
Thierry
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2016-08-24 12:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1469978126-925-1-git-send-email-simhavcs@gmail.com>
2016-07-31 15:15 ` [RESEND] [PATCH v2 2/4] dt-bindings: Add jdi lt070me05000 panel bindings Vinay Simha BN
2016-08-24 11:45 ` Thierry Reding
[not found] ` <20160824114534.GA3169-EkSeR96xj6Pcmrwk2tT4+A@public.gmane.org>
2016-08-24 12:04 ` Vinay Simha
2016-08-24 12:32 ` Thierry Reding
2016-08-24 17:24 ` Vinay Simha
2016-08-24 11:56 ` Thierry Reding
2016-08-24 12:23 ` Vinay Simha
2016-08-24 12:35 ` Thierry Reding [this message]
2016-07-31 15:15 ` [RESEND] [PATCH v3 3/4] drm/dsi: Implement dcs set/get display brightness Vinay Simha BN
2016-08-24 11:46 ` Thierry Reding
2016-07-31 15:15 ` [RESEND] [PATCH v9 4/4] drm/panel: Add JDI LT070ME05000 WUXGA DSI Panel Vinay Simha BN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160824123534.GB3714@ulmo.ba.sec \
--to=thierry.reding@gmail.com \
--cc=archit.taneja@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=simhavcs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox