From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/simple-helpers: Always add planes to the state update Date: Thu, 25 Aug 2016 08:30:47 +0200 Message-ID: <20160825063047.GF10980@phenom.ffwll.local> References: <1471933540-31131-1-git-send-email-daniel.vetter@ffwll.ch> <91379bfc-a1ea-ae1f-ada0-ec6f515dd2d8@tronnes.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-x242.google.com (mail-wm0-x242.google.com [IPv6:2a00:1450:400c:c09::242]) by gabe.freedesktop.org (Postfix) with ESMTPS id 93B196E36A for ; Thu, 25 Aug 2016 06:30:51 +0000 (UTC) Received: by mail-wm0-x242.google.com with SMTP id o80so5911027wme.0 for ; Wed, 24 Aug 2016 23:30:51 -0700 (PDT) Content-Disposition: inline In-Reply-To: <91379bfc-a1ea-ae1f-ada0-ec6f515dd2d8@tronnes.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Noralf =?iso-8859-1?Q?Tr=F8nnes?= Cc: andrea.merello@gmail.com, Daniel Vetter , DRI Development , Daniel Vetter List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCBBdWcgMjQsIDIwMTYgYXQgMDg6Mzg6MzdQTSArMDIwMCwgTm9yYWxmIFRyw7hubmVz IHdyb3RlOgo+IAo+IERlbiAyMy4wOC4yMDE2IDA4OjI1LCBza3JldiBEYW5pZWwgVmV0dGVyOgo+ ID4gT3VyIHVwZGF0ZSBmdW5jdGlvbiBpcyBob29rZWQgdG8gdGhlIHNpbmdsZSBwbGFuZSwgd2hp Y2ggbWlnaHQgbm90IGdldAo+ID4gY2FsbGVkIGZvciBjcnRjLW9ubHkgdXBkYXRlcy4gV2hpY2gg aXMgc3VycHJpc2luZywgc28gZml4IHRoaXMgYnkKPiA+IGFsd2F5cyBhZGRpbmcgdGhlIHBsYW5l Lgo+ID4gCj4gPiBXaGlsZSBhdCBpdCBkb2N1bWVudCBob3cmd2hlbiB0aGUgZXZlbnQgc2hvdWxk IGJlIHNlbnQgb3V0IGJldHRlciBpbgo+ID4gdGhlIGtlcm5lbGRvYy4KPiA+IAo+ID4gQ2M6IE5v cmFsZiBUcsO4bm5lcyA8bm9yYWxmQHRyb25uZXMub3JnPgo+ID4gQ2M6IGFuZHJlYS5tZXJlbGxv QGdtYWlsLmNvbQo+ID4gVGVzdGVkLWFuZC1SZXBvcnRlZC1ieTogYW5kcmVhLm1lcmVsbG9AZ21h aWwuY29tCj4gPiBTaWduZWQtb2ZmLWJ5OiBEYW5pZWwgVmV0dGVyIDxkYW5pZWwudmV0dGVyQGlu dGVsLmNvbT4KPiA+IC0tLQo+ID4gSSdtIG5vdCBlbnRpcmVseSBzdXJlIHdlIHJlYWxseSB3YW50 IHRvIHB1dCB0aGUgcmVzcG9uc2liaWxpdHkgZm9yCj4gPiB0aGlzIG9udG8gZHJpdmVyLiBQbGFu IEIpIHdvdWxkIGJlIHRvIHJlbW92ZSB0aGUga2VybmVsZG9jIEkgYWRkZWQKPiA+IGhlcmUgYW5k IGNhbGwgdGhlIHJpZ2h0IGZ1bmN0aW9uIGZyb20gZHJtX3NpbXBsZV9rbXNfcGxhbmVfYXRvbWlj X3VwZGF0ZS4KPiA+IFRoYXQgd2F5IHNpbXBsZSBkcml2ZXJzIGRvbid0IG5lZWQgdG8gZGVhbCB3 aXRoIHRoYXQgZGV0YWlsLCBhbmQgaW4KPiA+IGdlbmVyYWwgdGhvc2UgZHJpdmVycyBkb24ndCBj YXJlIHRoYXQgbXVjaCBhYm91dCB0aGUgbWluaXNjdWxlCj4gPiBwb3NzaWJsZSByYWNlIGEgZ2Vu ZXJpYyBpbXBsZW1lbnRhdGlvbiB3b3VsZCBjYXVzZS4gV2hhdCBkbyB5b3UKPiA+IHN1Z2dlc3Qg YXMgdGhlIGJlc3QgYXBwcm9hY2g/Cj4gCj4gSWYgdGhlIGRyaXZlciBpcyByZXNwb25zaWJsZSwg YSBoZWxwZXIgbGlrZSB0aGlzIHdvdWxkIGJlIG5pY2U6Cj4gCj4gdm9pZCBkcm1fc2ltcGxlX2Rp c3BsYXlfcGlwZV9oYW5kbGVfdmJsYW5rX2V2ZW50KHN0cnVjdAo+IGRybV9zaW1wbGVfZGlzcGxh eV9waXBlICpwaXBlKQo+IHsKPiAgICAgc3RydWN0IGRybV9jcnRjICpjcnRjID0gJnBpcGUtPmNy dGM7Cj4gCj4gICAgIGlmIChjcnRjLT5zdGF0ZSAmJiBjcnRjLT5zdGF0ZS0+ZXZlbnQpIHsKPiAg ICAgICAgIHNwaW5fbG9ja19pcnEoJmNydGMtPmRldi0+ZXZlbnRfbG9jayk7Cj4gICAgICAgICBk cm1fY3J0Y19zZW5kX3ZibGFua19ldmVudChjcnRjLCBjcnRjLT5zdGF0ZS0+ZXZlbnQpOwo+ICAg ICAgICAgc3Bpbl91bmxvY2tfaXJxKCZjcnRjLT5kZXYtPmV2ZW50X2xvY2spOwo+ICAgICAgICAg Y3J0Yy0+c3RhdGUtPmV2ZW50ID0gTlVMTDsKCkZvciBhIGdlbmVyaWMgdmVyc2lvbiB3ZSBwcm9i YWJseSB3YW50IHRvIGF1dG9tYXRpY2FsbHkgc3dpdGNoIHRvCmRybV9jcnRjX2FybV92Ymxhbmtf ZXZlbnQsIGlmIHZibGFuayBzdXBwb3J0IGlzIGF2YWlsYWJsZS4gVGhhdCBjYW4gYmUKY2hlY2tl ZCBieSBsb29raW5nIGF0IGRybV9kZXZpY2UtPm51bV9jcnRjcy4KCj4gICAgIH0KPiB9Cj4gCj4g VGhlbiBpZiB0aGUgdXBkYXRlKCkgY2FsbGJhY2sgaXMgbm90IHNldCwgZHJtX3NpbXBsZV9rbXNf cGxhbmVfYXRvbWljX3VwZGF0ZQo+IGNhbGxzIHRoaXMsIGFuZCBpZiBpdCBpcyBzZXQsIHRoZW4g dGhlIGRyaXZlciBoYXMgdG8gZG8gaXQgb3Igc29tZXRoaW5nCj4gc2ltaWxhci4KPiAKPiBJdCBp cyBkaWZmaWN1bHQgdG8gcHJlZGljdCB3aGF0IGZ1dHVyZSBkcml2ZXJzIHdpbGwgbmVlZC4KPiBV bmxlc3MgdGhlcmUgYXJlIGRyaXZlcnMgb24gdGhlIGhvcml6b24gdGhhdCB3aWxsIG5lZWQgdG8g aGFuZGxlIHRoZQo+IGV2ZW50IHRoZW1zZWx2ZXMsIEkgc3VnZ2VzdCB0aGF0IHdlIGZvbGxvdyB5 b3VyIHBsYW4gQi4gSWYgdGhlIG5lZWQgYXJpc2VzLAo+IHdlIGp1c3QgYWRkIGEgb25lLWxpbmVy IHRvIGFsbCBkcml2ZXJzIHRoYXQgaGFzIHRoZSB1cGRhdGUoKSBjYWxsYmFjayBzZXQuCgpIbSB5 ZWFoLiBXaGF0IGFib3V0IG1lcmdpbmcgdGhpcyBwYXRjaCBoZXJlIGZvciBub3cgKHdvdWxkIG5l ZWQgeW91cgpmb3JtYWwgcmV2aWV3ZWQtYnkpLCBhbmQgdGhlbiBsYXRlciBvbiB3aGVuIHdlIGhh dmUgMi0zIHNpbXBsZSBkcml2ZXJzCnVzaW5nIHRoaXMgd2UgY2FuIHJlY29uc2lkZXI/IFNpbmNl IEkgZG9udCBoYXZlIGh3IGZvciBhbnkgb2YgdGhlbSBJIGNhbid0CmRvIHRoaXMgbXlzZWxmLgoK PiBOb3JhbGYuCj4gCj4gU2lkZW5vdGU6Cj4gV2hlbiBJIGNvbnZlcnRlZCBzaW1wbGVkcm0gSSBo YWQgcHJvYmxlbXMgd2l0aCBmbGlwX2RvbmUgdGltZW91dHMuCj4gSW4gdGhlIGVuZCBJIGhhZCB0 byBjaGVjayBmb3IgdGhlIGV2ZW50IGluIGRpc2FibGUvZW5hYmxlL3VwZGF0ZS4KPiBUcnlpbmcg aXQgYWdhaW4gbm93LCBpdCdzIGVub3VnaCB0byBkbyBpdCBpbiB1cGRhdGUoKS4KPiBOb3Qgc3Vy ZSB3aGF0IGhhcyBjaGFuZ2VkLgoKVHJ5aW5nIGFnYWluIHdpdGggdGhpcyBwYXRjaCwgb3Igd2l0 aG91dD8gU2luY2UgdGhpcyBwYXRjaCBoZXJlIGlzIG1lYW50CnRvIGV4YWN0bHkgdGhlIHByb2Js ZW0gdGhhdCB5b3UgbmVlZCB0byBoYW5kbGUgdGhlIGV2ZW50IGluIHRvbyBtYW55CnBsYWNlcy4g SWYgaXQncyBmaXhlZCB3aXRoIGp1c3QgbGF0ZXN0IGRybS1taXNjLCB0aGF0IHdvdWxkIGJlIHN1 cnByaXNpbmcKLi4uCi1EYW5pZWwKCj4gCj4gPiAtRGFuaWVsCj4gPiAtLS0KPiA+ICAgZHJpdmVy cy9ncHUvZHJtL2RybV9zaW1wbGVfa21zX2hlbHBlci5jIHwgNyArKysrKysrCj4gPiAgIGluY2x1 ZGUvZHJtL2RybV9zaW1wbGVfa21zX2hlbHBlci5oICAgICB8IDYgKysrKysrCj4gPiAgIDIgZmls ZXMgY2hhbmdlZCwgMTMgaW5zZXJ0aW9ucygrKQo+ID4gCj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVy cy9ncHUvZHJtL2RybV9zaW1wbGVfa21zX2hlbHBlci5jIGIvZHJpdmVycy9ncHUvZHJtL2RybV9z aW1wbGVfa21zX2hlbHBlci5jCj4gPiBpbmRleCBiYWRhMTcxNjY1MTIuLjQ0NzYzMTAxODQyNiAx MDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fc2ltcGxlX2ttc19oZWxwZXIuYwo+ ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2RybV9zaW1wbGVfa21zX2hlbHBlci5jCj4gPiBAQCAt MzQsNiArMzQsMTIgQEAgc3RhdGljIGNvbnN0IHN0cnVjdCBkcm1fZW5jb2Rlcl9mdW5jcyBkcm1f c2ltcGxlX2ttc19lbmNvZGVyX2Z1bmNzID0gewo+ID4gICAJLmRlc3Ryb3kgPSBkcm1fZW5jb2Rl cl9jbGVhbnVwLAo+ID4gICB9Owo+ID4gK3N0YXRpYyBpbnQgZHJtX3NpbXBsZV9rbXNfY3J0Y19j aGVjayhzdHJ1Y3QgZHJtX2NydGMgKmNydGMsCj4gPiArCQkJCSAgICAgc3RydWN0IGRybV9jcnRj X3N0YXRlICpzdGF0ZSkKPiA+ICt7Cj4gPiArCXJldHVybiBkcm1fYXRvbWljX2FkZF9hZmZlY3Rl ZF9wbGFuZXMoc3RhdGUtPnN0YXRlLCBjcnRjKTsKPiA+ICt9Cj4gPiArCj4gPiAgIHN0YXRpYyB2 b2lkIGRybV9zaW1wbGVfa21zX2NydGNfZW5hYmxlKHN0cnVjdCBkcm1fY3J0YyAqY3J0YykKPiA+ ICAgewo+ID4gICAJc3RydWN0IGRybV9zaW1wbGVfZGlzcGxheV9waXBlICpwaXBlOwo+ID4gQEAg LTU3LDYgKzYzLDcgQEAgc3RhdGljIHZvaWQgZHJtX3NpbXBsZV9rbXNfY3J0Y19kaXNhYmxlKHN0 cnVjdCBkcm1fY3J0YyAqY3J0YykKPiA+ICAgfQo+ID4gICBzdGF0aWMgY29uc3Qgc3RydWN0IGRy bV9jcnRjX2hlbHBlcl9mdW5jcyBkcm1fc2ltcGxlX2ttc19jcnRjX2hlbHBlcl9mdW5jcyA9IHsK PiA+ICsJLmF0b21pY19jaGVjayA9IGRybV9zaW1wbGVfa21zX2NydGNfY2hlY2ssCj4gPiAgIAku ZGlzYWJsZSA9IGRybV9zaW1wbGVfa21zX2NydGNfZGlzYWJsZSwKPiA+ICAgCS5lbmFibGUgPSBk cm1fc2ltcGxlX2ttc19jcnRjX2VuYWJsZSwKPiA+ICAgfTsKPiA+IGRpZmYgLS1naXQgYS9pbmNs dWRlL2RybS9kcm1fc2ltcGxlX2ttc19oZWxwZXIuaCBiL2luY2x1ZGUvZHJtL2RybV9zaW1wbGVf a21zX2hlbHBlci5oCj4gPiBpbmRleCAyNjkwMzk3MjJmOTEuLjgyNjk0NmNhMmI4MiAxMDA2NDQK PiA+IC0tLSBhL2luY2x1ZGUvZHJtL2RybV9zaW1wbGVfa21zX2hlbHBlci5oCj4gPiArKysgYi9p bmNsdWRlL2RybS9kcm1fc2ltcGxlX2ttc19oZWxwZXIuaAo+ID4gQEAgLTYwLDYgKzYwLDEyIEBA IHN0cnVjdCBkcm1fc2ltcGxlX2Rpc3BsYXlfcGlwZV9mdW5jcyB7Cj4gPiAgIAkgKgo+ID4gICAJ ICogVGhpcyBmdW5jdGlvbiBpcyBjYWxsZWQgd2hlbiB0aGUgdW5kZXJseWluZyBwbGFuZSBzdGF0 ZSBpcyB1cGRhdGVkLgo+ID4gICAJICogVGhpcyBob29rIGlzIG9wdGlvbmFsLgo+ID4gKwkgKgo+ ID4gKwkgKiBUaGlzIGlzIHRoZSBmdW5jdGlvbiBkcml2ZXJzIHNob3VsZCBzdWJtaXQgdGhlCj4g PiArCSAqICZkcm1fcGVuZGluZ192YmxhbmtfZXZlbnQgZnJvbS4gVXNpbmcgZWl0aGVyCj4gPiAr CSAqIGRybV9jcnRjX2FybV92YmxhbmtfZXZlbnQoKSwgd2hlbiB0aGUgZHJpdmVyIHN1cHBvcnRz IHZibGFuawo+ID4gKwkgKiBpbnRlcnJ1cHQgaGFuZGxpbmcsIG9yIGRybV9jcnRjX3NlbmRfdmJs YW5rX2V2ZW50KCkgZGlyZWN0bHkgaW4gY2FzZQo+ID4gKwkgKiB0aGUgaGFyZHdhcmUgbGFja3Mg dmJsYW5rIHN1cHBvcnQgZW50aXJlbHkuCj4gPiAgIAkgKi8KPiA+ICAgCXZvaWQgKCp1cGRhdGUp KHN0cnVjdCBkcm1fc2ltcGxlX2Rpc3BsYXlfcGlwZSAqcGlwZSwKPiA+ICAgCQkgICAgICAgc3Ry dWN0IGRybV9wbGFuZV9zdGF0ZSAqcGxhbmVfc3RhdGUpOwo+IAoKLS0gCkRhbmllbCBWZXR0ZXIK U29mdHdhcmUgRW5naW5lZXIsIEludGVsIENvcnBvcmF0aW9uCmh0dHA6Ly9ibG9nLmZmd2xsLmNo Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZl bCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xp c3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=