From: Daniel Vetter <daniel@ffwll.ch>
To: Chris Wilson <chris@chris-wilson.co.uk>,
David Herrmann <dh.herrmann@gmail.com>,
dri-devel@lists.freedesktop.org,
Daniel Vetter <daniel.vetter@ffwll.ch>,
Dave Airlie <airlied@gmail.com>
Subject: Re: [PATCH 2/2] drm: make DRI1 drivers depend on BROKEN
Date: Thu, 25 Aug 2016 13:14:06 +0200 [thread overview]
Message-ID: <20160825111406.GQ10980@phenom.ffwll.local> (raw)
In-Reply-To: <20160804081507.GL12611@nuc-i3427.alporthouse.com>
On Thu, Aug 04, 2016 at 09:15:07AM +0100, Chris Wilson wrote:
> On Thu, Aug 04, 2016 at 10:06:57AM +0200, David Herrmann wrote:
> > The legacy DRI1 drivers expose highly broken interfaces to user-space. No
> > modern system should enable them, or you will effectively allow user-space
> > to circumvent most of your kernel security measures. The DRI1 kernel APIs
> > are simply broken.
> >
> > User-space can always use vesafb/efifb/simplefb and friends to get working
> > graphics.
> >
> > Lets hide the old drivers behind CONFIG_BROKEN. In case they turn out to
> > be still used (really?), we can easily revert this and figure out a way to
> > move them out of sight (e.g., moving all DRI1 drivers to
> > drivers/gpu/dri1/).
> >
> > Signed-off-by: David Herrmann <dh.herrmann@gmail.com>
>
> Acked-by: Chris Wilson <chris@chris-wilson.co.uk>
>
> I'd rather have a couple of distro devs check if they are still using
> any of these, and would value their a-b/r-b.
Mesa stopped shipping dri1 drivers years ago, and neither Fedora and
Debian here have that old version packaged (it should keep working since
the dri loader is an ABI). I don't think anyone needs this, and if I'm
wrong we'll hear about it ;-)
Both applied to drm-misc.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2016-08-25 11:14 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-04 8:06 [PATCH 1/2] drm: hide legacy drivers with CONFIG_DRM_LEGACY David Herrmann
2016-08-04 8:06 ` [PATCH 2/2] drm: make DRI1 drivers depend on BROKEN David Herrmann
2016-08-04 8:15 ` Chris Wilson
2016-08-25 11:14 ` Daniel Vetter [this message]
2016-08-25 15:04 ` Emil Velikov
2016-08-25 15:13 ` Alex Deucher
2016-08-25 16:37 ` Connor Behan
2016-08-26 4:52 ` Kevin Brace
2016-08-26 2:18 ` Dave Airlie
2016-08-04 8:13 ` [PATCH 1/2] drm: hide legacy drivers with CONFIG_DRM_LEGACY Chris Wilson
-- strict thread matches above, loose matches on Subject: below --
2016-08-26 0:19 [PATCH 2/2] drm: make DRI1 drivers depend on BROKEN Kevin Brace
2016-08-26 1:23 ` Emil Velikov
2016-08-26 3:04 ` Kevin Brace
2016-08-26 12:29 ` Emil Velikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160825111406.GQ10980@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=airlied@gmail.com \
--cc=chris@chris-wilson.co.uk \
--cc=daniel.vetter@ffwll.ch \
--cc=dh.herrmann@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox