From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/simple-helpers: Always add planes to the state update Date: Thu, 25 Aug 2016 20:46:49 +0200 Message-ID: <20160825184649.GU10980@phenom.ffwll.local> References: <1471933540-31131-1-git-send-email-daniel.vetter@ffwll.ch> <91379bfc-a1ea-ae1f-ada0-ec6f515dd2d8@tronnes.org> <20160825063047.GF10980@phenom.ffwll.local> <9fb8816d-48fd-6612-d430-ebb9c86c865b@tronnes.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-x241.google.com (mail-wm0-x241.google.com [IPv6:2a00:1450:400c:c09::241]) by gabe.freedesktop.org (Postfix) with ESMTPS id B357A6E08C for ; Thu, 25 Aug 2016 18:46:53 +0000 (UTC) Received: by mail-wm0-x241.google.com with SMTP id o80so8517573wme.0 for ; Thu, 25 Aug 2016 11:46:53 -0700 (PDT) Content-Disposition: inline In-Reply-To: <9fb8816d-48fd-6612-d430-ebb9c86c865b@tronnes.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Noralf =?iso-8859-1?Q?Tr=F8nnes?= Cc: andrea.merello@gmail.com, Daniel Vetter , DRI Development , Daniel Vetter List-Id: dri-devel@lists.freedesktop.org T24gVGh1LCBBdWcgMjUsIDIwMTYgYXQgMDc6MTM6MDdQTSArMDIwMCwgTm9yYWxmIFRyw7hubmVz IHdyb3RlOgo+IAo+IERlbiAyNS4wOC4yMDE2IDA4OjMwLCBza3JldiBEYW5pZWwgVmV0dGVyOgo+ ID4gT24gV2VkLCBBdWcgMjQsIDIwMTYgYXQgMDg6Mzg6MzdQTSArMDIwMCwgTm9yYWxmIFRyw7hu bmVzIHdyb3RlOgo+ID4gPiBEZW4gMjMuMDguMjAxNiAwODoyNSwgc2tyZXYgRGFuaWVsIFZldHRl cjoKPiA+ID4gPiBPdXIgdXBkYXRlIGZ1bmN0aW9uIGlzIGhvb2tlZCB0byB0aGUgc2luZ2xlIHBs YW5lLCB3aGljaCBtaWdodCBub3QgZ2V0Cj4gPiA+ID4gY2FsbGVkIGZvciBjcnRjLW9ubHkgdXBk YXRlcy4gV2hpY2ggaXMgc3VycHJpc2luZywgc28gZml4IHRoaXMgYnkKPiA+ID4gPiBhbHdheXMg YWRkaW5nIHRoZSBwbGFuZS4KPiA+ID4gPiAKPiA+ID4gPiBXaGlsZSBhdCBpdCBkb2N1bWVudCBo b3cmd2hlbiB0aGUgZXZlbnQgc2hvdWxkIGJlIHNlbnQgb3V0IGJldHRlciBpbgo+ID4gPiA+IHRo ZSBrZXJuZWxkb2MuCj4gPiA+ID4gCj4gPiA+ID4gQ2M6IE5vcmFsZiBUcsO4bm5lcyA8bm9yYWxm QHRyb25uZXMub3JnPgo+ID4gPiA+IENjOiBhbmRyZWEubWVyZWxsb0BnbWFpbC5jb20KPiA+ID4g PiBUZXN0ZWQtYW5kLVJlcG9ydGVkLWJ5OiBhbmRyZWEubWVyZWxsb0BnbWFpbC5jb20KPiA+ID4g PiBTaWduZWQtb2ZmLWJ5OiBEYW5pZWwgVmV0dGVyIDxkYW5pZWwudmV0dGVyQGludGVsLmNvbT4K PiA+ID4gPiAtLS0KPiA+ID4gPiBJJ20gbm90IGVudGlyZWx5IHN1cmUgd2UgcmVhbGx5IHdhbnQg dG8gcHV0IHRoZSByZXNwb25zaWJpbGl0eSBmb3IKPiA+ID4gPiB0aGlzIG9udG8gZHJpdmVyLiBQ bGFuIEIpIHdvdWxkIGJlIHRvIHJlbW92ZSB0aGUga2VybmVsZG9jIEkgYWRkZWQKPiA+ID4gPiBo ZXJlIGFuZCBjYWxsIHRoZSByaWdodCBmdW5jdGlvbiBmcm9tIGRybV9zaW1wbGVfa21zX3BsYW5l X2F0b21pY191cGRhdGUuCj4gPiA+ID4gVGhhdCB3YXkgc2ltcGxlIGRyaXZlcnMgZG9uJ3QgbmVl ZCB0byBkZWFsIHdpdGggdGhhdCBkZXRhaWwsIGFuZCBpbgo+ID4gPiA+IGdlbmVyYWwgdGhvc2Ug ZHJpdmVycyBkb24ndCBjYXJlIHRoYXQgbXVjaCBhYm91dCB0aGUgbWluaXNjdWxlCj4gPiA+ID4g cG9zc2libGUgcmFjZSBhIGdlbmVyaWMgaW1wbGVtZW50YXRpb24gd291bGQgY2F1c2UuIFdoYXQg ZG8geW91Cj4gPiA+ID4gc3VnZ2VzdCBhcyB0aGUgYmVzdCBhcHByb2FjaD8KPiA+ID4gSWYgdGhl IGRyaXZlciBpcyByZXNwb25zaWJsZSwgYSBoZWxwZXIgbGlrZSB0aGlzIHdvdWxkIGJlIG5pY2U6 Cj4gPiA+IAo+ID4gPiB2b2lkIGRybV9zaW1wbGVfZGlzcGxheV9waXBlX2hhbmRsZV92Ymxhbmtf ZXZlbnQoc3RydWN0Cj4gPiA+IGRybV9zaW1wbGVfZGlzcGxheV9waXBlICpwaXBlKQo+ID4gPiB7 Cj4gPiA+ICAgICAgc3RydWN0IGRybV9jcnRjICpjcnRjID0gJnBpcGUtPmNydGM7Cj4gPiA+IAo+ ID4gPiAgICAgIGlmIChjcnRjLT5zdGF0ZSAmJiBjcnRjLT5zdGF0ZS0+ZXZlbnQpIHsKPiA+ID4g ICAgICAgICAgc3Bpbl9sb2NrX2lycSgmY3J0Yy0+ZGV2LT5ldmVudF9sb2NrKTsKPiA+ID4gICAg ICAgICAgZHJtX2NydGNfc2VuZF92YmxhbmtfZXZlbnQoY3J0YywgY3J0Yy0+c3RhdGUtPmV2ZW50 KTsKPiA+ID4gICAgICAgICAgc3Bpbl91bmxvY2tfaXJxKCZjcnRjLT5kZXYtPmV2ZW50X2xvY2sp Owo+ID4gPiAgICAgICAgICBjcnRjLT5zdGF0ZS0+ZXZlbnQgPSBOVUxMOwo+ID4gRm9yIGEgZ2Vu ZXJpYyB2ZXJzaW9uIHdlIHByb2JhYmx5IHdhbnQgdG8gYXV0b21hdGljYWxseSBzd2l0Y2ggdG8K PiA+IGRybV9jcnRjX2FybV92YmxhbmtfZXZlbnQsIGlmIHZibGFuayBzdXBwb3J0IGlzIGF2YWls YWJsZS4gVGhhdCBjYW4gYmUKPiA+IGNoZWNrZWQgYnkgbG9va2luZyBhdCBkcm1fZGV2aWNlLT5u dW1fY3J0Y3MuCj4gPiAKPiA+ID4gICAgICB9Cj4gPiA+IH0KPiA+ID4gCj4gPiA+IFRoZW4gaWYg dGhlIHVwZGF0ZSgpIGNhbGxiYWNrIGlzIG5vdCBzZXQsIGRybV9zaW1wbGVfa21zX3BsYW5lX2F0 b21pY191cGRhdGUKPiA+ID4gY2FsbHMgdGhpcywgYW5kIGlmIGl0IGlzIHNldCwgdGhlbiB0aGUg ZHJpdmVyIGhhcyB0byBkbyBpdCBvciBzb21ldGhpbmcKPiA+ID4gc2ltaWxhci4KPiA+ID4gCj4g PiA+IEl0IGlzIGRpZmZpY3VsdCB0byBwcmVkaWN0IHdoYXQgZnV0dXJlIGRyaXZlcnMgd2lsbCBu ZWVkLgo+ID4gPiBVbmxlc3MgdGhlcmUgYXJlIGRyaXZlcnMgb24gdGhlIGhvcml6b24gdGhhdCB3 aWxsIG5lZWQgdG8gaGFuZGxlIHRoZQo+ID4gPiBldmVudCB0aGVtc2VsdmVzLCBJIHN1Z2dlc3Qg dGhhdCB3ZSBmb2xsb3cgeW91ciBwbGFuIEIuIElmIHRoZSBuZWVkIGFyaXNlcywKPiA+ID4gd2Ug anVzdCBhZGQgYSBvbmUtbGluZXIgdG8gYWxsIGRyaXZlcnMgdGhhdCBoYXMgdGhlIHVwZGF0ZSgp IGNhbGxiYWNrIHNldC4KPiA+IEhtIHllYWguIFdoYXQgYWJvdXQgbWVyZ2luZyB0aGlzIHBhdGNo IGhlcmUgZm9yIG5vdyAod291bGQgbmVlZCB5b3VyCj4gPiBmb3JtYWwgcmV2aWV3ZWQtYnkpLCBh bmQgdGhlbiBsYXRlciBvbiB3aGVuIHdlIGhhdmUgMi0zIHNpbXBsZSBkcml2ZXJzCj4gPiB1c2lu ZyB0aGlzIHdlIGNhbiByZWNvbnNpZGVyPyBTaW5jZSBJIGRvbnQgaGF2ZSBodyBmb3IgYW55IG9m IHRoZW0gSSBjYW4ndAo+ID4gZG8gdGhpcyBteXNlbGYuCj4gPiAKPiA+ID4gTm9yYWxmLgo+ID4g PiAKPiA+ID4gU2lkZW5vdGU6Cj4gPiA+IFdoZW4gSSBjb252ZXJ0ZWQgc2ltcGxlZHJtIEkgaGFk IHByb2JsZW1zIHdpdGggZmxpcF9kb25lIHRpbWVvdXRzLgo+ID4gPiBJbiB0aGUgZW5kIEkgaGFk IHRvIGNoZWNrIGZvciB0aGUgZXZlbnQgaW4gZGlzYWJsZS9lbmFibGUvdXBkYXRlLgo+ID4gPiBU cnlpbmcgaXQgYWdhaW4gbm93LCBpdCdzIGVub3VnaCB0byBkbyBpdCBpbiB1cGRhdGUoKS4KPiA+ ID4gTm90IHN1cmUgd2hhdCBoYXMgY2hhbmdlZC4KPiA+IFRyeWluZyBhZ2FpbiB3aXRoIHRoaXMg cGF0Y2gsIG9yIHdpdGhvdXQ/IFNpbmNlIHRoaXMgcGF0Y2ggaGVyZSBpcyBtZWFudAo+ID4gdG8g ZXhhY3RseSB0aGUgcHJvYmxlbSB0aGF0IHlvdSBuZWVkIHRvIGhhbmRsZSB0aGUgZXZlbnQgaW4g dG9vIG1hbnkKPiA+IHBsYWNlcy4gSWYgaXQncyBmaXhlZCB3aXRoIGp1c3QgbGF0ZXN0IGRybS1t aXNjLCB0aGF0IHdvdWxkIGJlIHN1cnByaXNpbmcKPiA+IC4uLgo+IAo+IEkgaGF2ZSB1cGRhdGVk IFJhc3BpYW4gc28gSSBjb3VsZCB1c2UgeG9yZyB0byB0ZXN0IHdpdGgsIGFuZCBpbmRlZWQKPiB3 aXRob3V0IHRoaXMgcGF0Y2ggYW5kIHdpdGhvdXQgc2VuZGluZyB2YmxhbmsgZXZlbnQgaW4gZGlz YWJsZSBhbmQgZW5hYmxlLAo+IHRoZSBmbGlwX2RvbmUgdGltZW91dCBzaG93ZWQgdXAuIG1vZGV0 ZXN0IC12IGRpZG4ndCB0cmlnZ2VyIGl0Lgo+IFdpdGggdGhpcyBwYXRjaCBJIG9ubHkgaGF2ZSB0 byBzZW5kIHRoZSB2YmxhbmsgZXZlbnQgaW4gdXBkYXRlKCkuCj4gCj4gUmV2aWV3ZWQtYnk6IE5v cmFsZiBUcsO4bm5lcyA8bm9yYWxmQHRyb25uZXMub3JnPgoKVGhhbmtzIGZvciB0aGUgcmV2aWV3 LCBwdXNoZWQgb250byAtbWlzYy4KLURhbmllbAoKPiAKPiA+IC1EYW5pZWwKPiA+IAo+ID4gPiA+ IC1EYW5pZWwKPiA+ID4gPiAtLS0KPiA+ID4gPiAgICBkcml2ZXJzL2dwdS9kcm0vZHJtX3NpbXBs ZV9rbXNfaGVscGVyLmMgfCA3ICsrKysrKysKPiA+ID4gPiAgICBpbmNsdWRlL2RybS9kcm1fc2lt cGxlX2ttc19oZWxwZXIuaCAgICAgfCA2ICsrKysrKwo+ID4gPiA+ICAgIDIgZmlsZXMgY2hhbmdl ZCwgMTMgaW5zZXJ0aW9ucygrKQo+ID4gPiA+IAo+ID4gPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJz L2dwdS9kcm0vZHJtX3NpbXBsZV9rbXNfaGVscGVyLmMgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX3Np bXBsZV9rbXNfaGVscGVyLmMKPiA+ID4gPiBpbmRleCBiYWRhMTcxNjY1MTIuLjQ0NzYzMTAxODQy NiAxMDA2NDQKPiA+ID4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vZHJtX3NpbXBsZV9rbXNfaGVs cGVyLmMKPiA+ID4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX3NpbXBsZV9rbXNfaGVscGVy LmMKPiA+ID4gPiBAQCAtMzQsNiArMzQsMTIgQEAgc3RhdGljIGNvbnN0IHN0cnVjdCBkcm1fZW5j b2Rlcl9mdW5jcyBkcm1fc2ltcGxlX2ttc19lbmNvZGVyX2Z1bmNzID0gewo+ID4gPiA+ICAgIAku ZGVzdHJveSA9IGRybV9lbmNvZGVyX2NsZWFudXAsCj4gPiA+ID4gICAgfTsKPiA+ID4gPiArc3Rh dGljIGludCBkcm1fc2ltcGxlX2ttc19jcnRjX2NoZWNrKHN0cnVjdCBkcm1fY3J0YyAqY3J0YywK PiA+ID4gPiArCQkJCSAgICAgc3RydWN0IGRybV9jcnRjX3N0YXRlICpzdGF0ZSkKPiA+ID4gPiAr ewo+ID4gPiA+ICsJcmV0dXJuIGRybV9hdG9taWNfYWRkX2FmZmVjdGVkX3BsYW5lcyhzdGF0ZS0+ c3RhdGUsIGNydGMpOwo+ID4gPiA+ICt9Cj4gPiA+ID4gKwo+ID4gPiA+ICAgIHN0YXRpYyB2b2lk IGRybV9zaW1wbGVfa21zX2NydGNfZW5hYmxlKHN0cnVjdCBkcm1fY3J0YyAqY3J0YykKPiA+ID4g PiAgICB7Cj4gPiA+ID4gICAgCXN0cnVjdCBkcm1fc2ltcGxlX2Rpc3BsYXlfcGlwZSAqcGlwZTsK PiA+ID4gPiBAQCAtNTcsNiArNjMsNyBAQCBzdGF0aWMgdm9pZCBkcm1fc2ltcGxlX2ttc19jcnRj X2Rpc2FibGUoc3RydWN0IGRybV9jcnRjICpjcnRjKQo+ID4gPiA+ICAgIH0KPiA+ID4gPiAgICBz dGF0aWMgY29uc3Qgc3RydWN0IGRybV9jcnRjX2hlbHBlcl9mdW5jcyBkcm1fc2ltcGxlX2ttc19j cnRjX2hlbHBlcl9mdW5jcyA9IHsKPiA+ID4gPiArCS5hdG9taWNfY2hlY2sgPSBkcm1fc2ltcGxl X2ttc19jcnRjX2NoZWNrLAo+ID4gPiA+ICAgIAkuZGlzYWJsZSA9IGRybV9zaW1wbGVfa21zX2Ny dGNfZGlzYWJsZSwKPiA+ID4gPiAgICAJLmVuYWJsZSA9IGRybV9zaW1wbGVfa21zX2NydGNfZW5h YmxlLAo+ID4gPiA+ICAgIH07Cj4gPiA+ID4gZGlmZiAtLWdpdCBhL2luY2x1ZGUvZHJtL2RybV9z aW1wbGVfa21zX2hlbHBlci5oIGIvaW5jbHVkZS9kcm0vZHJtX3NpbXBsZV9rbXNfaGVscGVyLmgK PiA+ID4gPiBpbmRleCAyNjkwMzk3MjJmOTEuLjgyNjk0NmNhMmI4MiAxMDA2NDQKPiA+ID4gPiAt LS0gYS9pbmNsdWRlL2RybS9kcm1fc2ltcGxlX2ttc19oZWxwZXIuaAo+ID4gPiA+ICsrKyBiL2lu Y2x1ZGUvZHJtL2RybV9zaW1wbGVfa21zX2hlbHBlci5oCj4gPiA+ID4gQEAgLTYwLDYgKzYwLDEy IEBAIHN0cnVjdCBkcm1fc2ltcGxlX2Rpc3BsYXlfcGlwZV9mdW5jcyB7Cj4gPiA+ID4gICAgCSAq Cj4gPiA+ID4gICAgCSAqIFRoaXMgZnVuY3Rpb24gaXMgY2FsbGVkIHdoZW4gdGhlIHVuZGVybHlp bmcgcGxhbmUgc3RhdGUgaXMgdXBkYXRlZC4KPiA+ID4gPiAgICAJICogVGhpcyBob29rIGlzIG9w dGlvbmFsLgo+ID4gPiA+ICsJICoKPiA+ID4gPiArCSAqIFRoaXMgaXMgdGhlIGZ1bmN0aW9uIGRy aXZlcnMgc2hvdWxkIHN1Ym1pdCB0aGUKPiA+ID4gPiArCSAqICZkcm1fcGVuZGluZ192Ymxhbmtf ZXZlbnQgZnJvbS4gVXNpbmcgZWl0aGVyCj4gPiA+ID4gKwkgKiBkcm1fY3J0Y19hcm1fdmJsYW5r X2V2ZW50KCksIHdoZW4gdGhlIGRyaXZlciBzdXBwb3J0cyB2YmxhbmsKPiA+ID4gPiArCSAqIGlu dGVycnVwdCBoYW5kbGluZywgb3IgZHJtX2NydGNfc2VuZF92YmxhbmtfZXZlbnQoKSBkaXJlY3Rs eSBpbiBjYXNlCj4gPiA+ID4gKwkgKiB0aGUgaGFyZHdhcmUgbGFja3MgdmJsYW5rIHN1cHBvcnQg ZW50aXJlbHkuCj4gPiA+ID4gICAgCSAqLwo+ID4gPiA+ICAgIAl2b2lkICgqdXBkYXRlKShzdHJ1 Y3QgZHJtX3NpbXBsZV9kaXNwbGF5X3BpcGUgKnBpcGUsCj4gPiA+ID4gICAgCQkgICAgICAgc3Ry dWN0IGRybV9wbGFuZV9zdGF0ZSAqcGxhbmVfc3RhdGUpOwo+IAoKLS0gCkRhbmllbCBWZXR0ZXIK U29mdHdhcmUgRW5naW5lZXIsIEludGVsIENvcnBvcmF0aW9uCmh0dHA6Ly9ibG9nLmZmd2xsLmNo Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZl bCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xp c3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=