From mboxrd@z Thu Jan 1 00:00:00 1970 From: Huang Rui Subject: Re: [PATCH] drm: amdgpu: mark symbols static where possible Date: Sat, 3 Sep 2016 17:10:11 +0800 Message-ID: <20160903091010.GA3730@hr-amur2> References: <1472882234-19385-1-git-send-email-baoyou.xie@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Return-path: Content-Disposition: inline In-Reply-To: <1472882234-19385-1-git-send-email-baoyou.xie@linaro.org> Sender: linux-kernel-owner@vger.kernel.org To: Baoyou Xie Cc: alexander.deucher@amd.com, christian.koenig@amd.com, airlied@linux.ie, Rex.Zhu@amd.com, Jammy.Zhou@amd.com, elfring@users.sourceforge.net, Young.Yang@amd.com, airlied@redhat.com, Mykola.Lysenko@amd.com, dan.carpenter@oracle.com, David1.Zhou@amd.com, Monk.Liu@amd.com, Jerry.Zhang@amd.com, samuel.li@amd.com, tom.stdenis@amd.com, Flora.Cui@amd.com, JinHuiEric.Huang@amd.com, funfunctor@folklore1984.net, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, arnd@arndb.de, xie.baoyou@zte.com.cn List-Id: dri-devel@lists.freedesktop.org On Sat, Sep 03, 2016 at 01:57:14PM +0800, Baoyou Xie wrote: > We get a few warnings when building kernel with W=1: > drivers/gpu/drm/amd/amdgpu/cz_smc.c:51:5: warning: no previous prototype for 'cz_send_msg_to_smc_async' [-Wmissing-prototypes] > drivers/gpu/drm/amd/amdgpu/cz_smc.c:143:5: warning: no previous prototype for 'cz_write_smc_sram_dword' [-Wmissing-prototypes] > drivers/gpu/drm/amd/amdgpu/iceland_smc.c:124:6: warning: no previous prototype for 'iceland_start_smc' [-Wmissing-prototypes] > drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c:3926:6: warning: no previous prototype for 'gfx_v8_0_rlc_stop' [-Wmissing-prototypes] > drivers/gpu/drm/amd/amdgpu/amdgpu_job.c:94:6: warning: no previous prototype for 'amdgpu_job_free_cb' [-Wmissing-prototypes] > .... > > In fact, these functions are only used in the file in which they are > declared and don't need a declaration, but can be made static. > So this patch marks these functions with 'static'. > > Signed-off-by: Baoyou Xie Thanks. Acked-by: Huang Rui