From mboxrd@z Thu Jan 1 00:00:00 1970 From: Huang Rui Subject: Re: [Updated PATCH v2] drm: modify drm_global_item_ref to avoid two times of writing ref->object Date: Wed, 7 Sep 2016 15:54:35 +0800 Message-ID: <20160907075435.GA13516@hr-amur2> References: <1473225871-2847-1-git-send-email-ray.huang@amd.com> <88949438-6e9e-502c-a543-9ca374411b1c@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <88949438-6e9e-502c-a543-9ca374411b1c-5C7GfCeVMHo@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: Christian =?iso-8859-1?Q?K=F6nig?= Cc: Dave Airlie , Daniel Vetter , dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, Sean Paul , amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, Alex Deucher , Ken Wang List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCBTZXAgMDcsIDIwMTYgYXQgMDk6MTI6MjlBTSArMDIwMCwgQ2hyaXN0aWFuIEvDtm5p ZyB3cm90ZToKPiBBbSAwNy4wOS4yMDE2IHVtIDA3OjI0IHNjaHJpZWIgSHVhbmcgUnVpOgo+ID5J biBwcmV2aW91cyBkcm1fZ2xvYmFsX2l0ZW1fcmVmLCB0aGVyZSBhcmUgdHdvIHRpbWVzIG9mIHdy aXRpbmcKPiA+cmVmLT5vYmplY3QgaWYgaXRlbS0+cmVmY291bnQgaXMgMC4gU28gdGhpcyBwYXRj aCBkb2VzIGEgbWlub3IgdXBkYXRlCj4gPnRvIHB1dCBhbGxvYyBhbmQgaW5pdCByZWYgZmlyc3Rs eSwgYW5kIHRoZW4gdG8gbW9kaWZ5IHRoZSBpdGVtIG9mIGdsb2IKPiA+YXJyYXkuIFVzZSAiZWxz ZSIgdG8gYXZvaWQgdHdvIHRpbWVzIG9mIHdyaXRpbmcgcmVmLT5vYmplY3QuIEl0IGNhbgo+ID5t YWtlIHRoZSBjb2RlIGxvZ2ljIG1vcmUgY2xlYXJseS4KPiA+Cj4gPlNpZ25lZC1vZmYtYnk6IEh1 YW5nIFJ1aSA8cmF5Lmh1YW5nQGFtZC5jb20+Cj4gCj4gV2VsbCB3aGVuIHlvdSB1cGRhdGUgeW91 ciBwYXRjaCwgZXZlbiB3aGVuIGl0J3MganVzdCBmaXhpbmcgYSBzbWFsbAo+IHR5cG8sIHBsZWFz ZSBpbmNyZWFzZSB0aGUgdmVyc2lvbiBudW1iZXIuCj4gCj4gVGhhdCBtYWtlcyBpdCBtdWNoIGVh c2llciB0byB0cmFjayB0aGUgZGlmZmVyZW50IGluc3RhbmNlcyBvZiBhIHBhdGNoLgo+IAoKT0su Cgo+IEEgZmV3IGFkZGl0aW9uYWwgbm90ZXMgYmVsb3cuCj4gCj4gPi0tLQo+ID4KPiA+Q2hhbmdl cyBmcm9tIFYxIC0+IFYyOgo+ID4tIEFkZCBrZnJlZSBleGNlcHRpb25hbCBoYW5kbGUgdG8gYXZv aWQgbWVtb3J5IGxlYWsuCj4gPi0gSW1wcm92ZSBjb2RlIHN0eWxlLgo+ID4KPiA+LS0tCj4gPiAg ZHJpdmVycy9ncHUvZHJtL2RybV9nbG9iYWwuYyB8IDIzICsrKysrKysrKysrKystLS0tLS0tLS0t Cj4gPiAgMSBmaWxlIGNoYW5nZWQsIDEzIGluc2VydGlvbnMoKyksIDEwIGRlbGV0aW9ucygtKQo+ ID4KPiA+ZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fZ2xvYmFsLmMgYi9kcml2ZXJz L2dwdS9kcm0vZHJtX2dsb2JhbC5jCj4gPmluZGV4IDNkMmU5MWMuLmIxODFlODEgMTAwNjQ0Cj4g Pi0tLSBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fZ2xvYmFsLmMKPiA+KysrIGIvZHJpdmVycy9ncHUv ZHJtL2RybV9nbG9iYWwuYwo+ID5AQCAtNjUsMzAgKzY1LDMzIEBAIHZvaWQgZHJtX2dsb2JhbF9y ZWxlYXNlKHZvaWQpCj4gPiAgaW50IGRybV9nbG9iYWxfaXRlbV9yZWYoc3RydWN0IGRybV9nbG9i YWxfcmVmZXJlbmNlICpyZWYpCj4gPiAgewo+ID4tCWludCByZXQ7Cj4gPisJaW50IHJldCA9IDA7 Cj4gPiAgCXN0cnVjdCBkcm1fZ2xvYmFsX2l0ZW0gKml0ZW0gPSAmZ2xvYltyZWYtPmdsb2JhbF90 eXBlXTsKPiA+ICAJbXV0ZXhfbG9jaygmaXRlbS0+bXV0ZXgpOwo+ID4gIAlpZiAoaXRlbS0+cmVm Y291bnQgPT0gMCkgewo+ID4tCQlpdGVtLT5vYmplY3QgPSBremFsbG9jKHJlZi0+c2l6ZSwgR0ZQ X0tFUk5FTCk7Cj4gPi0JCWlmICh1bmxpa2VseShpdGVtLT5vYmplY3QgPT0gTlVMTCkpIHsKPiA+ KwkJcmVmLT5vYmplY3QgPSBremFsbG9jKHJlZi0+c2l6ZSwgR0ZQX0tFUk5FTCk7Cj4gPisJCWlm ICh1bmxpa2VseShyZWYtPm9iamVjdCA9PSBOVUxMKSkgewo+ID4gIAkJCXJldCA9IC1FTk9NRU07 Cj4gPi0JCQlnb3RvIG91dF9lcnI7Cj4gPisJCQlnb3RvIG91dDsKPiA+ICAJCX0KPiA+LQo+ID4t CQlyZWYtPm9iamVjdCA9IGl0ZW0tPm9iamVjdDsKPiA+ICAJCXJldCA9IHJlZi0+aW5pdChyZWYp Owo+ID4gIAkJaWYgKHVubGlrZWx5KHJldCAhPSAwKSkKPiA+ICAJCQlnb3RvIG91dF9lcnI7Cj4g PisJCWl0ZW0tPm9iamVjdCA9IHJlZi0+b2JqZWN0Owo+ID4rCX0gZWxzZSB7Cj4gPisJCXJlZi0+ b2JqZWN0ID0gaXRlbS0+b2JqZWN0Owo+ID4gIAl9Cj4gPisKPiA+ICAJKytpdGVtLT5yZWZjb3Vu dDsKPiA+LQlyZWYtPm9iamVjdCA9IGl0ZW0tPm9iamVjdDsKPiA+LQltdXRleF91bmxvY2soJml0 ZW0tPm11dGV4KTsKPiA+LQlyZXR1cm4gMDsKPiA+Kwlnb3RvIG91dDsKPiAKPiBBIGdvdG8gaW4g dGhlIG5vdCBlcnJvciBwYXRoIGlzIGEgYml0IHVudXN1YWwuIFNpbmNlIG91dF9lcnIgaXMgb25s eQo+IHVzZWQgb25jZSBjb3VsZG4ndCB5b3UganVzdCBtb3ZlIHRoZSBjb2RlIGludG8gdGhlIGlm IGFuZCB0aGVuIGdvdG8KPiB0byBvdXQgYXMgd2VsbD8KPiAKPiBBbHRlcm5hdGl2ZSB5b3UgY291 bGQganVzdCBkdXBsaWNhdGUgdGhlIG11dGV4IHJlbGVhc2UgaW4gdGhlCj4gbm9uLWVycm9yIHBh dGguCj4gCgpBY3R1YWxseSwgSSBhbHNvIGhhdmUgYSBsaXR0bGUgY29uY2VybiB3aXRoICJnb3Rv IiBpbiBub24tZXJyb3IgcGF0aC4gQnV0CmFzIFNlYW4ncyBzdWdnZXN0aW9uLCB1c2UgImdvdG8i IGNhbiBhdm9pZCBhIGR1cGxpY2F0ZSBtdXRleCByZWxlYXNlLCB5b3UKa25vdy4KCkBTZWFuLCBp ZiB5b3UgZG9uJ3QgaGF2ZSBjb25jZXJuIHdpdGggYWRkaW5nIGEgbXV0ZXggcmVsZWFzZSBiZWxv dywgSSB3aWxsCnVwZGF0ZSBpdCBpbiBWMy4KCi0tLQogICAgICAgICsraXRlbS0+cmVmY291bnQ7 CiAgICAgICAgbXV0ZXhfdW5sb2NrKCZpdGVtLT5tdXRleCk7CiAgICAgICAgcmV0dXJuIDA7Cgpv dXRfZXJyOgogICAgICAgIGtmcmVlKHJlZi0+b2JqZWN0KTsKICAgICAgICByZWYtPm9iamVjdCA9 IE5VTEw7Cm91dDoKICAgICAgICBtdXRleF91bmxvY2soJml0ZW0tPm11dGV4KTsKICAgICAgICBy ZXR1cm4gcmV0OwotLS0KCgpUaGFua3MsClJ1aQpfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwphbWQtZ2Z4IG1haWxpbmcgbGlzdAphbWQtZ2Z4QGxpc3RzLmZy ZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2FtZC1nZngK