From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Baoyou Xie <baoyou.xie@linaro.org>
Cc: arnd@arndb.de, xie.baoyou@zte.com.cn,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
wens@csie.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] drm/sun4i: add missing header dependencies
Date: Thu, 8 Sep 2016 14:56:01 +0200 [thread overview]
Message-ID: <20160908125601.GQ8913@lukather> (raw)
In-Reply-To: <1473332362-25497-1-git-send-email-baoyou.xie@linaro.org>
[-- Attachment #1.1: Type: text/plain, Size: 1168 bytes --]
On Thu, Sep 08, 2016 at 06:59:22PM +0800, Baoyou Xie wrote:
> We get 5 warnings when building kernel with W=1:
> drivers/gpu/drm/sun4i/sun4i_framebuffer.c:33:23: warning: no previous prototype for 'sun4i_framebuffer_init' [-Wmissing-prototypes]
> drivers/gpu/drm/sun4i/sun4i_framebuffer.c:47:6: warning: no previous prototype for 'sun4i_framebuffer_free' [-Wmissing-prototypes]
> drivers/gpu/drm/sun4i/sun4i_rgb.c:202:5: warning: no previous prototype for 'sun4i_rgb_init' [-Wmissing-prototypes]
> drivers/gpu/drm/sun4i/sun4i_dotclock.c:151:5: warning: no previous prototype for 'sun4i_dclk_create' [-Wmissing-prototypes]
> drivers/gpu/drm/sun4i/sun4i_dotclock.c:186:5: warning: no previous prototype for 'sun4i_dclk_free' [-Wmissing-prototypes]
>
> In fact, these functions are declared in
> drivers/gpu/drm/sun4i/sun4i_framebuffer.h,
> drivers/gpu/drm/sun4i/sun4i_rgb.h,
> drivers/gpu/drm/sun4i/sun4i_dotclock.h,
> so this patch adds missing header dependencies.
>
> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
Applied, thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2016-09-08 12:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-08 10:59 [PATCH] drm/sun4i: add missing header dependencies Baoyou Xie
2016-09-08 12:56 ` Maxime Ripard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160908125601.GQ8913@lukather \
--to=maxime.ripard@free-electrons.com \
--cc=arnd@arndb.de \
--cc=baoyou.xie@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wens@csie.org \
--cc=xie.baoyou@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).