From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Donnellan Subject: [PATCH RESEND] drm/ast: free correct pointer in astfb_create() error paths Date: Tue, 20 Sep 2016 11:56:49 +1000 Message-ID: <20160920015649.31509-1-andrew.donnellan@au1.ibm.com> References: <20160919071346.580-1-andrew.donnellan@au1.ibm.com> Return-path: In-Reply-To: <20160919071346.580-1-andrew.donnellan@au1.ibm.com> Sender: linux-kernel-owner@vger.kernel.org To: airlied@linux.ie, dri-devel@lists.freedesktop.org Cc: linux-kernel@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org In the err_free_vram and err_release_fbi error paths in astfb_create(), we attempt to free afbdev->sysram. The only jumps to these error paths occur before we assign afbdev->sysram = sysram. Free sysram instead. Signed-off-by: Andrew Donnellan --- Found by Coverity Scan. Compile tested only. Resending as it looks like this didn't hit dri-devel. --- drivers/gpu/drm/ast/ast_fb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/ast/ast_fb.c b/drivers/gpu/drm/ast/ast_fb.c index c017a93..0fef8ea 100644 --- a/drivers/gpu/drm/ast/ast_fb.c +++ b/drivers/gpu/drm/ast/ast_fb.c @@ -254,7 +254,7 @@ static int astfb_create(struct drm_fb_helper *helper, err_release_fbi: drm_fb_helper_release_fbi(helper); err_free_vram: - vfree(afbdev->sysram); + vfree(sysram); return ret; } -- Andrew Donnellan OzLabs, ADL Canberra andrew.donnellan@au1.ibm.com IBM Australia Limited