From mboxrd@z Thu Jan 1 00:00:00 1970 From: Russell King - ARM Linux Subject: Re: [PATCH] drm/i2c: tda998x: don't register the connector Date: Fri, 23 Sep 2016 15:05:03 +0100 Message-ID: <20160923140503.GY1041@n2100.armlinux.org.uk> References: <20160921162803.GS1041@n2100.armlinux.org.uk> <20160922103917.GA5632@e106950-lin.cambridge.arm.com> <20160922105155.GT1041@n2100.armlinux.org.uk> <20160922141404.GA5222@e106950-lin.cambridge.arm.com> <20160923093416.GU8917@e106497-lin.cambridge.arm.com> <20160923125248.GA23321@e106950-lin.cambridge.arm.com> <20160923131315.GI3988@dvetter-linux.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20160923131315.GI3988@dvetter-linux.ger.corp.intel.com> Sender: linux-kernel-owner@vger.kernel.org To: Daniel Vetter Cc: Brian Starkey , Liviu Dudau , Sean Paul , Linux Kernel Mailing List , dri-devel List-Id: dri-devel@lists.freedesktop.org On Fri, Sep 23, 2016 at 03:13:15PM +0200, Daniel Vetter wrote: > Hm, maybe we should simply not call ->lastclose for kms drivers. That is > kinda only a hack for ums/dri1 drivers. Are you sure about that - isn't it needed so that the fbdev mode gets restored when the last DRM user exits, so that the VT consoles becomes functional again? I ended up needing a call to drm_fb_helper_restore_fbdev_mode_unlocked() in Armada's ->lastclose to ensure that VT consoles worked after Xorg was shutdown. -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net.