From mboxrd@z Thu Jan 1 00:00:00 1970 From: Russell King - ARM Linux Subject: Re: [PATCH] drm/i2c: mark tda998x_audio_digital_mute() static Date: Mon, 26 Sep 2016 16:17:52 +0100 Message-ID: <20160926151752.GF1041@n2100.armlinux.org.uk> References: <1474790359-17416-1-git-send-email-baoyou.xie@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1474790359-17416-1-git-send-email-baoyou.xie@linaro.org> Sender: linux-kernel-owner@vger.kernel.org To: Baoyou Xie Cc: airlied@linux.ie, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, arnd@arndb.de, xie.baoyou@zte.com.cn, han.fei@zte.comm.cn, tang.qiang007@zte.com.cn List-Id: dri-devel@lists.freedesktop.org On Sun, Sep 25, 2016 at 03:59:19PM +0800, Baoyou Xie wrote: > We get 1 warning when building kernel with W=1: > drivers/gpu/drm/i2c/tda998x_drv.c:1292:5: warning: no previous prototype for 'tda998x_audio_digital_mute' [-Wmissing-prototypes] > > In fact, this function is only used in the file in which it is > declared and don't need a declaration, but can be made static. > So this patch marks it 'static'. > > Signed-off-by: Baoyou Xie > --- > drivers/gpu/drm/i2c/tda998x_drv.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i2c/tda998x_drv.c b/drivers/gpu/drm/i2c/tda998x_drv.c > index 9798d40..8bf6611 100644 > --- a/drivers/gpu/drm/i2c/tda998x_drv.c > +++ b/drivers/gpu/drm/i2c/tda998x_drv.c > @@ -1289,7 +1289,7 @@ static void tda998x_audio_shutdown(struct device *dev, void *data) > mutex_unlock(&priv->audio_mutex); > } > > -int tda998x_audio_digital_mute(struct device *dev, void *data, bool enable) > +static int tda998x_audio_digital_mute(struct device *dev, void *data, bool enable) This causes the line to violate the coding style. Please place "bool enable" on the following line, thanks. > { > struct tda998x_priv *priv = dev_get_drvdata(dev); > > -- > 2.7.4 > -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net.