From: Lukas Wunner <lukas@wunner.de>
To: Grazvydas Ignotas <notasas@gmail.com>
Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/amdgpu: disable CRTCs before teardown
Date: Mon, 26 Sep 2016 19:29:14 +0200 [thread overview]
Message-ID: <20160926172914.GA5379@wunner.de> (raw)
In-Reply-To: <1474835690-2621-3-git-send-email-notasas@gmail.com>
On Sun, Sep 25, 2016 at 11:34:48PM +0300, Grazvydas Ignotas wrote:
> Some code called by drm_crtc_force_disable_all() wants to wait for all
> fences, so only do fence teardown after CRTCs are disabled.
Ugh, how embarrassing, that was added by me.
Do you have a BUG splat (e.g. soft lockup) for this? I'd be curious to
see exactly where things explode, would also be good to have that in
the commit message.
Thanks!
Lukas
>
> Signed-off-by: Grazvydas Ignotas <notasas@gmail.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> index 99a15ca..1a1bc79 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> @@ -1822,11 +1822,11 @@ void amdgpu_device_fini(struct amdgpu_device *adev)
>
> DRM_INFO("amdgpu: finishing device.\n");
> adev->shutdown = true;
> + drm_crtc_force_disable_all(adev->ddev);
> /* evict vram memory */
> amdgpu_bo_evict_vram(adev);
> amdgpu_ib_pool_fini(adev);
> amdgpu_fence_driver_fini(adev);
> - drm_crtc_force_disable_all(adev->ddev);
> amdgpu_fbdev_fini(adev);
> r = amdgpu_fini(adev);
> kfree(adev->ip_block_status);
> --
> 2.7.4
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2016-09-26 17:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-25 20:34 [PATCH] drm/amdgpu: disable CRTCs before teardown Grazvydas Ignotas
2016-09-26 17:29 ` Lukas Wunner [this message]
2016-09-26 23:00 ` Grazvydas Ignotas
2016-09-26 17:39 ` Lukas Wunner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160926172914.GA5379@wunner.de \
--to=lukas@wunner.de \
--cc=amd-gfx@lists.freedesktop.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=notasas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).