From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Ripard Subject: Re: [PATCH] drm/sun4i: rgb: Enable panel after controller Date: Thu, 29 Sep 2016 14:04:45 +0200 Message-ID: <20160929120445.GQ4189@lukather> References: <20160921130304.3486-1-net147@gmail.com> <20160921210340.GI8719@lukather> <20160923131626.GX8719@lukather> <20160924201813.GE16901@lukather> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0313344177==" Return-path: Received: from mail.free-electrons.com (down.free-electrons.com [37.187.137.238]) by gabe.freedesktop.org (Postfix) with ESMTP id 0B1326E8BB for ; Thu, 29 Sep 2016 17:26:11 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Sean Paul Cc: "dri-devel@lists.freedesktop.org" , Jonathan Liu , Chen-Yu Tsai , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" List-Id: dri-devel@lists.freedesktop.org --===============0313344177== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="8N5nZmKALFZnI1Hj" Content-Disposition: inline --8N5nZmKALFZnI1Hj Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Tue, Sep 27, 2016 at 10:42:09AM -0400, Sean Paul wrote: > As an aside, it seems like (from the diff, I haven't looked at the > code) the bridge_pre_enable and bridge_post_disable calls are missing, > and the enable/disable calls are in the wrong place. Actually, I don't even think that's necessary. The atomic helpers already call drm_bridge_pre_enable and drm_bridge_enable at the right time. So I guess the proper fix would be to just remove the driver's call to drm_bridge_enable. Thanks! Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --8N5nZmKALFZnI1Hj Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJX7QNdAAoJEBx+YmzsjxAgnn4P/A+Pu2kdoigfQhbx6+RSUQbS u9WOn27tcU1JtUVrzy1tubyctXnEckCCwDNl5sBZQUUyyEQ1vcU1MmdWZdEndVBK Lk5z/+n3qvtXhQIaBlg7kss9uF++rJUVYwFFMQaPBnbT7dFgU44E3IJcjwp3mtR0 QTqvw0lBTu0bwlUuzH7NPXH/cXa/Ff+Up0N1qNLoFkASAI3SdAu+xecQ5q2aMpiI XIKpwrtRGRrvJbNqBmaLlvTl9IIopWkHWiRQPiOPNzdRGPSADLSHMCeIZR9vXgbl f2M1/Is2VNWS2YhGT1+r/SVmgqHtfWEKJs5fm5DBcKtfBYE/kE+fcp6pGsfeopmI fX7/mT7mtcPF9Hlf8JDNgUoOaSn9tF+f8RbSunvYTqAQDRmrN9s4/vyu+ZL1pdDA fSQTFNM67TdANEyIm1ruj8UDTG+PRZeAXMP1tfuUtGUiLJg087lOg5NjasYy6tFy I/nkRS5stGYbFBzE1+0e0K0gBHdp7+fEbxBNvn+Gg86W08EsYsZ5dIkJJGjaEu01 FuSisehnb9+nZs7zZqJskegFZtn3m2UVc9O92g/MNSAucDNf9/XmFQc86+1Mm6Ao Prrtes9b2O0QPB/5uTvy34+1cxwBfw9+WQhiI0k0mjXEzvLkgS3+NCBV3Gb0qknS SCOg5OIqE1Qd6sDt12PW =WaOL -----END PGP SIGNATURE----- --8N5nZmKALFZnI1Hj-- --===============0313344177== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============0313344177==--