From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Brezillon Subject: Re: [PATCH] drm/sun4i: Check that the plane coordinates are not negative Date: Fri, 30 Sep 2016 18:08:26 +0200 Message-ID: <20160930180826.169e3daf@bbrezillon> References: <20160930143320.26241-1-maxime.ripard@free-electrons.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail.free-electrons.com (down.free-electrons.com [37.187.137.238]) by gabe.freedesktop.org (Postfix) with ESMTP id 722596E175 for ; Fri, 30 Sep 2016 16:08:28 +0000 (UTC) In-Reply-To: <20160930143320.26241-1-maxime.ripard@free-electrons.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Maxime Ripard Cc: Daniel Vetter , Chen-Yu Tsai , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org List-Id: dri-devel@lists.freedesktop.org T24gRnJpLCAzMCBTZXAgMjAxNiAxNjozMzoyMCArMDIwMApNYXhpbWUgUmlwYXJkIDxtYXhpbWUu cmlwYXJkQGZyZWUtZWxlY3Ryb25zLmNvbT4gd3JvdGU6Cgo+IE91ciBwbGFuZXMgY2Fubm90IGJl IHNldCBhdCBuZWdhdGl2ZSBjb29yZGluYXRlcy4gTWFrZSBzdXJlIHdlIHJlamVjdCBzdWNoCj4g Y29uZmlndXJhdGlvbi4KPiAKPiBSZXBvcnRlZC1ieTogQm9yaXMgQnJlemlsbG9uIDxib3Jpcy5i cmV6aWxsb25AZnJlZS1lbGVjdHJvbnMuY29tPgo+IFNpZ25lZC1vZmYtYnk6IE1heGltZSBSaXBh cmQgPG1heGltZS5yaXBhcmRAZnJlZS1lbGVjdHJvbnMuY29tPgo+IC0tLQo+ICBkcml2ZXJzL2dw dS9kcm0vc3VuNGkvc3VuNGlfbGF5ZXIuYyB8IDMgKysrCj4gIDEgZmlsZSBjaGFuZ2VkLCAzIGlu c2VydGlvbnMoKykKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL3N1bjRpL3N1bjRp X2xheWVyLmMgYi9kcml2ZXJzL2dwdS9kcm0vc3VuNGkvc3VuNGlfbGF5ZXIuYwo+IGluZGV4IGYw MDM1YmY1ZWZlYS4uZjU0NjNjNGMyY2RlIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9z dW40aS9zdW40aV9sYXllci5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL3N1bjRpL3N1bjRpX2xh eWVyLmMKPiBAQCAtMjksNiArMjksOSBAQCBzdHJ1Y3Qgc3VuNGlfcGxhbmVfZGVzYyB7Cj4gIHN0 YXRpYyBpbnQgc3VuNGlfYmFja2VuZF9sYXllcl9hdG9taWNfY2hlY2soc3RydWN0IGRybV9wbGFu ZSAqcGxhbmUsCj4gIAkJCQkJICAgIHN0cnVjdCBkcm1fcGxhbmVfc3RhdGUgKnN0YXRlKQo+ICB7 Cj4gKwlpZiAoKHN0YXRlLT5jcnRjX3ggPCAwKSB8fCAoc3RhdGUtPmNydGNfeSA8IDApKQo+ICsJ CXJldHVybiAtRUlOVkFMOwo+ICsKCkhtLCBJIHRoaW5rIGl0J3MgYSBwZXJmZWN0bHkgdmFsaWQg dXNlIGNhc2UgZnJvbSB0aGUgRFJNIGZyYW1ld29yayBhbmQKRFJNIHVzZXIgUG9WOiB5b3UgbWF5 IHdhbnQgdG8gcGxhY2UgeW91ciBwbGFuZSBhdCBhIG5lZ2F0aXZlIENSVEMKb2Zmc2V0ICh3aGlj aCBtZWFucyBwYXJ0IG9mIHRoZSBwbGFuZSB3aWxsIGJlIGhpZGRlbikuCgpNYXliZSBJJ20gd3Jv bmcsIGJ1dCBpdCBzZWVtcyB5b3UgY2FuIHN1cHBvcnQgdGhhdCBieSBhZGFwdGluZyB0aGUKc3Rh cnQgYWRkcmVzcyBvZiB5b3VyIGZyYW1lYnVmZmVyIHBvaW50ZXIgYW5kIHRoZSBsYXllciBzaXpl LgoKSGF2ZSB5b3UgdHJpZWQgZG9pbmcgc29tZXRoaW5nIGxpa2UgdGhhdD8KCi0tLT44LS0tCmRp ZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vc3VuNGkvc3VuNGlfYmFja2VuZC5jIGIvZHJpdmVy cy9ncHUvZHJtL3N1bjRpL3N1bjRpX2JhY2tlbmQuYwppbmRleCAzYWI1NjA0NTBhODIuLjZiNjg4 MDRmMzAzNSAxMDA2NDQKLS0tIGEvZHJpdmVycy9ncHUvZHJtL3N1bjRpL3N1bjRpX2JhY2tlbmQu YworKysgYi9kcml2ZXJzL2dwdS9kcm0vc3VuNGkvc3VuNGlfYmFja2VuZC5jCkBAIC0xMTAsMTUg KzExMCwzMCBAQCBpbnQgc3VuNGlfYmFja2VuZF91cGRhdGVfbGF5ZXJfY29vcmQoc3RydWN0IHN1 bjRpX2JhY2tlbmQgKmJhY2tlbmQsCiB7CiAgICAgICAgc3RydWN0IGRybV9wbGFuZV9zdGF0ZSAq c3RhdGUgPSBwbGFuZS0+c3RhdGU7CiAgICAgICAgc3RydWN0IGRybV9mcmFtZWJ1ZmZlciAqZmIg PSBzdGF0ZS0+ZmI7CisgICAgICAgaW50IGNydGNfdywgY3J0Y19oLCBjcnRjX3gsIGNydGNfeTsK IAogICAgICAgIERSTV9ERUJVR19EUklWRVIoIlVwZGF0aW5nIGxheWVyICVkXG4iLCBsYXllcik7 CiAKKyAgICAgICBjcnRjX3ggPSBzdGF0ZS0+Y3J0Y194OworICAgICAgIGNydGNfeSA9IHN0YXRl LT5jcnRjX3k7CisgICAgICAgY3J0Y193ID0gc3RhdGUtPmNydGNfdzsKKyAgICAgICBjcnRjX2gg PSBzdGF0ZS0+Y3J0Y19oOworCisgICAgICAgaWYgKGNydGNfeCA8IDApIHsKKyAgICAgICAgICAg ICAgIGNydGNfdyArPSBjcnR4X3g7CisgICAgICAgICAgICAgICBjcnRjX3ggPSAwOworICAgICAg IH0KKworICAgICAgIGlmIChjcnRjX3kgPCAwKSB7CisgICAgICAgICAgICAgICBjcnRjX2ggKz0g Y3J0eF95OworICAgICAgICAgICAgICAgY3J0Y195ID0gMDsKKyAgICAgICB9CisKICAgICAgICBp ZiAocGxhbmUtPnR5cGUgPT0gRFJNX1BMQU5FX1RZUEVfUFJJTUFSWSkgewogICAgICAgICAgICAg ICAgRFJNX0RFQlVHX0RSSVZFUigiUHJpbWFyeSBsYXllciwgdXBkYXRpbmcgZ2xvYmFsIHNpemUg VzogJXUgSDogJXVcbiIsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHN0YXRlLT5j cnRjX3csIHN0YXRlLT5jcnRjX2gpOwogICAgICAgICAgICAgICAgcmVnbWFwX3dyaXRlKGJhY2tl bmQtPnJlZ3MsIFNVTjRJX0JBQ0tFTkRfRElTU0laRV9SRUcsCi0gICAgICAgICAgICAgICAgICAg ICAgICAgICAgU1VONElfQkFDS0VORF9ESVNTSVpFKHN0YXRlLT5jcnRjX3csCi0gICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHN0YXRlLT5jcnRjX2gpKTsK KyAgICAgICAgICAgICAgICAgICAgICAgICAgICBTVU40SV9CQUNLRU5EX0RJU1NJWkUoY3J0Y193 LCBjcnRjX2gpKTsKICAgICAgICB9CiAKICAgICAgICAvKiBTZXQgdGhlIGxpbmUgd2lkdGggKi8K QEAgLTEzMCwxNSArMTQ1LDEzIEBAIGludCBzdW40aV9iYWNrZW5kX3VwZGF0ZV9sYXllcl9jb29y ZChzdHJ1Y3Qgc3VuNGlfYmFja2VuZCAqYmFja2VuZCwKICAgICAgICBEUk1fREVCVUdfRFJJVkVS KCJMYXllciBzaXplIFc6ICV1IEg6ICV1XG4iLAogICAgICAgICAgICAgICAgICAgICAgICAgc3Rh dGUtPmNydGNfdywgc3RhdGUtPmNydGNfaCk7CiAgICAgICAgcmVnbWFwX3dyaXRlKGJhY2tlbmQt PnJlZ3MsIFNVTjRJX0JBQ0tFTkRfTEFZU0laRV9SRUcobGF5ZXIpLAotICAgICAgICAgICAgICAg ICAgICBTVU40SV9CQUNLRU5EX0xBWVNJWkUoc3RhdGUtPmNydGNfdywKLSAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIHN0YXRlLT5jcnRjX2gpKTsKKyAgICAgICAgICAg ICAgICAgICAgU1VONElfQkFDS0VORF9MQVlTSVpFKGNydGNfdywgY3J0Y19oKSk7CiAKICAgICAg ICAvKiBTZXQgYmFzZSBjb29yZGluYXRlcyAqLwogICAgICAgIERSTV9ERUJVR19EUklWRVIoIkxh eWVyIGNvb3JkaW5hdGVzIFg6ICVkIFk6ICVkXG4iLAogICAgICAgICAgICAgICAgICAgICAgICAg c3RhdGUtPmNydGNfeCwgc3RhdGUtPmNydGNfeSk7CiAgICAgICAgcmVnbWFwX3dyaXRlKGJhY2tl bmQtPnJlZ3MsIFNVTjRJX0JBQ0tFTkRfTEFZQ09PUl9SRUcobGF5ZXIpLAotICAgICAgICAgICAg ICAgICAgICBTVU40SV9CQUNLRU5EX0xBWUNPT1Ioc3RhdGUtPmNydGNfeCwKLSAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHN0YXRlLT5jcnRjX3kpKTsKKyAgICAgICAg ICAgICAgICAgICAgU1VONElfQkFDS0VORF9MQVlDT09SKGNydGNfeCwgY3J0Y195KSk7CiAKICAg ICAgICByZXR1cm4gMDsKIH0KQEAgLTE5OCw2ICsyMTEsMTIgQEAgaW50IHN1bjRpX2JhY2tlbmRf dXBkYXRlX2xheWVyX2J1ZmZlcihzdHJ1Y3Qgc3VuNGlfYmFja2VuZCAqYmFja2VuZCwKICAgICAg ICBwYWRkciArPSAoc3RhdGUtPnNyY194ID4+IDE2KSAqIGJwcDsKICAgICAgICBwYWRkciArPSAo c3RhdGUtPnNyY195ID4+IDE2KSAqIGZiLT5waXRjaGVzWzBdOwogCisgICAgICAgaWYgKHN0YXRl LT5jcnRjX3ggPCAwKQorICAgICAgICAgICAgICAgcGFkZHIgLT0gYnBwICogc3RhdGUtPmNydGNf eDsKKworICAgICAgIGlmIChzdGF0ZS0+Y3J0Y195IDwgMCkKKyAgICAgICAgICAgICAgIHBhZGRy IC09IGZiLT5waXRjaGVzWzBdICogc3RhdGUtPmNydGNfeTsKKwogICAgICAgIERSTV9ERUJVR19E UklWRVIoIlNldHRpbmcgYnVmZmVyIGFkZHJlc3MgdG8gJXBhZFxuIiwgJnBhZGRyKTsKIAogICAg ICAgIC8qIFdyaXRlIHRoZSAzMiBsb3dlciBiaXRzIG9mIHRoZSBhZGRyZXNzIChpbiBiaXRzKSAq LwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2 ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9s aXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK