From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Brezillon Subject: Re: [PATCH] drm/sun4i: Check that the plane coordinates are not negative Date: Fri, 30 Sep 2016 18:33:48 +0200 Message-ID: <20160930183348.75541582@bbrezillon> References: <20160930143320.26241-1-maxime.ripard@free-electrons.com> <20160930180826.169e3daf@bbrezillon> <20160930162211.GQ4329@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail.free-electrons.com (down.free-electrons.com [37.187.137.238]) by gabe.freedesktop.org (Postfix) with ESMTP id 99F266EAA4 for ; Fri, 30 Sep 2016 16:33:50 +0000 (UTC) In-Reply-To: <20160930162211.GQ4329@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Ville =?UTF-8?B?U3lyasOkbMOk?= Cc: linux-arm-kernel@lists.infradead.org, Daniel Vetter , Maxime Ripard , Chen-Yu Tsai , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gRnJpLCAzMCBTZXAgMjAxNiAxOToyMjoxMSArMDMwMApWaWxsZSBTeXJqw6Rsw6QgPHZpbGxl LnN5cmphbGFAbGludXguaW50ZWwuY29tPiB3cm90ZToKCj4gT24gRnJpLCBTZXAgMzAsIDIwMTYg YXQgMDY6MDg6MjZQTSArMDIwMCwgQm9yaXMgQnJlemlsbG9uIHdyb3RlOgo+ID4gT24gRnJpLCAz MCBTZXAgMjAxNiAxNjozMzoyMCArMDIwMAo+ID4gTWF4aW1lIFJpcGFyZCA8bWF4aW1lLnJpcGFy ZEBmcmVlLWVsZWN0cm9ucy5jb20+IHdyb3RlOgo+ID4gICAKPiA+ID4gT3VyIHBsYW5lcyBjYW5u b3QgYmUgc2V0IGF0IG5lZ2F0aXZlIGNvb3JkaW5hdGVzLiBNYWtlIHN1cmUgd2UgcmVqZWN0IHN1 Y2gKPiA+ID4gY29uZmlndXJhdGlvbi4KPiA+ID4gCj4gPiA+IFJlcG9ydGVkLWJ5OiBCb3JpcyBC cmV6aWxsb24gPGJvcmlzLmJyZXppbGxvbkBmcmVlLWVsZWN0cm9ucy5jb20+Cj4gPiA+IFNpZ25l ZC1vZmYtYnk6IE1heGltZSBSaXBhcmQgPG1heGltZS5yaXBhcmRAZnJlZS1lbGVjdHJvbnMuY29t Pgo+ID4gPiAtLS0KPiA+ID4gIGRyaXZlcnMvZ3B1L2RybS9zdW40aS9zdW40aV9sYXllci5jIHwg MyArKysKPiA+ID4gIDEgZmlsZSBjaGFuZ2VkLCAzIGluc2VydGlvbnMoKykKPiA+ID4gCj4gPiA+ IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vc3VuNGkvc3VuNGlfbGF5ZXIuYyBiL2RyaXZl cnMvZ3B1L2RybS9zdW40aS9zdW40aV9sYXllci5jCj4gPiA+IGluZGV4IGYwMDM1YmY1ZWZlYS4u ZjU0NjNjNGMyY2RlIDEwMDY0NAo+ID4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vc3VuNGkvc3Vu NGlfbGF5ZXIuYwo+ID4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vc3VuNGkvc3VuNGlfbGF5ZXIu Ywo+ID4gPiBAQCAtMjksNiArMjksOSBAQCBzdHJ1Y3Qgc3VuNGlfcGxhbmVfZGVzYyB7Cj4gPiA+ ICBzdGF0aWMgaW50IHN1bjRpX2JhY2tlbmRfbGF5ZXJfYXRvbWljX2NoZWNrKHN0cnVjdCBkcm1f cGxhbmUgKnBsYW5lLAo+ID4gPiAgCQkJCQkgICAgc3RydWN0IGRybV9wbGFuZV9zdGF0ZSAqc3Rh dGUpCj4gPiA+ICB7Cj4gPiA+ICsJaWYgKChzdGF0ZS0+Y3J0Y194IDwgMCkgfHwgKHN0YXRlLT5j cnRjX3kgPCAwKSkKPiA+ID4gKwkJcmV0dXJuIC1FSU5WQUw7Cj4gPiA+ICsgIAo+ID4gCj4gPiBI bSwgSSB0aGluayBpdCdzIGEgcGVyZmVjdGx5IHZhbGlkIHVzZSBjYXNlIGZyb20gdGhlIERSTSBm cmFtZXdvcmsgYW5kCj4gPiBEUk0gdXNlciBQb1Y6IHlvdSBtYXkgd2FudCB0byBwbGFjZSB5b3Vy IHBsYW5lIGF0IGEgbmVnYXRpdmUgQ1JUQwo+ID4gb2Zmc2V0ICh3aGljaCBtZWFucyBwYXJ0IG9m IHRoZSBwbGFuZSB3aWxsIGJlIGhpZGRlbikuCj4gPiAKPiA+IE1heWJlIEknbSB3cm9uZywgYnV0 IGl0IHNlZW1zIHlvdSBjYW4gc3VwcG9ydCB0aGF0IGJ5IGFkYXB0aW5nIHRoZQo+ID4gc3RhcnQg YWRkcmVzcyBvZiB5b3VyIGZyYW1lYnVmZmVyIHBvaW50ZXIgYW5kIHRoZSBsYXllciBzaXplLgo+ ID4gCj4gPiBIYXZlIHlvdSB0cmllZCBkb2luZyBzb21ldGhpbmcgbGlrZSB0aGF0PyAgCj4gCj4g WW91IHNob3VsZG4ndCBldmVuIGJlIGxvb2tpbmcgYXQgdGhlIHVzZXIgcHJvdmlkZWQgY29vcmRp bmF0ZXMuIEFsc28KPiB5b3UgY2FuJ3QgcmV0dXJuIGFuIGVycm9yIGZyb20gdGhlIGF0b21pYyB1 cGRhdGUgaG9vay4gVGhlIHZvaWQgcmV0dXJuCj4gdmFsdWUgc2hvdWxkIGhhdmUgYmVlbiBhIGRl Y2VudCBoaW50IDspCgpOb3RlIHRoYXQgTWF4aW1lIGlzIG5vdCByZXR1cm5pbmcgYSB2YWx1ZSBm cm9tIHRoZSBhdG9taWMgdXBkYXRlCmltcGxlbWVudGF0aW9uIChpdCdzIGRvbmUgaW4gdGhlIGF0 b21pY19jaGVjayBpbXBsZW0pLCBhbmQgSSdtIG5vdApjaGVja2luZyBjcnRjX3gseSBjb25zaXN0 ZW5jeSBhdCBhbGwgKHdoaWNoIGlzIG9idmlvdXNseSB3cm9uZyksIEknbQpqdXN0IGJsaW5kbHkg cGF0Y2hpbmcgdGhlIHZhbHVlcyBpbiBzdW40aV9iYWNrZW5kIGhlbHBlcnMuCgo+IFRoZSByaWdo dCBmaXggd291bGQgYmUKPiB0byBtb3ZlIGFsbCB0aGUgZXJyb3IgaGFuZGxpbmcgaW50byB0aGUg YXRvbWljIGNoZWNrIGhvb2ssIHdoaWNoCj4gcHJvYmFibHkgc2hvdWxkIGp1c3QgY2FsbCB0aGUg aGVscGVyIHRvIGNsaXAgdGhlIGNvb3JkaW5hdGVzIGFuZAo+IHdoYXRub3QuIFRoZW4gdGhlIHVw ZGF0ZSBob29rIGNhbiBqdXN0IHVzZSBhdCB0aGUgY2xpcHBlZCAKPiBjb29yZGluYXRlcyB3aGVu IHByb2dyYW1taW5nIHRoZSBodyByZWdpc3RlcnMuCgpUaGF0J3MgcHJvYmFibHkgdGhlIGJlc3Qg YXBwcm9hY2ggaW5kZWVkLCBidXQgdGhhdCBtZWFucyBoYXZpbmcgb3VyCnByaXZhdGUgc3VuNGlf cGxhbmVfc3RhdGUgc3RydWN0IHdoZXJlIHdlIHdvdWxkIHN0b3JlIHRoZSBwYXRjaGVkCmNydGNf e3csaCx4LHl9IGluZm8uCgpBbnl3YXksIGJlZm9yZSB3ZSBkbyB0aGF0LCB0aGF0J3MgcHJvYmFi bHkgYmV0dGVyIHRvIGNoZWNrIGlmIGl0IHJlYWxseQp3b3JrcyBvbiB0aGlzIEhXICh3aGljaCBp cyB3aHkgSSBzZW50IHRoaXMgaW5mb3JtYWwgcGF0Y2gpLgoKPiAKPiA+ICAgCj4gPiAtLS0+OC0t LSAgCj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL3N1bjRpL3N1bjRpX2JhY2tlbmQu YyBiL2RyaXZlcnMvZ3B1L2RybS9zdW40aS9zdW40aV9iYWNrZW5kLmMKPiA+IGluZGV4IDNhYjU2 MDQ1MGE4Mi4uNmI2ODgwNGYzMDM1IDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL3N1 bjRpL3N1bjRpX2JhY2tlbmQuYwo+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL3N1bjRpL3N1bjRp X2JhY2tlbmQuYwo+ID4gQEAgLTExMCwxNSArMTEwLDMwIEBAIGludCBzdW40aV9iYWNrZW5kX3Vw ZGF0ZV9sYXllcl9jb29yZChzdHJ1Y3Qgc3VuNGlfYmFja2VuZCAqYmFja2VuZCwKPiA+ICB7Cj4g PiAgICAgICAgIHN0cnVjdCBkcm1fcGxhbmVfc3RhdGUgKnN0YXRlID0gcGxhbmUtPnN0YXRlOwo+ ID4gICAgICAgICBzdHJ1Y3QgZHJtX2ZyYW1lYnVmZmVyICpmYiA9IHN0YXRlLT5mYjsKPiA+ICsg ICAgICAgaW50IGNydGNfdywgY3J0Y19oLCBjcnRjX3gsIGNydGNfeTsKPiA+ICAKPiA+ICAgICAg ICAgRFJNX0RFQlVHX0RSSVZFUigiVXBkYXRpbmcgbGF5ZXIgJWRcbiIsIGxheWVyKTsKPiA+ICAK PiA+ICsgICAgICAgY3J0Y194ID0gc3RhdGUtPmNydGNfeDsKPiA+ICsgICAgICAgY3J0Y195ID0g c3RhdGUtPmNydGNfeTsKPiA+ICsgICAgICAgY3J0Y193ID0gc3RhdGUtPmNydGNfdzsKPiA+ICsg ICAgICAgY3J0Y19oID0gc3RhdGUtPmNydGNfaDsKPiA+ICsKPiA+ICsgICAgICAgaWYgKGNydGNf eCA8IDApIHsKPiA+ICsgICAgICAgICAgICAgICBjcnRjX3cgKz0gY3J0eF94Owo+ID4gKyAgICAg ICAgICAgICAgIGNydGNfeCA9IDA7Cj4gPiArICAgICAgIH0KPiA+ICsKPiA+ICsgICAgICAgaWYg KGNydGNfeSA8IDApIHsKPiA+ICsgICAgICAgICAgICAgICBjcnRjX2ggKz0gY3J0eF95Owo+ID4g KyAgICAgICAgICAgICAgIGNydGNfeSA9IDA7Cj4gPiArICAgICAgIH0KPiA+ICsKPiA+ICAgICAg ICAgaWYgKHBsYW5lLT50eXBlID09IERSTV9QTEFORV9UWVBFX1BSSU1BUlkpIHsKPiA+ICAgICAg ICAgICAgICAgICBEUk1fREVCVUdfRFJJVkVSKCJQcmltYXJ5IGxheWVyLCB1cGRhdGluZyBnbG9i YWwgc2l6ZSBXOiAldSBIOiAldVxuIiwKPiA+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIHN0YXRlLT5jcnRjX3csIHN0YXRlLT5jcnRjX2gpOwo+ID4gICAgICAgICAgICAgICAgIHJl Z21hcF93cml0ZShiYWNrZW5kLT5yZWdzLCBTVU40SV9CQUNLRU5EX0RJU1NJWkVfUkVHLAo+ID4g LSAgICAgICAgICAgICAgICAgICAgICAgICAgICBTVU40SV9CQUNLRU5EX0RJU1NJWkUoc3RhdGUt PmNydGNfdywKPiA+IC0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIHN0YXRlLT5jcnRjX2gpKTsKPiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAg U1VONElfQkFDS0VORF9ESVNTSVpFKGNydGNfdywgY3J0Y19oKSk7Cj4gPiAgICAgICAgIH0KPiA+ ICAKPiA+ICAgICAgICAgLyogU2V0IHRoZSBsaW5lIHdpZHRoICovCj4gPiBAQCAtMTMwLDE1ICsx NDUsMTMgQEAgaW50IHN1bjRpX2JhY2tlbmRfdXBkYXRlX2xheWVyX2Nvb3JkKHN0cnVjdCBzdW40 aV9iYWNrZW5kICpiYWNrZW5kLAo+ID4gICAgICAgICBEUk1fREVCVUdfRFJJVkVSKCJMYXllciBz aXplIFc6ICV1IEg6ICV1XG4iLAo+ID4gICAgICAgICAgICAgICAgICAgICAgICAgIHN0YXRlLT5j cnRjX3csIHN0YXRlLT5jcnRjX2gpOwo+ID4gICAgICAgICByZWdtYXBfd3JpdGUoYmFja2VuZC0+ cmVncywgU1VONElfQkFDS0VORF9MQVlTSVpFX1JFRyhsYXllciksCj4gPiAtICAgICAgICAgICAg ICAgICAgICBTVU40SV9CQUNLRU5EX0xBWVNJWkUoc3RhdGUtPmNydGNfdywKPiA+IC0gICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBzdGF0ZS0+Y3J0Y19oKSk7Cj4gPiAr ICAgICAgICAgICAgICAgICAgICBTVU40SV9CQUNLRU5EX0xBWVNJWkUoY3J0Y193LCBjcnRjX2gp KTsKPiA+ICAKPiA+ICAgICAgICAgLyogU2V0IGJhc2UgY29vcmRpbmF0ZXMgKi8KPiA+ICAgICAg ICAgRFJNX0RFQlVHX0RSSVZFUigiTGF5ZXIgY29vcmRpbmF0ZXMgWDogJWQgWTogJWRcbiIsCj4g PiAgICAgICAgICAgICAgICAgICAgICAgICAgc3RhdGUtPmNydGNfeCwgc3RhdGUtPmNydGNfeSk7 Cj4gPiAgICAgICAgIHJlZ21hcF93cml0ZShiYWNrZW5kLT5yZWdzLCBTVU40SV9CQUNLRU5EX0xB WUNPT1JfUkVHKGxheWVyKSwKPiA+IC0gICAgICAgICAgICAgICAgICAgIFNVTjRJX0JBQ0tFTkRf TEFZQ09PUihzdGF0ZS0+Y3J0Y194LAo+ID4gLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIHN0YXRlLT5jcnRjX3kpKTsKPiA+ICsgICAgICAgICAgICAgICAgICAgIFNV TjRJX0JBQ0tFTkRfTEFZQ09PUihjcnRjX3gsIGNydGNfeSkpOwo+ID4gIAo+ID4gICAgICAgICBy ZXR1cm4gMDsKPiA+ICB9Cj4gPiBAQCAtMTk4LDYgKzIxMSwxMiBAQCBpbnQgc3VuNGlfYmFja2Vu ZF91cGRhdGVfbGF5ZXJfYnVmZmVyKHN0cnVjdCBzdW40aV9iYWNrZW5kICpiYWNrZW5kLAo+ID4g ICAgICAgICBwYWRkciArPSAoc3RhdGUtPnNyY194ID4+IDE2KSAqIGJwcDsKPiA+ICAgICAgICAg cGFkZHIgKz0gKHN0YXRlLT5zcmNfeSA+PiAxNikgKiBmYi0+cGl0Y2hlc1swXTsKPiA+ICAKPiA+ ICsgICAgICAgaWYgKHN0YXRlLT5jcnRjX3ggPCAwKQo+ID4gKyAgICAgICAgICAgICAgIHBhZGRy IC09IGJwcCAqIHN0YXRlLT5jcnRjX3g7Cj4gPiArCj4gPiArICAgICAgIGlmIChzdGF0ZS0+Y3J0 Y195IDwgMCkKPiA+ICsgICAgICAgICAgICAgICBwYWRkciAtPSBmYi0+cGl0Y2hlc1swXSAqIHN0 YXRlLT5jcnRjX3k7Cj4gPiArCj4gPiAgICAgICAgIERSTV9ERUJVR19EUklWRVIoIlNldHRpbmcg YnVmZmVyIGFkZHJlc3MgdG8gJXBhZFxuIiwgJnBhZGRyKTsKPiA+ICAKPiA+ICAgICAgICAgLyog V3JpdGUgdGhlIDMyIGxvd2VyIGJpdHMgb2YgdGhlIGFkZHJlc3MgKGluIGJpdHMpICovCj4gPiBf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+ID4gZHJpLWRl dmVsIG1haWxpbmcgbGlzdAo+ID4gZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+ID4g aHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwg IAo+IAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJp LWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBz Oi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==