From: Daniel Vetter <daniel@ffwll.ch>
To: Stefan Christ <contact@stefanchrist.eu>
Cc: daniel.vetter@ffwll.ch, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/fb-helper: fix sphinx markup for DRM_FB_HELPER_DEFAULT_OPS
Date: Thu, 6 Oct 2016 11:18:30 +0200 [thread overview]
Message-ID: <20161006091830.GO20761@phenom.ffwll.local> (raw)
In-Reply-To: <1475692454-11543-1-git-send-email-contact@stefanchrist.eu>
On Wed, Oct 05, 2016 at 08:34:14PM +0200, Stefan Christ wrote:
> Fix invalid sphinx markup in the comment for the newly added
> DRM_FB_HELPER_DEFAULT_OPS.
>
> Signed-off-by: Stefan Christ <contact@stefanchrist.eu>
> ---
> Hi,
>
> > > If I'm not mistaken v1 of this patch is already in drm-misc so you may
> > > want to send a patch that fix just the line above.
> >
> > Yup, I need an incremental patch which applies on top of drm-misc or
> > linux-next. Sorry if this wasn't clear.
> > -Daniel
>
> Thanks for the head-ups. Here is a fix patch for it. Actually I should have
> come up with the same idea myself seeing the patch queued for the next pull
> request.
>
> I have not added a "Fixes:" trailer in the commit message. If this is necessary
> I can resend it, when I see the offending patch in Linus master tree with a
> commit id.
drm-misc has stable sha1, which means you can cite them already when they
show up in linux-next. But for a minor fix like this no big deal really.
Applied to drm-misc, thanks.
-Daniel
>
> Kind regards,
> Stefan Christ
> ---
> include/drm/drm_fb_helper.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/drm/drm_fb_helper.h b/include/drm/drm_fb_helper.h
> index 3c5f599..ed8edfe 100644
> --- a/include/drm/drm_fb_helper.h
> +++ b/include/drm/drm_fb_helper.h
> @@ -218,7 +218,7 @@ struct drm_fb_helper {
> };
>
> /**
> - * @DRM_FB_HELPER_DEFAULT_OPS:
> + * define DRM_FB_HELPER_DEFAULT_OPS - helper define for drm drivers
> *
> * Helper define to register default implementations of drm_fb_helper
> * functions. To be used in struct fb_ops of drm drivers.
> --
> 2.1.4
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2016-10-06 9:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-30 15:18 [drm-intel:topic/drm-misc 3/3] htmldocs: include/drm/drm_fb_helper.h:222: warning: Cannot understand * @DRM_FB_HELPER_DEFAULT_OPS: kbuild test robot
2016-10-03 9:35 ` Jani Nikula
2016-10-03 13:50 ` [Intel-gfx] " Daniel Vetter
2016-10-04 21:36 ` [PATCH v2] drm/fb-helper: add DRM_FB_HELPER_DEFAULT_OPS for fb_ops Stefan Christ
2016-10-05 9:00 ` Gustavo Padovan
2016-10-05 13:13 ` Daniel Vetter
2016-10-05 18:34 ` [PATCH] drm/fb-helper: fix sphinx markup for DRM_FB_HELPER_DEFAULT_OPS Stefan Christ
2016-10-06 9:18 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161006091830.GO20761@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=contact@stefanchrist.eu \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox