[bug report] drm/vc4: Add support for drawing 3D frames.

[bug report] drm/vc4: Add support for drawing 3D frames.

[Dan Carpenter]

Hello Eric Anholt,

The patch d5b1a78a772f: "drm/vc4: Add support for drawing 3D frames."
from Nov 30, 2015, leads to the following static checker warning:

	drivers/gpu/drm/vc4/vc4_gem.c:797 vc4_wait_for_seqno_ioctl_helper()
	warn: ret is never (-4)

drivers/gpu/drm/vc4/vc4_gem.c
   790  static int
   791  vc4_wait_for_seqno_ioctl_helper(struct drm_device *dev,
   792                                  uint64_t seqno,
   793                                  uint64_t *timeout_ns)
   794  {
   795          unsigned long start = jiffies;
   796          int ret = vc4_wait_for_seqno(dev, seqno, *timeout_ns, true);
   797  
   798          if ((ret == -EINTR || ret == -ERESTARTSYS) && *timeout_ns != ~0ull) {
                     ^^^^^^^^^^^^^
Presumably this could be removed?

   799                  uint64_t delta = jiffies_to_nsecs(jiffies - start);
   800  
   801                  if (*timeout_ns >= delta)
   802                          *timeout_ns -= delta;
   803          }
   804  
   805          return ret;
   806  }


regards,
dan carpenter
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [bug report] drm/vc4: Add support for drawing 3D frames.

[Eric Anholt]

[-- Attachment #1.1: Type: text/plain, Size: 930 bytes --]

Dan Carpenter <dan.carpenter@oracle.com> writes:

> Hello Eric Anholt,
>
> The patch d5b1a78a772f: "drm/vc4: Add support for drawing 3D frames."
> from Nov 30, 2015, leads to the following static checker warning:
>
> 	drivers/gpu/drm/vc4/vc4_gem.c:797 vc4_wait_for_seqno_ioctl_helper()
> 	warn: ret is never (-4)
>
> drivers/gpu/drm/vc4/vc4_gem.c
>    790  static int
>    791  vc4_wait_for_seqno_ioctl_helper(struct drm_device *dev,
>    792                                  uint64_t seqno,
>    793                                  uint64_t *timeout_ns)
>    794  {
>    795          unsigned long start = jiffies;
>    796          int ret = vc4_wait_for_seqno(dev, seqno, *timeout_ns, true);
>    797  
>    798          if ((ret == -EINTR || ret == -ERESTARTSYS) && *timeout_ns != ~0ull) {
>                      ^^^^^^^^^^^^^
> Presumably this could be removed?

I think so.  Want to send the patch?

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 800 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel