From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH] drm/edid: Only print the bad edid when aborting Date: Fri, 14 Oct 2016 13:46:37 +0300 Message-ID: <20161014104637.GX4329@intel.com> References: <20161013194355.30669-1-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20161013194355.30669-1-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gVGh1LCBPY3QgMTMsIDIwMTYgYXQgMDg6NDM6NTVQTSArMDEwMCwgQ2hyaXMgV2lsc29uIHdy b3RlOgo+IEN1cnJlbnRseSwgaWYgZHJtLmRlYnVnIGlzIGVuYWJsZWQsIHdlIGdldCBhIERSTV9F UlJPUiBtZXNzYWdlIG9uIHRoZQo+IGludGVybWVkaWF0ZSBlZGlkIHJlYWRzLiBUaGlzIGNhdXNl cyB0cmFuc2llbnQgZmFpbHVyZXMgaW4gQ0kgd2hpY2gKPiBmbGFncyB1cCB0aGUgc3BvcmFkaWMg RURJRCByZWFkIGZhaWx1cmVzLCB3aGljaCBhcmUgcmVjb3ZlcmVkIGJ5Cj4gcmVyZWFkaW5nIHRo ZSBFRElEIGF1dG9tYXRpY2FsbHkuIFRoaXMgcGF0Y2ggY29tYmluZXMgdGhlIHJlcG9ydGluZyBk b25lCj4gYnkgZHJtX2RvX2dldF9lZGlkKCkgaXRzZWxmIHdpdGggdGhlIGJhZCBibG9jayBwcmlu dGluZyBmcm9tCj4gZ2V0X2VkaWRfYmxvY2soKSwgaW50byBhIHNpbmdsZSB3YXJuaW5nIGFzc29j aWF0ZWQgd2l0aCB0aGUgY29ubmVjdG9yCj4gb25jZSBhbGwgYXR0ZW1wdHMgdG8gcmV0cmlldmUg dGhlIEVESUQgZmFpbC4KCk9uZSBxdWVzdGlvbiBpcyB3aHkgaGF2ZSBiZWVuIGdldHRpbmcgbW9y ZSBvZiB0aGVzZSBjb3JydXB0IEVESUQgcmVhZHMKcmVjZW50bHkuIER1ZSB0byB5b3VyIGdtYnVz IGNoYW5nZSwgb3IgdGhlIGxpdmUgc3RhdHVzIHJldmVydCBwZXJoYXBzPwoKPiAKPiBSZWZlcmVu Y2VzOiBodHRwczovL2J1Z3MuZnJlZWRlc2t0b3Aub3JnL3Nob3dfYnVnLmNnaT9pZD05ODIyOAo+ IFNpZ25lZC1vZmYtYnk6IENocmlzIFdpbHNvbiA8Y2hyaXNAY2hyaXMtd2lsc29uLmNvLnVrPgo+ IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vZHJtX2VkaWQuYyB8IDgyICsrKysrKysrKysrKysrKysr KysrKysrKystLS0tLS0tLS0tLS0tLS0tLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDQ0IGluc2Vy dGlvbnMoKyksIDM4IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9k cm0vZHJtX2VkaWQuYyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fZWRpZC5jCj4gaW5kZXggZWM3N2Jk M2UxZjA4Li41MWRkMTBjNjViNTMgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2RybV9l ZGlkLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2VkaWQuYwo+IEBAIC0xMjYwLDYgKzEy NjAsMjYgQEAgZHJtX2RvX3Byb2JlX2RkY19lZGlkKHZvaWQgKmRhdGEsIHU4ICpidWYsIHVuc2ln bmVkIGludCBibG9jaywgc2l6ZV90IGxlbikKPiAgCXJldHVybiByZXQgPT0geGZlcnMgPyAwIDog LTE7Cj4gIH0KPiAgCj4gK3N0YXRpYyB2b2lkIGNvbm5lY3Rvcl9hZGRfYmFkX2VkaWQoc3RydWN0 IGRybV9jb25uZWN0b3IgKmNvbm5lY3RvciwKPiArCQkJCSAgIHU4ICpibG9jaywgaW50IG51bSkK PiArewo+ICsJaWYgKGNvbm5lY3Rvci0+YmFkX2VkaWRfY291bnRlcisrICYmICEoZHJtX2RlYnVn ICYgRFJNX1VUX0tNUykpCj4gKwkJcmV0dXJuOwo+ICsKPiArCWlmIChkcm1fZWRpZF9pc196ZXJv KGJsb2NrLCBFRElEX0xFTkdUSCkpIHsKPiArCQlkZXZfd2Fybihjb25uZWN0b3ItPmRldi0+ZGV2 LAo+ICsJCQkgIiVzOiBFRElEIGJsb2NrICVkIGlzIGFsbCB6ZXJvZXMuXG4iLAo+ICsJCQkgY29u bmVjdG9yLT5uYW1lLCBudW0pOwo+ICsJfSBlbHNlIHsKPiArCQlkZXZfd2Fybihjb25uZWN0b3It PmRldi0+ZGV2LAo+ICsJCQkgIiVzOiBFRElEIGJsb2NrICVkIGludmFsaWQ6XG4iLAo+ICsJCQkg Y29ubmVjdG9yLT5uYW1lLCBudW0pOwo+ICsJCXByaW50X2hleF9kdW1wKEtFUk5fV0FSTklORywK PiArCQkJICAgICAgICIgXHQiLCBEVU1QX1BSRUZJWF9OT05FLCAxNiwgMSwKPiArCQkJICAgICAg IGJsb2NrLCBFRElEX0xFTkdUSCwgZmFsc2UpOwo+ICsJfQo+ICt9Cj4gKwo+ICAvKioKPiAgICog ZHJtX2RvX2dldF9lZGlkIC0gZ2V0IEVESUQgZGF0YSB1c2luZyBhIGN1c3RvbSBFRElEIGJsb2Nr IHJlYWQgZnVuY3Rpb24KPiAgICogQGNvbm5lY3RvcjogY29ubmVjdG9yIHdlJ3JlIHByb2JpbmcK PiBAQCAtMTI4MiwyMCArMTMwMiwxOSBAQCBzdHJ1Y3QgZWRpZCAqZHJtX2RvX2dldF9lZGlkKHN0 cnVjdCBkcm1fY29ubmVjdG9yICpjb25uZWN0b3IsCj4gIAl2b2lkICpkYXRhKQo+ICB7Cj4gIAlp bnQgaSwgaiA9IDAsIHZhbGlkX2V4dGVuc2lvbnMgPSAwOwo+IC0JdTggKmJsb2NrLCAqbmV3Owo+ IC0JYm9vbCBwcmludF9iYWRfZWRpZCA9ICFjb25uZWN0b3ItPmJhZF9lZGlkX2NvdW50ZXIgfHwg KGRybV9kZWJ1ZyAmIERSTV9VVF9LTVMpOwo+ICsJdTggKmVkaWQsICpuZXc7Cj4gIAo+IC0JaWYg KChibG9jayA9IGttYWxsb2MoRURJRF9MRU5HVEgsIEdGUF9LRVJORUwpKSA9PSBOVUxMKQo+ICsJ aWYgKChlZGlkID0ga21hbGxvYyhFRElEX0xFTkdUSCwgR0ZQX0tFUk5FTCkpID09IE5VTEwpCj4g IAkJcmV0dXJuIE5VTEw7Cj4gIAo+ICAJLyogYmFzZSBibG9jayBmZXRjaCAqLwo+ICAJZm9yIChp ID0gMDsgaSA8IDQ7IGkrKykgewo+IC0JCWlmIChnZXRfZWRpZF9ibG9jayhkYXRhLCBibG9jaywg MCwgRURJRF9MRU5HVEgpKQo+ICsJCWlmIChnZXRfZWRpZF9ibG9jayhkYXRhLCBlZGlkLCAwLCBF RElEX0xFTkdUSCkpCj4gIAkJCWdvdG8gb3V0Owo+IC0JCWlmIChkcm1fZWRpZF9ibG9ja192YWxp ZChibG9jaywgMCwgcHJpbnRfYmFkX2VkaWQsCj4gKwkJaWYgKGRybV9lZGlkX2Jsb2NrX3ZhbGlk KGVkaWQsIDAsIGZhbHNlLAo+ICAJCQkJCSAmY29ubmVjdG9yLT5lZGlkX2NvcnJ1cHQpKQo+ICAJ CQlicmVhazsKPiAtCQlpZiAoaSA9PSAwICYmIGRybV9lZGlkX2lzX3plcm8oYmxvY2ssIEVESURf TEVOR1RIKSkgewo+ICsJCWlmIChpID09IDAgJiYgZHJtX2VkaWRfaXNfemVybyhlZGlkLCBFRElE X0xFTkdUSCkpIHsKPiAgCQkJY29ubmVjdG9yLT5udWxsX2VkaWRfY291bnRlcisrOwo+ICAJCQln b3RvIGNhcnA7Cj4gIAkJfQo+IEBAIC0xMzA0LDU4ICsxMzIzLDQ1IEBAIHN0cnVjdCBlZGlkICpk cm1fZG9fZ2V0X2VkaWQoc3RydWN0IGRybV9jb25uZWN0b3IgKmNvbm5lY3RvciwKPiAgCQlnb3Rv IGNhcnA7Cj4gIAo+ICAJLyogaWYgdGhlcmUncyBubyBleHRlbnNpb25zLCB3ZSdyZSBkb25lICov Cj4gLQlpZiAoYmxvY2tbMHg3ZV0gPT0gMCkKPiAtCQlyZXR1cm4gKHN0cnVjdCBlZGlkICopYmxv Y2s7Cj4gKwlpZiAoZWRpZFsweDdlXSA9PSAwKQo+ICsJCXJldHVybiAoc3RydWN0IGVkaWQgKill ZGlkOwo+ICAKPiAtCW5ldyA9IGtyZWFsbG9jKGJsb2NrLCAoYmxvY2tbMHg3ZV0gKyAxKSAqIEVE SURfTEVOR1RILCBHRlBfS0VSTkVMKTsKPiArCW5ldyA9IGtyZWFsbG9jKGVkaWQsIChlZGlkWzB4 N2VdICsgMSkgKiBFRElEX0xFTkdUSCwgR0ZQX0tFUk5FTCk7Cj4gIAlpZiAoIW5ldykKPiAgCQln b3RvIG91dDsKPiAtCWJsb2NrID0gbmV3Owo+ICsJZWRpZCA9IG5ldzsKPiArCj4gKwlmb3IgKGog PSAxOyBqIDw9IGVkaWRbMHg3ZV07IGorKykgewo+ICsJCXU4ICpibG9jayA9IGVkaWQgKyAodmFs aWRfZXh0ZW5zaW9ucyArIDEpICogRURJRF9MRU5HVEg7Cj4gIAo+IC0JZm9yIChqID0gMTsgaiA8 PSBibG9ja1sweDdlXTsgaisrKSB7Cj4gIAkJZm9yIChpID0gMDsgaSA8IDQ7IGkrKykgewo+IC0J CQlpZiAoZ2V0X2VkaWRfYmxvY2soZGF0YSwKPiAtCQkJCSAgYmxvY2sgKyAodmFsaWRfZXh0ZW5z aW9ucyArIDEpICogRURJRF9MRU5HVEgsCj4gLQkJCQkgIGosIEVESURfTEVOR1RIKSkKPiArCQkJ aWYgKGdldF9lZGlkX2Jsb2NrKGRhdGEsIGJsb2NrLCBqLCBFRElEX0xFTkdUSCkpCj4gIAkJCQln b3RvIG91dDsKPiAtCQkJaWYgKGRybV9lZGlkX2Jsb2NrX3ZhbGlkKGJsb2NrICsgKHZhbGlkX2V4 dGVuc2lvbnMgKyAxKQo+IC0JCQkJCQkgKiBFRElEX0xFTkdUSCwgaiwKPiAtCQkJCQkJIHByaW50 X2JhZF9lZGlkLAo+IC0JCQkJCQkgTlVMTCkpIHsKPiArCQkJaWYgKGRybV9lZGlkX2Jsb2NrX3Zh bGlkKGJsb2NrLCBqLCBmYWxzZSwgTlVMTCkpIHsKPiAgCQkJCXZhbGlkX2V4dGVuc2lvbnMrKzsK PiAgCQkJCWJyZWFrOwo+ICAJCQl9Cj4gIAkJfQo+ICAKPiAtCQlpZiAoaSA9PSA0ICYmIHByaW50 X2JhZF9lZGlkKSB7Cj4gLQkJCWRldl93YXJuKGNvbm5lY3Rvci0+ZGV2LT5kZXYsCj4gLQkJCSAi JXM6IElnbm9yaW5nIGludmFsaWQgRURJRCBibG9jayAlZC5cbiIsCj4gLQkJCSBjb25uZWN0b3It Pm5hbWUsIGopOwo+IC0KPiAtCQkJY29ubmVjdG9yLT5iYWRfZWRpZF9jb3VudGVyKys7Cj4gLQkJ fQo+ICsJCWlmIChpID09IDQpCj4gKwkJCWNvbm5lY3Rvcl9hZGRfYmFkX2VkaWQoY29ubmVjdG9y LCBibG9jaywgaik7Cj4gIAl9Cj4gIAo+IC0JaWYgKHZhbGlkX2V4dGVuc2lvbnMgIT0gYmxvY2tb MHg3ZV0pIHsKPiAtCQlibG9ja1tFRElEX0xFTkdUSC0xXSArPSBibG9ja1sweDdlXSAtIHZhbGlk X2V4dGVuc2lvbnM7Cj4gLQkJYmxvY2tbMHg3ZV0gPSB2YWxpZF9leHRlbnNpb25zOwo+IC0JCW5l dyA9IGtyZWFsbG9jKGJsb2NrLCAodmFsaWRfZXh0ZW5zaW9ucyArIDEpICogRURJRF9MRU5HVEgs IEdGUF9LRVJORUwpOwo+ICsJaWYgKHZhbGlkX2V4dGVuc2lvbnMgIT0gZWRpZFsweDdlXSkgewo+ ICsJCWVkaWRbRURJRF9MRU5HVEgtMV0gKz0gZWRpZFsweDdlXSAtIHZhbGlkX2V4dGVuc2lvbnM7 Cj4gKwkJZWRpZFsweDdlXSA9IHZhbGlkX2V4dGVuc2lvbnM7Cj4gKwkJbmV3ID0ga3JlYWxsb2Mo ZWRpZCwgKHZhbGlkX2V4dGVuc2lvbnMgKyAxKSAqIEVESURfTEVOR1RILCBHRlBfS0VSTkVMKTsK PiAgCQlpZiAoIW5ldykKPiAgCQkJZ290byBvdXQ7Cj4gLQkJYmxvY2sgPSBuZXc7Cj4gKwkJZWRp ZCA9IG5ldzsKPiAgCX0KPiAgCj4gLQlyZXR1cm4gKHN0cnVjdCBlZGlkICopYmxvY2s7Cj4gKwly ZXR1cm4gKHN0cnVjdCBlZGlkICopZWRpZDsKPiAgCj4gIGNhcnA6Cj4gLQlpZiAocHJpbnRfYmFk X2VkaWQpIHsKPiAtCQlkZXZfd2Fybihjb25uZWN0b3ItPmRldi0+ZGV2LCAiJXM6IEVESUQgYmxv Y2sgJWQgaW52YWxpZC5cbiIsCj4gLQkJCSBjb25uZWN0b3ItPm5hbWUsIGopOwo+IC0JfQo+IC0J Y29ubmVjdG9yLT5iYWRfZWRpZF9jb3VudGVyKys7Cj4gLQo+ICsJY29ubmVjdG9yX2FkZF9iYWRf ZWRpZChjb25uZWN0b3IsIGVkaWQsIDApOwo+ICBvdXQ6Cj4gLQlrZnJlZShibG9jayk7Cj4gKwlr ZnJlZShlZGlkKTsKPiAgCXJldHVybiBOVUxMOwo+ICB9Cj4gIEVYUE9SVF9TWU1CT0xfR1BMKGRy bV9kb19nZXRfZWRpZCk7Cj4gLS0gCj4gMi45LjMKPiAKPiBfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwo+IGRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKPiBkcmkt ZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5v cmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwKCi0tIApWaWxsZSBTeXJqw6Rsw6QKSW50ZWwg T1RDCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1k ZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczov L2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=