From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 3/3] drm/edid: Only print the bad edid when aborting Date: Mon, 17 Oct 2016 14:07:28 +0300 Message-ID: <20161017110728.GL4329@intel.com> References: <20161017061945.GS20761@phenom.ffwll.local> <20161017083514.21772-1-chris@chris-wilson.co.uk> <20161017083514.21772-3-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id CB8206E1C7 for ; Mon, 17 Oct 2016 11:07:31 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20161017083514.21772-3-chris@chris-wilson.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Chris Wilson Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gTW9uLCBPY3QgMTcsIDIwMTYgYXQgMDk6MzU6MTRBTSArMDEwMCwgQ2hyaXMgV2lsc29uIHdy b3RlOgo+IEN1cnJlbnRseSwgaWYgZHJtLmRlYnVnIGlzIGVuYWJsZWQsIHdlIGdldCBhIERSTV9F UlJPUiBtZXNzYWdlIG9uIHRoZQo+IGludGVybWVkaWF0ZSBlZGlkIHJlYWRzLiBUaGlzIGNhdXNl cyB0cmFuc2llbnQgZmFpbHVyZXMgaW4gQ0kgd2hpY2gKPiBmbGFncyB1cCB0aGUgc3BvcmFkaWMg RURJRCByZWFkIGZhaWx1cmVzLCB3aGljaCBhcmUgcmVjb3ZlcmVkIGJ5Cj4gcmVyZWFkaW5nIHRo ZSBFRElEIGF1dG9tYXRpY2FsbHkuIFRoaXMgcGF0Y2ggY29tYmluZXMgdGhlIHJlcG9ydGluZyBk b25lCj4gYnkgZHJtX2RvX2dldF9lZGlkKCkgaXRzZWxmIHdpdGggdGhlIGJhZCBibG9jayBwcmlu dGluZyBmcm9tCj4gZ2V0X2VkaWRfYmxvY2soKSwgaW50byBhIHNpbmdsZSB3YXJuaW5nIGFzc29j aWF0ZWQgd2l0aCB0aGUgY29ubmVjdG9yCj4gb25jZSBhbGwgYXR0ZW1wdHMgdG8gcmV0cmlldmUg dGhlIEVESUQgZmFpbC4KPiAKPiBSZWZlcmVuY2VzOiBodHRwczovL2J1Z3MuZnJlZWRlc2t0b3Au b3JnL3Nob3dfYnVnLmNnaT9pZD05ODIyOAo+IFNpZ25lZC1vZmYtYnk6IENocmlzIFdpbHNvbiA8 Y2hyaXNAY2hyaXMtd2lsc29uLmNvLnVrPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vZHJtX2Vk aWQuYyB8IDQyICsrKysrKysrKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0tLS0tLQo+ICAx IGZpbGUgY2hhbmdlZCwgMjUgaW5zZXJ0aW9ucygrKSwgMTcgZGVsZXRpb25zKC0pCj4gCj4gZGlm ZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fZWRpZC5jIGIvZHJpdmVycy9ncHUvZHJtL2Ry bV9lZGlkLmMKPiBpbmRleCA5NWRlNDdiYTFlNzcuLjUxZGQxMGM2NWI1MyAxMDA2NDQKPiAtLS0g YS9kcml2ZXJzL2dwdS9kcm0vZHJtX2VkaWQuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1f ZWRpZC5jCj4gQEAgLTEyNjAsNiArMTI2MCwyNiBAQCBkcm1fZG9fcHJvYmVfZGRjX2VkaWQodm9p ZCAqZGF0YSwgdTggKmJ1ZiwgdW5zaWduZWQgaW50IGJsb2NrLCBzaXplX3QgbGVuKQo+ICAJcmV0 dXJuIHJldCA9PSB4ZmVycyA/IDAgOiAtMTsKPiAgfQo+ICAKPiArc3RhdGljIHZvaWQgY29ubmVj dG9yX2FkZF9iYWRfZWRpZChzdHJ1Y3QgZHJtX2Nvbm5lY3RvciAqY29ubmVjdG9yLAo+ICsJCQkJ ICAgdTggKmJsb2NrLCBpbnQgbnVtKQo+ICt7Cj4gKwlpZiAoY29ubmVjdG9yLT5iYWRfZWRpZF9j b3VudGVyKysgJiYgIShkcm1fZGVidWcgJiBEUk1fVVRfS01TKSkKPiArCQlyZXR1cm47Cj4gKwo+ ICsJaWYgKGRybV9lZGlkX2lzX3plcm8oYmxvY2ssIEVESURfTEVOR1RIKSkgewo+ICsJCWRldl93 YXJuKGNvbm5lY3Rvci0+ZGV2LT5kZXYsCj4gKwkJCSAiJXM6IEVESUQgYmxvY2sgJWQgaXMgYWxs IHplcm9lcy5cbiIsCj4gKwkJCSBjb25uZWN0b3ItPm5hbWUsIG51bSk7Cj4gKwl9IGVsc2Ugewo+ ICsJCWRldl93YXJuKGNvbm5lY3Rvci0+ZGV2LT5kZXYsCj4gKwkJCSAiJXM6IEVESUQgYmxvY2sg JWQgaW52YWxpZDpcbiIsCj4gKwkJCSBjb25uZWN0b3ItPm5hbWUsIG51bSk7Cj4gKwkJcHJpbnRf aGV4X2R1bXAoS0VSTl9XQVJOSU5HLAo+ICsJCQkgICAgICAgIiBcdCIsIERVTVBfUFJFRklYX05P TkUsIDE2LCAxLAo+ICsJCQkgICAgICAgYmxvY2ssIEVESURfTEVOR1RILCBmYWxzZSk7Cj4gKwl9 Cj4gK30KPiArCj4gIC8qKgo+ICAgKiBkcm1fZG9fZ2V0X2VkaWQgLSBnZXQgRURJRCBkYXRhIHVz aW5nIGEgY3VzdG9tIEVESUQgYmxvY2sgcmVhZCBmdW5jdGlvbgo+ICAgKiBAY29ubmVjdG9yOiBj b25uZWN0b3Igd2UncmUgcHJvYmluZwo+IEBAIC0xMjgzLDcgKzEzMDMsNiBAQCBzdHJ1Y3QgZWRp ZCAqZHJtX2RvX2dldF9lZGlkKHN0cnVjdCBkcm1fY29ubmVjdG9yICpjb25uZWN0b3IsCj4gIHsK PiAgCWludCBpLCBqID0gMCwgdmFsaWRfZXh0ZW5zaW9ucyA9IDA7Cj4gIAl1OCAqZWRpZCwgKm5l dzsKPiAtCWJvb2wgcHJpbnRfYmFkX2VkaWQgPSAhY29ubmVjdG9yLT5iYWRfZWRpZF9jb3VudGVy IHx8IChkcm1fZGVidWcgJiBEUk1fVVRfS01TKTsKPiAgCj4gIAlpZiAoKGVkaWQgPSBrbWFsbG9j KEVESURfTEVOR1RILCBHRlBfS0VSTkVMKSkgPT0gTlVMTCkKPiAgCQlyZXR1cm4gTlVMTDsKPiBA QCAtMTI5Miw3ICsxMzExLDcgQEAgc3RydWN0IGVkaWQgKmRybV9kb19nZXRfZWRpZChzdHJ1Y3Qg ZHJtX2Nvbm5lY3RvciAqY29ubmVjdG9yLAo+ICAJZm9yIChpID0gMDsgaSA8IDQ7IGkrKykgewo+ ICAJCWlmIChnZXRfZWRpZF9ibG9jayhkYXRhLCBlZGlkLCAwLCBFRElEX0xFTkdUSCkpCj4gIAkJ CWdvdG8gb3V0Owo+IC0JCWlmIChkcm1fZWRpZF9ibG9ja192YWxpZChlZGlkLCAwLCBwcmludF9i YWRfZWRpZCwKPiArCQlpZiAoZHJtX2VkaWRfYmxvY2tfdmFsaWQoZWRpZCwgMCwgZmFsc2UsCj4g IAkJCQkJICZjb25uZWN0b3ItPmVkaWRfY29ycnVwdCkpCj4gIAkJCWJyZWFrOwo+ICAJCWlmIChp ID09IDAgJiYgZHJtX2VkaWRfaXNfemVybyhlZGlkLCBFRElEX0xFTkdUSCkpIHsKPiBAQCAtMTMx OCwyMCArMTMzNywxNCBAQCBzdHJ1Y3QgZWRpZCAqZHJtX2RvX2dldF9lZGlkKHN0cnVjdCBkcm1f Y29ubmVjdG9yICpjb25uZWN0b3IsCj4gIAkJZm9yIChpID0gMDsgaSA8IDQ7IGkrKykgewo+ICAJ CQlpZiAoZ2V0X2VkaWRfYmxvY2soZGF0YSwgYmxvY2ssIGosIEVESURfTEVOR1RIKSkKPiAgCQkJ CWdvdG8gb3V0Owo+IC0JCQlpZiAoZHJtX2VkaWRfYmxvY2tfdmFsaWQoYmxvY2ssIGosCj4gLQkJ CQkJCSBwcmludF9iYWRfZWRpZCwgTlVMTCkpIHsKPiArCQkJaWYgKGRybV9lZGlkX2Jsb2NrX3Zh bGlkKGJsb2NrLCBqLCBmYWxzZSwgTlVMTCkpIHsKPiAgCQkJCXZhbGlkX2V4dGVuc2lvbnMrKzsK PiAgCQkJCWJyZWFrOwo+ICAJCQl9Cj4gIAkJfQo+ICAKPiAtCQlpZiAoaSA9PSA0ICYmIHByaW50 X2JhZF9lZGlkKSB7Cj4gLQkJCWRldl93YXJuKGNvbm5lY3Rvci0+ZGV2LT5kZXYsCj4gLQkJCSAi JXM6IElnbm9yaW5nIGludmFsaWQgRURJRCBibG9jayAlZC5cbiIsCj4gLQkJCSBjb25uZWN0b3It Pm5hbWUsIGopOwo+IC0KPiAtCQkJY29ubmVjdG9yLT5iYWRfZWRpZF9jb3VudGVyKys7Cj4gLQkJ fQo+ICsJCWlmIChpID09IDQpCj4gKwkJCWNvbm5lY3Rvcl9hZGRfYmFkX2VkaWQoY29ubmVjdG9y LCBibG9jaywgaik7CgpIbW0uIFNvIHRoaXMgd2lsbCBvbmx5IHByaW50IHRoZSBmaXJzdCBiYWQg YmxvY2sgd2UgZmluZC4gU2hvdWxkIHdlCnBlcmhhcHMganVzdCBkdW1wIG91dCB0aGUgZW50aXJl IEVESUQgYXQgdGhlIGVuZCwgd2l0aCB0aGUgYmFkIGJsb2NrcwpjbGVhcmx5IG1hcmtlZCBhcyBz dWNoPwoKPiAgCX0KPiAgCj4gIAlpZiAodmFsaWRfZXh0ZW5zaW9ucyAhPSBlZGlkWzB4N2VdKSB7 Cj4gQEAgLTEzNDYsMTIgKzEzNTksNyBAQCBzdHJ1Y3QgZWRpZCAqZHJtX2RvX2dldF9lZGlkKHN0 cnVjdCBkcm1fY29ubmVjdG9yICpjb25uZWN0b3IsCj4gIAlyZXR1cm4gKHN0cnVjdCBlZGlkICop ZWRpZDsKPiAgCj4gIGNhcnA6Cj4gLQlpZiAocHJpbnRfYmFkX2VkaWQpIHsKPiAtCQlkZXZfd2Fy bihjb25uZWN0b3ItPmRldi0+ZGV2LCAiJXM6IEVESUQgYmxvY2sgJWQgaW52YWxpZC5cbiIsCj4g LQkJCSBjb25uZWN0b3ItPm5hbWUsIGopOwo+IC0JfQo+IC0JY29ubmVjdG9yLT5iYWRfZWRpZF9j b3VudGVyKys7Cj4gLQo+ICsJY29ubmVjdG9yX2FkZF9iYWRfZWRpZChjb25uZWN0b3IsIGVkaWQs IDApOwo+ICBvdXQ6Cj4gIAlrZnJlZShlZGlkKTsKPiAgCXJldHVybiBOVUxMOwo+IC0tIAo+IDIu OS4zCj4gCj4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K PiBkcmktZGV2ZWwgbWFpbGluZyBsaXN0Cj4gZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9y Zwo+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRl dmVsCgotLSAKVmlsbGUgU3lyasOkbMOkCkludGVsIE9UQwpfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZl bEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFp bG1hbi9saXN0aW5mby9kcmktZGV2ZWwK