dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v5 00/13] Centralize format information
Date: Tue, 18 Oct 2016 15:45:14 +0300	[thread overview]
Message-ID: <20161018124514.GC4329@intel.com> (raw)
In-Reply-To: <2021221.rVgQfdL3aY@avalon>

On Tue, Oct 18, 2016 at 03:33:29PM +0300, Laurent Pinchart wrote:
> Hi Ville,
> 
> On Tuesday 18 Oct 2016 14:43:18 Ville Syrjälä wrote:
> > On Tue, Oct 18, 2016 at 01:41:08AM +0300, Laurent Pinchart wrote:
> > > Hello,
> > > 
> > > Various pieces of information about DRM formats (number of planes, color
> > > depth, chroma subsampling, ...) are scattered across different helper
> > > functions in the DRM core. Callers of those functions often need to access
> > > more than a single parameter of the format, leading to inefficiencies due
> > > to multiple lookups.
> > > 
> > > This patch series addresses this issue by centralizing all format
> > > information in a single data structure (01/13). It reimplements the
> > > existing format helper functions based on that structure (02/13) and
> > > converts the DRM core code to use the new structure (03/13). The DRM core
> > > now WARNs when a driver tries to query information about an unsupported
> > > format (04/13).
> > > 
> > > The second part of the patch series removes the drm_fb_get_bpp_depth()
> > > legacy function that shouldn't be used directly by drivers. It modifies
> > > all its users to use the appropriate API instead (05/13 to 12/13) and
> > > finally merges the function into its only caller in the DRM core (13/13).
> > > 
> > > The new API is also useful for drivers as shown by the "[PATCH v2 00/20]
> > > OMAP DRM fixes and improvements" patch series previously posted.
> > > 
> > > All patches have been acked, the series is ready to be merged for v4.10.
> > 
> > BTW and idea I had recently is that we could store the pointer to the
> > format info into drm_framebuffer, and then a lot of the
> > drm_format_...() calls could just vanish, or if the information we
> > need isn't directly stored in the info structure we'd just need a small
> > function that takes the entire drm_framebuffer or just the format info
> > struct and computes what we need. Would avoid having to sprinkle
> > drm_format_info() calls into the drivers.
> 
> That's a good idea. I didn't want to add that to my patch series in order to 
> avoid merge delays, but patches are certainly welcome :-)

Sure. I'll preserve the idea for a rainy day, unless someone else beats
me to it that is.

-- 
Ville Syrjälä
Intel OTC
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2016-10-18 12:45 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-17 22:41 [PATCH v5 00/13] Centralize format information Laurent Pinchart
2016-10-17 22:41 ` [PATCH v5 01/13] drm: " Laurent Pinchart
2016-10-17 22:41 ` [PATCH v5 02/13] drm: Implement the drm_format_*() helpers as drm_format_info() wrappers Laurent Pinchart
2016-10-17 22:41 ` [PATCH v5 03/13] drm: Use drm_format_info() in DRM core code Laurent Pinchart
2016-10-17 22:41 ` [PATCH v5 04/13] drm: WARN when calling drm_format_info() for an unsupported format Laurent Pinchart
2016-10-18 15:14   ` Eric Engestrom
2016-10-17 22:41 ` [PATCH v5 05/13] drm: hdlcd: Replace drm_fb_get_bpp_depth() with drm_format_plane_cpp() Laurent Pinchart
2016-10-17 22:41 ` [PATCH v5 06/13] drm: tilcdc: " Laurent Pinchart
2016-10-17 22:41 ` [PATCH v5 07/13] drm: cirrus: " Laurent Pinchart
2016-10-17 22:41 ` [PATCH v5 08/13] drm: gma500: Replace drm_fb_get_bpp_depth() with drm_format_info() Laurent Pinchart
2016-10-17 22:41 ` [PATCH v5 09/13] drm: amdgpu: Replace drm_fb_get_bpp_depth() with drm_format_plane_cpp() Laurent Pinchart
2016-10-17 22:41 ` [PATCH v5 10/13] drm: radeon: " Laurent Pinchart
2016-10-17 22:41 ` [PATCH v5 11/13] drm: vmwgfx: Replace drm_fb_get_bpp_depth() with drm_format_info() Laurent Pinchart
2016-10-17 22:41 ` [PATCH v5 12/13] drm/arm: mali-dp: Replace drm_fb_get_bpp_depth() with drm_format_plane_cpp() Laurent Pinchart
2016-10-17 22:41 ` [PATCH v5 13/13] drm: Don't export the drm_fb_get_bpp_depth() function Laurent Pinchart
2016-10-18 15:14   ` Eric Engestrom
2016-10-18 10:33 ` [PATCH v5 00/13] Centralize format information Archit Taneja
2016-10-18 11:43 ` Ville Syrjälä
2016-10-18 12:33   ` Laurent Pinchart
2016-10-18 12:45     ` Ville Syrjälä [this message]
2016-10-18 12:49       ` Laurent Pinchart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161018124514.GC4329@intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=tomi.valkeinen@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox