Re: [PATCH 2/4] drm/i2c: tda998x: Remove obsolete drm_connector_register() call

[Brian Starkey <brian.starkey@arm.com>]

Hi Jyri,

I believe this will break mali-dp and hdlcd, unless something changed
while I wasn't looking. Please see this previous thread where I did
the same thing and then had to have it reverted: [1]

Before removing this, we need to refactor (at least) mali-dp and hdlcd
to move drm_dev_register() to the end of their ->bind() callback.

That could be done without moving drm_dev_unregister() to the start
of ->unbind() if you really want to nuke the drm_connector_register()
call, but to maintain symmetry (and introduce correctness) I was
putting it off until I had a chance to remove drm_vblank_cleanup()
from drm_dev_unregister() (because [2]).

Thanks,
Brian

[1] https://lists.freedesktop.org/archives/dri-devel/2016-September/119038.html
[2] https://lists.freedesktop.org/archives/dri-devel/2016-September/119268.html

On Wed, Oct 19, 2016 at 12:33:54AM +0300, Jyri Sarha wrote:
>Remove obsolete drm_connector_register() call from tda998x_bind(). All
>connectors are registered when drm_dev_register() is called by the
>master drm_device driver.
>
>Signed-off-by: Jyri Sarha <jsarha@ti.com>
>---
> drivers/gpu/drm/i2c/tda998x_drv.c | 6 ------
> 1 file changed, 6 deletions(-)
>
>diff --git a/drivers/gpu/drm/i2c/tda998x_drv.c b/drivers/gpu/drm/i2c/tda998x_drv.c
>index 9798d40..265f854 100644
>--- a/drivers/gpu/drm/i2c/tda998x_drv.c
>+++ b/drivers/gpu/drm/i2c/tda998x_drv.c
>@@ -1656,16 +1656,10 @@ static int tda998x_bind(struct device *dev, struct device *master, void *data)
> 	if (ret)
> 		goto err_connector;
>
>-	ret = drm_connector_register(&priv->connector);
>-	if (ret)
>-		goto err_sysfs;
>-
> 	drm_mode_connector_attach_encoder(&priv->connector, &priv->encoder);
>
> 	return 0;
>
>-err_sysfs:
>-	drm_connector_cleanup(&priv->connector);
> err_connector:
> 	drm_encoder_cleanup(&priv->encoder);
> err_encoder:
>-- 
>1.9.1
>
>_______________________________________________
>dri-devel mailing list
>dri-devel@lists.freedesktop.org
>https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel