dri-devel.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: Christophe Fergeau <cfergeau@redhat.com>
To: spice-devel@lists.freedesktop.org
Cc: airlied@redhat.com, dri-devel@lists.freedesktop.org
Subject: [drm/qxl 6/6] qxl: Allow resolution which are not multiple of 8
Date: Fri, 28 Oct 2016 14:12:27 +0200	[thread overview]
Message-ID: <20161028121227.16904-7-cfergeau@redhat.com> (raw)
In-Reply-To: <20161028121227.16904-1-cfergeau@redhat.com>

The use of drm_cvt_mode() in qxl_add_monitors_config_modes() means that
the resolutions we are going to present to user-space are going to be
rounded down to a multiple of 8. In the QXL arbitrary resolution case,
this is not useful.
This commit forces the actual width/height that was requested by the
client in the drm_display_mode structure rather than keeping the
rounded version.

Signed-off-by: Christophe Fergeau <cfergeau@redhat.com>
---

I know this is very hacky, but I have no idea what is important to be set in the mode struct,
if there is a better way to create it without getting the rounding to a multiple of 8, ...


 drivers/gpu/drm/qxl/qxl_display.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/gpu/drm/qxl/qxl_display.c b/drivers/gpu/drm/qxl/qxl_display.c
index edb90f6..fc5b01e 100644
--- a/drivers/gpu/drm/qxl/qxl_display.c
+++ b/drivers/gpu/drm/qxl/qxl_display.c
@@ -202,6 +202,9 @@ static int qxl_add_monitors_config_modes(struct drm_connector *connector,
 	mode = drm_cvt_mode(dev, head->width, head->height, 60, false, false,
 			    false);
 	mode->type |= DRM_MODE_TYPE_PREFERRED;
+	mode->hdisplay = head->width;
+	mode->vdisplay = head->height;
+	drm_mode_set_name(mode);
 	*pwidth = head->width;
 	*pheight = head->height;
 	drm_mode_probed_add(connector, mode);
-- 
2.9.3

_______________________________________________
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel

  parent reply	other threads:[~2016-10-28 12:12 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-28 12:12 [drm/qxl 0/6] Various cleanups/fixes Christophe Fergeau
2016-10-28 12:12 ` [drm/qxl 1/6] qxl: Mark some internal functions as static Christophe Fergeau
2016-10-31 11:28   ` [Spice-devel] " Frediano Ziglio
2016-10-28 12:12 ` [drm/qxl 2/6] qxl: Remove unused prototype Christophe Fergeau
2016-10-31 11:30   ` Frediano Ziglio
2016-10-28 12:12 ` [drm/qxl 3/6] qxl: Add missing '\n' to qxl_io_log() call Christophe Fergeau
2016-10-31 11:29   ` [Spice-devel] " Frediano Ziglio
2016-10-28 12:12 ` [drm/qxl 4/6] qxl: Call qxl_gem_{init,fini} Christophe Fergeau
2016-10-31 11:42   ` [Spice-devel] " Frediano Ziglio
2016-11-02 16:07     ` Christophe Fergeau
2016-10-28 12:12 ` [drm/qxl 5/6] qxl: Don't notify userspace when monitors config is unchanged Christophe Fergeau
2016-10-31 12:00   ` Frediano Ziglio
2016-11-02 16:31     ` [Spice-devel] " Christophe Fergeau
2016-11-02 17:05       ` Christophe Fergeau
2016-11-03 18:42       ` [Spice-devel] " Emil Velikov
2016-11-04 10:42         ` Christophe Fergeau
2016-10-28 12:12 ` Christophe Fergeau [this message]
2016-10-31 11:35   ` [Spice-devel] [drm/qxl 6/6] qxl: Allow resolution which are not multiple of 8 Frediano Ziglio
2016-10-31 11:49     ` Pavel Grunt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161028121227.16904-7-cfergeau@redhat.com \
    --to=cfergeau@redhat.com \
    --cc=airlied@redhat.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=spice-devel@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).