From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH] drm: move check for min/max width/height for atomic drivers Date: Thu, 3 Nov 2016 16:12:49 +0200 Message-ID: <20161103141249.GT4617@intel.com> References: <1478096864-14639-1-git-send-email-robdclark@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6009F6E701 for ; Thu, 3 Nov 2016 14:12:53 +0000 (UTC) Content-Disposition: inline In-Reply-To: <1478096864-14639-1-git-send-email-robdclark@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Rob Clark Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCBOb3YgMDIsIDIwMTYgYXQgMTA6Mjc6NDRBTSAtMDQwMCwgUm9iIENsYXJrIHdyb3Rl Ogo+IGRybS1od2MgKyBhbmRyb2lkIHRyaWVzIHRvIGNyZWF0ZSBhbiBmYiBmb3IgdGhlIHdhbGxw YXBlciBsYXllciwgd2hpY2gKPiBpcyBsYXJnZXIgdGhhbiB0aGUgc2NyZWVuIHJlc29sdXRpb24s IGFuZCBwb3RlbnRpYWxseSBsYXJnZXIgdGhhbgo+IG1vZGVfY29uZmlnLT5tYXhfe3dpZHRoLGhl aWdodH0uICBCdXQgdGhlIHBsYW5lIHNyY193L3NyY19oIGlzIHdpdGhpbgo+IHRoZSBtYXggbGlt aXRzLCBzbyBpdCBpcyBzb21ldGhpbmcgdGhlIGhhcmR3YXJlIGNhbiBvdGhlcndpc2UgZG8uCj4g Cj4gRm9yIGF0b21pYyBkcml2ZXJzLCBkZWZlciB0aGUgY2hlY2sgdG8gZHJtX2F0b21pY19wbGFu ZV9jaGVjaygpLgo+IAo+IFNpZ25lZC1vZmYtYnk6IFJvYiBDbGFyayA8cm9iZGNsYXJrQGdtYWls LmNvbT4KPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2RybV9hdG9taWMuYyB8IDE3ICsrKysrKysr KysrKysrKysrCj4gIGRyaXZlcnMvZ3B1L2RybS9kcm1fY3J0Yy5jICAgfCAyNiArKysrKysrKysr KysrKysrKy0tLS0tLS0tLQo+ICAyIGZpbGVzIGNoYW5nZWQsIDM0IGluc2VydGlvbnMoKyksIDkg ZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fYXRvbWlj LmMgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pYy5jCj4gaW5kZXggMzRlZGQ0Zi4uZmIwZjA3 Y2UgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2RybV9hdG9taWMuYwo+ICsrKyBiL2Ry aXZlcnMvZ3B1L2RybS9kcm1fYXRvbWljLmMKPiBAQCAtODQ2LDcgKzg0Niw5IEBAIHBsYW5lX3N3 aXRjaGluZ19jcnRjKHN0cnVjdCBkcm1fYXRvbWljX3N0YXRlICpzdGF0ZSwKPiAgc3RhdGljIGlu dCBkcm1fYXRvbWljX3BsYW5lX2NoZWNrKHN0cnVjdCBkcm1fcGxhbmUgKnBsYW5lLAo+ICAJCXN0 cnVjdCBkcm1fcGxhbmVfc3RhdGUgKnN0YXRlKQo+ICB7Cj4gKwlzdHJ1Y3QgZHJtX21vZGVfY29u ZmlnICpjb25maWcgPSAmcGxhbmUtPmRldi0+bW9kZV9jb25maWc7Cj4gIAl1bnNpZ25lZCBpbnQg ZmJfd2lkdGgsIGZiX2hlaWdodDsKPiArCXVuc2lnbmVkIGludCBtaW5fd2lkdGgsIG1heF93aWR0 aCwgbWluX2hlaWdodCwgbWF4X2hlaWdodDsKPiAgCWludCByZXQ7Cj4gIAo+ICAJLyogZWl0aGVy ICpib3RoKiBDUlRDIGFuZCBGQiBtdXN0IGJlIHNldCwgb3IgbmVpdGhlciAqLwo+IEBAIC05MDks NiArOTExLDIxIEBAIHN0YXRpYyBpbnQgZHJtX2F0b21pY19wbGFuZV9jaGVjayhzdHJ1Y3QgZHJt X3BsYW5lICpwbGFuZSwKPiAgCQlyZXR1cm4gLUVOT1NQQzsKPiAgCX0KPiAgCj4gKwltaW5fd2lk dGggPSBjb25maWctPm1pbl93aWR0aCA8PCAxNjsKPiArCW1heF93aWR0aCA9IGNvbmZpZy0+bWF4 X3dpZHRoIDw8IDE2Owo+ICsJbWluX2hlaWdodCA9IGNvbmZpZy0+bWluX2hlaWdodCA8PCAxNjsK PiArCW1heF9oZWlnaHQgPSBjb25maWctPm1heF9oZWlnaHQgPDwgMTY7Cj4gKwo+ICsJLyogTWFr ZSBzdXJlIHNvdXJjZSBkaW1lbnNpb25zIGFyZSB3aXRoaW4gYm91bmRzLiAqLwo+ICsJaWYgKG1p bl93aWR0aCA+IHN0YXRlLT5zcmNfdyB8fCBzdGF0ZS0+c3JjX3cgPiBtYXhfd2lkdGggfHwKPiAr CSAgICBtaW5faGVpZ2h0ID4gc3RhdGUtPnNyY19oIHx8IHN0YXRlLT5zcmNfaCA+IG1heF9oZWln aHQpIHsKPiArCQlEUk1fREVCVUdfQVRPTUlDKCJJbnZhbGlkIHNvdXJjZSBzaXplICIKPiArCQkJ CSAiJXUuJTA2dXgldS4lMDZ1XG4iLAo+ICsJCQkJIHN0YXRlLT5zcmNfdyA+PiAxNiwgKChzdGF0 ZS0+c3JjX3cgJiAweGZmZmYpICogMTU2MjUpID4+IDEwLAo+ICsJCQkJIHN0YXRlLT5zcmNfaCA+ PiAxNiwgKChzdGF0ZS0+c3JjX2ggJiAweGZmZmYpICogMTU2MjUpID4+IDEwKTsKPiArCQlyZXR1 cm4gLUVSQU5HRTsKPiArCX0KPiArCj4gIAlpZiAocGxhbmVfc3dpdGNoaW5nX2NydGMoc3RhdGUt PnN0YXRlLCBwbGFuZSwgc3RhdGUpKSB7Cj4gIAkJRFJNX0RFQlVHX0FUT01JQygiW1BMQU5FOiVk OiVzXSBzd2l0Y2hpbmcgQ1JUQyBkaXJlY3RseVxuIiwKPiAgCQkJCSBwbGFuZS0+YmFzZS5pZCwg cGxhbmUtPm5hbWUpOwo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2NydGMuYyBi L2RyaXZlcnMvZ3B1L2RybS9kcm1fY3J0Yy5jCj4gaW5kZXggYjRiOTczZi4uNzI5NGJkZSAxMDA2 NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2NydGMuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1 L2RybS9kcm1fY3J0Yy5jCj4gQEAgLTMzNjksMTUgKzMzNjksMjMgQEAgaW50ZXJuYWxfZnJhbWVi dWZmZXJfY3JlYXRlKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsCj4gIAkJcmV0dXJuIEVSUl9QVFIo LUVJTlZBTCk7Cj4gIAl9Cj4gIAo+IC0JaWYgKChjb25maWctPm1pbl93aWR0aCA+IHItPndpZHRo KSB8fCAoci0+d2lkdGggPiBjb25maWctPm1heF93aWR0aCkpIHsKPiAtCQlEUk1fREVCVUdfS01T KCJiYWQgZnJhbWVidWZmZXIgd2lkdGggJWQsIHNob3VsZCBiZSA+PSAlZCAmJiA8PSAlZFxuIiwK PiAtCQkJICByLT53aWR0aCwgY29uZmlnLT5taW5fd2lkdGgsIGNvbmZpZy0+bWF4X3dpZHRoKTsK PiAtCQlyZXR1cm4gRVJSX1BUUigtRUlOVkFMKTsKPiAtCX0KPiAtCWlmICgoY29uZmlnLT5taW5f aGVpZ2h0ID4gci0+aGVpZ2h0KSB8fCAoci0+aGVpZ2h0ID4gY29uZmlnLT5tYXhfaGVpZ2h0KSkg ewo+IC0JCURSTV9ERUJVR19LTVMoImJhZCBmcmFtZWJ1ZmZlciBoZWlnaHQgJWQsIHNob3VsZCBi ZSA+PSAlZCAmJiA8PSAlZFxuIiwKPiAtCQkJICByLT5oZWlnaHQsIGNvbmZpZy0+bWluX2hlaWdo dCwgY29uZmlnLT5tYXhfaGVpZ2h0KTsKPiAtCQlyZXR1cm4gRVJSX1BUUigtRUlOVkFMKTsKPiAr CS8qIGZvciBhdG9taWMgZHJpdmVycywgd2UgY2hlY2sgdGhlIHNyYyBkaW1lbnNpb25zIGluCj4g KwkgKiBkcm1fYXRvbWljX3BsYW5lX2NoZWNrKCkuLiBhbGxvdyBjcmVhdGlvbiBvZiBhIGZiCj4g KwkgKiB0aGF0IGlzIGxhcmdlciB0aGFuIHdoYXQgY2FuIGJlIHNjYW5uZWQgb3V0LCBhcwo+ICsJ ICogbG9uZyBhcyB1c2Vyc3BhY2UgZG9lc24ndCB0cnkgdG8gc2Nhbm91dCBhIHBvcnRpb24KPiAr CSAqIG9mIHRoZSBmYiB0aGF0IGlzIHRvbyBsYXJnZS4KPiArCSAqLwo+ICsJaWYgKCFmaWxlX3By aXYtPmF0b21pYykgewo+ICsJCWlmICgoY29uZmlnLT5taW5fd2lkdGggPiByLT53aWR0aCkgfHwg KHItPndpZHRoID4gY29uZmlnLT5tYXhfd2lkdGgpKSB7Cj4gKwkJCURSTV9ERUJVR19LTVMoImJh ZCBmcmFtZWJ1ZmZlciB3aWR0aCAlZCwgc2hvdWxkIGJlID49ICVkICYmIDw9ICVkXG4iLAo+ICsJ CQkJICByLT53aWR0aCwgY29uZmlnLT5taW5fd2lkdGgsIGNvbmZpZy0+bWF4X3dpZHRoKTsKPiAr CQkJcmV0dXJuIEVSUl9QVFIoLUVJTlZBTCk7Cj4gKwkJfQo+ICsJCWlmICgoY29uZmlnLT5taW5f aGVpZ2h0ID4gci0+aGVpZ2h0KSB8fCAoci0+aGVpZ2h0ID4gY29uZmlnLT5tYXhfaGVpZ2h0KSkg ewo+ICsJCQlEUk1fREVCVUdfS01TKCJiYWQgZnJhbWVidWZmZXIgaGVpZ2h0ICVkLCBzaG91bGQg YmUgPj0gJWQgJiYgPD0gJWRcbiIsCj4gKwkJCQkgIHItPmhlaWdodCwgY29uZmlnLT5taW5faGVp Z2h0LCBjb25maWctPm1heF9oZWlnaHQpOwo+ICsJCQlyZXR1cm4gRVJSX1BUUigtRUlOVkFMKTsK PiArCQl9CgpTbyB3aHkgbm90IGp1c3QgYnVtcCBtYXhfZm9vIGluIHlvdXIgZHJpdmVyPwoKUmVt b3ZpbmcgdGhlIHJlc3RyaWN0aW9uIGZyb20gdGhlIGNvcmUgc2VlbXMgbGlrZWx5IHRvIGJyZWFr IHNvbWUKZHJpdmVycyBhcyB0aGV5IHdvdWxkIG5vdyBoYXZlIHRvIGNoZWNrIHRoZSBmYiBkaW1l bnNpb25zIHRoZW1zZWx2ZXMuCgo+ICAJfQo+ICAKPiAgCWlmIChyLT5mbGFncyAmIERSTV9NT0RF X0ZCX01PRElGSUVSUyAmJgo+IC0tIAo+IDIuNy40CgotLSAKVmlsbGUgU3lyasOkbMOkCkludGVs IE9UQwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmkt ZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6 Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK