From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH] drm: move check for min/max width/height for atomic drivers Date: Thu, 3 Nov 2016 16:55:28 +0200 Message-ID: <20161103145528.GV4617@intel.com> References: <1478096864-14639-1-git-send-email-robdclark@gmail.com> <20161103141249.GT4617@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id ED7766E718 for ; Thu, 3 Nov 2016 14:55:31 +0000 (UTC) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Rob Clark Cc: "dri-devel@lists.freedesktop.org" List-Id: dri-devel@lists.freedesktop.org T24gVGh1LCBOb3YgMDMsIDIwMTYgYXQgMTA6MTQ6MjBBTSAtMDQwMCwgUm9iIENsYXJrIHdyb3Rl Ogo+IE9uIFRodSwgTm92IDMsIDIwMTYgYXQgMTA6MTIgQU0sIFZpbGxlIFN5cmrDpGzDpAo+IDx2 aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4gd3JvdGU6Cj4gPiBPbiBXZWQsIE5vdiAwMiwg MjAxNiBhdCAxMDoyNzo0NEFNIC0wNDAwLCBSb2IgQ2xhcmsgd3JvdGU6Cj4gPj4gZHJtLWh3YyAr IGFuZHJvaWQgdHJpZXMgdG8gY3JlYXRlIGFuIGZiIGZvciB0aGUgd2FsbHBhcGVyIGxheWVyLCB3 aGljaAo+ID4+IGlzIGxhcmdlciB0aGFuIHRoZSBzY3JlZW4gcmVzb2x1dGlvbiwgYW5kIHBvdGVu dGlhbGx5IGxhcmdlciB0aGFuCj4gPj4gbW9kZV9jb25maWctPm1heF97d2lkdGgsaGVpZ2h0fS4g IEJ1dCB0aGUgcGxhbmUgc3JjX3cvc3JjX2ggaXMgd2l0aGluCj4gPj4gdGhlIG1heCBsaW1pdHMs IHNvIGl0IGlzIHNvbWV0aGluZyB0aGUgaGFyZHdhcmUgY2FuIG90aGVyd2lzZSBkby4KPiA+Pgo+ ID4+IEZvciBhdG9taWMgZHJpdmVycywgZGVmZXIgdGhlIGNoZWNrIHRvIGRybV9hdG9taWNfcGxh bmVfY2hlY2soKS4KPiA+Pgo+ID4+IFNpZ25lZC1vZmYtYnk6IFJvYiBDbGFyayA8cm9iZGNsYXJr QGdtYWlsLmNvbT4KPiA+PiAtLS0KPiA+PiAgZHJpdmVycy9ncHUvZHJtL2RybV9hdG9taWMuYyB8 IDE3ICsrKysrKysrKysrKysrKysrCj4gPj4gIGRyaXZlcnMvZ3B1L2RybS9kcm1fY3J0Yy5jICAg fCAyNiArKysrKysrKysrKysrKysrKy0tLS0tLS0tLQo+ID4+ICAyIGZpbGVzIGNoYW5nZWQsIDM0 IGluc2VydGlvbnMoKyksIDkgZGVsZXRpb25zKC0pCj4gPj4KPiA+PiBkaWZmIC0tZ2l0IGEvZHJp dmVycy9ncHUvZHJtL2RybV9hdG9taWMuYyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fYXRvbWljLmMK PiA+PiBpbmRleCAzNGVkZDRmLi5mYjBmMDdjZSAxMDA2NDQKPiA+PiAtLS0gYS9kcml2ZXJzL2dw dS9kcm0vZHJtX2F0b21pYy5jCj4gPj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2RybV9hdG9taWMu Ywo+ID4+IEBAIC04NDYsNyArODQ2LDkgQEAgcGxhbmVfc3dpdGNoaW5nX2NydGMoc3RydWN0IGRy bV9hdG9taWNfc3RhdGUgKnN0YXRlLAo+ID4+ICBzdGF0aWMgaW50IGRybV9hdG9taWNfcGxhbmVf Y2hlY2soc3RydWN0IGRybV9wbGFuZSAqcGxhbmUsCj4gPj4gICAgICAgICAgICAgICBzdHJ1Y3Qg ZHJtX3BsYW5lX3N0YXRlICpzdGF0ZSkKPiA+PiAgewo+ID4+ICsgICAgIHN0cnVjdCBkcm1fbW9k ZV9jb25maWcgKmNvbmZpZyA9ICZwbGFuZS0+ZGV2LT5tb2RlX2NvbmZpZzsKPiA+PiAgICAgICB1 bnNpZ25lZCBpbnQgZmJfd2lkdGgsIGZiX2hlaWdodDsKPiA+PiArICAgICB1bnNpZ25lZCBpbnQg bWluX3dpZHRoLCBtYXhfd2lkdGgsIG1pbl9oZWlnaHQsIG1heF9oZWlnaHQ7Cj4gPj4gICAgICAg aW50IHJldDsKPiA+Pgo+ID4+ICAgICAgIC8qIGVpdGhlciAqYm90aCogQ1JUQyBhbmQgRkIgbXVz dCBiZSBzZXQsIG9yIG5laXRoZXIgKi8KPiA+PiBAQCAtOTA5LDYgKzkxMSwyMSBAQCBzdGF0aWMg aW50IGRybV9hdG9taWNfcGxhbmVfY2hlY2soc3RydWN0IGRybV9wbGFuZSAqcGxhbmUsCj4gPj4g ICAgICAgICAgICAgICByZXR1cm4gLUVOT1NQQzsKPiA+PiAgICAgICB9Cj4gPj4KPiA+PiArICAg ICBtaW5fd2lkdGggPSBjb25maWctPm1pbl93aWR0aCA8PCAxNjsKPiA+PiArICAgICBtYXhfd2lk dGggPSBjb25maWctPm1heF93aWR0aCA8PCAxNjsKPiA+PiArICAgICBtaW5faGVpZ2h0ID0gY29u ZmlnLT5taW5faGVpZ2h0IDw8IDE2Owo+ID4+ICsgICAgIG1heF9oZWlnaHQgPSBjb25maWctPm1h eF9oZWlnaHQgPDwgMTY7Cj4gPj4gKwo+ID4+ICsgICAgIC8qIE1ha2Ugc3VyZSBzb3VyY2UgZGlt ZW5zaW9ucyBhcmUgd2l0aGluIGJvdW5kcy4gKi8KPiA+PiArICAgICBpZiAobWluX3dpZHRoID4g c3RhdGUtPnNyY193IHx8IHN0YXRlLT5zcmNfdyA+IG1heF93aWR0aCB8fAo+ID4+ICsgICAgICAg ICBtaW5faGVpZ2h0ID4gc3RhdGUtPnNyY19oIHx8IHN0YXRlLT5zcmNfaCA+IG1heF9oZWlnaHQp IHsKPiA+PiArICAgICAgICAgICAgIERSTV9ERUJVR19BVE9NSUMoIkludmFsaWQgc291cmNlIHNp emUgIgo+ID4+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAiJXUuJTA2dXgldS4lMDZ1 XG4iLAo+ID4+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBzdGF0ZS0+c3JjX3cgPj4g MTYsICgoc3RhdGUtPnNyY193ICYgMHhmZmZmKSAqIDE1NjI1KSA+PiAxMCwKPiA+PiArICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgc3RhdGUtPnNyY19oID4+IDE2LCAoKHN0YXRlLT5zcmNf aCAmIDB4ZmZmZikgKiAxNTYyNSkgPj4gMTApOwo+ID4+ICsgICAgICAgICAgICAgcmV0dXJuIC1F UkFOR0U7Cj4gPj4gKyAgICAgfQo+ID4+ICsKPiA+PiAgICAgICBpZiAocGxhbmVfc3dpdGNoaW5n X2NydGMoc3RhdGUtPnN0YXRlLCBwbGFuZSwgc3RhdGUpKSB7Cj4gPj4gICAgICAgICAgICAgICBE Uk1fREVCVUdfQVRPTUlDKCJbUExBTkU6JWQ6JXNdIHN3aXRjaGluZyBDUlRDIGRpcmVjdGx5XG4i LAo+ID4+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBwbGFuZS0+YmFzZS5pZCwgcGxh bmUtPm5hbWUpOwo+ID4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2NydGMuYyBi L2RyaXZlcnMvZ3B1L2RybS9kcm1fY3J0Yy5jCj4gPj4gaW5kZXggYjRiOTczZi4uNzI5NGJkZSAx MDA2NDQKPiA+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2NydGMuYwo+ID4+ICsrKyBiL2Ry aXZlcnMvZ3B1L2RybS9kcm1fY3J0Yy5jCj4gPj4gQEAgLTMzNjksMTUgKzMzNjksMjMgQEAgaW50 ZXJuYWxfZnJhbWVidWZmZXJfY3JlYXRlKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsCj4gPj4gICAg ICAgICAgICAgICByZXR1cm4gRVJSX1BUUigtRUlOVkFMKTsKPiA+PiAgICAgICB9Cj4gPj4KPiA+ PiAtICAgICBpZiAoKGNvbmZpZy0+bWluX3dpZHRoID4gci0+d2lkdGgpIHx8IChyLT53aWR0aCA+ IGNvbmZpZy0+bWF4X3dpZHRoKSkgewo+ID4+IC0gICAgICAgICAgICAgRFJNX0RFQlVHX0tNUygi YmFkIGZyYW1lYnVmZmVyIHdpZHRoICVkLCBzaG91bGQgYmUgPj0gJWQgJiYgPD0gJWRcbiIsCj4g Pj4gLSAgICAgICAgICAgICAgICAgICAgICAgci0+d2lkdGgsIGNvbmZpZy0+bWluX3dpZHRoLCBj b25maWctPm1heF93aWR0aCk7Cj4gPj4gLSAgICAgICAgICAgICByZXR1cm4gRVJSX1BUUigtRUlO VkFMKTsKPiA+PiAtICAgICB9Cj4gPj4gLSAgICAgaWYgKChjb25maWctPm1pbl9oZWlnaHQgPiBy LT5oZWlnaHQpIHx8IChyLT5oZWlnaHQgPiBjb25maWctPm1heF9oZWlnaHQpKSB7Cj4gPj4gLSAg ICAgICAgICAgICBEUk1fREVCVUdfS01TKCJiYWQgZnJhbWVidWZmZXIgaGVpZ2h0ICVkLCBzaG91 bGQgYmUgPj0gJWQgJiYgPD0gJWRcbiIsCj4gPj4gLSAgICAgICAgICAgICAgICAgICAgICAgci0+ aGVpZ2h0LCBjb25maWctPm1pbl9oZWlnaHQsIGNvbmZpZy0+bWF4X2hlaWdodCk7Cj4gPj4gLSAg ICAgICAgICAgICByZXR1cm4gRVJSX1BUUigtRUlOVkFMKTsKPiA+PiArICAgICAvKiBmb3IgYXRv bWljIGRyaXZlcnMsIHdlIGNoZWNrIHRoZSBzcmMgZGltZW5zaW9ucyBpbgo+ID4+ICsgICAgICAq IGRybV9hdG9taWNfcGxhbmVfY2hlY2soKS4uIGFsbG93IGNyZWF0aW9uIG9mIGEgZmIKPiA+PiAr ICAgICAgKiB0aGF0IGlzIGxhcmdlciB0aGFuIHdoYXQgY2FuIGJlIHNjYW5uZWQgb3V0LCBhcwo+ ID4+ICsgICAgICAqIGxvbmcgYXMgdXNlcnNwYWNlIGRvZXNuJ3QgdHJ5IHRvIHNjYW5vdXQgYSBw b3J0aW9uCj4gPj4gKyAgICAgICogb2YgdGhlIGZiIHRoYXQgaXMgdG9vIGxhcmdlLgo+ID4+ICsg ICAgICAqLwo+ID4+ICsgICAgIGlmICghZmlsZV9wcml2LT5hdG9taWMpIHsKPiA+PiArICAgICAg ICAgICAgIGlmICgoY29uZmlnLT5taW5fd2lkdGggPiByLT53aWR0aCkgfHwgKHItPndpZHRoID4g Y29uZmlnLT5tYXhfd2lkdGgpKSB7Cj4gPj4gKyAgICAgICAgICAgICAgICAgICAgIERSTV9ERUJV R19LTVMoImJhZCBmcmFtZWJ1ZmZlciB3aWR0aCAlZCwgc2hvdWxkIGJlID49ICVkICYmIDw9ICVk XG4iLAo+ID4+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgci0+d2lkdGgsIGNvbmZp Zy0+bWluX3dpZHRoLCBjb25maWctPm1heF93aWR0aCk7Cj4gPj4gKyAgICAgICAgICAgICAgICAg ICAgIHJldHVybiBFUlJfUFRSKC1FSU5WQUwpOwo+ID4+ICsgICAgICAgICAgICAgfQo+ID4+ICsg ICAgICAgICAgICAgaWYgKChjb25maWctPm1pbl9oZWlnaHQgPiByLT5oZWlnaHQpIHx8IChyLT5o ZWlnaHQgPiBjb25maWctPm1heF9oZWlnaHQpKSB7Cj4gPj4gKyAgICAgICAgICAgICAgICAgICAg IERSTV9ERUJVR19LTVMoImJhZCBmcmFtZWJ1ZmZlciBoZWlnaHQgJWQsIHNob3VsZCBiZSA+PSAl ZCAmJiA8PSAlZFxuIiwKPiA+PiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHItPmhl aWdodCwgY29uZmlnLT5taW5faGVpZ2h0LCBjb25maWctPm1heF9oZWlnaHQpOwo+ID4+ICsgICAg ICAgICAgICAgICAgICAgICByZXR1cm4gRVJSX1BUUigtRUlOVkFMKTsKPiA+PiArICAgICAgICAg ICAgIH0KPiA+Cj4gPiBTbyB3aHkgbm90IGp1c3QgYnVtcCBtYXhfZm9vIGluIHlvdXIgZHJpdmVy Pwo+ID4KPiA+IFJlbW92aW5nIHRoZSByZXN0cmljdGlvbiBmcm9tIHRoZSBjb3JlIHNlZW1zIGxp a2VseSB0byBicmVhayBzb21lCj4gPiBkcml2ZXJzIGFzIHRoZXkgd291bGQgbm93IGhhdmUgdG8g Y2hlY2sgdGhlIGZiIGRpbWVuc2lvbnMgdGhlbXNlbHZlcy4KPiAKPiB0aGF0IGlzIHdoeSBJIGRp ZCBpdCBvbmx5IGZvciBhdG9taWMgZHJpdmVycywgc28gd2UgY291bGQgcmVseSBvbiB0aGUKPiBj aGVja2luZyBpbiBkcm1fYXRvbWljX3BsYW5lX2NoZWNrKCkuLgoKVGhhdCdzIG5vdCB1c2VkIHRv IGNoZWNrIHRoZSBmcmFtZWJ1ZmZlciBkaW1lbnNpb25zLgoKLS0gClZpbGxlIFN5cmrDpGzDpApJ bnRlbCBPVEMKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K ZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0 dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==