From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH] drm: move check for min/max width/height for atomic drivers Date: Thu, 3 Nov 2016 20:32:21 +0200 Message-ID: <20161103183221.GL4617@intel.com> References: <1478096864-14639-1-git-send-email-robdclark@gmail.com> <20161103141249.GT4617@intel.com> <20161103145528.GV4617@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id 934C96E74C for ; Thu, 3 Nov 2016 18:32:28 +0000 (UTC) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Rob Clark Cc: "dri-devel@lists.freedesktop.org" List-Id: dri-devel@lists.freedesktop.org T24gVGh1LCBOb3YgMDMsIDIwMTYgYXQgMTE6MjI6MzdBTSAtMDQwMCwgUm9iIENsYXJrIHdyb3Rl Ogo+IE9uIFRodSwgTm92IDMsIDIwMTYgYXQgMTA6NTUgQU0sIFZpbGxlIFN5cmrDpGzDpAo+IDx2 aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4gd3JvdGU6Cj4gPiBPbiBUaHUsIE5vdiAwMywg MjAxNiBhdCAxMDoxNDoyMEFNIC0wNDAwLCBSb2IgQ2xhcmsgd3JvdGU6Cj4gPj4gT24gVGh1LCBO b3YgMywgMjAxNiBhdCAxMDoxMiBBTSwgVmlsbGUgU3lyasOkbMOkCj4gPj4gPHZpbGxlLnN5cmph bGFAbGludXguaW50ZWwuY29tPiB3cm90ZToKPiA+PiA+IE9uIFdlZCwgTm92IDAyLCAyMDE2IGF0 IDEwOjI3OjQ0QU0gLTA0MDAsIFJvYiBDbGFyayB3cm90ZToKPiA+PiA+PiBkcm0taHdjICsgYW5k cm9pZCB0cmllcyB0byBjcmVhdGUgYW4gZmIgZm9yIHRoZSB3YWxscGFwZXIgbGF5ZXIsIHdoaWNo Cj4gPj4gPj4gaXMgbGFyZ2VyIHRoYW4gdGhlIHNjcmVlbiByZXNvbHV0aW9uLCBhbmQgcG90ZW50 aWFsbHkgbGFyZ2VyIHRoYW4KPiA+PiA+PiBtb2RlX2NvbmZpZy0+bWF4X3t3aWR0aCxoZWlnaHR9 LiAgQnV0IHRoZSBwbGFuZSBzcmNfdy9zcmNfaCBpcyB3aXRoaW4KPiA+PiA+PiB0aGUgbWF4IGxp bWl0cywgc28gaXQgaXMgc29tZXRoaW5nIHRoZSBoYXJkd2FyZSBjYW4gb3RoZXJ3aXNlIGRvLgo+ ID4+ID4+Cj4gPj4gPj4gRm9yIGF0b21pYyBkcml2ZXJzLCBkZWZlciB0aGUgY2hlY2sgdG8gZHJt X2F0b21pY19wbGFuZV9jaGVjaygpLgo+ID4+ID4+Cj4gPj4gPj4gU2lnbmVkLW9mZi1ieTogUm9i IENsYXJrIDxyb2JkY2xhcmtAZ21haWwuY29tPgo+ID4+ID4+IC0tLQo+ID4+ID4+ICBkcml2ZXJz L2dwdS9kcm0vZHJtX2F0b21pYy5jIHwgMTcgKysrKysrKysrKysrKysrKysKPiA+PiA+PiAgZHJp dmVycy9ncHUvZHJtL2RybV9jcnRjLmMgICB8IDI2ICsrKysrKysrKysrKysrKysrLS0tLS0tLS0t Cj4gPj4gPj4gIDIgZmlsZXMgY2hhbmdlZCwgMzQgaW5zZXJ0aW9ucygrKSwgOSBkZWxldGlvbnMo LSkKPiA+PiA+Pgo+ID4+ID4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2F0b21p Yy5jIGIvZHJpdmVycy9ncHUvZHJtL2RybV9hdG9taWMuYwo+ID4+ID4+IGluZGV4IDM0ZWRkNGYu LmZiMGYwN2NlIDEwMDY0NAo+ID4+ID4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fYXRvbWlj LmMKPiA+PiA+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pYy5jCj4gPj4gPj4gQEAg LTg0Niw3ICs4NDYsOSBAQCBwbGFuZV9zd2l0Y2hpbmdfY3J0YyhzdHJ1Y3QgZHJtX2F0b21pY19z dGF0ZSAqc3RhdGUsCj4gPj4gPj4gIHN0YXRpYyBpbnQgZHJtX2F0b21pY19wbGFuZV9jaGVjayhz dHJ1Y3QgZHJtX3BsYW5lICpwbGFuZSwKPiA+PiA+PiAgICAgICAgICAgICAgIHN0cnVjdCBkcm1f cGxhbmVfc3RhdGUgKnN0YXRlKQo+ID4+ID4+ICB7Cj4gPj4gPj4gKyAgICAgc3RydWN0IGRybV9t b2RlX2NvbmZpZyAqY29uZmlnID0gJnBsYW5lLT5kZXYtPm1vZGVfY29uZmlnOwo+ID4+ID4+ICAg ICAgIHVuc2lnbmVkIGludCBmYl93aWR0aCwgZmJfaGVpZ2h0Owo+ID4+ID4+ICsgICAgIHVuc2ln bmVkIGludCBtaW5fd2lkdGgsIG1heF93aWR0aCwgbWluX2hlaWdodCwgbWF4X2hlaWdodDsKPiA+ PiA+PiAgICAgICBpbnQgcmV0Owo+ID4+ID4+Cj4gPj4gPj4gICAgICAgLyogZWl0aGVyICpib3Ro KiBDUlRDIGFuZCBGQiBtdXN0IGJlIHNldCwgb3IgbmVpdGhlciAqLwo+ID4+ID4+IEBAIC05MDks NiArOTExLDIxIEBAIHN0YXRpYyBpbnQgZHJtX2F0b21pY19wbGFuZV9jaGVjayhzdHJ1Y3QgZHJt X3BsYW5lICpwbGFuZSwKPiA+PiA+PiAgICAgICAgICAgICAgIHJldHVybiAtRU5PU1BDOwo+ID4+ ID4+ICAgICAgIH0KPiA+PiA+Pgo+ID4+ID4+ICsgICAgIG1pbl93aWR0aCA9IGNvbmZpZy0+bWlu X3dpZHRoIDw8IDE2Owo+ID4+ID4+ICsgICAgIG1heF93aWR0aCA9IGNvbmZpZy0+bWF4X3dpZHRo IDw8IDE2Owo+ID4+ID4+ICsgICAgIG1pbl9oZWlnaHQgPSBjb25maWctPm1pbl9oZWlnaHQgPDwg MTY7Cj4gPj4gPj4gKyAgICAgbWF4X2hlaWdodCA9IGNvbmZpZy0+bWF4X2hlaWdodCA8PCAxNjsK PiA+PiA+PiArCj4gPj4gPj4gKyAgICAgLyogTWFrZSBzdXJlIHNvdXJjZSBkaW1lbnNpb25zIGFy ZSB3aXRoaW4gYm91bmRzLiAqLwo+ID4+ID4+ICsgICAgIGlmIChtaW5fd2lkdGggPiBzdGF0ZS0+ c3JjX3cgfHwgc3RhdGUtPnNyY193ID4gbWF4X3dpZHRoIHx8Cj4gPj4gPj4gKyAgICAgICAgIG1p bl9oZWlnaHQgPiBzdGF0ZS0+c3JjX2ggfHwgc3RhdGUtPnNyY19oID4gbWF4X2hlaWdodCkgewo+ ID4+ID4+ICsgICAgICAgICAgICAgRFJNX0RFQlVHX0FUT01JQygiSW52YWxpZCBzb3VyY2Ugc2l6 ZSAiCj4gPj4gPj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICIldS4lMDZ1eCV1LiUw NnVcbiIsCj4gPj4gPj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHN0YXRlLT5zcmNf dyA+PiAxNiwgKChzdGF0ZS0+c3JjX3cgJiAweGZmZmYpICogMTU2MjUpID4+IDEwLAo+ID4+ID4+ ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBzdGF0ZS0+c3JjX2ggPj4gMTYsICgoc3Rh dGUtPnNyY19oICYgMHhmZmZmKSAqIDE1NjI1KSA+PiAxMCk7Cj4gPj4gPj4gKyAgICAgICAgICAg ICByZXR1cm4gLUVSQU5HRTsKPiA+PiA+PiArICAgICB9Cj4gPj4gPj4gKwo+ID4+ID4+ICAgICAg IGlmIChwbGFuZV9zd2l0Y2hpbmdfY3J0YyhzdGF0ZS0+c3RhdGUsIHBsYW5lLCBzdGF0ZSkpIHsK PiA+PiA+PiAgICAgICAgICAgICAgIERSTV9ERUJVR19BVE9NSUMoIltQTEFORTolZDolc10gc3dp dGNoaW5nIENSVEMgZGlyZWN0bHlcbiIsCj4gPj4gPj4gICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIHBsYW5lLT5iYXNlLmlkLCBwbGFuZS0+bmFtZSk7Cj4gPj4gPj4gZGlmZiAtLWdpdCBh L2RyaXZlcnMvZ3B1L2RybS9kcm1fY3J0Yy5jIGIvZHJpdmVycy9ncHUvZHJtL2RybV9jcnRjLmMK PiA+PiA+PiBpbmRleCBiNGI5NzNmLi43Mjk0YmRlIDEwMDY0NAo+ID4+ID4+IC0tLSBhL2RyaXZl cnMvZ3B1L2RybS9kcm1fY3J0Yy5jCj4gPj4gPj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2RybV9j cnRjLmMKPiA+PiA+PiBAQCAtMzM2OSwxNSArMzM2OSwyMyBAQCBpbnRlcm5hbF9mcmFtZWJ1ZmZl cl9jcmVhdGUoc3RydWN0IGRybV9kZXZpY2UgKmRldiwKPiA+PiA+PiAgICAgICAgICAgICAgIHJl dHVybiBFUlJfUFRSKC1FSU5WQUwpOwo+ID4+ID4+ICAgICAgIH0KPiA+PiA+Pgo+ID4+ID4+IC0g ICAgIGlmICgoY29uZmlnLT5taW5fd2lkdGggPiByLT53aWR0aCkgfHwgKHItPndpZHRoID4gY29u ZmlnLT5tYXhfd2lkdGgpKSB7Cj4gPj4gPj4gLSAgICAgICAgICAgICBEUk1fREVCVUdfS01TKCJi YWQgZnJhbWVidWZmZXIgd2lkdGggJWQsIHNob3VsZCBiZSA+PSAlZCAmJiA8PSAlZFxuIiwKPiA+ PiA+PiAtICAgICAgICAgICAgICAgICAgICAgICByLT53aWR0aCwgY29uZmlnLT5taW5fd2lkdGgs IGNvbmZpZy0+bWF4X3dpZHRoKTsKPiA+PiA+PiAtICAgICAgICAgICAgIHJldHVybiBFUlJfUFRS KC1FSU5WQUwpOwo+ID4+ID4+IC0gICAgIH0KPiA+PiA+PiAtICAgICBpZiAoKGNvbmZpZy0+bWlu X2hlaWdodCA+IHItPmhlaWdodCkgfHwgKHItPmhlaWdodCA+IGNvbmZpZy0+bWF4X2hlaWdodCkp IHsKPiA+PiA+PiAtICAgICAgICAgICAgIERSTV9ERUJVR19LTVMoImJhZCBmcmFtZWJ1ZmZlciBo ZWlnaHQgJWQsIHNob3VsZCBiZSA+PSAlZCAmJiA8PSAlZFxuIiwKPiA+PiA+PiAtICAgICAgICAg ICAgICAgICAgICAgICByLT5oZWlnaHQsIGNvbmZpZy0+bWluX2hlaWdodCwgY29uZmlnLT5tYXhf aGVpZ2h0KTsKPiA+PiA+PiAtICAgICAgICAgICAgIHJldHVybiBFUlJfUFRSKC1FSU5WQUwpOwo+ ID4+ID4+ICsgICAgIC8qIGZvciBhdG9taWMgZHJpdmVycywgd2UgY2hlY2sgdGhlIHNyYyBkaW1l bnNpb25zIGluCj4gPj4gPj4gKyAgICAgICogZHJtX2F0b21pY19wbGFuZV9jaGVjaygpLi4gYWxs b3cgY3JlYXRpb24gb2YgYSBmYgo+ID4+ID4+ICsgICAgICAqIHRoYXQgaXMgbGFyZ2VyIHRoYW4g d2hhdCBjYW4gYmUgc2Nhbm5lZCBvdXQsIGFzCj4gPj4gPj4gKyAgICAgICogbG9uZyBhcyB1c2Vy c3BhY2UgZG9lc24ndCB0cnkgdG8gc2Nhbm91dCBhIHBvcnRpb24KPiA+PiA+PiArICAgICAgKiBv ZiB0aGUgZmIgdGhhdCBpcyB0b28gbGFyZ2UuCj4gPj4gPj4gKyAgICAgICovCj4gPj4gPj4gKyAg ICAgaWYgKCFmaWxlX3ByaXYtPmF0b21pYykgewo+ID4+ID4+ICsgICAgICAgICAgICAgaWYgKChj b25maWctPm1pbl93aWR0aCA+IHItPndpZHRoKSB8fCAoci0+d2lkdGggPiBjb25maWctPm1heF93 aWR0aCkpIHsKPiA+PiA+PiArICAgICAgICAgICAgICAgICAgICAgRFJNX0RFQlVHX0tNUygiYmFk IGZyYW1lYnVmZmVyIHdpZHRoICVkLCBzaG91bGQgYmUgPj0gJWQgJiYgPD0gJWRcbiIsCj4gPj4g Pj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICByLT53aWR0aCwgY29uZmlnLT5taW5f d2lkdGgsIGNvbmZpZy0+bWF4X3dpZHRoKTsKPiA+PiA+PiArICAgICAgICAgICAgICAgICAgICAg cmV0dXJuIEVSUl9QVFIoLUVJTlZBTCk7Cj4gPj4gPj4gKyAgICAgICAgICAgICB9Cj4gPj4gPj4g KyAgICAgICAgICAgICBpZiAoKGNvbmZpZy0+bWluX2hlaWdodCA+IHItPmhlaWdodCkgfHwgKHIt PmhlaWdodCA+IGNvbmZpZy0+bWF4X2hlaWdodCkpIHsKPiA+PiA+PiArICAgICAgICAgICAgICAg ICAgICAgRFJNX0RFQlVHX0tNUygiYmFkIGZyYW1lYnVmZmVyIGhlaWdodCAlZCwgc2hvdWxkIGJl ID49ICVkICYmIDw9ICVkXG4iLAo+ID4+ID4+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgci0+aGVpZ2h0LCBjb25maWctPm1pbl9oZWlnaHQsIGNvbmZpZy0+bWF4X2hlaWdodCk7Cj4g Pj4gPj4gKyAgICAgICAgICAgICAgICAgICAgIHJldHVybiBFUlJfUFRSKC1FSU5WQUwpOwo+ID4+ ID4+ICsgICAgICAgICAgICAgfQo+ID4+ID4KPiA+PiA+IFNvIHdoeSBub3QganVzdCBidW1wIG1h eF9mb28gaW4geW91ciBkcml2ZXI/Cj4gPj4gPgo+ID4+ID4gUmVtb3ZpbmcgdGhlIHJlc3RyaWN0 aW9uIGZyb20gdGhlIGNvcmUgc2VlbXMgbGlrZWx5IHRvIGJyZWFrIHNvbWUKPiA+PiA+IGRyaXZl cnMgYXMgdGhleSB3b3VsZCBub3cgaGF2ZSB0byBjaGVjayB0aGUgZmIgZGltZW5zaW9ucyB0aGVt c2VsdmVzLgo+ID4+Cj4gPj4gdGhhdCBpcyB3aHkgSSBkaWQgaXQgb25seSBmb3IgYXRvbWljIGRy aXZlcnMsIHNvIHdlIGNvdWxkIHJlbHkgb24gdGhlCj4gPj4gY2hlY2tpbmcgaW4gZHJtX2F0b21p Y19wbGFuZV9jaGVjaygpLi4KPiA+Cj4gPiBUaGF0J3Mgbm90IHVzZWQgdG8gY2hlY2sgdGhlIGZy YW1lYnVmZmVyIGRpbWVuc2lvbnMuCj4gCj4gYnV0IGl0IGlzIHVzZWQgdG8gY2hlY2sgc2Nhbm91 dCBkaW1lbnNpb25zIGFuZCB0aGF0IGlzIHVzdWFsbHkgd2hhdAo+IG1hdHRlcnMuLiAgd2UgY291 bGQgYWRkIGEgbWF4LXBpdGNoIHBhcmFtIGlmIG5lZWRlZCwgYnV0IHRoZSBtYXgtZmIKPiBkaW1l bnNpb24gY2hlY2sgaXMgbW9zdGx5IHVzZWxlc3MuCgpUaGVyZSdzIG5vIHBvaW50IGluIGxldHRp bmcgdGhlIHVzZXIgY3JlYXRlIGEgZnJhbWVidWZmZXIgdGhhdCBjYW4ndCBiZQpzY2FubmVkIG91 dCBhdCBhbGwuCgotLSAKVmlsbGUgU3lyasOkbMOkCkludGVsIE9UQwpfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRy aS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5v cmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK