From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH] drm: move check for min/max width/height for atomic drivers Date: Thu, 3 Nov 2016 20:48:34 +0200 Message-ID: <20161103184834.GM4617@intel.com> References: <1478096864-14639-1-git-send-email-robdclark@gmail.com> <20161103141249.GT4617@intel.com> <20161103145528.GV4617@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id 092F56E7E2 for ; Thu, 3 Nov 2016 18:48:38 +0000 (UTC) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Sean Paul Cc: "dri-devel@lists.freedesktop.org" List-Id: dri-devel@lists.freedesktop.org T24gVGh1LCBOb3YgMDMsIDIwMTYgYXQgMDk6MzU6MjRBTSAtMDYwMCwgU2VhbiBQYXVsIHdyb3Rl Ogo+IE9uIFRodSwgTm92IDMsIDIwMTYgYXQgOToyMiBBTSwgUm9iIENsYXJrIDxyb2JkY2xhcmtA Z21haWwuY29tPiB3cm90ZToKPiA+IE9uIFRodSwgTm92IDMsIDIwMTYgYXQgMTA6NTUgQU0sIFZp bGxlIFN5cmrDpGzDpAo+ID4gPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPiB3cm90ZToK PiA+PiBPbiBUaHUsIE5vdiAwMywgMjAxNiBhdCAxMDoxNDoyMEFNIC0wNDAwLCBSb2IgQ2xhcmsg d3JvdGU6Cj4gPj4+IE9uIFRodSwgTm92IDMsIDIwMTYgYXQgMTA6MTIgQU0sIFZpbGxlIFN5cmrD pGzDpAo+ID4+PiA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+IHdyb3RlOgo+ID4+PiA+ IE9uIFdlZCwgTm92IDAyLCAyMDE2IGF0IDEwOjI3OjQ0QU0gLTA0MDAsIFJvYiBDbGFyayB3cm90 ZToKPiA+Pj4gPj4gZHJtLWh3YyArIGFuZHJvaWQgdHJpZXMgdG8gY3JlYXRlIGFuIGZiIGZvciB0 aGUgd2FsbHBhcGVyIGxheWVyLCB3aGljaAo+ID4+PiA+PiBpcyBsYXJnZXIgdGhhbiB0aGUgc2Ny ZWVuIHJlc29sdXRpb24sIGFuZCBwb3RlbnRpYWxseSBsYXJnZXIgdGhhbgo+ID4+PiA+PiBtb2Rl X2NvbmZpZy0+bWF4X3t3aWR0aCxoZWlnaHR9LiAgQnV0IHRoZSBwbGFuZSBzcmNfdy9zcmNfaCBp cyB3aXRoaW4KPiA+Pj4gPj4gdGhlIG1heCBsaW1pdHMsIHNvIGl0IGlzIHNvbWV0aGluZyB0aGUg aGFyZHdhcmUgY2FuIG90aGVyd2lzZSBkby4KPiA+Pj4gPj4KPiA+Pj4gPj4gRm9yIGF0b21pYyBk cml2ZXJzLCBkZWZlciB0aGUgY2hlY2sgdG8gZHJtX2F0b21pY19wbGFuZV9jaGVjaygpLgo+ID4+ PiA+Pgo+ID4+PiA+PiBTaWduZWQtb2ZmLWJ5OiBSb2IgQ2xhcmsgPHJvYmRjbGFya0BnbWFpbC5j b20+Cj4gPj4+ID4+IC0tLQo+ID4+PiA+PiAgZHJpdmVycy9ncHUvZHJtL2RybV9hdG9taWMuYyB8 IDE3ICsrKysrKysrKysrKysrKysrCj4gPj4+ID4+ICBkcml2ZXJzL2dwdS9kcm0vZHJtX2NydGMu YyAgIHwgMjYgKysrKysrKysrKysrKysrKystLS0tLS0tLS0KPiA+Pj4gPj4gIDIgZmlsZXMgY2hh bmdlZCwgMzQgaW5zZXJ0aW9ucygrKSwgOSBkZWxldGlvbnMoLSkKPiA+Pj4gPj4KPiA+Pj4gPj4g ZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fYXRvbWljLmMgYi9kcml2ZXJzL2dwdS9k cm0vZHJtX2F0b21pYy5jCj4gPj4+ID4+IGluZGV4IDM0ZWRkNGYuLmZiMGYwN2NlIDEwMDY0NAo+ ID4+PiA+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pYy5jCj4gPj4+ID4+ICsrKyBi L2RyaXZlcnMvZ3B1L2RybS9kcm1fYXRvbWljLmMKPiA+Pj4gPj4gQEAgLTg0Niw3ICs4NDYsOSBA QCBwbGFuZV9zd2l0Y2hpbmdfY3J0YyhzdHJ1Y3QgZHJtX2F0b21pY19zdGF0ZSAqc3RhdGUsCj4g Pj4+ID4+ICBzdGF0aWMgaW50IGRybV9hdG9taWNfcGxhbmVfY2hlY2soc3RydWN0IGRybV9wbGFu ZSAqcGxhbmUsCj4gPj4+ID4+ICAgICAgICAgICAgICAgc3RydWN0IGRybV9wbGFuZV9zdGF0ZSAq c3RhdGUpCj4gPj4+ID4+ICB7Cj4gPj4+ID4+ICsgICAgIHN0cnVjdCBkcm1fbW9kZV9jb25maWcg KmNvbmZpZyA9ICZwbGFuZS0+ZGV2LT5tb2RlX2NvbmZpZzsKPiA+Pj4gPj4gICAgICAgdW5zaWdu ZWQgaW50IGZiX3dpZHRoLCBmYl9oZWlnaHQ7Cj4gPj4+ID4+ICsgICAgIHVuc2lnbmVkIGludCBt aW5fd2lkdGgsIG1heF93aWR0aCwgbWluX2hlaWdodCwgbWF4X2hlaWdodDsKPiA+Pj4gPj4gICAg ICAgaW50IHJldDsKPiA+Pj4gPj4KPiA+Pj4gPj4gICAgICAgLyogZWl0aGVyICpib3RoKiBDUlRD IGFuZCBGQiBtdXN0IGJlIHNldCwgb3IgbmVpdGhlciAqLwo+ID4+PiA+PiBAQCAtOTA5LDYgKzkx MSwyMSBAQCBzdGF0aWMgaW50IGRybV9hdG9taWNfcGxhbmVfY2hlY2soc3RydWN0IGRybV9wbGFu ZSAqcGxhbmUsCj4gPj4+ID4+ICAgICAgICAgICAgICAgcmV0dXJuIC1FTk9TUEM7Cj4gPj4+ID4+ ICAgICAgIH0KPiA+Pj4gPj4KPiA+Pj4gPj4gKyAgICAgbWluX3dpZHRoID0gY29uZmlnLT5taW5f d2lkdGggPDwgMTY7Cj4gPj4+ID4+ICsgICAgIG1heF93aWR0aCA9IGNvbmZpZy0+bWF4X3dpZHRo IDw8IDE2Owo+ID4+PiA+PiArICAgICBtaW5faGVpZ2h0ID0gY29uZmlnLT5taW5faGVpZ2h0IDw8 IDE2Owo+ID4+PiA+PiArICAgICBtYXhfaGVpZ2h0ID0gY29uZmlnLT5tYXhfaGVpZ2h0IDw8IDE2 Owo+ID4+PiA+PiArCj4gPj4+ID4+ICsgICAgIC8qIE1ha2Ugc3VyZSBzb3VyY2UgZGltZW5zaW9u cyBhcmUgd2l0aGluIGJvdW5kcy4gKi8KPiA+Pj4gPj4gKyAgICAgaWYgKG1pbl93aWR0aCA+IHN0 YXRlLT5zcmNfdyB8fCBzdGF0ZS0+c3JjX3cgPiBtYXhfd2lkdGggfHwKPiA+Pj4gPj4gKyAgICAg ICAgIG1pbl9oZWlnaHQgPiBzdGF0ZS0+c3JjX2ggfHwgc3RhdGUtPnNyY19oID4gbWF4X2hlaWdo dCkgewo+ID4+PiA+PiArICAgICAgICAgICAgIERSTV9ERUJVR19BVE9NSUMoIkludmFsaWQgc291 cmNlIHNpemUgIgo+ID4+PiA+PiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIiV1LiUw NnV4JXUuJTA2dVxuIiwKPiA+Pj4gPj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHN0 YXRlLT5zcmNfdyA+PiAxNiwgKChzdGF0ZS0+c3JjX3cgJiAweGZmZmYpICogMTU2MjUpID4+IDEw LAo+ID4+PiA+PiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgc3RhdGUtPnNyY19oID4+ IDE2LCAoKHN0YXRlLT5zcmNfaCAmIDB4ZmZmZikgKiAxNTYyNSkgPj4gMTApOwo+ID4+PiA+PiAr ICAgICAgICAgICAgIHJldHVybiAtRVJBTkdFOwo+ID4+PiA+PiArICAgICB9Cj4gPj4+ID4+ICsK PiA+Pj4gPj4gICAgICAgaWYgKHBsYW5lX3N3aXRjaGluZ19jcnRjKHN0YXRlLT5zdGF0ZSwgcGxh bmUsIHN0YXRlKSkgewo+ID4+PiA+PiAgICAgICAgICAgICAgIERSTV9ERUJVR19BVE9NSUMoIltQ TEFORTolZDolc10gc3dpdGNoaW5nIENSVEMgZGlyZWN0bHlcbiIsCj4gPj4+ID4+ICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICBwbGFuZS0+YmFzZS5pZCwgcGxhbmUtPm5hbWUpOwo+ID4+ PiA+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2RybV9jcnRjLmMgYi9kcml2ZXJzL2dw dS9kcm0vZHJtX2NydGMuYwo+ID4+PiA+PiBpbmRleCBiNGI5NzNmLi43Mjk0YmRlIDEwMDY0NAo+ ID4+PiA+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2NydGMuYwo+ID4+PiA+PiArKysgYi9k cml2ZXJzL2dwdS9kcm0vZHJtX2NydGMuYwo+ID4+PiA+PiBAQCAtMzM2OSwxNSArMzM2OSwyMyBA QCBpbnRlcm5hbF9mcmFtZWJ1ZmZlcl9jcmVhdGUoc3RydWN0IGRybV9kZXZpY2UgKmRldiwKPiA+ Pj4gPj4gICAgICAgICAgICAgICByZXR1cm4gRVJSX1BUUigtRUlOVkFMKTsKPiA+Pj4gPj4gICAg ICAgfQo+ID4+PiA+Pgo+ID4+PiA+PiAtICAgICBpZiAoKGNvbmZpZy0+bWluX3dpZHRoID4gci0+ d2lkdGgpIHx8IChyLT53aWR0aCA+IGNvbmZpZy0+bWF4X3dpZHRoKSkgewo+ID4+PiA+PiAtICAg ICAgICAgICAgIERSTV9ERUJVR19LTVMoImJhZCBmcmFtZWJ1ZmZlciB3aWR0aCAlZCwgc2hvdWxk IGJlID49ICVkICYmIDw9ICVkXG4iLAo+ID4+PiA+PiAtICAgICAgICAgICAgICAgICAgICAgICBy LT53aWR0aCwgY29uZmlnLT5taW5fd2lkdGgsIGNvbmZpZy0+bWF4X3dpZHRoKTsKPiA+Pj4gPj4g LSAgICAgICAgICAgICByZXR1cm4gRVJSX1BUUigtRUlOVkFMKTsKPiA+Pj4gPj4gLSAgICAgfQo+ ID4+PiA+PiAtICAgICBpZiAoKGNvbmZpZy0+bWluX2hlaWdodCA+IHItPmhlaWdodCkgfHwgKHIt PmhlaWdodCA+IGNvbmZpZy0+bWF4X2hlaWdodCkpIHsKPiA+Pj4gPj4gLSAgICAgICAgICAgICBE Uk1fREVCVUdfS01TKCJiYWQgZnJhbWVidWZmZXIgaGVpZ2h0ICVkLCBzaG91bGQgYmUgPj0gJWQg JiYgPD0gJWRcbiIsCj4gPj4+ID4+IC0gICAgICAgICAgICAgICAgICAgICAgIHItPmhlaWdodCwg Y29uZmlnLT5taW5faGVpZ2h0LCBjb25maWctPm1heF9oZWlnaHQpOwo+ID4+PiA+PiAtICAgICAg ICAgICAgIHJldHVybiBFUlJfUFRSKC1FSU5WQUwpOwo+ID4+PiA+PiArICAgICAvKiBmb3IgYXRv bWljIGRyaXZlcnMsIHdlIGNoZWNrIHRoZSBzcmMgZGltZW5zaW9ucyBpbgo+ID4+PiA+PiArICAg ICAgKiBkcm1fYXRvbWljX3BsYW5lX2NoZWNrKCkuLiBhbGxvdyBjcmVhdGlvbiBvZiBhIGZiCj4g Pj4+ID4+ICsgICAgICAqIHRoYXQgaXMgbGFyZ2VyIHRoYW4gd2hhdCBjYW4gYmUgc2Nhbm5lZCBv dXQsIGFzCj4gPj4+ID4+ICsgICAgICAqIGxvbmcgYXMgdXNlcnNwYWNlIGRvZXNuJ3QgdHJ5IHRv IHNjYW5vdXQgYSBwb3J0aW9uCj4gPj4+ID4+ICsgICAgICAqIG9mIHRoZSBmYiB0aGF0IGlzIHRv byBsYXJnZS4KPiA+Pj4gPj4gKyAgICAgICovCj4gPj4+ID4+ICsgICAgIGlmICghZmlsZV9wcml2 LT5hdG9taWMpIHsKPiA+Pj4gPj4gKyAgICAgICAgICAgICBpZiAoKGNvbmZpZy0+bWluX3dpZHRo ID4gci0+d2lkdGgpIHx8IChyLT53aWR0aCA+IGNvbmZpZy0+bWF4X3dpZHRoKSkgewo+ID4+PiA+ PiArICAgICAgICAgICAgICAgICAgICAgRFJNX0RFQlVHX0tNUygiYmFkIGZyYW1lYnVmZmVyIHdp ZHRoICVkLCBzaG91bGQgYmUgPj0gJWQgJiYgPD0gJWRcbiIsCj4gPj4+ID4+ICsgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgci0+d2lkdGgsIGNvbmZpZy0+bWluX3dpZHRoLCBjb25maWct Pm1heF93aWR0aCk7Cj4gPj4+ID4+ICsgICAgICAgICAgICAgICAgICAgICByZXR1cm4gRVJSX1BU UigtRUlOVkFMKTsKPiA+Pj4gPj4gKyAgICAgICAgICAgICB9Cj4gPj4+ID4+ICsgICAgICAgICAg ICAgaWYgKChjb25maWctPm1pbl9oZWlnaHQgPiByLT5oZWlnaHQpIHx8IChyLT5oZWlnaHQgPiBj b25maWctPm1heF9oZWlnaHQpKSB7Cj4gPj4+ID4+ICsgICAgICAgICAgICAgICAgICAgICBEUk1f REVCVUdfS01TKCJiYWQgZnJhbWVidWZmZXIgaGVpZ2h0ICVkLCBzaG91bGQgYmUgPj0gJWQgJiYg PD0gJWRcbiIsCj4gPj4+ID4+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgci0+aGVp Z2h0LCBjb25maWctPm1pbl9oZWlnaHQsIGNvbmZpZy0+bWF4X2hlaWdodCk7Cj4gPj4+ID4+ICsg ICAgICAgICAgICAgICAgICAgICByZXR1cm4gRVJSX1BUUigtRUlOVkFMKTsKPiA+Pj4gPj4gKyAg ICAgICAgICAgICB9Cj4gPj4+ID4KPiA+Pj4gPiBTbyB3aHkgbm90IGp1c3QgYnVtcCBtYXhfZm9v IGluIHlvdXIgZHJpdmVyPwo+ID4+PiA+Cj4gPj4+ID4gUmVtb3ZpbmcgdGhlIHJlc3RyaWN0aW9u IGZyb20gdGhlIGNvcmUgc2VlbXMgbGlrZWx5IHRvIGJyZWFrIHNvbWUKPiA+Pj4gPiBkcml2ZXJz IGFzIHRoZXkgd291bGQgbm93IGhhdmUgdG8gY2hlY2sgdGhlIGZiIGRpbWVuc2lvbnMgdGhlbXNl bHZlcy4KPiA+Pj4KPiA+Pj4gdGhhdCBpcyB3aHkgSSBkaWQgaXQgb25seSBmb3IgYXRvbWljIGRy aXZlcnMsIHNvIHdlIGNvdWxkIHJlbHkgb24gdGhlCj4gPj4+IGNoZWNraW5nIGluIGRybV9hdG9t aWNfcGxhbmVfY2hlY2soKS4uCj4gPj4KPiA+PiBUaGF0J3Mgbm90IHVzZWQgdG8gY2hlY2sgdGhl IGZyYW1lYnVmZmVyIGRpbWVuc2lvbnMuCj4gPgo+ID4gYnV0IGl0IGlzIHVzZWQgdG8gY2hlY2sg c2Nhbm91dCBkaW1lbnNpb25zIGFuZCB0aGF0IGlzIHVzdWFsbHkgd2hhdAo+ID4gbWF0dGVycy4u ICB3ZSBjb3VsZCBhZGQgYSBtYXgtcGl0Y2ggcGFyYW0gaWYgbmVlZGVkLCBidXQgdGhlIG1heC1m Ygo+ID4gZGltZW5zaW9uIGNoZWNrIGlzIG1vc3RseSB1c2VsZXNzLgo+ID4KPiAKPiBZZWFoLCBJ IHN1cHBvc2UgdGhpcyBkZXBlbmRzIG9uIGhvdyB5b3UgaW50ZXJwcmV0IHRoZSBtb2RlX2NvbmZp Zwo+IGNvbnN0cmFpbnRzLiBJIHRoaW5rIHRoaXMgY2hhbmdlIG1ha2VzIHNlbnNlIHNpbmNlIHdl IHNob3VsZG4ndCBsaW1pdAo+IGZiIHNpemUgb24gc2Nhbm91dCByZXN0cmljdGlvbnMuCgpIbW0u IFNvIHdoYXQgYXJlIHRoZSB1c2VzIHdlIGhhdmUgZm9yIHRoaXMgaW5mb3JtYXRpb24/CgpGaXJz dCBvbmUgaXMgdGhlIG1heCBmYiBzaXplLCB0aGUgb3RoZXIgb25lIGlzIG1vZGUgZmlsdGVyaW5n LgpTbyBJJ20gdGhpbmtpbmcgd2UgY291bGQganVzdCBzcGxpdCB0aGUgZmIgc2l6ZSBsaW1pdCBp bnRvIGl0cwpvd24gdGhpbmcgYW5kIGxlYXZlIHRoZSBjdXJyZW50IHRoaW5nIGluZGljYXRpbmcg dGhlIGxpbWl0cyBvZgp0aGUgdGltaW5nIGdlbmVyYXRvcnMgaGRpc3BsYXkvdmRpc3BsYXkgZm9y IG1vZGUgZmlsdGVyaW5nLgoKQWx0aG91Z2ggZHJpdmVycyBzaG91bGQgc3RpbGwgZmlsdGVyIHRo ZSBtb2RlcyBmdXJ0aGVyIGJhc2VkIG9uCnRoZSBvdGhlciB0aW1pbmdzIGFzIHdlbGwsIHNvIG5v dCBzdXJlIGhvdyBtdWNoIHVzZSB0aGVyZSBpcwppbiBoYXZpbmcgdGhlIGNvcmUgZG8gcGFydCBv ZiBpdC4gQnV0IEkgdGhpbmsgY3VycmVudGx5IG1hbnkKZHJpdmVycyBtaWdodCBub3QgZG8gdGhl IGZpbHRlcmluZyB2ZXJ5IHJvYnVzdGx5IHNvIGhhdmluZwpzb21ldGhpbmcgaW4gdGhlIGNvcmUg aXMgcHJvYmFibHkgYmV0dGVyIHRoYW4gbm90aGluZy4KCkFkZGl0aW9uYWxseSBwbGFuZXMgY291 bGQgaGF2ZSBhZGRpdGlvbmFsIHNjYW5vdXQgbGltaXRhdGlvbnMsCmJ1dCB0aG9zZSBzaG91bGQg YWxyZWFkeSBiZSBoYW5kbGVkIGJ5IGFueSByZWFzb25hYmx5IGNvbXBldGVtbnQKYXRvbWljX2No ZWNrIGltcGxlbWVudGF0aW9uLiBBbHRob3VnaCBJIHN1c3BlY3QgYSBidW5jaCBvZiB0aGluZ3MK d291bGQgZ28gYSBiaXQgbnV0cyBpZiB3ZSBjb3VsZG4ndCBzdXBwb3J0IGFuIHVuc2NhbGVkIGZ1 bGwKc2NyZWVuIHByaW1hcnkgcGxhbmUuIFNvIHBvdGVudGlhbGx5IHRoZSBtb2RlX2NvbmZpZyBs aW1pdHMKc2hvdWxkIGJlIHRoZSBtaW5pbXVtIG9mIHRoZSB0aW1pbmcgZ2VuZXJhdG9yIGFuZCBw bGFuZSBzY2Fub3V0CmxpbWl0cz8gSSBzdXBwb3NlIHRoZSB0d28gd291bGQgdXN1c2FsbHkgYmUg bWF0Y2hlZCBpbiB0aGUgaGFyZHdhcmUKYW55d2F5LgoKLS0gClZpbGxlIFN5cmrDpGzDpApJbnRl bCBPVEMKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJp LWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBz Oi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==