From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH] drm: move check for min/max width/height for atomic drivers Date: Thu, 3 Nov 2016 20:52:07 +0200 Message-ID: <20161103185207.GN4617@intel.com> References: <1478096864-14639-1-git-send-email-robdclark@gmail.com> <20161103141249.GT4617@intel.com> <20161103145528.GV4617@intel.com> <20161103183221.GL4617@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4B9196E7F6 for ; Thu, 3 Nov 2016 18:52:11 +0000 (UTC) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Rob Clark Cc: "dri-devel@lists.freedesktop.org" List-Id: dri-devel@lists.freedesktop.org T24gVGh1LCBOb3YgMDMsIDIwMTYgYXQgMDI6Mzc6MzBQTSAtMDQwMCwgUm9iIENsYXJrIHdyb3Rl Ogo+IE9uIFRodSwgTm92IDMsIDIwMTYgYXQgMjozMiBQTSwgVmlsbGUgU3lyasOkbMOkCj4gPHZp bGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPiB3cm90ZToKPiA+IE9uIFRodSwgTm92IDAzLCAy MDE2IGF0IDExOjIyOjM3QU0gLTA0MDAsIFJvYiBDbGFyayB3cm90ZToKPiA+PiBPbiBUaHUsIE5v diAzLCAyMDE2IGF0IDEwOjU1IEFNLCBWaWxsZSBTeXJqw6Rsw6QKPiA+PiA8dmlsbGUuc3lyamFs YUBsaW51eC5pbnRlbC5jb20+IHdyb3RlOgo+ID4+ID4gT24gVGh1LCBOb3YgMDMsIDIwMTYgYXQg MTA6MTQ6MjBBTSAtMDQwMCwgUm9iIENsYXJrIHdyb3RlOgo+ID4+ID4+IE9uIFRodSwgTm92IDMs IDIwMTYgYXQgMTA6MTIgQU0sIFZpbGxlIFN5cmrDpGzDpAo+ID4+ID4+IDx2aWxsZS5zeXJqYWxh QGxpbnV4LmludGVsLmNvbT4gd3JvdGU6Cj4gPj4gPj4gPiBPbiBXZWQsIE5vdiAwMiwgMjAxNiBh dCAxMDoyNzo0NEFNIC0wNDAwLCBSb2IgQ2xhcmsgd3JvdGU6Cj4gPj4gPj4gPj4gZHJtLWh3YyAr IGFuZHJvaWQgdHJpZXMgdG8gY3JlYXRlIGFuIGZiIGZvciB0aGUgd2FsbHBhcGVyIGxheWVyLCB3 aGljaAo+ID4+ID4+ID4+IGlzIGxhcmdlciB0aGFuIHRoZSBzY3JlZW4gcmVzb2x1dGlvbiwgYW5k IHBvdGVudGlhbGx5IGxhcmdlciB0aGFuCj4gPj4gPj4gPj4gbW9kZV9jb25maWctPm1heF97d2lk dGgsaGVpZ2h0fS4gIEJ1dCB0aGUgcGxhbmUgc3JjX3cvc3JjX2ggaXMgd2l0aGluCj4gPj4gPj4g Pj4gdGhlIG1heCBsaW1pdHMsIHNvIGl0IGlzIHNvbWV0aGluZyB0aGUgaGFyZHdhcmUgY2FuIG90 aGVyd2lzZSBkby4KPiA+PiA+PiA+Pgo+ID4+ID4+ID4+IEZvciBhdG9taWMgZHJpdmVycywgZGVm ZXIgdGhlIGNoZWNrIHRvIGRybV9hdG9taWNfcGxhbmVfY2hlY2soKS4KPiA+PiA+PiA+Pgo+ID4+ ID4+ID4+IFNpZ25lZC1vZmYtYnk6IFJvYiBDbGFyayA8cm9iZGNsYXJrQGdtYWlsLmNvbT4KPiA+ PiA+PiA+PiAtLS0KPiA+PiA+PiA+PiAgZHJpdmVycy9ncHUvZHJtL2RybV9hdG9taWMuYyB8IDE3 ICsrKysrKysrKysrKysrKysrCj4gPj4gPj4gPj4gIGRyaXZlcnMvZ3B1L2RybS9kcm1fY3J0Yy5j ICAgfCAyNiArKysrKysrKysrKysrKysrKy0tLS0tLS0tLQo+ID4+ID4+ID4+ICAyIGZpbGVzIGNo YW5nZWQsIDM0IGluc2VydGlvbnMoKyksIDkgZGVsZXRpb25zKC0pCj4gPj4gPj4gPj4KPiA+PiA+ PiA+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2RybV9hdG9taWMuYyBiL2RyaXZlcnMv Z3B1L2RybS9kcm1fYXRvbWljLmMKPiA+PiA+PiA+PiBpbmRleCAzNGVkZDRmLi5mYjBmMDdjZSAx MDA2NDQKPiA+PiA+PiA+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pYy5jCj4gPj4g Pj4gPj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2RybV9hdG9taWMuYwo+ID4+ID4+ID4+IEBAIC04 NDYsNyArODQ2LDkgQEAgcGxhbmVfc3dpdGNoaW5nX2NydGMoc3RydWN0IGRybV9hdG9taWNfc3Rh dGUgKnN0YXRlLAo+ID4+ID4+ID4+ICBzdGF0aWMgaW50IGRybV9hdG9taWNfcGxhbmVfY2hlY2so c3RydWN0IGRybV9wbGFuZSAqcGxhbmUsCj4gPj4gPj4gPj4gICAgICAgICAgICAgICBzdHJ1Y3Qg ZHJtX3BsYW5lX3N0YXRlICpzdGF0ZSkKPiA+PiA+PiA+PiAgewo+ID4+ID4+ID4+ICsgICAgIHN0 cnVjdCBkcm1fbW9kZV9jb25maWcgKmNvbmZpZyA9ICZwbGFuZS0+ZGV2LT5tb2RlX2NvbmZpZzsK PiA+PiA+PiA+PiAgICAgICB1bnNpZ25lZCBpbnQgZmJfd2lkdGgsIGZiX2hlaWdodDsKPiA+PiA+ PiA+PiArICAgICB1bnNpZ25lZCBpbnQgbWluX3dpZHRoLCBtYXhfd2lkdGgsIG1pbl9oZWlnaHQs IG1heF9oZWlnaHQ7Cj4gPj4gPj4gPj4gICAgICAgaW50IHJldDsKPiA+PiA+PiA+Pgo+ID4+ID4+ ID4+ICAgICAgIC8qIGVpdGhlciAqYm90aCogQ1JUQyBhbmQgRkIgbXVzdCBiZSBzZXQsIG9yIG5l aXRoZXIgKi8KPiA+PiA+PiA+PiBAQCAtOTA5LDYgKzkxMSwyMSBAQCBzdGF0aWMgaW50IGRybV9h dG9taWNfcGxhbmVfY2hlY2soc3RydWN0IGRybV9wbGFuZSAqcGxhbmUsCj4gPj4gPj4gPj4gICAg ICAgICAgICAgICByZXR1cm4gLUVOT1NQQzsKPiA+PiA+PiA+PiAgICAgICB9Cj4gPj4gPj4gPj4K PiA+PiA+PiA+PiArICAgICBtaW5fd2lkdGggPSBjb25maWctPm1pbl93aWR0aCA8PCAxNjsKPiA+ PiA+PiA+PiArICAgICBtYXhfd2lkdGggPSBjb25maWctPm1heF93aWR0aCA8PCAxNjsKPiA+PiA+ PiA+PiArICAgICBtaW5faGVpZ2h0ID0gY29uZmlnLT5taW5faGVpZ2h0IDw8IDE2Owo+ID4+ID4+ ID4+ICsgICAgIG1heF9oZWlnaHQgPSBjb25maWctPm1heF9oZWlnaHQgPDwgMTY7Cj4gPj4gPj4g Pj4gKwo+ID4+ID4+ID4+ICsgICAgIC8qIE1ha2Ugc3VyZSBzb3VyY2UgZGltZW5zaW9ucyBhcmUg d2l0aGluIGJvdW5kcy4gKi8KPiA+PiA+PiA+PiArICAgICBpZiAobWluX3dpZHRoID4gc3RhdGUt PnNyY193IHx8IHN0YXRlLT5zcmNfdyA+IG1heF93aWR0aCB8fAo+ID4+ID4+ID4+ICsgICAgICAg ICBtaW5faGVpZ2h0ID4gc3RhdGUtPnNyY19oIHx8IHN0YXRlLT5zcmNfaCA+IG1heF9oZWlnaHQp IHsKPiA+PiA+PiA+PiArICAgICAgICAgICAgIERSTV9ERUJVR19BVE9NSUMoIkludmFsaWQgc291 cmNlIHNpemUgIgo+ID4+ID4+ID4+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAiJXUu JTA2dXgldS4lMDZ1XG4iLAo+ID4+ID4+ID4+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICBzdGF0ZS0+c3JjX3cgPj4gMTYsICgoc3RhdGUtPnNyY193ICYgMHhmZmZmKSAqIDE1NjI1KSA+ PiAxMCwKPiA+PiA+PiA+PiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgc3RhdGUtPnNy Y19oID4+IDE2LCAoKHN0YXRlLT5zcmNfaCAmIDB4ZmZmZikgKiAxNTYyNSkgPj4gMTApOwo+ID4+ ID4+ID4+ICsgICAgICAgICAgICAgcmV0dXJuIC1FUkFOR0U7Cj4gPj4gPj4gPj4gKyAgICAgfQo+ ID4+ID4+ID4+ICsKPiA+PiA+PiA+PiAgICAgICBpZiAocGxhbmVfc3dpdGNoaW5nX2NydGMoc3Rh dGUtPnN0YXRlLCBwbGFuZSwgc3RhdGUpKSB7Cj4gPj4gPj4gPj4gICAgICAgICAgICAgICBEUk1f REVCVUdfQVRPTUlDKCJbUExBTkU6JWQ6JXNdIHN3aXRjaGluZyBDUlRDIGRpcmVjdGx5XG4iLAo+ ID4+ID4+ID4+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBwbGFuZS0+YmFzZS5pZCwg cGxhbmUtPm5hbWUpOwo+ID4+ID4+ID4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vZHJt X2NydGMuYyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fY3J0Yy5jCj4gPj4gPj4gPj4gaW5kZXggYjRi OTczZi4uNzI5NGJkZSAxMDA2NDQKPiA+PiA+PiA+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vZHJt X2NydGMuYwo+ID4+ID4+ID4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fY3J0Yy5jCj4gPj4g Pj4gPj4gQEAgLTMzNjksMTUgKzMzNjksMjMgQEAgaW50ZXJuYWxfZnJhbWVidWZmZXJfY3JlYXRl KHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsCj4gPj4gPj4gPj4gICAgICAgICAgICAgICByZXR1cm4g RVJSX1BUUigtRUlOVkFMKTsKPiA+PiA+PiA+PiAgICAgICB9Cj4gPj4gPj4gPj4KPiA+PiA+PiA+ PiAtICAgICBpZiAoKGNvbmZpZy0+bWluX3dpZHRoID4gci0+d2lkdGgpIHx8IChyLT53aWR0aCA+ IGNvbmZpZy0+bWF4X3dpZHRoKSkgewo+ID4+ID4+ID4+IC0gICAgICAgICAgICAgRFJNX0RFQlVH X0tNUygiYmFkIGZyYW1lYnVmZmVyIHdpZHRoICVkLCBzaG91bGQgYmUgPj0gJWQgJiYgPD0gJWRc biIsCj4gPj4gPj4gPj4gLSAgICAgICAgICAgICAgICAgICAgICAgci0+d2lkdGgsIGNvbmZpZy0+ bWluX3dpZHRoLCBjb25maWctPm1heF93aWR0aCk7Cj4gPj4gPj4gPj4gLSAgICAgICAgICAgICBy ZXR1cm4gRVJSX1BUUigtRUlOVkFMKTsKPiA+PiA+PiA+PiAtICAgICB9Cj4gPj4gPj4gPj4gLSAg ICAgaWYgKChjb25maWctPm1pbl9oZWlnaHQgPiByLT5oZWlnaHQpIHx8IChyLT5oZWlnaHQgPiBj b25maWctPm1heF9oZWlnaHQpKSB7Cj4gPj4gPj4gPj4gLSAgICAgICAgICAgICBEUk1fREVCVUdf S01TKCJiYWQgZnJhbWVidWZmZXIgaGVpZ2h0ICVkLCBzaG91bGQgYmUgPj0gJWQgJiYgPD0gJWRc biIsCj4gPj4gPj4gPj4gLSAgICAgICAgICAgICAgICAgICAgICAgci0+aGVpZ2h0LCBjb25maWct Pm1pbl9oZWlnaHQsIGNvbmZpZy0+bWF4X2hlaWdodCk7Cj4gPj4gPj4gPj4gLSAgICAgICAgICAg ICByZXR1cm4gRVJSX1BUUigtRUlOVkFMKTsKPiA+PiA+PiA+PiArICAgICAvKiBmb3IgYXRvbWlj IGRyaXZlcnMsIHdlIGNoZWNrIHRoZSBzcmMgZGltZW5zaW9ucyBpbgo+ID4+ID4+ID4+ICsgICAg ICAqIGRybV9hdG9taWNfcGxhbmVfY2hlY2soKS4uIGFsbG93IGNyZWF0aW9uIG9mIGEgZmIKPiA+ PiA+PiA+PiArICAgICAgKiB0aGF0IGlzIGxhcmdlciB0aGFuIHdoYXQgY2FuIGJlIHNjYW5uZWQg b3V0LCBhcwo+ID4+ID4+ID4+ICsgICAgICAqIGxvbmcgYXMgdXNlcnNwYWNlIGRvZXNuJ3QgdHJ5 IHRvIHNjYW5vdXQgYSBwb3J0aW9uCj4gPj4gPj4gPj4gKyAgICAgICogb2YgdGhlIGZiIHRoYXQg aXMgdG9vIGxhcmdlLgo+ID4+ID4+ID4+ICsgICAgICAqLwo+ID4+ID4+ID4+ICsgICAgIGlmICgh ZmlsZV9wcml2LT5hdG9taWMpIHsKPiA+PiA+PiA+PiArICAgICAgICAgICAgIGlmICgoY29uZmln LT5taW5fd2lkdGggPiByLT53aWR0aCkgfHwgKHItPndpZHRoID4gY29uZmlnLT5tYXhfd2lkdGgp KSB7Cj4gPj4gPj4gPj4gKyAgICAgICAgICAgICAgICAgICAgIERSTV9ERUJVR19LTVMoImJhZCBm cmFtZWJ1ZmZlciB3aWR0aCAlZCwgc2hvdWxkIGJlID49ICVkICYmIDw9ICVkXG4iLAo+ID4+ID4+ ID4+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgci0+d2lkdGgsIGNvbmZpZy0+bWlu X3dpZHRoLCBjb25maWctPm1heF93aWR0aCk7Cj4gPj4gPj4gPj4gKyAgICAgICAgICAgICAgICAg ICAgIHJldHVybiBFUlJfUFRSKC1FSU5WQUwpOwo+ID4+ID4+ID4+ICsgICAgICAgICAgICAgfQo+ ID4+ID4+ID4+ICsgICAgICAgICAgICAgaWYgKChjb25maWctPm1pbl9oZWlnaHQgPiByLT5oZWln aHQpIHx8IChyLT5oZWlnaHQgPiBjb25maWctPm1heF9oZWlnaHQpKSB7Cj4gPj4gPj4gPj4gKyAg ICAgICAgICAgICAgICAgICAgIERSTV9ERUJVR19LTVMoImJhZCBmcmFtZWJ1ZmZlciBoZWlnaHQg JWQsIHNob3VsZCBiZSA+PSAlZCAmJiA8PSAlZFxuIiwKPiA+PiA+PiA+PiArICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIHItPmhlaWdodCwgY29uZmlnLT5taW5faGVpZ2h0LCBjb25maWct Pm1heF9oZWlnaHQpOwo+ID4+ID4+ID4+ICsgICAgICAgICAgICAgICAgICAgICByZXR1cm4gRVJS X1BUUigtRUlOVkFMKTsKPiA+PiA+PiA+PiArICAgICAgICAgICAgIH0KPiA+PiA+PiA+Cj4gPj4g Pj4gPiBTbyB3aHkgbm90IGp1c3QgYnVtcCBtYXhfZm9vIGluIHlvdXIgZHJpdmVyPwo+ID4+ID4+ ID4KPiA+PiA+PiA+IFJlbW92aW5nIHRoZSByZXN0cmljdGlvbiBmcm9tIHRoZSBjb3JlIHNlZW1z IGxpa2VseSB0byBicmVhayBzb21lCj4gPj4gPj4gPiBkcml2ZXJzIGFzIHRoZXkgd291bGQgbm93 IGhhdmUgdG8gY2hlY2sgdGhlIGZiIGRpbWVuc2lvbnMgdGhlbXNlbHZlcy4KPiA+PiA+Pgo+ID4+ ID4+IHRoYXQgaXMgd2h5IEkgZGlkIGl0IG9ubHkgZm9yIGF0b21pYyBkcml2ZXJzLCBzbyB3ZSBj b3VsZCByZWx5IG9uIHRoZQo+ID4+ID4+IGNoZWNraW5nIGluIGRybV9hdG9taWNfcGxhbmVfY2hl Y2soKS4uCj4gPj4gPgo+ID4+ID4gVGhhdCdzIG5vdCB1c2VkIHRvIGNoZWNrIHRoZSBmcmFtZWJ1 ZmZlciBkaW1lbnNpb25zLgo+ID4+Cj4gPj4gYnV0IGl0IGlzIHVzZWQgdG8gY2hlY2sgc2Nhbm91 dCBkaW1lbnNpb25zIGFuZCB0aGF0IGlzIHVzdWFsbHkgd2hhdAo+ID4+IG1hdHRlcnMuLiAgd2Ug Y291bGQgYWRkIGEgbWF4LXBpdGNoIHBhcmFtIGlmIG5lZWRlZCwgYnV0IHRoZSBtYXgtZmIKPiA+ PiBkaW1lbnNpb24gY2hlY2sgaXMgbW9zdGx5IHVzZWxlc3MuCj4gPgo+ID4gVGhlcmUncyBubyBw b2ludCBpbiBsZXR0aW5nIHRoZSB1c2VyIGNyZWF0ZSBhIGZyYW1lYnVmZmVyIHRoYXQgY2FuJ3Qg YmUKPiA+IHNjYW5uZWQgb3V0IGF0IGFsbC4KPiAKPiBCdXQgaWYgYSB1c2VyIGNhbiBzY2FuIG91 dCAqcGFydCogb2YgaXQuLiB3aGljaCBpcyB0aGUgY2FzZSBoZXJlLiAgQW5kCj4gYSBjb21tb24g Y2FzZS4KClRoYXQncyBub3QgaG93IEkgaW50ZXJwcmV0IHRoZXNlIGxpbWl0cy4gSW4gbXkgYm9v ayB0aGV5J3JlIHN1cHBvc2VkIHRvCmJlIHRoZSBtYXggZmIgc2l6ZSB5b3UgY2FuIHNjYW4gb3V0 IChvciB3aGF0IHlvdSdyZSB3aWxsaW5nIHRvIHN1cHBvcnQKaW4geW91ciBkcml2ZXIpLiBXaGV0 aGVyIHlvdSBjYW4gc2NhbiBvdXQganVzdCBhIHBhcnQgb2YgaXQgaXMgYW5vdGhlcgptYXR0ZXIg KGFuZCBhIG1hdHRlciBmb3IgYXRvbWljX2NoZWNrKCkgYXQgdGhhdCkuCgo+IAo+IHRiaCwgb3Vy IG1pbi9tYXggY2hlY2tzIGFyZSBwcmV0dHkgYm9ndXMgZm9yIG1vc3QgaGFyZHdhcmUsIG90aGVy IHRoYW4KPiBtYXliZSB0aWxjZGMgd2hlcmUgd2lkdGg9PXBpdGNoLi4uICBpdCBzaG91bGQgYmUg bW9yZSBhbG9uZyB0aGUgbGluZXMKPiBvZiBtYXhfcGl0Y2ggb3Igc3RyaWRlLCBwbHVzIHNyY193 L3NyY19oIGNoZWNrcyBpbgo+IGRybV9hdG9taWNfcGxhbmVfY2hlY2soKS4KClllYWgsIEkgZ3Vl c3Mgc3RyaWRlIGlzIG9mdGVuIHRoZSBsaW1pdGluZyBmYWN0b3IuIEFsdGhvdWdoIHdpdGgKcm90 YXRpb24gZXZlbiB0aGUgdmVydGljYWwgc3RyaWRlIG1pZ2h0IHN0YXJ0IHRvIG1hdHRlci4KCi0t IApWaWxsZSBTeXJqw6Rsw6QKSW50ZWwgT1RDCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3Rz LmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2RyaS1kZXZlbAo=