From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Ripard Subject: Re: [PATCH v2 2/9] drm/sun4i: support A33 tcon Date: Sun, 6 Nov 2016 19:50:59 +0100 Message-ID: <20161106185059.uo2cb67wmquwtnuc@lukather> References: <20160906144620.6322-1-maxime.ripard@free-electrons.com> <20160906144620.6322-3-maxime.ripard@free-electrons.com> Reply-To: maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="sepn643nfxjbazal" Return-path: Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Content-Disposition: inline In-Reply-To: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Chen-Yu Tsai Cc: Daniel Vetter , David Airlie , Thierry Reding , Rob Herring , dri-devel , linux-arm-kernel , linux-kernel , linux-sunxi , Thomas Petazzoni List-Id: dri-devel@lists.freedesktop.org --sepn643nfxjbazal Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline On Sat, Nov 05, 2016 at 11:54:28PM +0800, Chen-Yu Tsai wrote: > Hi, > > On Tue, Sep 6, 2016 at 10:46 PM, Maxime Ripard > wrote: > > The A33 has a significantly different pipeline, with components that differ > > too. > > > > Make sure we had compatible for them. > > > > Signed-off-by: Maxime Ripard > > --- > > Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt | 7 ++++++- > > drivers/gpu/drm/sun4i/sun4i_backend.c | 1 + > > drivers/gpu/drm/sun4i/sun4i_drv.c | 8 +++++--- > > drivers/gpu/drm/sun4i/sun4i_tcon.c | 8 +++++++- > > 4 files changed, 19 insertions(+), 5 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt b/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt > > index df8f4aeefe4c..bd3136a5cba5 100644 > > --- a/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt > > +++ b/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt > > @@ -26,7 +26,9 @@ TCON > > The TCON acts as a timing controller for RGB, LVDS and TV interfaces. > > > > Required properties: > > - - compatible: value should be "allwinner,sun5i-a13-tcon". > > + - compatible: value must be either: > > + * allwinner,sun5i-a13-tcon > > + * allwinner,sun8i-a33-tcon > > - reg: base address and size of memory-mapped region > > - interrupts: interrupt associated to this IP > > - clocks: phandles to the clocks feeding the TCON. Three are needed: > > @@ -59,6 +61,7 @@ system. > > Required properties: > > - compatible: value must be one of: > > * allwinner,sun5i-a13-display-backend > > + * allwinner,sun8i-a33-display-backend > > - reg: base address and size of the memory-mapped region. > > - clocks: phandles to the clocks feeding the frontend and backend > > * ahb: the backend interface clock > > @@ -80,6 +83,7 @@ deinterlacing and color space conversion. > > Required properties: > > - compatible: value must be one of: > > * allwinner,sun5i-a13-display-frontend > > + * allwinner,sun8i-a33-display-frontend > > I just looked at the A23. It seems it's the same display frontend as the A33. > Should we change the compatible string to a23 while it's still in RC? > > The backend is probably different. The A33 only claims to support 2048x2048 > layers, while the A23 claims to support 8192x8192 layers. I think we can still keep it. Especially if we're not sure, we might need to make use of it in the future. Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --sepn643nfxjbazal--