From: Christophe Fergeau <cfergeau@redhat.com>
To: spice-devel@lists.freedesktop.org
Cc: airlied@redhat.com, dri-devel@lists.freedesktop.org
Subject: [drm/qxl v3 7/7] qxl: Allow resolution which are not multiple of 8
Date: Mon, 7 Nov 2016 09:01:03 +0100 [thread overview]
Message-ID: <20161107080103.22299-8-cfergeau@redhat.com> (raw)
In-Reply-To: <20161107080103.22299-1-cfergeau@redhat.com>
The use of drm_cvt_mode() in qxl_add_monitors_config_modes() means that
the resolutions we are going to present to user-space are going to be
rounded down to a multiple of 8. In the QXL arbitrary resolution case,
this is not useful.
This commit forces the actual width/height that was requested by the
client in the drm_display_mode structure rather than keeping the
rounded version.
Signed-off-by: Christophe Fergeau <cfergeau@redhat.com>
---
drivers/gpu/drm/qxl/qxl_display.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/qxl/qxl_display.c b/drivers/gpu/drm/qxl/qxl_display.c
index 518333c..fa99481 100644
--- a/drivers/gpu/drm/qxl/qxl_display.c
+++ b/drivers/gpu/drm/qxl/qxl_display.c
@@ -199,6 +199,9 @@ static int qxl_add_monitors_config_modes(struct drm_connector *connector,
mode = drm_cvt_mode(dev, head->width, head->height, 60, false, false,
false);
mode->type |= DRM_MODE_TYPE_PREFERRED;
+ mode->hdisplay = head->width;
+ mode->vdisplay = head->height;
+ drm_mode_set_name(mode);
*pwidth = head->width;
*pheight = head->height;
drm_mode_probed_add(connector, mode);
--
2.9.3
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2016-11-07 8:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-07 8:00 [drm/qxl v3 0/7] qxl: Various cleanups/fixes Christophe Fergeau
2016-11-07 8:00 ` [drm/qxl v3 1/7] qxl: Mark some internal functions as static Christophe Fergeau
2016-11-07 8:00 ` [drm/qxl v3 2/7] qxl: Remove unused prototype Christophe Fergeau
2016-11-07 8:00 ` [drm/qxl v3 3/7] qxl: Add missing '\n' to qxl_io_log() call Christophe Fergeau
2016-11-07 8:01 ` [drm/qxl v3 4/7] qxl: Call qxl_gem_{init,fini} Christophe Fergeau
2016-11-07 8:01 ` [drm/qxl v3 5/7] qxl: Remove qxl_bo_init() return value Christophe Fergeau
2016-11-07 8:57 ` Frediano Ziglio
2016-11-07 8:01 ` [drm/qxl v3 6/7] qxl: Don't notify userspace when monitors config is unchanged Christophe Fergeau
2016-11-07 9:08 ` [Spice-devel] " Frediano Ziglio
2016-11-07 9:17 ` Christophe Fergeau
2016-11-07 8:01 ` Christophe Fergeau [this message]
2016-11-07 9:15 ` [drm/qxl v3 0/7] qxl: Various cleanups/fixes Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161107080103.22299-8-cfergeau@redhat.com \
--to=cfergeau@redhat.com \
--cc=airlied@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=spice-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox