From: Gustavo Padovan <gustavo@padovan.org>
To: Alex Deucher <alexdeucher@gmail.com>
Cc: "Alex Deucher" <alexander.deucher@amd.com>,
dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org,
"Christian König" <christian.koenig@amd.com>
Subject: Re: [PATCH 4/4] reservation: revert "wait only with non-zero timeout specified (v3)" v2
Date: Tue, 8 Nov 2016 09:50:23 +0900 [thread overview]
Message-ID: <20161108005023.GN3327@joana> (raw)
In-Reply-To: <1478553376-18575-4-git-send-email-alexander.deucher@amd.com>
2016-11-07 Alex Deucher <alexdeucher@gmail.com>:
> From: Christian König <christian.koenig@amd.com>
>
> This reverts commit fb8b7d2b9d80e1e71f379e57355936bd2b024be9.
>
> Otherwise signaling might never be activated on the fences. This can
> result in infinite waiting with hardware which has unreliable interrupts.
>
> v2: still return one when the timeout is zero and we don't have any fences.
>
> Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
> Signed-off-by: Christian König <christian.koenig@amd.com>
> Reviewed-by: Chunming Zhou <david1.zhou@amd.com> (v1)
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
> ---
> drivers/dma-buf/reservation.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
You left all my r-b out. For the whole series:
Reviewed-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
Gustavo
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2016-11-08 0:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-07 21:16 [PATCH 1/4] dma-buf/fence: make timeout handling in fence_default_wait consistent (v2) Alex Deucher
[not found] ` <1478553376-18575-1-git-send-email-alexander.deucher-5C7GfCeVMHo@public.gmane.org>
2016-11-07 21:16 ` [PATCH 2/4] dma-buf/fence: revert "don't wait when specified timeout is zero" (v2) Alex Deucher
2016-11-07 21:16 ` [PATCH 3/4] drm/ttm: fix ttm_bo_wait Alex Deucher
2016-11-07 21:16 ` [PATCH 4/4] reservation: revert "wait only with non-zero timeout specified (v3)" v2 Alex Deucher
2016-11-08 0:50 ` Gustavo Padovan [this message]
2016-11-08 19:35 ` [PATCH 1/4] dma-buf/fence: make timeout handling in fence_default_wait consistent (v2) Sumit Semwal
-- strict thread matches above, loose matches on Subject: below --
2016-10-25 12:25 Fixing zero timeout handling for fence functions Christian König
2016-10-25 12:25 ` [PATCH 4/4] reservation: revert "wait only with non-zero timeout specified (v3)" v2 Christian König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161108005023.GN3327@joana \
--to=gustavo@padovan.org \
--cc=alexander.deucher@amd.com \
--cc=alexdeucher@gmail.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).