From: Stefan Christ <contact@stefanchrist.eu>
To: "Christian König" <deathsimple@vodafone.de>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v2 00/18] Introduce DRM_FB_HELPER_DEFAULT_OPS for struct fb_ops
Date: Mon, 14 Nov 2016 13:37:48 +0100 [thread overview]
Message-ID: <20161114123748.GA1844@sill.h.stcim.de> (raw)
In-Reply-To: <2916c677-c40c-95ab-0ea3-f4110475e6c4@vodafone.de>
Hi Christian,
On Mon, Nov 14, 2016 at 10:43:10AM +0100, Christian König wrote:
> Am 14.11.2016 um 00:03 schrieb Stefan Christ:
> > Hi,
> >
> > this is the second version of the refactoring work suggested by Daniel Vetter
> > in the email:
> >
> > https://lists.freedesktop.org/archives/dri-devel/2016-July/113237.html
> >
> > The define DRM_FB_HELPER_DEFAULT_OPS provides the drm_fb_helper default
> > implementations for functions in struct fb_ops. A drm driver can use it like:
> >
> > static struct fb_ops drm_fbdev_cma_ops = {
> > .owner = THIS_MODULE,
> > DRM_FB_HELPER_DEFAULT_OPS,
> > /* driver specific implementations */
> > };
>
> Looks good to me in general, but I've got one question. Why didn't you
> put the owner field into the macro as well?
>
> I have strong doubts that anybody would set anything else than
> THIS_MODULE here.
>
In the initial suggestion by Daniel Vetter he also mentioned this
possibility. See email and response:
https://lists.freedesktop.org/archives/dri-devel/2016-July/114136.html
But I decided against it, since it hides even more magic behind the
helper define.
Mit freundlichen Grüßen / Kind regards,
Stefan Christ
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2016-11-14 12:37 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-13 23:03 [PATCH v2 00/18] Introduce DRM_FB_HELPER_DEFAULT_OPS for struct fb_ops Stefan Christ
2016-11-13 23:03 ` [PATCH v2 01/18] drm/fb-helper: fix segfaults in drm_fb_helper_debug_* Stefan Christ
2016-11-13 23:03 ` [PATCH v2 02/18] drm/fb-helper: add fb_debug_* to DRM_FB_HELPER_DEFAULT_OPS Stefan Christ
2016-11-13 23:03 ` [PATCH v2 03/18] drm/amdgpu: use DRM_FB_HELPER_DEFAULT_OPS for fb_ops Stefan Christ
2016-11-13 23:03 ` [PATCH v2 04/18] drm/armada: " Stefan Christ
2016-11-13 23:03 ` [PATCH v2 05/18] drm/bochs: " Stefan Christ
2016-11-13 23:03 ` [PATCH v2 06/18] drm/fb_cma_helper: " Stefan Christ
2016-11-13 23:03 ` [PATCH v2 07/18] drm/exynos: " Stefan Christ
2016-11-13 23:03 ` [PATCH v2 08/18] drm/nouveau: " Stefan Christ
2016-11-13 23:03 ` [PATCH v2 09/18] drm/qxl: " Stefan Christ
2016-11-13 23:03 ` [PATCH v2 10/18] drm/rockchip: " Stefan Christ
2016-11-13 23:03 ` [PATCH v2 11/18] drm/radeon: " Stefan Christ
2016-11-13 23:03 ` [PATCH v2 12/18] drm/tegra: " Stefan Christ
2016-11-13 23:03 ` [PATCH v2 13/18] drm/udl: " Stefan Christ
2016-11-13 23:03 ` [PATCH v2 14/18] drm/msm: " Stefan Christ
2016-11-13 23:03 ` [PATCH v2 15/18] drm/virtio: " Stefan Christ
2016-11-13 23:03 ` [PATCH v2 16/18] drm/omapdrm: " Stefan Christ
2016-11-13 23:03 ` [PATCH v2 17/18] drm/i915: " Stefan Christ
2016-11-13 23:03 ` [PATCH v2 18/18] drm/gma500: " Stefan Christ
2016-11-14 7:02 ` [PATCH v2 00/18] Introduce DRM_FB_HELPER_DEFAULT_OPS for struct fb_ops Daniel Vetter
2016-11-14 9:43 ` Christian König
2016-11-14 12:37 ` Stefan Christ [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161114123748.GA1844@sill.h.stcim.de \
--to=contact@stefanchrist.eu \
--cc=deathsimple@vodafone.de \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).