dri-devel.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
* [drm-intel:topic/drm-misc 23/26] include/drm/drm_fb_cma_helper.h:45:13: warning: 'struct drm_plane_state' declared inside parameter list will not be visible outside of this definition or declaration
@ 2016-11-15  8:29 kbuild test robot
  2016-11-15  8:47 ` Daniel Vetter
  0 siblings, 1 reply; 4+ messages in thread
From: kbuild test robot @ 2016-11-15  8:29 UTC (permalink / raw)
  To: Marek Vasut; +Cc: Daniel Vetter, intel-gfx, kbuild-all, dri-devel, Lucas Stach

[-- Attachment #1: Type: text/plain, Size: 1730 bytes --]

tree:   git://anongit.freedesktop.org/drm-intel topic/drm-misc
head:   35cf03508d8466ecc5199c9d609e74e85bec785b
commit: 14d7f96f90fb65c2ca0e0ac7df237e06ff001c29 [23/26] drm/fb_cma_helper: Add drm_fb_cma_prepare_fb() helper
config: i386-allmodconfig (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
        git checkout 14d7f96f90fb65c2ca0e0ac7df237e06ff001c29
        # save the attached .config to linux build tree
        make ARCH=i386 

All warnings (new ones prefixed by >>):

   In file included from drivers/gpu/drm/vc4/vc4_drv.c:18:0:
>> include/drm/drm_fb_cma_helper.h:45:13: warning: 'struct drm_plane_state' declared inside parameter list will not be visible outside of this definition or declaration
         struct drm_plane_state *state);
                ^~~~~~~~~~~~~~~
>> include/drm/drm_fb_cma_helper.h:44:34: warning: 'struct drm_plane' declared inside parameter list will not be visible outside of this definition or declaration
    int drm_fb_cma_prepare_fb(struct drm_plane *plane,
                                     ^~~~~~~~~

vim +45 include/drm/drm_fb_cma_helper.h

    38	struct drm_framebuffer *drm_fb_cma_create(struct drm_device *dev,
    39		struct drm_file *file_priv, const struct drm_mode_fb_cmd2 *mode_cmd);
    40	
    41	struct drm_gem_cma_object *drm_fb_cma_get_gem_obj(struct drm_framebuffer *fb,
    42		unsigned int plane);
    43	
  > 44	int drm_fb_cma_prepare_fb(struct drm_plane *plane,
  > 45				  struct drm_plane_state *state);
    46	
    47	#ifdef CONFIG_DEBUG_FS
    48	struct seq_file;

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 56846 bytes --]

[-- Attachment #3: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [drm-intel:topic/drm-misc 23/26] include/drm/drm_fb_cma_helper.h:45:13: warning: 'struct drm_plane_state' declared inside parameter list will not be visible outside of this definition or declaration
  2016-11-15  8:29 [drm-intel:topic/drm-misc 23/26] include/drm/drm_fb_cma_helper.h:45:13: warning: 'struct drm_plane_state' declared inside parameter list will not be visible outside of this definition or declaration kbuild test robot
@ 2016-11-15  8:47 ` Daniel Vetter
  2016-11-15 10:02   ` Daniel Vetter
  0 siblings, 1 reply; 4+ messages in thread
From: Daniel Vetter @ 2016-11-15  8:47 UTC (permalink / raw)
  To: kbuild test robot
  Cc: Marek Vasut, Daniel Vetter, intel-gfx, dri-devel, kbuild-all,
	Lucas Stach

On Tue, Nov 15, 2016 at 04:29:04PM +0800, kbuild test robot wrote:
> tree:   git://anongit.freedesktop.org/drm-intel topic/drm-misc
> head:   35cf03508d8466ecc5199c9d609e74e85bec785b
> commit: 14d7f96f90fb65c2ca0e0ac7df237e06ff001c29 [23/26] drm/fb_cma_helper: Add drm_fb_cma_prepare_fb() helper
> config: i386-allmodconfig (attached as .config)
> compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
> reproduce:
>         git checkout 14d7f96f90fb65c2ca0e0ac7df237e06ff001c29
>         # save the attached .config to linux build tree
>         make ARCH=i386 
> 
> All warnings (new ones prefixed by >>):
> 
>    In file included from drivers/gpu/drm/vc4/vc4_drv.c:18:0:
> >> include/drm/drm_fb_cma_helper.h:45:13: warning: 'struct drm_plane_state' declared inside parameter list will not be visible outside of this definition or declaration
>          struct drm_plane_state *state);
>                 ^~~~~~~~~~~~~~~
> >> include/drm/drm_fb_cma_helper.h:44:34: warning: 'struct drm_plane' declared inside parameter list will not be visible outside of this definition or declaration
>     int drm_fb_cma_prepare_fb(struct drm_plane *plane,
>                                      ^~~~~~~~~

Oops, didn't noticed this compiler warning before pushing. Since drm-misc
is non-rebasing, can you pls supply a full fixup patch Marek?

Thanks, Daniel

> 
> vim +45 include/drm/drm_fb_cma_helper.h
> 
>     38	struct drm_framebuffer *drm_fb_cma_create(struct drm_device *dev,
>     39		struct drm_file *file_priv, const struct drm_mode_fb_cmd2 *mode_cmd);
>     40	
>     41	struct drm_gem_cma_object *drm_fb_cma_get_gem_obj(struct drm_framebuffer *fb,
>     42		unsigned int plane);
>     43	
>   > 44	int drm_fb_cma_prepare_fb(struct drm_plane *plane,
>   > 45				  struct drm_plane_state *state);
>     46	
>     47	#ifdef CONFIG_DEBUG_FS
>     48	struct seq_file;
> 
> ---
> 0-DAY kernel test infrastructure                Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all                   Intel Corporation



-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [drm-intel:topic/drm-misc 23/26] include/drm/drm_fb_cma_helper.h:45:13: warning: 'struct drm_plane_state' declared inside parameter list will not be visible outside of this definition or declaration
  2016-11-15  8:47 ` Daniel Vetter
@ 2016-11-15 10:02   ` Daniel Vetter
  2016-11-15 10:53     ` Marek Vasut
  0 siblings, 1 reply; 4+ messages in thread
From: Daniel Vetter @ 2016-11-15 10:02 UTC (permalink / raw)
  To: kbuild test robot
  Cc: Marek Vasut, Daniel Vetter, intel-gfx, dri-devel, kbuild-all,
	Lucas Stach

On Tue, Nov 15, 2016 at 09:47:31AM +0100, Daniel Vetter wrote:
> On Tue, Nov 15, 2016 at 04:29:04PM +0800, kbuild test robot wrote:
> > tree:   git://anongit.freedesktop.org/drm-intel topic/drm-misc
> > head:   35cf03508d8466ecc5199c9d609e74e85bec785b
> > commit: 14d7f96f90fb65c2ca0e0ac7df237e06ff001c29 [23/26] drm/fb_cma_helper: Add drm_fb_cma_prepare_fb() helper
> > config: i386-allmodconfig (attached as .config)
> > compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
> > reproduce:
> >         git checkout 14d7f96f90fb65c2ca0e0ac7df237e06ff001c29
> >         # save the attached .config to linux build tree
> >         make ARCH=i386 
> > 
> > All warnings (new ones prefixed by >>):
> > 
> >    In file included from drivers/gpu/drm/vc4/vc4_drv.c:18:0:
> > >> include/drm/drm_fb_cma_helper.h:45:13: warning: 'struct drm_plane_state' declared inside parameter list will not be visible outside of this definition or declaration
> >          struct drm_plane_state *state);
> >                 ^~~~~~~~~~~~~~~
> > >> include/drm/drm_fb_cma_helper.h:44:34: warning: 'struct drm_plane' declared inside parameter list will not be visible outside of this definition or declaration
> >     int drm_fb_cma_prepare_fb(struct drm_plane *plane,
> >                                      ^~~~~~~~~
> 
> Oops, didn't noticed this compiler warning before pushing. Since drm-misc
> is non-rebasing, can you pls supply a full fixup patch Marek?

Probably just need an #include <drm/drm_plane.h> in drm_fb_cma_helper.h.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [drm-intel:topic/drm-misc 23/26] include/drm/drm_fb_cma_helper.h:45:13: warning: 'struct drm_plane_state' declared inside parameter list will not be visible outside of this definition or declaration
  2016-11-15 10:02   ` Daniel Vetter
@ 2016-11-15 10:53     ` Marek Vasut
  0 siblings, 0 replies; 4+ messages in thread
From: Marek Vasut @ 2016-11-15 10:53 UTC (permalink / raw)
  To: Daniel Vetter, kbuild test robot
  Cc: Daniel Vetter, intel-gfx, kbuild-all, dri-devel, Lucas Stach

On 11/15/2016 11:02 AM, Daniel Vetter wrote:
> On Tue, Nov 15, 2016 at 09:47:31AM +0100, Daniel Vetter wrote:
>> On Tue, Nov 15, 2016 at 04:29:04PM +0800, kbuild test robot wrote:
>>> tree:   git://anongit.freedesktop.org/drm-intel topic/drm-misc
>>> head:   35cf03508d8466ecc5199c9d609e74e85bec785b
>>> commit: 14d7f96f90fb65c2ca0e0ac7df237e06ff001c29 [23/26] drm/fb_cma_helper: Add drm_fb_cma_prepare_fb() helper
>>> config: i386-allmodconfig (attached as .config)
>>> compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
>>> reproduce:
>>>         git checkout 14d7f96f90fb65c2ca0e0ac7df237e06ff001c29
>>>         # save the attached .config to linux build tree
>>>         make ARCH=i386 
>>>
>>> All warnings (new ones prefixed by >>):
>>>
>>>    In file included from drivers/gpu/drm/vc4/vc4_drv.c:18:0:
>>>>> include/drm/drm_fb_cma_helper.h:45:13: warning: 'struct drm_plane_state' declared inside parameter list will not be visible outside of this definition or declaration
>>>          struct drm_plane_state *state);
>>>                 ^~~~~~~~~~~~~~~
>>>>> include/drm/drm_fb_cma_helper.h:44:34: warning: 'struct drm_plane' declared inside parameter list will not be visible outside of this definition or declaration
>>>     int drm_fb_cma_prepare_fb(struct drm_plane *plane,
>>>                                      ^~~~~~~~~
>>
>> Oops, didn't noticed this compiler warning before pushing. Since drm-misc
>> is non-rebasing, can you pls supply a full fixup patch Marek?
> 
> Probably just need an #include <drm/drm_plane.h> in drm_fb_cma_helper.h.

Actually, just a forward declaration of the struct drm_plane and
drm_plane_state is what is needed, it's already done for the other
structures there. Patch is coming.

-- 
Best regards,
Marek Vasut
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-11-15 10:53 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-15  8:29 [drm-intel:topic/drm-misc 23/26] include/drm/drm_fb_cma_helper.h:45:13: warning: 'struct drm_plane_state' declared inside parameter list will not be visible outside of this definition or declaration kbuild test robot
2016-11-15  8:47 ` Daniel Vetter
2016-11-15 10:02   ` Daniel Vetter
2016-11-15 10:53     ` Marek Vasut

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).