[PATCH] drm/bridge: tc358767: don't warn if display side ASSR enable fails

[PATCH] drm/bridge: tc358767: don't warn if display side ASSR enable fails

[Lucas Stach]

ASSR is an optional feature, so it's a valid operating condition for
the display to reject ASSR enable. Demote the warning to the debug
level.

Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
---
 drivers/gpu/drm/bridge/tc358767.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/bridge/tc358767.c b/drivers/gpu/drm/bridge/tc358767.c
index 44d476ea6d2e..a7872400eed8 100644
--- a/drivers/gpu/drm/bridge/tc358767.c
+++ b/drivers/gpu/drm/bridge/tc358767.c
@@ -908,7 +908,7 @@ static int tc_main_link_setup(struct tc_data *tc)
 			goto err_dpcd_read;
 
 		if (tmp[0] != tc->assr) {
-			dev_warn(dev, "Failed to switch display ASSR to %d, falling back to unscrambled mode\n",
+			dev_dbg(dev, "Failed to switch display ASSR to %d, falling back to unscrambled mode\n",
 				 tc->assr);
 			/* trying with disabled scrambler */
 			tc->link.scrambler_dis = 1;
-- 
2.10.2

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] drm/bridge: tc358767: don't warn if display side ASSR enable fails

[Archit Taneja]

On 11/30/2016 05:18 PM, Lucas Stach wrote:
> ASSR is an optional feature, so it's a valid operating condition for
> the display to reject ASSR enable. Demote the warning to the debug
> level.

Lgtm. Will pull it if Philipp or Andrey don't have any comments on it.

Thanks,
Archit

>
> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> ---
>  drivers/gpu/drm/bridge/tc358767.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/bridge/tc358767.c b/drivers/gpu/drm/bridge/tc358767.c
> index 44d476ea6d2e..a7872400eed8 100644
> --- a/drivers/gpu/drm/bridge/tc358767.c
> +++ b/drivers/gpu/drm/bridge/tc358767.c
> @@ -908,7 +908,7 @@ static int tc_main_link_setup(struct tc_data *tc)
>  			goto err_dpcd_read;
>
>  		if (tmp[0] != tc->assr) {
> -			dev_warn(dev, "Failed to switch display ASSR to %d, falling back to unscrambled mode\n",
> +			dev_dbg(dev, "Failed to switch display ASSR to %d, falling back to unscrambled mode\n",
>  				 tc->assr);
>  			/* trying with disabled scrambler */
>  			tc->link.scrambler_dis = 1;
>

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] drm/bridge: tc358767: don't warn if display side ASSR enable fails

[Philipp Zabel]

Am Donnerstag, den 01.12.2016, 09:56 +0530 schrieb Archit Taneja:
> 
> On 11/30/2016 05:18 PM, Lucas Stach wrote:
> > ASSR is an optional feature, so it's a valid operating condition for
> > the display to reject ASSR enable. Demote the warning to the debug
> > level.
> 
> Lgtm. Will pull it if Philipp or Andrey don't have any comments on it.

No objections, this message is not helpful to a normal user.

Acked-by: Philipp Zabel <p.zabel@pengutronix.de>

regards
Philipp

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] drm/bridge: tc358767: don't warn if display side ASSR enable fails

[Andrey Gusakov]

Hi.

I'm fine with that change.

Acked-by:Andrey Gusakov <andrey.gusakov@cogentembedded.com>

On Thu, Dec 1, 2016 at 10:58 AM, Philipp Zabel <p.zabel@pengutronix.de> wrote:
> Am Donnerstag, den 01.12.2016, 09:56 +0530 schrieb Archit Taneja:
>>
>> On 11/30/2016 05:18 PM, Lucas Stach wrote:
>> > ASSR is an optional feature, so it's a valid operating condition for
>> > the display to reject ASSR enable. Demote the warning to the debug
>> > level.
>>
>> Lgtm. Will pull it if Philipp or Andrey don't have any comments on it.
>
> No objections, this message is not helpful to a normal user.
>
> Acked-by: Philipp Zabel <p.zabel@pengutronix.de>
>
> regards
> Philipp
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel