From: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
To: Atul Raj <atul.r@samsung.com>
Cc: "alcooperx@gmail.com" <alcooperx@gmail.com>,
"mathias.nyman@linux.intel.com" <mathias.nyman@linux.intel.com>,
Pankaj Singh <pankaj.s4@samsung.com>,
Viresh Kumar <viresh.kumar@linaro.org>,
"oneukum@suse.com" <oneukum@suse.com>,
"atulraj.nith@gmail.com" <atulraj.nith@gmail.com>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"stern@rowland.harvard.edu" <stern@rowland.harvard.edu>,
"hansy@nvidia.com" <hansy@nvidia.com>,
"baolu.lu@linux.intel.com" <baolu.lu@linux.intel.com>
Subject: Re: [PATCH] usb:hub: readibility and consistency in coding style
Date: Wed, 30 Nov 2016 13:02:32 +0100 [thread overview]
Message-ID: <20161130120232.GA8761@kroah.com> (raw)
In-Reply-To: <20161130115139epcms5p3fb0520cf6cabcf69e470be63463a46d1@epcms5p3>
On Wed, Nov 30, 2016 at 11:51:39AM +0000, Atul Raj wrote:
> It is suggested to keep braces if there is a comment in if case as
> comment also takes a line.
> ---
> drivers/usb/core/hub.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Ok, this is getting to be a joke.
Take a few days off, relax, then try to send a patch that works to
yourself first, and run it through scripts/checkpatch.pl to verify that
it really is correct. Hint, this one isn't at all.
Then, maybe you should start doing some work on drivers/staging/ first,
which is where new developers should start out to work out all of these
issues so you don't bother the other developers who are working on
adding new features and fixing bugs.
Also, why are you including a ton of people who have nothing to do with
usb patches on this one?
good luck,
greg k-h
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2016-11-30 12:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20161130063238epcms5p5b82d469df3d562bdfb1b6ca53ea1e226@epcms5p5>
[not found] ` <20161130063238epcms5p5b82d469df3d562bdfb1b6ca53ea1e226@epcms5p5>
2016-11-30 11:40 ` RE: [PATCH v2] usb: core:hub.c: do not print error log on -enomem Atul Raj
2016-11-30 11:55 ` gregkh
2016-11-30 11:51 ` [PATCH] usb:hub: readibility and consistency in coding style Atul Raj
2016-11-30 12:02 ` gregkh [this message]
2016-11-30 12:35 ` Atul Raj
2016-11-30 13:49 ` gregkh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161130120232.GA8761@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=alcooperx@gmail.com \
--cc=atul.r@samsung.com \
--cc=atulraj.nith@gmail.com \
--cc=baolu.lu@linux.intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=hansy@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathias.nyman@linux.intel.com \
--cc=oneukum@suse.com \
--cc=pankaj.s4@samsung.com \
--cc=stern@rowland.harvard.edu \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).