From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [Intel-gfx] [PATCH 24/37] drm/i915: Eliminate the ugly 'fb?:' constructs from the ilk/skl wm code Date: Wed, 30 Nov 2016 17:59:30 +0200 Message-ID: <20161130155930.GK31595@intel.com> References: <1479498793-31021-1-git-send-email-ville.syrjala@linux.intel.com> <1479498793-31021-25-git-send-email-ville.syrjala@linux.intel.com> <20161130155133.44iy275zfxvta34k@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20161130155133.44iy275zfxvta34k@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Daniel Vetter Cc: intel-gfx@lists.freedesktop.org, Laurent Pinchart , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCBOb3YgMzAsIDIwMTYgYXQgMDQ6NTE6MzNQTSArMDEwMCwgRGFuaWVsIFZldHRlciB3 cm90ZToKPiBPbiBGcmksIE5vdiAxOCwgMjAxNiBhdCAwOTo1MzowMFBNICswMjAwLCB2aWxsZS5z eXJqYWxhQGxpbnV4LmludGVsLmNvbSB3cm90ZToKPiA+IEZyb206IFZpbGxlIFN5cmrDpGzDpCA8 dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4gPiAKPiA+IERvbid0IGFjY2VzcyBwbGFu ZV9zdGF0ZS0+ZmIgdW50aWwgd2Uga25vdyB0aGUgcGxhbmUgdG8gYmUgdmlzaWJsZS4KPiA+IEl0 IGl0J3MgdmlzaWJsZSwgaXQgd2lsbCBoYXZlIGFuIGZiLCBhbmQgdGh1cyB3ZSBkb24ndCBoYXZl IHRvCj4gPiBjb25zaWRlciB0aGUgTlVMTCBmYiBjYXNlLiBNYWtlcyB0aGUgY29kZSBsb29rIG5p Y2VyLgo+ID4gCj4gPiBDYzogaW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+ID4gU2ln bmVkLW9mZi1ieTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNv bT4KPiA+IC0tLQo+ID4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3BtLmMgfCAyMyArKysr KysrKysrKysrKystLS0tLS0tLQo+ID4gIDEgZmlsZSBjaGFuZ2VkLCAxNSBpbnNlcnRpb25zKCsp LCA4IGRlbGV0aW9ucygtKQo+ID4gCj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaW50ZWxfcG0uYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3BtLmMKPiA+IGluZGV4 IGJiYjFlYWYxZTZkYi4uOGJhNzQxMzg3MmRkIDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaW50ZWxfcG0uYwo+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf cG0uYwo+ID4gQEAgLTE3ODEsMTMgKzE3ODEsMTQgQEAgc3RhdGljIHVpbnQzMl90IGlsa19jb21w dXRlX3ByaV93bShjb25zdCBzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqY3N0YXRlLAo+ID4gIAkJ CQkgICB1aW50MzJfdCBtZW1fdmFsdWUsCj4gPiAgCQkJCSAgIGJvb2wgaXNfbHApCj4gPiAgewo+ ID4gLQlpbnQgY3BwID0gcHN0YXRlLT5iYXNlLmZiID8KPiA+IC0JCWRybV9mb3JtYXRfcGxhbmVf Y3BwKHBzdGF0ZS0+YmFzZS5mYi0+cGl4ZWxfZm9ybWF0LCAwKSA6IDA7Cj4gPiAgCXVpbnQzMl90 IG1ldGhvZDEsIG1ldGhvZDI7Cj4gPiArCWludCBjcHA7Cj4gPiAgCj4gPiAgCWlmICghY3N0YXRl LT5iYXNlLmFjdGl2ZSB8fCAhcHN0YXRlLT5iYXNlLnZpc2libGUpCj4gPiAgCQlyZXR1cm4gMDsK PiAKPiBXaHkgZG8gd2Ugc3RpbGwgbG9vayBmb3IgY3J0Y19zdGF0ZS0+YWN0aXZlIGhlcmU/IFNv dW5kcyBsaWtlIGEgYnVnIGluCj4gcHJvcGVyIHZhbGlkYXRpbmcgb3VyIHdtIG5lZWRzLgoKWWVh aCwgdW5mb3J0dW5hdGVseSB0aGF0IHRoaW5nIGlzIHN0aWxsIGJyb2tlbiBhbGwgb3ZlciA6KCBU aGVyZSBhcmUKYnJva2VuIGFzc3VtcHRpb25zIGFib3V0IHRoaXMgaGlnaGVyIHVwIGFzIHdlbGws IHNvIGZpeGluZyB0aGlzIHdpbGwKaW52b2x2ZSBhY3R1YWwgd29yayBJIGZlYXIuCgo+IEFud2F5 LCBjaGFuZ2UgaXRzZWxmIGxvb2tzIGdvb2QuCj4gCj4gUmV2aWV3ZWQtYnk6IERhbmllbCBWZXR0 ZXIgPGRhbmllbC52ZXR0ZXJAZmZ3bGwuY2g+Cj4gCj4gPiAgCj4gPiArCWNwcCA9IGRybV9mb3Jt YXRfcGxhbmVfY3BwKHBzdGF0ZS0+YmFzZS5mYi0+cGl4ZWxfZm9ybWF0LCAwKTsKPiA+ICsKPiA+ ICAJbWV0aG9kMSA9IGlsa193bV9tZXRob2QxKGlsa19waXBlX3BpeGVsX3JhdGUoY3N0YXRlKSwg Y3BwLCBtZW1fdmFsdWUpOwo+ID4gIAo+ID4gIAlpZiAoIWlzX2xwKQo+ID4gQEAgLTE4MDksMTMg KzE4MTAsMTQgQEAgc3RhdGljIHVpbnQzMl90IGlsa19jb21wdXRlX3Nwcl93bShjb25zdCBzdHJ1 Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqY3N0YXRlLAo+ID4gIAkJCQkgICBjb25zdCBzdHJ1Y3QgaW50 ZWxfcGxhbmVfc3RhdGUgKnBzdGF0ZSwKPiA+ICAJCQkJICAgdWludDMyX3QgbWVtX3ZhbHVlKQo+ ID4gIHsKPiA+IC0JaW50IGNwcCA9IHBzdGF0ZS0+YmFzZS5mYiA/Cj4gPiAtCQlkcm1fZm9ybWF0 X3BsYW5lX2NwcChwc3RhdGUtPmJhc2UuZmItPnBpeGVsX2Zvcm1hdCwgMCkgOiAwOwo+ID4gIAl1 aW50MzJfdCBtZXRob2QxLCBtZXRob2QyOwo+ID4gKwlpbnQgY3BwOwo+ID4gIAo+ID4gIAlpZiAo IWNzdGF0ZS0+YmFzZS5hY3RpdmUgfHwgIXBzdGF0ZS0+YmFzZS52aXNpYmxlKQo+ID4gIAkJcmV0 dXJuIDA7Cj4gPiAgCj4gPiArCWNwcCA9IGRybV9mb3JtYXRfcGxhbmVfY3BwKHBzdGF0ZS0+YmFz ZS5mYi0+cGl4ZWxfZm9ybWF0LCAwKTsKPiA+ICsKPiA+ICAJbWV0aG9kMSA9IGlsa193bV9tZXRo b2QxKGlsa19waXBlX3BpeGVsX3JhdGUoY3N0YXRlKSwgY3BwLCBtZW1fdmFsdWUpOwo+ID4gIAlt ZXRob2QyID0gaWxrX3dtX21ldGhvZDIoaWxrX3BpcGVfcGl4ZWxfcmF0ZShjc3RhdGUpLAo+ID4g IAkJCQkgY3N0YXRlLT5iYXNlLmFkanVzdGVkX21vZGUuY3J0Y19odG90YWwsCj4gPiBAQCAtMTg1 MywxMiArMTg1NSwxMyBAQCBzdGF0aWMgdWludDMyX3QgaWxrX2NvbXB1dGVfZmJjX3dtKGNvbnN0 IHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpjc3RhdGUsCj4gPiAgCQkJCSAgIGNvbnN0IHN0cnVj dCBpbnRlbF9wbGFuZV9zdGF0ZSAqcHN0YXRlLAo+ID4gIAkJCQkgICB1aW50MzJfdCBwcmlfdmFs KQo+ID4gIHsKPiA+IC0JaW50IGNwcCA9IHBzdGF0ZS0+YmFzZS5mYiA/Cj4gPiAtCQlkcm1fZm9y bWF0X3BsYW5lX2NwcChwc3RhdGUtPmJhc2UuZmItPnBpeGVsX2Zvcm1hdCwgMCkgOiAwOwo+ID4g KwlpbnQgY3BwOwo+ID4gIAo+ID4gIAlpZiAoIWNzdGF0ZS0+YmFzZS5hY3RpdmUgfHwgIXBzdGF0 ZS0+YmFzZS52aXNpYmxlKQo+ID4gIAkJcmV0dXJuIDA7Cj4gPiAgCj4gPiArCWNwcCA9IGRybV9m b3JtYXRfcGxhbmVfY3BwKHBzdGF0ZS0+YmFzZS5mYi0+cGl4ZWxfZm9ybWF0LCAwKTsKPiA+ICsK PiA+ICAJcmV0dXJuIGlsa193bV9mYmMocHJpX3ZhbCwgZHJtX3JlY3Rfd2lkdGgoJnBzdGF0ZS0+ YmFzZS5kc3QpLCBjcHApOwo+ID4gIH0KPiA+ICAKPiA+IEBAIC0zMjI5LDEzICszMjMyLDE3IEBA IHNrbF9wbGFuZV9yZWxhdGl2ZV9kYXRhX3JhdGUoY29uc3Qgc3RydWN0IGludGVsX2NydGNfc3Rh dGUgKmNzdGF0ZSwKPiA+ICAJCQkgICAgIGludCB5KQo+ID4gIHsKPiA+ICAJc3RydWN0IGludGVs X3BsYW5lX3N0YXRlICppbnRlbF9wc3RhdGUgPSB0b19pbnRlbF9wbGFuZV9zdGF0ZShwc3RhdGUp Owo+ID4gLQlzdHJ1Y3QgZHJtX2ZyYW1lYnVmZmVyICpmYiA9IHBzdGF0ZS0+ZmI7Cj4gPiAgCXVp bnQzMl90IGRvd25fc2NhbGVfYW1vdW50LCBkYXRhX3JhdGU7Cj4gPiAgCXVpbnQzMl90IHdpZHRo ID0gMCwgaGVpZ2h0ID0gMDsKPiA+IC0JdW5zaWduZWQgZm9ybWF0ID0gZmIgPyBmYi0+cGl4ZWxf Zm9ybWF0IDogRFJNX0ZPUk1BVF9YUkdCODg4ODsKPiA+ICsJc3RydWN0IGRybV9mcmFtZWJ1ZmZl ciAqZmI7Cj4gPiArCXUzMiBmb3JtYXQ7Cj4gPiAgCj4gPiAgCWlmICghaW50ZWxfcHN0YXRlLT5i YXNlLnZpc2libGUpCj4gPiAgCQlyZXR1cm4gMDsKPiA+ICsKPiA+ICsJZmIgPSBwc3RhdGUtPmZi Owo+ID4gKwlmb3JtYXQgPSBmYi0+cGl4ZWxfZm9ybWF0Owo+ID4gKwo+ID4gIAlpZiAocHN0YXRl LT5wbGFuZS0+dHlwZSA9PSBEUk1fUExBTkVfVFlQRV9DVVJTT1IpCj4gPiAgCQlyZXR1cm4gMDsK PiA+ICAJaWYgKHkgJiYgZm9ybWF0ICE9IERSTV9GT1JNQVRfTlYxMikKPiA+IC0tIAo+ID4gMi43 LjQKPiA+IAo+ID4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KPiA+IEludGVsLWdmeCBtYWlsaW5nIGxpc3QKPiA+IEludGVsLWdmeEBsaXN0cy5mcmVlZGVz a3RvcC5vcmcKPiA+IGh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGlu Zm8vaW50ZWwtZ2Z4Cj4gCj4gLS0gCj4gRGFuaWVsIFZldHRlcgo+IFNvZnR3YXJlIEVuZ2luZWVy LCBJbnRlbCBDb3Jwb3JhdGlvbgo+IGh0dHA6Ly9ibG9nLmZmd2xsLmNoCgotLSAKVmlsbGUgU3ly asOkbMOkCkludGVsIE9UQwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3Rv cC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmkt ZGV2ZWwK