From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: Jose Abreu <joabreu@synopsys.com>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH v2 2/3] drm/edid: Implement SCDC support detection
Date: Mon, 5 Dec 2016 15:35:32 +0200 [thread overview]
Message-ID: <20161205133532.GE31595@intel.com> (raw)
In-Reply-To: <20161205111146.GC19891@ulmo.ba.sec>
On Mon, Dec 05, 2016 at 12:11:46PM +0100, Thierry Reding wrote:
> On Mon, Dec 05, 2016 at 09:16:27AM +0100, Daniel Vetter wrote:
> > On Mon, Dec 05, 2016 at 08:57:43AM +0100, Thierry Reding wrote:
> > > On Sat, Dec 03, 2016 at 04:35:24AM +0000, Sharma, Shashank wrote:
> > > > Hi Thierry,
> > > >
> > > > If you can please have a look on this patch, I had written one to parse HF-VSDB, which was covering SCDC detection too.
> > > > https://patchwork.kernel.org/patch/9452259/
> > >
> > > I think there had been pushback before about caching capabilities from
> > > EDID, so from that point of view my patch is more inline with existing
> > > EDID parsing API.
> >
> > Hm, where was that pushback? We do have a bit a mess between explicitly
> > parsing stuff (e.g. eld) and stuffing parsed data into drm_display_info.
>
> You did object to a very similar patch some time ago that did a similar
> thing for DPCD stuff. And also Villa had commented on an earlier patch
> from Jose about concerns of bloating core structures:
>
> https://patchwork.freedesktop.org/patch/104806/
Yeah, the same old "adding stuff all over without actual users" story.
It's near impossible to judge whether the added things are actually
useful (or if the implementation is the best) without seeing how it's
going to be used.
--
Ville Syrjälä
Intel OTC
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2016-12-05 13:35 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-02 19:24 [PATCH v2 1/3] drm: Add SCDC helpers Thierry Reding
2016-12-02 19:24 ` [PATCH v2 2/3] drm/edid: Implement SCDC support detection Thierry Reding
2016-12-03 4:35 ` Sharma, Shashank
2016-12-05 7:57 ` Thierry Reding
2016-12-05 8:16 ` Daniel Vetter
2016-12-05 11:11 ` Thierry Reding
2016-12-05 13:35 ` Ville Syrjälä [this message]
2016-12-05 16:21 ` Daniel Vetter
2016-12-05 17:11 ` Thierry Reding
2016-12-06 8:19 ` Daniel Vetter
2016-12-07 19:23 ` Jani Nikula
2016-12-19 8:15 ` Sharma, Shashank
2016-12-02 19:24 ` [PATCH v2 3/3] drm/edid: Implement SCDC Read Request capability detection Thierry Reding
2016-12-05 11:06 ` Jose Abreu
2016-12-05 11:14 ` Thierry Reding
2016-12-05 14:19 ` Jose Abreu
2016-12-05 16:37 ` Thierry Reding
2016-12-06 8:23 ` Daniel Vetter
2016-12-06 10:32 ` Jose Abreu
2016-12-05 10:12 ` [PATCH v2 1/3] drm: Add SCDC helpers Jose Abreu
2016-12-05 11:16 ` Thierry Reding
2016-12-05 13:31 ` Ville Syrjälä
2016-12-05 14:10 ` Jose Abreu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161205133532.GE31595@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=joabreu@synopsys.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).