From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Jani Nikula <jani.nikula@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org, "Syrjala,
Ville" <ville.syrjala@intel.com>,
Vidya Srinivas <vidya.srinivas@intel.com>,
dri-devel@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH] drm: Fix for invalid pruning of modes in dual display cases
Date: Tue, 13 Dec 2016 17:46:53 +0200 [thread overview]
Message-ID: <20161213154653.GL31595@intel.com> (raw)
In-Reply-To: <87shprswz2.fsf@intel.com>
On Tue, Dec 13, 2016 at 04:52:01PM +0200, Jani Nikula wrote:
> On Tue, 13 Dec 2016, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> > On Tue, Dec 13, 2016 at 03:46:54PM +0530, Vidya Srinivas wrote:
> >> Currently in dual display connected boot scenarios, minimum of the resolutions
> >> is taken for fb width and height as reference. Based on this resolution, other
> >> modes are pruned.
> >>
> >> Example Scenario: If DSI mode is 2560x1440 and HDMI is 1920x1080, during the probing
> >> the fb width and height is set to max 1920x1080 and the DSI mode gets pruned as it is
> >> more than the reference. As a result, there is no DSI display.
> >> Patch fixes this issue by taking the max of the resolutions and creating the fb
> >> based on the same.
> >
> > On the other hand, the viewable content is defined by the smaller mode.
> > If that is the only output visible at panic time, you don't want that
> > information lost due to it being invisible.
> >
> > This is only used for fbcon, which has to be the lowest common
> > denominator. Any actual application can set their own modes and fb.
>
> Do we fail to take over non-native modes with scaling on DSI then?
> Ville?
I believe we are taking the panel fitter into account when we
reconstruct the BIOS fb. So in case the BIOS is upscaling we'll
come up with some less than screen size framebuffer. The fb
helper will want to use the native mode of the panel however,
so at some point we'll drop the BIOS fb (as it's too small)
and allocate a new one.
--
Ville Syrjälä
Intel OTC
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2016-12-13 15:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-13 10:16 [PATCH] drm: Fix for invalid pruning of modes in dual display cases Vidya Srinivas
2016-12-13 10:28 ` [Intel-gfx] " Jani Nikula
2016-12-13 10:46 ` Chris Wilson
2016-12-13 14:52 ` [Intel-gfx] " Jani Nikula
2016-12-13 15:46 ` Ville Syrjälä [this message]
2017-01-16 10:13 ` Srinivas, Vidya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161213154653.GL31595@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=vidya.srinivas@intel.com \
--cc=ville.syrjala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).