From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH v2 3/4] drm/atomic: Add macros to access existing old/new state Date: Wed, 28 Dec 2016 15:25:10 +0100 Message-ID: <20161228142510.GP347@dvetter-linux.ger.corp.intel.com> References: <1479304688-24010-1-git-send-email-maarten.lankhorst@linux.intel.com> <1479304688-24010-4-git-send-email-maarten.lankhorst@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-x242.google.com (mail-wm0-x242.google.com [IPv6:2a00:1450:400c:c09::242]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4A53689F8B for ; Wed, 28 Dec 2016 14:25:16 +0000 (UTC) Received: by mail-wm0-x242.google.com with SMTP id c85so23979550wmi.1 for ; Wed, 28 Dec 2016 06:25:16 -0800 (PST) Content-Disposition: inline In-Reply-To: <1479304688-24010-4-git-send-email-maarten.lankhorst@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Maarten Lankhorst Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCBOb3YgMTYsIDIwMTYgYXQgMDI6NTg6MDdQTSArMDEwMCwgTWFhcnRlbiBMYW5raG9y c3Qgd3JvdGU6Cj4gRHVyaW5nIGF0b21pYyBjaGVjay9jb21taXQsIHRoZXNlIG1hY3JvcyBzaG91 bGQgYmUgdXNlZCBpbiBwbGFjZSBvZgo+IGdldF9leGlzdGluZ19zdGF0ZS4KPiAKPiBXZSBhbHNv IGJhbiB0aGUgdXNlIG9mIGdldF94eF9zdGF0ZSBhZnRlciBhdG9taWMgY2hlY2ssIGJlY2F1c2Ug YXQgdGhhdAo+IHBvaW50IG5vIG5ldyBsb2NrcyBzaG91bGQgYmUgdGFrZW4gYW5kIGdldF9uZXcv b2xkX3N0YXRlIHNob3VsZCBiZSB1c2VkCj4gaW5zdGVhZC4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBN YWFydGVuIExhbmtob3JzdCA8bWFhcnRlbi5sYW5raG9yc3RAbGludXguaW50ZWwuY29tPgoKU28g b25lIHNsaWdodGx5IGFubm95aW5nIHRoaW5nIHdpdGggdGhlIG5ldy9vbGQgc3BsaXQgaXMgdGhh dCBjb25zdC1uZXNzCm9mIHRoZXNlIGNoYW5nZXMuIEluIGF0b21pY19jaGVjayB0aGUgb2xkIHN0 YXRlIHNob3VsZCBiZSBjb25zdCwgaW4KYXRvbWljX2NvbW1pdCB0aGUgbmV3IHN0YXRlLiBCeSBn b2luZyB0byB0aGUgbmV3L29sZCBzcGxpdCB3ZSdyZSBsb3NpbmcKdGhhdCBzYWZlZ3VhcmQuIE90 b2ggd2UgaGF2ZSBsb3RzIGFuZCBsb3RzIG9mIGV4Y2VwdGlvbnMgdG8gdGhhdCBydWxlIC4uLgpu b3Qgc3VyZSBob3cgbXVjaCBhaW1pbmcgZm9yIGNvbnN0IGNvcnJlY3RuZXNzIGlzIHdvcnRoIGl0 LgotRGFuaWVsCgo+IC0tLQo+ICBpbmNsdWRlL2RybS9kcm1fYXRvbWljLmggfCAxMDAgKysrKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysKPiAgMSBmaWxlIGNoYW5n ZWQsIDEwMCBpbnNlcnRpb25zKCspCj4gCj4gZGlmZiAtLWdpdCBhL2luY2x1ZGUvZHJtL2RybV9h dG9taWMuaCBiL2luY2x1ZGUvZHJtL2RybV9hdG9taWMuaAo+IGluZGV4IDQ2MjQwOGEyZDFiOC4u N2JlMTc4MjY0NzMyIDEwMDY0NAo+IC0tLSBhL2luY2x1ZGUvZHJtL2RybV9hdG9taWMuaAo+ICsr KyBiL2luY2x1ZGUvZHJtL2RybV9hdG9taWMuaAo+IEBAIC0yNjQsNiArMjY0LDM2IEBAIGRybV9h dG9taWNfZ2V0X2V4aXN0aW5nX2NydGNfc3RhdGUoc3RydWN0IGRybV9hdG9taWNfc3RhdGUgKnN0 YXRlLAo+ICB9Cj4gIAo+ICAvKioKPiArICogZHJtX2F0b21pY19nZXRfb2xkX2NydGNfc3RhdGUg LSBnZXQgb2xkIGNydGMgc3RhdGUsIGlmIGl0IGV4aXN0cwo+ICsgKiBAc3RhdGU6IGdsb2JhbCBh dG9taWMgc3RhdGUgb2JqZWN0Cj4gKyAqIEBjcnRjOiBjcnRjIHRvIGdyYWIKPiArICoKPiArICog VGhpcyBmdW5jdGlvbiByZXR1cm5zIHRoZSBvbGQgY3J0YyBzdGF0ZSBmb3IgdGhlIGdpdmVuIGNy dGMsIG9yCj4gKyAqIE5VTEwgaWYgdGhlIGNydGMgaXMgbm90IHBhcnQgb2YgdGhlIGdsb2JhbCBh dG9taWMgc3RhdGUuCj4gKyAqLwo+ICtzdGF0aWMgaW5saW5lIHN0cnVjdCBkcm1fY3J0Y19zdGF0 ZSAqCj4gK2RybV9hdG9taWNfZ2V0X29sZF9jcnRjX3N0YXRlKHN0cnVjdCBkcm1fYXRvbWljX3N0 YXRlICpzdGF0ZSwKPiArCQkJICAgICAgc3RydWN0IGRybV9jcnRjICpjcnRjKQo+ICt7Cj4gKwly ZXR1cm4gc3RhdGUtPmNydGNzW2RybV9jcnRjX2luZGV4KGNydGMpXS5vbGRfc3RhdGU7Cj4gK30K PiArCj4gKy8qKgo+ICsgKiBkcm1fYXRvbWljX2dldF9uZXdfY3J0Y19zdGF0ZSAtIGdldCBuZXcg Y3J0YyBzdGF0ZSwgaWYgaXQgZXhpc3RzCj4gKyAqIEBzdGF0ZTogZ2xvYmFsIGF0b21pYyBzdGF0 ZSBvYmplY3QKPiArICogQGNydGM6IGNydGMgdG8gZ3JhYgo+ICsgKgo+ICsgKiBUaGlzIGZ1bmN0 aW9uIHJldHVybnMgdGhlIG5ldyBjcnRjIHN0YXRlIGZvciB0aGUgZ2l2ZW4gY3J0Yywgb3IKPiAr ICogTlVMTCBpZiB0aGUgY3J0YyBpcyBub3QgcGFydCBvZiB0aGUgZ2xvYmFsIGF0b21pYyBzdGF0 ZS4KPiArICovCj4gK3N0YXRpYyBpbmxpbmUgc3RydWN0IGRybV9jcnRjX3N0YXRlICoKPiArZHJt X2F0b21pY19nZXRfbmV3X2NydGNfc3RhdGUoc3RydWN0IGRybV9hdG9taWNfc3RhdGUgKnN0YXRl LAo+ICsJCQkgICAgICBzdHJ1Y3QgZHJtX2NydGMgKmNydGMpCj4gK3sKPiArCXJldHVybiBzdGF0 ZS0+Y3J0Y3NbZHJtX2NydGNfaW5kZXgoY3J0YyldLm5ld19zdGF0ZTsKPiArfQo+ICsKPiArLyoq Cj4gICAqIGRybV9hdG9taWNfZ2V0X2V4aXN0aW5nX3BsYW5lX3N0YXRlIC0gZ2V0IHBsYW5lIHN0 YXRlLCBpZiBpdCBleGlzdHMKPiAgICogQHN0YXRlOiBnbG9iYWwgYXRvbWljIHN0YXRlIG9iamVj dAo+ICAgKiBAcGxhbmU6IHBsYW5lIHRvIGdyYWIKPiBAQCAtMjc5LDYgKzMwOSwzNiBAQCBkcm1f YXRvbWljX2dldF9leGlzdGluZ19wbGFuZV9zdGF0ZShzdHJ1Y3QgZHJtX2F0b21pY19zdGF0ZSAq c3RhdGUsCj4gIH0KPiAgCj4gIC8qKgo+ICsgKiBkcm1fYXRvbWljX2dldF9vbGRfcGxhbmVfc3Rh dGUgLSBnZXQgcGxhbmUgc3RhdGUsIGlmIGl0IGV4aXN0cwo+ICsgKiBAc3RhdGU6IGdsb2JhbCBh dG9taWMgc3RhdGUgb2JqZWN0Cj4gKyAqIEBwbGFuZTogcGxhbmUgdG8gZ3JhYgo+ICsgKgo+ICsg KiBUaGlzIGZ1bmN0aW9uIHJldHVybnMgdGhlIG9sZCBwbGFuZSBzdGF0ZSBmb3IgdGhlIGdpdmVu IHBsYW5lLCBvcgo+ICsgKiBOVUxMIGlmIHRoZSBwbGFuZSBpcyBub3QgcGFydCBvZiB0aGUgZ2xv YmFsIGF0b21pYyBzdGF0ZS4KPiArICovCj4gK3N0YXRpYyBpbmxpbmUgc3RydWN0IGRybV9wbGFu ZV9zdGF0ZSAqCj4gK2RybV9hdG9taWNfZ2V0X29sZF9wbGFuZV9zdGF0ZShzdHJ1Y3QgZHJtX2F0 b21pY19zdGF0ZSAqc3RhdGUsCj4gKwkJCSAgICAgICBzdHJ1Y3QgZHJtX3BsYW5lICpwbGFuZSkK PiArewo+ICsJcmV0dXJuIHN0YXRlLT5wbGFuZXNbZHJtX3BsYW5lX2luZGV4KHBsYW5lKV0ub2xk X3N0YXRlOwo+ICt9Cj4gKwo+ICsvKioKPiArICogZHJtX2F0b21pY19nZXRfbmV3X3BsYW5lX3N0 YXRlIC0gZ2V0IHBsYW5lIHN0YXRlLCBpZiBpdCBleGlzdHMKPiArICogQHN0YXRlOiBnbG9iYWwg YXRvbWljIHN0YXRlIG9iamVjdAo+ICsgKiBAcGxhbmU6IHBsYW5lIHRvIGdyYWIKPiArICoKPiAr ICogVGhpcyBmdW5jdGlvbiByZXR1cm5zIHRoZSBuZXcgcGxhbmUgc3RhdGUgZm9yIHRoZSBnaXZl biBwbGFuZSwgb3IKPiArICogTlVMTCBpZiB0aGUgcGxhbmUgaXMgbm90IHBhcnQgb2YgdGhlIGds b2JhbCBhdG9taWMgc3RhdGUuCj4gKyAqLwo+ICtzdGF0aWMgaW5saW5lIHN0cnVjdCBkcm1fcGxh bmVfc3RhdGUgKgo+ICtkcm1fYXRvbWljX2dldF9uZXdfcGxhbmVfc3RhdGUoc3RydWN0IGRybV9h dG9taWNfc3RhdGUgKnN0YXRlLAo+ICsJCQkgICAgICAgc3RydWN0IGRybV9wbGFuZSAqcGxhbmUp Cj4gK3sKPiArCXJldHVybiBzdGF0ZS0+cGxhbmVzW2RybV9wbGFuZV9pbmRleChwbGFuZSldLm5l d19zdGF0ZTsKPiArfQo+ICsKPiArLyoqCj4gICAqIGRybV9hdG9taWNfZ2V0X2V4aXN0aW5nX2Nv bm5lY3Rvcl9zdGF0ZSAtIGdldCBjb25uZWN0b3Igc3RhdGUsIGlmIGl0IGV4aXN0cwo+ICAgKiBA c3RhdGU6IGdsb2JhbCBhdG9taWMgc3RhdGUgb2JqZWN0Cj4gICAqIEBjb25uZWN0b3I6IGNvbm5l Y3RvciB0byBncmFiCj4gQEAgLTI5OSw2ICszNTksNDYgQEAgZHJtX2F0b21pY19nZXRfZXhpc3Rp bmdfY29ubmVjdG9yX3N0YXRlKHN0cnVjdCBkcm1fYXRvbWljX3N0YXRlICpzdGF0ZSwKPiAgfQo+ ICAKPiAgLyoqCj4gKyAqIGRybV9hdG9taWNfZ2V0X29sZF9jb25uZWN0b3Jfc3RhdGUgLSBnZXQg Y29ubmVjdG9yIHN0YXRlLCBpZiBpdCBleGlzdHMKPiArICogQHN0YXRlOiBnbG9iYWwgYXRvbWlj IHN0YXRlIG9iamVjdAo+ICsgKiBAY29ubmVjdG9yOiBjb25uZWN0b3IgdG8gZ3JhYgo+ICsgKgo+ ICsgKiBUaGlzIGZ1bmN0aW9uIHJldHVybnMgdGhlIG9sZCBjb25uZWN0b3Igc3RhdGUgZm9yIHRo ZSBnaXZlbiBjb25uZWN0b3IsCj4gKyAqIG9yIE5VTEwgaWYgdGhlIGNvbm5lY3RvciBpcyBub3Qg cGFydCBvZiB0aGUgZ2xvYmFsIGF0b21pYyBzdGF0ZS4KPiArICovCj4gK3N0YXRpYyBpbmxpbmUg c3RydWN0IGRybV9jb25uZWN0b3Jfc3RhdGUgKgo+ICtkcm1fYXRvbWljX2dldF9vbGRfY29ubmVj dG9yX3N0YXRlKHN0cnVjdCBkcm1fYXRvbWljX3N0YXRlICpzdGF0ZSwKPiArCQkJCSAgIHN0cnVj dCBkcm1fY29ubmVjdG9yICpjb25uZWN0b3IpCj4gK3sKPiArCWludCBpbmRleCA9IGRybV9jb25u ZWN0b3JfaW5kZXgoY29ubmVjdG9yKTsKPiArCj4gKwlpZiAoaW5kZXggPj0gc3RhdGUtPm51bV9j b25uZWN0b3IpCj4gKwkJcmV0dXJuIE5VTEw7Cj4gKwo+ICsJcmV0dXJuIHN0YXRlLT5jb25uZWN0 b3JzW2luZGV4XS5vbGRfc3RhdGU7Cj4gK30KPiArCj4gKy8qKgo+ICsgKiBkcm1fYXRvbWljX2dl dF9uZXdfY29ubmVjdG9yX3N0YXRlIC0gZ2V0IGNvbm5lY3RvciBzdGF0ZSwgaWYgaXQgZXhpc3Rz Cj4gKyAqIEBzdGF0ZTogZ2xvYmFsIGF0b21pYyBzdGF0ZSBvYmplY3QKPiArICogQGNvbm5lY3Rv cjogY29ubmVjdG9yIHRvIGdyYWIKPiArICoKPiArICogVGhpcyBmdW5jdGlvbiByZXR1cm5zIHRo ZSBuZXcgY29ubmVjdG9yIHN0YXRlIGZvciB0aGUgZ2l2ZW4gY29ubmVjdG9yLAo+ICsgKiBvciBO VUxMIGlmIHRoZSBjb25uZWN0b3IgaXMgbm90IHBhcnQgb2YgdGhlIGdsb2JhbCBhdG9taWMgc3Rh dGUuCj4gKyAqLwo+ICtzdGF0aWMgaW5saW5lIHN0cnVjdCBkcm1fY29ubmVjdG9yX3N0YXRlICoK PiArZHJtX2F0b21pY19nZXRfbmV3X2Nvbm5lY3Rvcl9zdGF0ZShzdHJ1Y3QgZHJtX2F0b21pY19z dGF0ZSAqc3RhdGUsCj4gKwkJCQkgICBzdHJ1Y3QgZHJtX2Nvbm5lY3RvciAqY29ubmVjdG9yKQo+ ICt7Cj4gKwlpbnQgaW5kZXggPSBkcm1fY29ubmVjdG9yX2luZGV4KGNvbm5lY3Rvcik7Cj4gKwo+ ICsJaWYgKGluZGV4ID49IHN0YXRlLT5udW1fY29ubmVjdG9yKQo+ICsJCXJldHVybiBOVUxMOwo+ ICsKPiArCXJldHVybiBzdGF0ZS0+Y29ubmVjdG9yc1tpbmRleF0ubmV3X3N0YXRlOwo+ICt9Cj4g Kwo+ICsvKioKPiAgICogX19kcm1fYXRvbWljX2dldF9jdXJyZW50X3BsYW5lX3N0YXRlIC0gZ2V0 IGN1cnJlbnQgcGxhbmUgc3RhdGUKPiAgICogQHN0YXRlOiBnbG9iYWwgYXRvbWljIHN0YXRlIG9i amVjdAo+ICAgKiBAcGxhbmU6IHBsYW5lIHRvIGdyYWIKPiAtLSAKPiAyLjcuNAo+IAo+IF9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gZHJpLWRldmVsIG1h aWxpbmcgbGlzdAo+IGRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBodHRwczovL2xp c3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAoKLS0gCkRhbmll bCBWZXR0ZXIKU29mdHdhcmUgRW5naW5lZXIsIEludGVsIENvcnBvcmF0aW9uCmh0dHA6Ly9ibG9n LmZmd2xsLmNoCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpo dHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=