From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 1/2] drm: remove useless parameters from drm_pick_cmdline_mode function Date: Mon, 9 Jan 2017 11:24:57 +0100 Message-ID: <20170109102457.bv3rdec4srknq652@phenom.ffwll.local> References: <1483721084-20278-1-git-send-email-vincent.abriou@st.com> <1483721084-20278-2-git-send-email-vincent.abriou@st.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-x241.google.com (mail-wm0-x241.google.com [IPv6:2a00:1450:400c:c09::241]) by gabe.freedesktop.org (Postfix) with ESMTPS id F41F16E1CE for ; Mon, 9 Jan 2017 10:25:02 +0000 (UTC) Received: by mail-wm0-x241.google.com with SMTP id r126so662330wmr.3 for ; Mon, 09 Jan 2017 02:25:02 -0800 (PST) Content-Disposition: inline In-Reply-To: <1483721084-20278-2-git-send-email-vincent.abriou@st.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Vincent Abriou Cc: Daniel Vetter , Fabien Dessenne , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gRnJpLCBKYW4gMDYsIDIwMTcgYXQgMDU6NDQ6NDNQTSArMDEwMCwgVmluY2VudCBBYnJpb3Ug d3JvdGU6Cj4gZHJtX3BpY2tfY21kbGluZV9tb2RlIHdpZHRoIGFuZCBoZWlnaHQgcGFyYW1ldGVy cyBhcmUgdXNlbGVzcy4KPiBKdXN0IHJlbW92ZSB0aGVtLgo+IAo+IENjOiBEYW5pZWwgVmV0dGVy IDxkYW5pZWwudmV0dGVyQGludGVsLmNvbT4KPiBDYzogSmFuaSBOaWt1bGEgPGphbmkubmlrdWxh QGxpbnV4LmludGVsLmNvbT4KPiBTaWduZWQtb2ZmLWJ5OiBWaW5jZW50IEFicmlvdSA8dmluY2Vu dC5hYnJpb3VAc3QuY29tPgoKQXBwbGllZCwgdGhhbmtzIGEgbG90LiBJJ2xsIHdhaXQgZm9yIHNv bWVvbmUgZWxzZSB0byByZXZpZXcgcGF0Y2ggMiBiZWZvcmUKbWVyZ2luZyBpdC4KLURhbmllbAo+ IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vZHJtX2ZiX2hlbHBlci5jICAgIHwgNyArKystLS0tCj4g IGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2ZiZGV2LmMgfCAyICstCj4gIGluY2x1ZGUvZHJt L2RybV9mYl9oZWxwZXIuaCAgICAgICAgfCAzICstLQo+ICAzIGZpbGVzIGNoYW5nZWQsIDUgaW5z ZXJ0aW9ucygrKSwgNyBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUv ZHJtL2RybV9mYl9oZWxwZXIuYyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fZmJfaGVscGVyLmMKPiBp bmRleCBlOTM0YjU0Li43N2Q5YWM2IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9kcm1f ZmJfaGVscGVyLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2ZiX2hlbHBlci5jCj4gQEAg LTE3NDgsOCArMTc0OCw3IEBAIHN0YXRpYyBib29sIGRybV9oYXNfY21kbGluZV9tb2RlKHN0cnVj dCBkcm1fZmJfaGVscGVyX2Nvbm5lY3RvciAqZmJfY29ubmVjdG9yKQo+ICAJcmV0dXJuIGZiX2Nv bm5lY3Rvci0+Y29ubmVjdG9yLT5jbWRsaW5lX21vZGUuc3BlY2lmaWVkOwo+ICB9Cj4gIAo+IC1z dHJ1Y3QgZHJtX2Rpc3BsYXlfbW9kZSAqZHJtX3BpY2tfY21kbGluZV9tb2RlKHN0cnVjdCBkcm1f ZmJfaGVscGVyX2Nvbm5lY3RvciAqZmJfaGVscGVyX2Nvbm4sCj4gLQkJCQkJCSAgICAgIGludCB3 aWR0aCwgaW50IGhlaWdodCkKPiArc3RydWN0IGRybV9kaXNwbGF5X21vZGUgKmRybV9waWNrX2Nt ZGxpbmVfbW9kZShzdHJ1Y3QgZHJtX2ZiX2hlbHBlcl9jb25uZWN0b3IgKmZiX2hlbHBlcl9jb25u KQo+ICB7Cj4gIAlzdHJ1Y3QgZHJtX2NtZGxpbmVfbW9kZSAqY21kbGluZV9tb2RlOwo+ICAJc3Ry dWN0IGRybV9kaXNwbGF5X21vZGUgKm1vZGU7Cj4gQEAgLTE4NjcsNyArMTg2Niw3IEBAIHN0YXRp YyBib29sIGRybV90YXJnZXRfY2xvbmVkKHN0cnVjdCBkcm1fZmJfaGVscGVyICpmYl9oZWxwZXIs Cj4gIAkJaWYgKCFlbmFibGVkW2ldKQo+ICAJCQljb250aW51ZTsKPiAgCQlmYl9oZWxwZXJfY29u biA9IGZiX2hlbHBlci0+Y29ubmVjdG9yX2luZm9baV07Cj4gLQkJbW9kZXNbaV0gPSBkcm1fcGlj a19jbWRsaW5lX21vZGUoZmJfaGVscGVyX2Nvbm4sIHdpZHRoLCBoZWlnaHQpOwo+ICsJCW1vZGVz W2ldID0gZHJtX3BpY2tfY21kbGluZV9tb2RlKGZiX2hlbHBlcl9jb25uKTsKPiAgCQlpZiAoIW1v ZGVzW2ldKSB7Cj4gIAkJCWNhbl9jbG9uZSA9IGZhbHNlOwo+ICAJCQlicmVhazsKPiBAQCAtMTk4 OSw3ICsxOTg4LDcgQEAgc3RhdGljIGJvb2wgZHJtX3RhcmdldF9wcmVmZXJyZWQoc3RydWN0IGRy bV9mYl9oZWxwZXIgKmZiX2hlbHBlciwKPiAgCQkJICAgICAgZmJfaGVscGVyX2Nvbm4tPmNvbm5l Y3Rvci0+YmFzZS5pZCk7Cj4gIAo+ICAJCS8qIGdvdCBmb3IgY29tbWFuZCBsaW5lIG1vZGUgZmly c3QgKi8KPiAtCQltb2Rlc1tpXSA9IGRybV9waWNrX2NtZGxpbmVfbW9kZShmYl9oZWxwZXJfY29u biwgd2lkdGgsIGhlaWdodCk7Cj4gKwkJbW9kZXNbaV0gPSBkcm1fcGlja19jbWRsaW5lX21vZGUo ZmJfaGVscGVyX2Nvbm4pOwo+ICAJCWlmICghbW9kZXNbaV0pIHsKPiAgCQkJRFJNX0RFQlVHX0tN UygibG9va2luZyBmb3IgcHJlZmVycmVkIG1vZGUgb24gY29ubmVjdG9yICVkICVkXG4iLAo+ICAJ CQkJICAgICAgZmJfaGVscGVyX2Nvbm4tPmNvbm5lY3Rvci0+YmFzZS5pZCwgZmJfaGVscGVyX2Nv bm4tPmNvbm5lY3Rvci0+dGlsZV9ncm91cCA/IGZiX2hlbHBlcl9jb25uLT5jb25uZWN0b3ItPnRp bGVfZ3JvdXAtPmlkIDogMCk7Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2lu dGVsX2ZiZGV2LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9mYmRldi5jCj4gaW5kZXgg YmViMDg5OC4uNGIzMDJmOCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl bF9mYmRldi5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZmJkZXYuYwo+IEBA IC00NDcsNyArNDQ3LDcgQEAgc3RhdGljIGJvb2wgaW50ZWxfZmJfaW5pdGlhbF9jb25maWcoc3Ry dWN0IGRybV9mYl9oZWxwZXIgKmZiX2hlbHBlciwKPiAgCQkJICAgICAgY29ubmVjdG9yLT5uYW1l KTsKPiAgCj4gIAkJLyogZ28gZm9yIGNvbW1hbmQgbGluZSBtb2RlIGZpcnN0ICovCj4gLQkJbW9k ZXNbaV0gPSBkcm1fcGlja19jbWRsaW5lX21vZGUoZmJfY29ubiwgd2lkdGgsIGhlaWdodCk7Cj4g KwkJbW9kZXNbaV0gPSBkcm1fcGlja19jbWRsaW5lX21vZGUoZmJfY29ubik7Cj4gIAo+ICAJCS8q IHRyeSBmb3IgcHJlZmVycmVkIG5leHQgKi8KPiAgCQlpZiAoIW1vZGVzW2ldKSB7Cj4gZGlmZiAt LWdpdCBhL2luY2x1ZGUvZHJtL2RybV9mYl9oZWxwZXIuaCBiL2luY2x1ZGUvZHJtL2RybV9mYl9o ZWxwZXIuaAo+IGluZGV4IDk3NWRlZWQuLjQ4ZTA5ZTggMTAwNjQ0Cj4gLS0tIGEvaW5jbHVkZS9k cm0vZHJtX2ZiX2hlbHBlci5oCj4gKysrIGIvaW5jbHVkZS9kcm0vZHJtX2ZiX2hlbHBlci5oCj4g QEAgLTI5NSw4ICsyOTUsNyBAQCBzdHJ1Y3QgZHJtX2Rpc3BsYXlfbW9kZSAqCj4gIGRybV9oYXNf cHJlZmVycmVkX21vZGUoc3RydWN0IGRybV9mYl9oZWxwZXJfY29ubmVjdG9yICpmYl9jb25uZWN0 b3IsCj4gIAkJCWludCB3aWR0aCwgaW50IGhlaWdodCk7Cj4gIHN0cnVjdCBkcm1fZGlzcGxheV9t b2RlICoKPiAtZHJtX3BpY2tfY21kbGluZV9tb2RlKHN0cnVjdCBkcm1fZmJfaGVscGVyX2Nvbm5l Y3RvciAqZmJfaGVscGVyX2Nvbm4sCj4gLQkJICAgICAgaW50IHdpZHRoLCBpbnQgaGVpZ2h0KTsK PiArZHJtX3BpY2tfY21kbGluZV9tb2RlKHN0cnVjdCBkcm1fZmJfaGVscGVyX2Nvbm5lY3RvciAq ZmJfaGVscGVyX2Nvbm4pOwo+ICAKPiAgaW50IGRybV9mYl9oZWxwZXJfYWRkX29uZV9jb25uZWN0 b3Ioc3RydWN0IGRybV9mYl9oZWxwZXIgKmZiX2hlbHBlciwgc3RydWN0IGRybV9jb25uZWN0b3Ig KmNvbm5lY3Rvcik7Cj4gIGludCBkcm1fZmJfaGVscGVyX3JlbW92ZV9vbmVfY29ubmVjdG9yKHN0 cnVjdCBkcm1fZmJfaGVscGVyICpmYl9oZWxwZXIsCj4gLS0gCj4gMi43LjQKPiAKPiBfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+IGRyaS1kZXZlbCBtYWls aW5nIGxpc3QKPiBkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gaHR0cHM6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwKCi0tIApEYW5pZWwg VmV0dGVyClNvZnR3YXJlIEVuZ2luZWVyLCBJbnRlbCBDb3Jwb3JhdGlvbgpodHRwOi8vYmxvZy5m ZndsbC5jaApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpk cmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0 cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK