From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/probe-helpers: Drop locking from poll_enable Date: Tue, 10 Jan 2017 17:34:08 +0100 Message-ID: <20170110163408.q2b2rm2wopcljs2u@phenom.ffwll.local> References: <20170110142910.29922-1-daniel.vetter@ffwll.ch> <20170110151744.GK5700@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20170110151744.GK5700@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , Daniel Vetter , DRI Development , Intel Graphics Development , Daniel Vetter List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCBKYW4gMTAsIDIwMTcgYXQgMDM6MTc6NDRQTSArMDAwMCwgQ2hyaXMgV2lsc29uIHdy b3RlOgo+IE9uIFR1ZSwgSmFuIDEwLCAyMDE3IGF0IDAzOjI5OjEwUE0gKzAxMDAsIERhbmllbCBW ZXR0ZXIgd3JvdGU6Cj4gPiBJdCB3YXMgb25seSBuZWVkZWQgdG8gcHJvdGVjdCB0aGUgY29ubmVj dG9yX2xpc3Qgd2Fsa2luZywgc2VlCj4gPiAKPiA+IGNvbW1pdCA4YzRjY2M0YWI2ZjY0ZTg1OWQ0 ZmY4ZDdjMDJjMmVkMmU5NTZlMDdmCj4gPiBBdXRob3I6IERhbmllbCBWZXR0ZXIgPGRhbmllbC52 ZXR0ZXJAZmZ3bGwuY2g+Cj4gPiBEYXRlOiAgIFRodSBKdWwgOSAyMzo0NDoyNiAyMDE1ICswMjAw Cj4gPiAKPiA+ICAgICBkcm0vcHJvYmUtaGVscGVyOiBHcmFiIG1vZGVfY29uZmlnLm11dGV4IGlu IHBvbGxfaW5pdC9lbmFibGUKPiA+IAo+ID4gVW5mb3J0dW5hdGVseSB0aGUgY29tbWl0IG1lc3Nh Z2Ugb2YgdGhhdCBwYXRjaCBmYWlscyB0byBtZW50aW9uIHRoYXQKPiA+IHRoZSBuZXcgbG9ja2lu ZyBjaGVjayB3YXMgZm9yIHRoZSBjb25uZWN0b3JfbGlzdC4KPiA+IAo+ID4gQnV0IHRoYXQgcmVx dWlyZW1lbnQgZGlzYXBwZWFyZWQgaW4KPiA+IAo+ID4gY29tbWl0IGMzNmEzMjU0Zjc4NTdmMWFk OWJhZGJlMzU3OGNjYzkyYmU1NDFhOGUKPiA+IEF1dGhvcjogRGFuaWVsIFZldHRlciA8ZGFuaWVs LnZldHRlckBmZndsbC5jaD4KPiA+IERhdGU6ICAgVGh1IERlYyAxNSAxNjo1ODo0MyAyMDE2ICsw MTAwCj4gPiAKPiA+ICAgICBkcm06IENvbnZlcnQgYWxsIGhlbHBlcnMgdG8gZHJtX2Nvbm5lY3Rv cl9saXN0X2l0ZXIKPiA+IAo+ID4gYW5kIHNvIHdlIGNhbiBkcm9wIHRoaXMgYWdhaW4uCj4gPiAK PiA+IFRoaXMgZml4ZXMgYSBsb2NraW5nIGludmVyc2lvbiBvbiBub3V2ZWF1LCB3aGVyZSB0aGUg cnBtIGNvZGUgbmVlZHMgdG8KPiA+IHJlLWVuYWJsZS4gQnV0IGluIG90aGVyIHBsYWNlcyB0aGUg cnBtX2dldCgpIGNhbGxzIGFyZSBuZXN0ZWQgd2l0aGluCj4gPiB0aGUgYmlnIG1vZGVzZXQgbG9j a3MuCj4gPiAKPiA+IFdoaWxlIGF0IGl0LCBhbHNvIGltcHJvdmUgdGhlIGtlcm5lbGRvYyBmb3Ig dGhlc2UgdHdvIGZ1bmN0aW9ucyBhCj4gPiBub3RjaC4KPiA+IAo+ID4gQ2M6IERhdmUgQWlybGll IDxhaXJsaWVkQGdtYWlsLmNvbT4KPiA+IFNpZ25lZC1vZmYtYnk6IERhbmllbCBWZXR0ZXIgPGRh bmllbC52ZXR0ZXJAaW50ZWwuY29tPgo+ID4gLS0tCj4gPiAgZHJpdmVycy9ncHUvZHJtL2RybV9w cm9iZV9oZWxwZXIuYyAgIHwgNDEgKysrKysrKysrKy0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t Cj4gPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfaG90cGx1Zy5jIHwgIDQgKystLQo+ID4g IGluY2x1ZGUvZHJtL2RybV9jcnRjX2hlbHBlci5oICAgICAgICB8ICAxIC0KPiA+ICAzIGZpbGVz IGNoYW5nZWQsIDEzIGluc2VydGlvbnMoKyksIDMzIGRlbGV0aW9ucygtKQo+ID4gCj4gPiBkaWZm IC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2RybV9wcm9iZV9oZWxwZXIuYyBiL2RyaXZlcnMvZ3B1 L2RybS9kcm1fcHJvYmVfaGVscGVyLmMKPiA+IGluZGV4IDA2MDIxMWFjNzRhMS4uN2M3MGYyYTUy MjUwIDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2RybV9wcm9iZV9oZWxwZXIuYwo+ ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2RybV9wcm9iZV9oZWxwZXIuYwo+ID4gQEAgLTExNSwy NSArMTE1LDI0IEBAIHN0YXRpYyBpbnQgZHJtX2hlbHBlcl9wcm9iZV9hZGRfY21kbGluZV9tb2Rl KHN0cnVjdCBkcm1fY29ubmVjdG9yICpjb25uZWN0b3IpCj4gPiAgCj4gPiAgI2RlZmluZSBEUk1f T1VUUFVUX1BPTExfUEVSSU9EICgxMCpIWikKPiA+ICAvKioKPiA+IC0gKiBkcm1fa21zX2hlbHBl cl9wb2xsX2VuYWJsZV9sb2NrZWQgLSByZS1lbmFibGUgb3V0cHV0IHBvbGxpbmcuCj4gPiArICog ZHJtX2ttc19oZWxwZXJfcG9sbF9lbmFibGUgLSByZS1lbmFibGUgb3V0cHV0IHBvbGxpbmcuCj4g PiAgICogQGRldjogZHJtX2RldmljZQo+ID4gICAqCj4gPiAtICogVGhpcyBmdW5jdGlvbiByZS1l bmFibGVzIHRoZSBvdXRwdXQgcG9sbGluZyB3b3JrIHdpdGhvdXQKPiA+IC0gKiBsb2NraW5nIHRo ZSBtb2RlX2NvbmZpZyBtdXRleC4KPiA+ICsgKiBUaGlzIGZ1bmN0aW9uIHJlLWVuYWJsZXMgdGhl IG91dHB1dCBwb2xsaW5nIHdvcmssIGFmdGVyIGl0IGhhcyBiZWVuCj4gPiArICogdGVtcG9yYXJp bHkgZGlzYWJsZWQgdXNpbmcgZHJtX2ttc19oZWxwZXJfcG9sbF9kaXNhYmxlKCksIGZvciBleGFt cGxlIG92ZXIKPiA+ICsgKiBzdXNwZW5kL3Jlc3VtZS4KPiA+ICAgKgo+ID4gLSAqIFRoaXMgaXMg bGlrZSBkcm1fa21zX2hlbHBlcl9wb2xsX2VuYWJsZSgpIGhvd2V2ZXIgaXQgaXMgdG8gYmUKPiA+ IC0gKiBjYWxsZWQgZnJvbSBhIGNvbnRleHQgd2hlcmUgdGhlIG1vZGVfY29uZmlnIG11dGV4IGlz IGxvY2tlZAo+ID4gLSAqIGFscmVhZHkuCj4gPiArICogRHJpdmVycyBjYW4gY2FsbCB0aGlzIGhl bHBlciBmcm9tIHRoZWlyIGRldmljZSByZXN1bWUgaW1wbGVtZW50YXRpb24uIEl0IGlzCj4gPiAr ICogYW4gZXJyb3IgdG8gY2FsbCB0aGlzIHdoZW4gdGhlIG91dHB1dCBwb2xsaW5nIHN1cHBvcnQg aGFzIG5vdCB5ZXQgYmVlbiBzZXQKPiA+ICsgKiB1cC4KPiA+ICAgKi8KPiA+IC12b2lkIGRybV9r bXNfaGVscGVyX3BvbGxfZW5hYmxlX2xvY2tlZChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2KQo+ID4g K3ZvaWQgZHJtX2ttc19oZWxwZXJfcG9sbF9lbmFibGUoc3RydWN0IGRybV9kZXZpY2UgKmRldikK PiA+ICB7Cj4gPiAgCWJvb2wgcG9sbCA9IGZhbHNlOwo+ID4gIAlzdHJ1Y3QgZHJtX2Nvbm5lY3Rv ciAqY29ubmVjdG9yOwo+ID4gIAlzdHJ1Y3QgZHJtX2Nvbm5lY3Rvcl9saXN0X2l0ZXIgY29ubl9p dGVyOwo+ID4gIAl1bnNpZ25lZCBsb25nIGRlbGF5ID0gRFJNX09VVFBVVF9QT0xMX1BFUklPRDsK PiA+ICAKPiA+IC0JV0FSTl9PTighbXV0ZXhfaXNfbG9ja2VkKCZkZXYtPm1vZGVfY29uZmlnLm11 dGV4KSk7Cj4gPiAtCj4gPiAgCWlmICghZGV2LT5tb2RlX2NvbmZpZy5wb2xsX2VuYWJsZWQgfHwg IWRybV9rbXNfaGVscGVyX3BvbGwpCj4gPiAgCQlyZXR1cm47Cj4gCj4gSG1tLCBvdXRwdXRfcG9s bF9leGVjdXRlKCkgaXRzZWxmIGlzIG5vdCBjaGVja2luZyB0aGlzIGNvcnJlY3RseSwKPiAKPiBk aWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2RybV9wcm9iZV9oZWxwZXIuYyBiL2RyaXZlcnMv Z3B1L2RybS9kcm1fcHJvYmVfaGVscGVyLmMKPiBpbmRleCA4NGI3NTcwOWFmOTAuLmNiM2ZlYmM2 ZTcxOSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vZHJtX3Byb2JlX2hlbHBlci5jCj4g KysrIGIvZHJpdmVycy9ncHUvZHJtL2RybV9wcm9iZV9oZWxwZXIuYwo+IEBAIC00MDUsNyArNDA1 LDcgQEAgc3RhdGljIHZvaWQgb3V0cHV0X3BvbGxfZXhlY3V0ZShzdHJ1Y3Qgd29ya19zdHJ1Y3Qg KndvcmspCj4gICAgICAgICBjaGFuZ2VkID0gZGV2LT5tb2RlX2NvbmZpZy5kZWxheWVkX2V2ZW50 Owo+ICAgICAgICAgZGV2LT5tb2RlX2NvbmZpZy5kZWxheWVkX2V2ZW50ID0gZmFsc2U7Cj4gIAo+ IC0gICAgICAgaWYgKCFkcm1fa21zX2hlbHBlcl9wb2xsKQo+ICsgICAgICAgaWYgKCFkZXYtPm1v ZGVfY29uZmlnLnBvbGxfZW5hYmxlZCB8fCAhZHJtX2ttc19oZWxwZXJfcG9sbCkKPiAgICAgICAg ICAgICAgICAgZ290byBvdXQ7CgpUaGUgY2FuY2VsX3dvcmtfc3luYyBpbiBwb2xsX2Rpc2FibGUg c2hvdWxkIG1ha2UgdGhpcyBpbXBvc3NpYmxlLCBidXQgaXQKbWlnaHQgYmUgYSBnb29kIHRoaW5n IHRvIGNoZWNrIHRoaXMgd2l0aCBhIFdBUk5fT04/IENhcmUgdG8gdHlwZSB0aGF0CnBhdGNoIGFz IGEgZm9sbG93IHVwIHBsZWFzZT8KCj4gICAgICAgICBpZiAoIW11dGV4X3RyeWxvY2soJmRldi0+ bW9kZV9jb25maWcubXV0ZXgpKSB7Cj4gCj4gVGhlIGNvbm5lY3RvciBsaXN0IGlzIGxvY2tlZCwg YnV0IHRoZSBvdGhlciByZWFkcyBhcmUgYWxsIHJhY3kKPiAoY29ubmVjdG9yLT5wb2xsZWQsIGRl bGF5ZWRfZXZlbnQpLiBUaG9zZSByYWNlcyBzZWVtIGludHJpbnNpYyBhbmQgaGFuZGxlZAo+IGJ5 IGUuZy4gaW50ZWxfaG90cGx1Zy5jLgo+IAo+IFNpbmNlIHRoZSBsb2NraW5nIGhlcmUgd2FzIG9u bHkgY292ZXJpbmcgdGhlIGNvbm5lY3RvciBsaXN0IGFuZCB0aGF0IG5vdwo+IGhhcyBpdHMgb3du IGxvY2ssCj4gUmV2aWV3ZWQtYnk6IENocmlzIFdpbHNvbiA8Y2hyaXNAY2hyaXMtd2lsc29uLmNv LnVrPgoKVGhhbmtzIGZvciB0aGUgcmV2aWV3LCBJIHRoaW5rIEknbGwgd2FpdCBmb3IgRGF2ZSB0 byBzdXBwbHkgYnVnemlsbGEgbGluawpvciBjb25maXJtYXRpb24gaXQgc29sdmVzIGhpcyBsb2Nr ZGVwIGlzc3VlIGJlZm9yZSBtZXJnaW5nLgotRGFuaWVsCi0tIApEYW5pZWwgVmV0dGVyClNvZnR3 YXJlIEVuZ2luZWVyLCBJbnRlbCBDb3Jwb3JhdGlvbgpodHRwOi8vYmxvZy5mZndsbC5jaApfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFp bGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5m cmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK