From: Thierry Reding <thierry.reding@gmail.com>
To: Lucas Stach <l.stach@pengutronix.de>
Cc: Daniel Vetter <daniel.vetter@intel.com>,
kernel@pengutronix.de, dri-devel@lists.freedesktop.org,
patchwork-lst@pengutronix.de
Subject: Re: [PATCH] drm: don't link DP aux i2c adapter to the hardware device node
Date: Mon, 23 Jan 2017 17:33:47 +0100 [thread overview]
Message-ID: <20170123163347.GC2043@ulmo.ba.sec> (raw)
In-Reply-To: <20170113173630.22138-1-l.stach@pengutronix.de>
[-- Attachment #1.1: Type: text/plain, Size: 695 bytes --]
On Fri, Jan 13, 2017 at 06:36:30PM +0100, Lucas Stach wrote:
> The i2c adapter on DP AUX is purely a software construct. Linking
> it to the device node of the parent device is wrong, as it leads to
> 2 devices sharing the same device node, which is bad practice, as
Who says that two devices can't share the same device node? It's done
all the time.
> well as the i2c trying to populate children of the i2c adapter by
> looking at the child device nodes of the parent device.
A set of patches landed in v4.9 to work around this issue in a better
way. See:
98b00488459e dt-bindings: i2c: Add support for 'i2c-bus' subnode
7e4c224abfe8 i2c: core: Add support for 'i2c-bus' subnode
Thierry
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2017-01-23 16:33 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-13 17:36 [PATCH] drm: don't link DP aux i2c adapter to the hardware device node Lucas Stach
2017-01-23 8:16 ` Daniel Vetter
2017-01-23 16:33 ` Thierry Reding [this message]
2017-01-23 16:42 ` Lucas Stach
2017-03-29 13:56 ` Rob Herring
2017-04-05 8:52 ` Lucas Stach
2017-04-05 12:04 ` Thierry Reding
2017-11-14 14:34 ` Andrzej Hajda
2017-11-20 7:54 ` Daniel Vetter
2017-11-20 8:53 ` Andrzej Hajda
2018-02-05 16:11 ` Thierry Reding
2018-02-05 16:29 ` Lucas Stach
2018-02-05 17:11 ` Thierry Reding
2018-02-05 17:33 ` Thierry Reding
2018-02-05 17:39 ` Lucas Stach
2018-02-05 18:07 ` Thierry Reding
2018-02-07 13:53 ` Andrzej Hajda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170123163347.GC2043@ulmo.ba.sec \
--to=thierry.reding@gmail.com \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=kernel@pengutronix.de \
--cc=l.stach@pengutronix.de \
--cc=patchwork-lst@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox