From: Daniel Vetter <daniel@ffwll.ch>
To: Harry Wentland <harry.wentland@amd.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>,
Alex Deucher <alexander.deucher@amd.com>,
Ben Skeggs <bskeggs@redhat.com>
Subject: Re: [PATCH v2 4/9] drm: Add driver private objects to atomic state
Date: Thu, 26 Jan 2017 09:40:07 +0100 [thread overview]
Message-ID: <20170126084007.jbgetami2nldde4s@phenom.ffwll.local> (raw)
In-Reply-To: <227ecbd6-0986-af85-c8e2-de31a839a5be@amd.com>
On Wed, Jan 25, 2017 at 04:33:16PM -0500, Harry Wentland wrote:
> On 2017-01-25 12:59 AM, Daniel Vetter wrote:
> > On Tue, Jan 24, 2017 at 03:49:32PM -0800, Dhinakaran Pandiyan wrote:
> >> +struct drm_private_state_funcs {
> >
> > I also wonder whether we shouldn't give this a drm_atomic_ prefix ...
>
> I think leaving the atomic prefix out is more consistent with the other
> atomic state objects (drm_crtc_state, etc). drm_xyz_state seems to apply
> atomic.
>
> I don't have a strong preference either way, though.
Yeah, makes sense ... I suggested the atomic prefix since it's (at least
right now) only used for atomic updates. But just calling them
drm_private_{state,obj} makes sense too.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-01-26 8:40 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-24 23:49 [PATCH v2 0/9] Adding private objects to atomic state Dhinakaran Pandiyan
2017-01-24 23:49 ` [PATCH v2 1/9] drm/dp: Store drm_device in MST topology manager Dhinakaran Pandiyan
2017-01-25 0:30 ` [Intel-gfx] " Dave Airlie
2017-01-24 23:49 ` [PATCH v2 2/9] drm/dp: Kill unused MST vcpi slot availability tracking Dhinakaran Pandiyan
2017-01-25 5:43 ` Daniel Vetter
2017-01-25 20:36 ` Pandiyan, Dhinakaran
2017-01-24 23:49 ` [PATCH v2 3/9] drm/dp: Split drm_dp_mst_allocate_vcpi Dhinakaran Pandiyan
2017-01-25 0:31 ` Dave Airlie
2017-01-25 20:34 ` Pandiyan, Dhinakaran
2017-01-24 23:49 ` [PATCH v2 4/9] drm: Add driver private objects to atomic state Dhinakaran Pandiyan
2017-01-25 5:59 ` Daniel Vetter
2017-01-25 20:47 ` Pandiyan, Dhinakaran
2017-01-26 8:38 ` [Intel-gfx] " Daniel Vetter
2017-01-25 21:33 ` Harry Wentland
2017-01-26 8:40 ` Daniel Vetter [this message]
2017-01-24 23:49 ` [PATCH v2 5/9] drm/dp: Introduce MST topology state Dhinakaran Pandiyan
2017-01-25 6:05 ` Daniel Vetter
2017-01-24 23:49 ` [PATCH v2 6/9] drm/dp: Add DP MST helpers to atomically find and release vcpi slots Dhinakaran Pandiyan
2017-01-24 23:49 ` [PATCH v2 7/9] drm: Connector helper function to release atomic state Dhinakaran Pandiyan
2017-01-25 6:18 ` Daniel Vetter
2017-01-25 21:01 ` Pandiyan, Dhinakaran
2017-01-31 0:14 ` Pandiyan, Dhinakaran
2017-01-24 23:49 ` [PATCH v2 8/9] drm/dp: Release DP MST shared link bandwidth Dhinakaran Pandiyan
2017-01-25 6:16 ` Daniel Vetter
2017-01-25 20:53 ` Pandiyan, Dhinakaran
2017-01-26 8:41 ` [Intel-gfx] " Daniel Vetter
2017-01-24 23:49 ` [PATCH v2 9/9] drm/dp: Track MST " Dhinakaran Pandiyan
2017-01-25 6:15 ` Daniel Vetter
2017-01-25 21:00 ` Pandiyan, Dhinakaran
2017-01-26 8:42 ` [Intel-gfx] " Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170126084007.jbgetami2nldde4s@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=alexander.deucher@amd.com \
--cc=bskeggs@redhat.com \
--cc=daniel.vetter@ffwll.ch \
--cc=dhinakaran.pandiyan@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=harry.wentland@amd.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox