From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH] drm: mxsfb: Implement drm_panel handling Date: Wed, 1 Feb 2017 18:22:16 +0100 Message-ID: <20170201172216.GA27271@ulmo.ba.sec> References: <1485969587-3630-1-git-send-email-fabio.estevam@nxp.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1413362957==" Return-path: Received: from mail-wm0-x243.google.com (mail-wm0-x243.google.com [IPv6:2a00:1450:400c:c09::243]) by gabe.freedesktop.org (Postfix) with ESMTPS id A618F6E886 for ; Wed, 1 Feb 2017 17:22:20 +0000 (UTC) Received: by mail-wm0-x243.google.com with SMTP id v77so6989394wmv.0 for ; Wed, 01 Feb 2017 09:22:20 -0800 (PST) In-Reply-To: <1485969587-3630-1-git-send-email-fabio.estevam@nxp.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Fabio Estevam Cc: marex@denx.de, breno.lima@nxp.com, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============1413362957== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="AhhlLboLdkugWU4S" Content-Disposition: inline --AhhlLboLdkugWU4S Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Feb 01, 2017 at 03:19:47PM -0200, Fabio Estevam wrote: > Currently when the 'power-supply' regulator is passed via device tree > it does not actually work since drm_panel_prepare()/drm_panel_enable() > are never called. >=20 > Quoting Thierry Reding: "It should really call drm_panel_prepare() and > drm_panel_enable() while switching on the display pipeline and > drm_panel_disable(), followed by drm_panel_unprepare() while switching > off the display pipeline." >=20 > So do as suggested, so that the 'power-supply' regulator can be functiona= l. >=20 > Reported-by: Breno Lima > Suggested-by: Thierry Reding > Signed-off-by: Fabio Estevam > --- > drivers/gpu/drm/mxsfb/mxsfb_drv.c | 4 ++++ > 1 file changed, 4 insertions(+) Reviewed-by: Thierry Reding --AhhlLboLdkugWU4S Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAliSGUYACgkQ3SOs138+ s6GkPxAAs6OiQiYssvr/APKk3aQZdyFhQ0yUNl1Z8KhChx5sOJU5WuneQ63P9k0b Mkd341v1BH6q2Ae/DFOdpmjxVCxHPQys9aP61tfcD++h1dF32+E0v/sI2PpjcNEY JaRJy+zp91WwV0Xb2NxVIQMimjHNTzcvj3dAFmzxYlaMQLVb1FpWwzlcQZpg9b98 e22GIk4SQ2+VI6VhsznFzyIC9DXBE7GstsoRS6oIMtN70Hbm0otEL5hvi/Tz9M7l JyUYC6tgvswZONLKsqYfGPzY5LjKUWYM7zZw19UugKJtoBCGXWTkdibrUaLylD7a PB/CT7Q/O8ZfTwd/EEjluTr29zpqbbsJ45qJEA+iY7rh+UlxJPE2cz95wODeAXRp ZQYpk65HVB6EbpzPiuWHjIHykHPYMrwILBsEZ0liwxcKEu/pwM1V+fPnb8Z7NPIm GbzNqLX25/bhGmekldfbqgHFnoEVsxyYyus7SmquLqTOygv+MLveXqz6I0/40RhW 7NvBKkAgJ0OlcSdiFU513M3eFujJG2v0tRbPK997Hpq3wFYMxiRcIa9q7593s2Mr 2P3xGuuxitZFG0BNKqezPuJ2PoOIzTfSYntC1lA1OW/FomcUTFnlmfJejhzCzWSq /CsNoqQEM4qGx4728+PZdLsejRW+NNaM3hQvEJ25YDwg/AHENuA= =QsTK -----END PGP SIGNATURE----- --AhhlLboLdkugWU4S-- --===============1413362957== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============1413362957==--