dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Engestrom <eric.engestrom@imgtec.com>
To: Archit Taneja <architt@codeaurora.org>
Cc: daniel.vetter@intel.com, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/doc: Fix up some kms function names
Date: Fri, 24 Feb 2017 13:41:16 +0000	[thread overview]
Message-ID: <20170224134116.izmhypkyj2e4dhog@imgtec.com> (raw)
In-Reply-To: <20170222084741.8485-1-architt@codeaurora.org>

On Wednesday, 2017-02-22 14:17:41 +0530, Archit Taneja wrote:
> A couple of the kms functions didn't have the correct/newest names.
> This prevented them to be identified as refs in the html doc.
> 
> Signed-off-by: Archit Taneja <architt@codeaurora.org>

Thanks!
Reviewed-by: Eric Engestrom <eric.engestrom@imgtec.com>
Tested-by: Eric Engestrom <eric.engestrom@imgtec.com>

There's a lot of other symbols not ref-linked because of incorrect syntax,
including in this file; can I interest you in fixing those as well? :)

> ---
>  include/drm/drm_mode_config.h | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/include/drm/drm_mode_config.h b/include/drm/drm_mode_config.h
> index 6cd541d69c2e..888cc038899b 100644
> --- a/include/drm/drm_mode_config.h
> +++ b/include/drm/drm_mode_config.h
> @@ -267,7 +267,7 @@ struct drm_mode_config_funcs {
>  	 * passed-in &drm_atomic_state. This hook is called when the caller
>  	 * encountered a &drm_modeset_lock deadlock and needs to drop all
>  	 * already acquired locks as part of the deadlock avoidance dance
> -	 * implemented in drm_modeset_lock_backoff().
> +	 * implemented in drm_modeset_backoff().
>  	 *
>  	 * Any duplicated state must be invalidated since a concurrent atomic
>  	 * update might change it, and the drm atomic interfaces always apply
> @@ -285,8 +285,8 @@ struct drm_mode_config_funcs {
>  	 * itself. Note that the core first calls drm_atomic_state_clear() to
>  	 * avoid code duplicate between the clear and free hooks.
>  	 *
> -	 * Drivers that implement this must call drm_atomic_state_default_free()
> -	 * to release common resources.
> +	 * Drivers that implement this must call
> +	 * drm_atomic_state_default_release() to release common resources.
>  	 */
>  	void (*atomic_state_free)(struct drm_atomic_state *state);
>  };
> -- 
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> hosted by The Linux Foundation
> 
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2017-02-24 13:41 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-22  8:47 [PATCH] drm/doc: Fix up some kms function names Archit Taneja
2017-02-24 13:41 ` Eric Engestrom [this message]
2017-02-26 13:44   ` Archit Taneja
2017-02-26 21:47     ` Daniel Vetter
2017-02-27  3:27       ` Archit Taneja

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170224134116.izmhypkyj2e4dhog@imgtec.com \
    --to=eric.engestrom@imgtec.com \
    --cc=architt@codeaurora.org \
    --cc=daniel.vetter@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox