From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [Intel-gfx] [PATCH 8/9] drm/i915: Implement .get_format_info() hook for CCS Date: Mon, 27 Feb 2017 17:13:41 +0200 Message-ID: <20170227151341.GE31595@intel.com> References: <20170104184232.23048-1-ville.syrjala@linux.intel.com> <20170104184232.23048-9-ville.syrjala@linux.intel.com> <20170226224150.GA26183@chadversary-glaptop0.roam.corp.google.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20170226224150.GA26183@chadversary-glaptop0.roam.corp.google.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Chad Versace , intel-gfx@lists.freedesktop.org, Ben Widawsky , Vandana Kannan , dri-devel@lists.freedesktop.org, Jason Ekstrand List-Id: dri-devel@lists.freedesktop.org T24gU3VuLCBGZWIgMjYsIDIwMTcgYXQgMDI6NDE6NTBQTSAtMDgwMCwgQ2hhZCBWZXJzYWNlIHdy b3RlOgo+IE9uIFdlZCAwNCBKYW4gMjAxNywgdmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20g d3JvdGU6Cj4gPiBGcm9tOiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50 ZWwuY29tPgo+ID4gCj4gPiBTS0wrIGRpc3BsYXkgZW5naW5lIGNhbiBzY2FuIG91dCBjZXJ0YWlu IGtpbmRzIG9mIGNvbXByZXNzZWQgc3VyZmFjZXMKPiA+IHByb2R1Y2VkIGJ5IHRoZSByZW5kZXIg ZW5naW5lLiBUaGlzIGludm9sdmVkIHRlbGxpbmcgdGhlIGRpc3BsYXkgZW5naW5lCj4gPiB0aGUg bG9jYXRpb24gb2YgdGhlIGNvbG9yIGNvbnRyb2wgc3VyZmFlIChDQ1MpIHdoaWNoIGRlc2NyaWJl cyB3aGljaAo+ID4gcGFydHMgb2YgdGhlIG1haW4gc3VyZmFjZSBhcmUgY29tcHJlc3NlZCBhbmQg d2hpY2ggYXJlIG5vdC4gVGhlIGxvY2F0aW9uCj4gPiBvZiBDQ1MgaXMgcHJvdmlkZWQgYnkgdXNl cnNwYWNlIGFzIGp1c3QgYW5vdGhlciBwbGFuZSB3aXRoIGl0cyBvd24gb2Zmc2V0Lgo+ID4gCj4g PiBCeSBwcm92aWRpbmcgb3VyIG93biBmb3JtYXQgaW5mb3JtYXRpb24gZm9yIHRoZSBDQ1MgZm9y bWF0cywgd2Ugc2hvdWxkCj4gPiBiZSBhYmxlIHRvIG1ha2UgZnJhbWVidWZmZXJfY2hlY2soKSBk byB0aGUgcmlnaHQgdGhpbmcgZm9yIHRoZSBDQ1MKPiA+IHN1cmZhY2UgYXMgd2VsbC4KPiA+IAo+ ID4gTm90ZSB0aGF0IHdlJ2xsIHJldHVybiB0aGUgc2FtZSBmb3JtYXQgaW5mbyBmb3IgYm90aCBZ IGFuZCBZZiB0aWxlZAo+ID4gZm9ybWF0IGFzIHRoYXQncyB3aGF0IGhhcHBlbnMgd2l0aCB0aGUg bm9uLUNDUyBZIHZzLiBZZiBhcyB3ZWxsLiBJZgo+ID4gZGVzaXJlZCwgd2UgY291bGQgcG90ZW50 aWFsbHkgcmV0dXJuIGEgdW5pcXVlIHBvaW50ZXIgZm9yIGVhY2gKPiA+IHBpeGVsX2Zvcm1hdCt0 aWxpbmcrY2NzIGNvbWJpbmF0aW9uLCBpbiB3aGljaCBjYXNlIHdlIGltbWVkaWF0ZWx5IGJlCj4g PiBhYmxlIHRvIHRlbGwgaWYgYW55IG9mIHRoYXQgc3R1ZmYgY2hhbmdlZCBieSBqdXN0IGNvbXBh cmluZyB0aGUKPiA+IHBvaW50ZXJzLiBCdXQgdGhhdCBkb2VzIHNvdW5kIGEgYml0IHdhc3RlZnVs IHNwYWNlIHdpc2UuCj4gPiAKPiA+IHYyOiBEcm9wIHRoZSAnZGV2JyBhcmd1bWVudCBmcm9tIHRo ZSBob29rCj4gPiB2MzogSW5jbHVkZSB0aGUgZGVzY3JpcHRpb24gb2YgdGhlIENDUyBzdXJmYWNl IGxheW91dAo+ID4gCj4gPiBDYzogVmFuZGFuYSBLYW5uYW4gPHZhbmRhbmEua2FubmFuQGludGVs LmNvbT4KPiA+IENjOiBEYW5pZWwgVmV0dGVyIDxkYW5pZWxAZmZ3bGwuY2g+Cj4gPiBDYzogQmVu IFdpZGF3c2t5IDxiZW5AYndpZGF3c2submV0Pgo+ID4gQ2M6IEphc29uIEVrc3RyYW5kIDxqYXNv bkBqbGVrc3RyYW5kLm5ldD4KPiA+IFJldmlld2VkLWJ5OiBCZW4gV2lkYXdza3kgPGJlbkBid2lk YXdzay5uZXQ+Cj4gPiBTaWduZWQtb2ZmLWJ5OiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmph bGFAbGludXguaW50ZWwuY29tPgo+ID4gLS0tCj4gPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfZGlzcGxheS5jIHwgMzYgKysrKysrKysrKysrKysrKysrKysrKysrKysKPiA+ICBpbmNsdWRl L3VhcGkvZHJtL2RybV9mb3VyY2MuaCAgICAgICAgfCA0OSArKysrKysrKysrKysrKysrKysrKysr KysrKysrKysrKysrKysKPiA+ICAyIGZpbGVzIGNoYW5nZWQsIDg1IGluc2VydGlvbnMoKykKPiAK PiAKPiA+IGRpZmYgLS1naXQgYS9pbmNsdWRlL3VhcGkvZHJtL2RybV9mb3VyY2MuaCBiL2luY2x1 ZGUvdWFwaS9kcm0vZHJtX2ZvdXJjYy5oCj4gPiBpbmRleCA5ZTFiYjdmYWJjZGUuLjQ1ODFlM2Q0 MWU1YyAxMDA2NDQKPiA+IC0tLSBhL2luY2x1ZGUvdWFwaS9kcm0vZHJtX2ZvdXJjYy5oCj4gPiAr KysgYi9pbmNsdWRlL3VhcGkvZHJtL2RybV9mb3VyY2MuaAo+ID4gQEAgLTIzMCw2ICsyMzAsNTUg QEAgZXh0ZXJuICJDIiB7Cj4gPiAgI2RlZmluZSBJOTE1X0ZPUk1BVF9NT0RfWWZfVElMRUQgZm91 cmNjX21vZF9jb2RlKElOVEVMLCAzKQo+ID4gIAo+ID4gIC8qCj4gPiArICogSW50ZWwgY29sb3Ig Y29udHJvbCBzdXJmYWNlIChDQ1MpIGZvciByZW5kZXIgY29tcHJlc3Npb24KPiA+ICsgKgo+ID4g KyAqIFRoZSBmcmFtZWJ1ZmZlciBmb3JtYXQgbXVzdCBiZSBvbmUgb2YgdGhlIDg6ODo4OjggUkdC IGZvcm1hdHMsCj4gPiArICogdGhlIG1haW4gc3VyZmFjZSB3aWxsIGJlIHBsYW5lIGluZGV4IDAg YW5kIHdpbGwgYmUgWS9ZZi10aWxlZCwKPiA+ICsgKiB0aGUgQ0NTIHdpbGwgYmUgcGxhbmUgaW5k ZXggMS4KPiA+ICsgKgo+IAo+IFRoZSBwYXJhZ3JhcGggYmVsb3cgaXMuLi4KPiAKPiA+ICsgKiBF YWNoIGJ5dGUgb2YgQ0NTIGNvbnRhaW5zIDQgcGFpcnMgb2YgYml0cywgd2l0aCBlYWNoIHBhaXIg b2YgYml0cwo+ID4gKyAqIG1hdGNoaW5nIGFuIGFyZWEgb2YgOHg0IHBpeGVscyBvZiB0aGUgbWFp biBzdXJmYWNlLiBXaGljaCB3b3VsZCBzZWVtCj4gPiArICogdG8gbWF0Y2ggMiBjYWNoZWxpbmVz IGNvbnRhaW5pbmcgNHg0IHBpeGVscyBlYWNoLiBUaGUgcGFpcnMgYml0cyB3aXRoaW4KPiA+ICsg KiB0aGUgYnl0ZSBmb3JtIGEgMngyIGdyaWQsIHdoaWNoIHRodXMgbWF0Y2hlcyBhIDE2eDggcGl4 ZWwgYXJlYSBvZiB0aGUKPiA+ICsgKiBtYWluIHN1cmZhY2UuIFRoaXMgaXMgdGhlIDJ4MiBwYXR0 ZXJuIHRoZSBiaXRzIGZvcm0gKDA9bHNiLCA3PW1zYik6Cj4gPiArICogLS0tLS0tLS0tLS0KPiA+ ICsgKiB8IDAxIHwgMjMgfAo+ID4gKyAqICAtLS0tLS0tLS0tCj4gPiArICogfCA0NSB8IDY3IHwK PiA+ICsgKiAtLS0tLS0tLS0tLQo+IAo+IC4uLmFsbW9zdCBjb3JyZWN0LiBUaGUgaHcgZG9jcyBz dGF0ZSB0aGF0IGVhY2ggYml0LXBhaXIgb2YgdGhlIENDUyBtYXBzCj4gY2FjaGVsaW5lLXBhaXIs IGhvcml6b250YWxseSBhZGphY2VudCBpbiB0aGUgWSB0aWxlLCBvZiB0aGUgcHJpbWFyeSBzdXJm YWNlLiBBcwo+IGEgY29uc2VxdWVuY2UsIHRoZSByZW1haW5kZXIgb2YgdGhlIGFib3ZlIHBhcmFn cmFwaCBpcyBjb3JyZWN0IGZvciAzMi1iaXQKPiBmb3JtYXRzLCBidXQgbm90IG90aGVycy4KCldo aWNoIGlzIHdoeSB0aGUgY29tbWVudCBzYXlzIGF0IHRoZSB2ZXJ5IHRvcCB0aGF0IHRoZSBmYiBu ZWVkcyB0bwp1c2UgYSA4Ojg6ODo4IGZvcm1hdC4gSUlSQyB0aGF0J3MgdGhlIG9ubHkgdGhpbmcg dGhlIGhhcmR3YXJlIHN1cHBvcnRzLgoKPiAKPiBUaGlzIGlzIG5vdCBhIG5pdHBpY2ssIGJlY2F1 c2UgVnVsa2FuIGFuZCBFR0wgdXNlcnMgbWF5IHdhbnQgdG8gc2hhcmUKPiBkbWFfYnVmcyB3aXRo IGEgZmF0IGZvcm1hdCBsaWtlIFIzMkczMkIzMkEzMl9VTk9STSwgYW5kIHdhbnQgdG8gaGF2ZSBD Q1MKPiBlbmFibGVkIHdoZW4gcG9zc2libGUuIEFzIGxvbmcgYXMgdGhlIHVzZXJzIHVzZSB0aGUg ZG1hX2J1ZiBvbmx5IHRoZSAzRAo+IGVuZ2luZSwgYW5kIGRvbid0IHN1Ym1pdCBpdCB0byBLTVMs IGl0J3MgYWxsIHNhZmUuCj4gCj4gRm9yIHRob3NlIHVzZXJzLCB3ZSBzaG91bGQgZG9jdW1lbnQg dGhlIGJpdC1wYWlyL2NhY2hlbGluZS1wYWlyIHJlbGF0aW9uc2hpcAo+IGNvcnJlY3RseS4gQW5k IHRoZW4gcHJlZmFjZSB0aGUgZm9sbG93aW5nIGRldGFpbGVkIGV4cGxhbmF0aW9uIGFuZCBuaWNl IGFzY2lpCj4gZGlhZ3JhbXMgYnkgc2F5aW5nICJ0aGlzIGFwcGxpZXMgb25seSB0byB0aGUgMzIt Yml0IGZvcm1hdHMiLgo+IAo+IEhlcmUncyB0aGUgcmVsZXZhbnQgUFJNIHF1b3RlOgo+IAo+ICAg ICAgVGhlIENvbG9yIENvbnRyb2wgU3VyZmFjZSAoQ0NTKSBjb250YWlucyB0aGUgY29tcHJlc3Np b24gc3RhdHVzCj4gICAgICBvZiB0aGUgY2FjaGUtbGluZSBwYWlycy4gVGhlIGNvbXByZXNzaW9u IHN0YXRlIG9mIHRoZSBjYWNoZS1saW5lCj4gICAgICBwYWlyIGlzIHNwZWNpZmllZCBieSAyIGJp dHMgaW4gdGhlIENDUy4gIEVhY2ggQ0NTIGNhY2hlLWxpbmUKPiAgICAgIHJlcHJlc2VudHMgYW4g YXJlYSBvbiB0aGUgbWFpbiBzdXJmYWNlIG9mIDE2eDE2IHNldHMgb2YgMTI4IGJ5dGUKPiAgICAg IFktdGlsZWQgY2FjaGUtbGluZS1wYWlycy4gQ0NTIGlzIGFsd2F5cyBZIHRpbGVkLgo+IAo+IFNl ZSB0aGlzIE1lc2EgY29tbWVudCBmb3IgbW9yZSBkZXRhaWxzOgo+IGh0dHBzOi8vY2dpdC5mcmVl ZGVza3RvcC5vcmcvbWVzYS9tZXNhL3RyZWUvc3JjL2ludGVsL2lzbC9pc2wuYz9oPTE3LjAjbjIx MQo+IAo+ID4gKyAqIEFjdHVhbGx5IG9ubHkgdGhlIGxvd2VyIGJpdCBvZiB0aGUgcGFpciBzZWVt cyB0byBoYXZlIGFueSBlZmZlY3QuCj4gPiArICogTm8gaWRlYSB3aHkuIDAgaW4gdGhlIGxvd2Vy IGJpdCB3b3VsZCBzZWVtIHRvIG1lYW4gbm90IGNvbXByZXNzZWQsCj4gPiArICogYW5kIDEgaXMg Y29tcHJlc3NlZC4gIFRoZSBpbnRlcnByZWF0aW9uIG9mIHRoZSBtYWluIHN1cmZhY2UgZGF0YQo+ ID4gKyAqIHdoZW4gdGhlIGJsb2NrIGlzIG1hcmtlZCBjb21wcmVzc2VkIGlzIHVua25vd24gYXMg b2Ygbm93Lgo+IAo+IElmIEkgcmVjYWxsIGNvcnJlY3RseSAoaXQncyBiZWVuIHNldmVyYWwgbW9u dGhzIHNpbmNlIEkgaW5zcGVjdGVkIHRoZQo+IGJpdHMpLCB0aGUgaGlnaCBiaXQgaXMgYWN0dWFs bHkgc2lnbmlmaWNhbnQuIEJpdCBwYXR0ZXJuIDExIG1lYW5zIHRoYXQKPiB0aGUgZGF0YSBpbiBw cmltYXJ5IHN1cmZhY2UncyBjYWNoZWxpbmUtcGFpciBpcyBpbnZhbGlkOyB0aGUgM0QgZW5naW5l Cj4gaW50ZXJwcmV0cyB0aGUgY29sb3Igb2YgYWxsIHBpeGVscyBpbiB0aGF0IGNhY2hlbGluZS1w YWlyIHRvIGJlIHRoZQo+IGNsZWFyIGNvbG9yIHN0b3JlZCBpbiBSRU5ERVJfU1VSRkFDRV9TVEFU RS4gQmVmb3JlIHRoZSBkaXNwbGF5IGVuZ2luZQo+IGNhbiBjb25zdW1lIHRoZSBzdXJmYWNlLCB1 c2Vyc3BhY2UgaXMgcmVxdWlyZWQgdG8gZG8gYSBwYXJ0aWFsIHJlc29sdmUsCj4gZmx1c2hpbmcg dGhlIGNsZWFyIGNvbG9yIGludG8gdGhlIHByaW1hcnkgc3VyZmFjZS4gU28gaXQgbWFrZXMgc2Vu c2UKPiB0aGF0IHRoZSBrZXJuZWwgd291bGQgbmV2ZXIgb2JzZXJ2ZSB0aGF0IGJpdCBwYXR0ZXJu IGluIGFuIGluY29taW5nIGNjcwo+IHN1cmZhY2UsIGFzIGxvbmcgYXMgdXNlcnNwYWNlIGlzIGRv aW5nIGl0cyBqb2IgY29ycmVjdGx5LiBBbmQgaXQgbWFrZXMKPiBzZW5zZSB0aGF0IHRoZSBkaXNw bGF5IGVuZ2luZSB3b3VsZCBpZ25vcmUgdGhlIGhpZ2ggYml0LCBiZWNhdXNlIHRoZXJlIGlzCj4g bm8gd2F5IHRvIHByb3ZpZGUgdGhlIGNsZWFyIGNvbG9yIHRvIHRoZSBkaXNwbGF5IGVuZ2luZSAo YXQgbGVhc3QKPiBhY2NvcmRpbmcgbXkgcmVhZGluZyBvZiB0aGUgZG9jcykuCj4gCj4gSmFzb24s IGRvZXMgdGhpcyBtYXRjaCB5b3VyIHVuZGVyc3RhbmRpbmcgb2YgdGhlIGhpZ2ggYml0Pwo+IAo+ ID4gKyAqCj4gPiArICogQ0NTIHRpbGUgaXMgbGFpZCBvdXQgaW4gOCBieXRlIGhvcml6b250YWwg c3RyaXBzIGVhY2ggc3RyaXAgdGh1cyBjb3JyZXNwb25kcwo+ID4gKyAqIHRvIGEgMTI4eDggcGl4 ZWwgYXJlIG9mIHRoZSBtYWluIHN1cmZhY2UuIFNvIGVhY2ggOHg4IGJ5dGVzIG9mIHRoZSBDQ1MK PiA+ICsgKiAoMSBjYWNoZWxpbmUpIHdpbGwgbWF0Y2ggYW4gYXJlYSBvZiA0eDIgdGlsZXMgb24g dGhlIG1haW4gc3VyZmFjZS4KPiA+ICsgKgo+ID4gKyAqIEhlcmUgaXMgdGhlIGxheW91dCBvZiBh IGZ1bGwgQ0NTIHRpbGUsIHdpdGggdGhlIDggYnl0ZSBzdHJpcHMgbnVtYmVyZWQgMC01MTE6Cj4g PiArICogLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCj4gPiArICogfCAgMCB8ICA2NCB8IC4uLiB8 IDQ0OCB8Cj4gPiArICogfCAgMSB8ICA2NSB8ICAgICB8IDQ0OSB8Cj4gPiArICogfCAgMiB8ICA2 NiB8ICAgICB8IDQ1MCB8Cj4gPiArICogfCAgLiB8ICAgLiB8ICAgICB8ICAgLiB8Cj4gPiArICog fCAgLiB8ICAgLiB8ICAgICB8ICAgLiB8Cj4gPiArICogfCAgLiB8ICAgLiB8ICAgICB8ICAgLiB8 Cj4gPiArICogfCA2MyB8IDEyNyB8ICAgICB8IDUxMSB8Cj4gPiArICogLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tCj4gPiArICoKPiA+ICsgKiBUaGlzIHdpbGwgbWF0Y2ggYW4gYXJlYSBvZiAxMDI0 eDUxMiBwaXhlbHMgb24gdGhlIG1haW4gc3VyZmFjZS4KPiA+ICsgKgo+ID4gKyAqIFRoZSBDQ1Mg cGxhbmUgcGl0Y2ggbXVzdCBiZSBhIG11bHRpcGxlIG9mIHRoZSBDQ1MgdGlsZSB3aWR0aCAoNjQg Ynl0ZXMpLAo+ID4gKyAqIGFuZCBmb3IgdGhlIHB1cnBvc2VzIG9mIHRoZSBDQ1MgcGxhbmUgb2Zm c2V0IHdlIGFzc3VtZSBjcHA9PTEuIEFzIGVhY2gKPiA+ICsgKiBieXRlIG1hdGNoZXMgYSAxNng4 IGFyZWEgb2YgdGhlIG1haW4gc3VyZmFjZSwgdGhlIGRpbWVuc2lvbnMgb2YgdGhlIENDUwo+ID4g KyAqIHBsYW5lIHdpbGwgdGh1cyBhcHBlYXIgdG8gYmUgd2lkdGgvMTYgeCBoZWlnaHQvOC4gQm90 aCBwbGFuZXMgbXVzdCBiZQo+ID4gKyAqIGNvbnRhaW5lZCB3aXRoaW4gdGhlIHNhbWUgZ2VtIG9i amVjdC4KPiAKPiBBZ2FpbiwgdGhlIGFib3ZlIHBhcmFncmFwaHMgc2hvdWxkIGNsYXJpZnkgdGhh dCB0aGV5IGFwcGx5IG9ubHkgdG8gMzItYml0IGZvcm1hdHMuCj4gCj4gPiArICovCj4gPiArI2Rl ZmluZSBJOTE1X0ZPUk1BVF9NT0RfWV9USUxFRF9DQ1MJZm91cmNjX21vZF9jb2RlKElOVEVMLCA0 KQo+ID4gKyNkZWZpbmUgSTkxNV9GT1JNQVRfTU9EX1lmX1RJTEVEX0NDUwlmb3VyY2NfbW9kX2Nv ZGUoSU5URUwsIDUpCgotLSAKVmlsbGUgU3lyasOkbMOkCkludGVsIE9UQwpfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0 CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3Rv cC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK