From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Widawsky Subject: Re: [PATCH 8/9] drm/i915: Implement .get_format_info() hook for CCS Date: Mon, 27 Feb 2017 21:36:47 -0800 Message-ID: <20170228053645.GA4011@mail.bwidawsk.net> References: <20170104184232.23048-1-ville.syrjala@linux.intel.com> <20170104184232.23048-9-ville.syrjala@linux.intel.com> <20170226224150.GA26183@chadversary-glaptop0.roam.corp.google.com> <20170227151341.GE31595@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20170227151341.GE31595@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ville =?utf-8?B?U3lyasOkbMOk?= Cc: Chad Versace , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Vandana Kannan List-Id: dri-devel@lists.freedesktop.org T24gMTctMDItMjcgMTc6MTM6NDEsIFZpbGxlIFN5cmrDpGzDpCB3cm90ZToKPk9uIFN1biwgRmVi IDI2LCAyMDE3IGF0IDAyOjQxOjUwUE0gLTA4MDAsIENoYWQgVmVyc2FjZSB3cm90ZToKPj4gT24g V2VkIDA0IEphbiAyMDE3LCB2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbSB3cm90ZToKPj4g PiBGcm9tOiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPgo+ PiA+Cj4+ID4gU0tMKyBkaXNwbGF5IGVuZ2luZSBjYW4gc2NhbiBvdXQgY2VydGFpbiBraW5kcyBv ZiBjb21wcmVzc2VkIHN1cmZhY2VzCj4+ID4gcHJvZHVjZWQgYnkgdGhlIHJlbmRlciBlbmdpbmUu IFRoaXMgaW52b2x2ZWQgdGVsbGluZyB0aGUgZGlzcGxheSBlbmdpbmUKPj4gPiB0aGUgbG9jYXRp b24gb2YgdGhlIGNvbG9yIGNvbnRyb2wgc3VyZmFlIChDQ1MpIHdoaWNoIGRlc2NyaWJlcyB3aGlj aAo+PiA+IHBhcnRzIG9mIHRoZSBtYWluIHN1cmZhY2UgYXJlIGNvbXByZXNzZWQgYW5kIHdoaWNo IGFyZSBub3QuIFRoZSBsb2NhdGlvbgo+PiA+IG9mIENDUyBpcyBwcm92aWRlZCBieSB1c2Vyc3Bh Y2UgYXMganVzdCBhbm90aGVyIHBsYW5lIHdpdGggaXRzIG93biBvZmZzZXQuCj4+ID4KPj4gPiBC eSBwcm92aWRpbmcgb3VyIG93biBmb3JtYXQgaW5mb3JtYXRpb24gZm9yIHRoZSBDQ1MgZm9ybWF0 cywgd2Ugc2hvdWxkCj4+ID4gYmUgYWJsZSB0byBtYWtlIGZyYW1lYnVmZmVyX2NoZWNrKCkgZG8g dGhlIHJpZ2h0IHRoaW5nIGZvciB0aGUgQ0NTCj4+ID4gc3VyZmFjZSBhcyB3ZWxsLgo+PiA+Cj4+ ID4gTm90ZSB0aGF0IHdlJ2xsIHJldHVybiB0aGUgc2FtZSBmb3JtYXQgaW5mbyBmb3IgYm90aCBZ IGFuZCBZZiB0aWxlZAo+PiA+IGZvcm1hdCBhcyB0aGF0J3Mgd2hhdCBoYXBwZW5zIHdpdGggdGhl IG5vbi1DQ1MgWSB2cy4gWWYgYXMgd2VsbC4gSWYKPj4gPiBkZXNpcmVkLCB3ZSBjb3VsZCBwb3Rl bnRpYWxseSByZXR1cm4gYSB1bmlxdWUgcG9pbnRlciBmb3IgZWFjaAo+PiA+IHBpeGVsX2Zvcm1h dCt0aWxpbmcrY2NzIGNvbWJpbmF0aW9uLCBpbiB3aGljaCBjYXNlIHdlIGltbWVkaWF0ZWx5IGJl Cj4+ID4gYWJsZSB0byB0ZWxsIGlmIGFueSBvZiB0aGF0IHN0dWZmIGNoYW5nZWQgYnkganVzdCBj b21wYXJpbmcgdGhlCj4+ID4gcG9pbnRlcnMuIEJ1dCB0aGF0IGRvZXMgc291bmQgYSBiaXQgd2Fz dGVmdWwgc3BhY2Ugd2lzZS4KPj4gPgo+PiA+IHYyOiBEcm9wIHRoZSAnZGV2JyBhcmd1bWVudCBm cm9tIHRoZSBob29rCj4+ID4gdjM6IEluY2x1ZGUgdGhlIGRlc2NyaXB0aW9uIG9mIHRoZSBDQ1Mg c3VyZmFjZSBsYXlvdXQKPj4gPgo+PiA+IENjOiBWYW5kYW5hIEthbm5hbiA8dmFuZGFuYS5rYW5u YW5AaW50ZWwuY29tPgo+PiA+IENjOiBEYW5pZWwgVmV0dGVyIDxkYW5pZWxAZmZ3bGwuY2g+Cj4+ ID4gQ2M6IEJlbiBXaWRhd3NreSA8YmVuQGJ3aWRhd3NrLm5ldD4KPj4gPiBDYzogSmFzb24gRWtz dHJhbmQgPGphc29uQGpsZWtzdHJhbmQubmV0Pgo+PiA+IFJldmlld2VkLWJ5OiBCZW4gV2lkYXdz a3kgPGJlbkBid2lkYXdzay5uZXQ+Cj4+ID4gU2lnbmVkLW9mZi1ieTogVmlsbGUgU3lyasOkbMOk IDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KPj4gPiAtLS0KPj4gPiAgZHJpdmVycy9n cHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jIHwgMzYgKysrKysrKysrKysrKysrKysrKysrKysr KysKPj4gPiAgaW5jbHVkZS91YXBpL2RybS9kcm1fZm91cmNjLmggICAgICAgIHwgNDkgKysrKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrCj4+ID4gIDIgZmlsZXMgY2hhbmdlZCwgODUg aW5zZXJ0aW9ucygrKQo+Pgo+Pgo+PiA+IGRpZmYgLS1naXQgYS9pbmNsdWRlL3VhcGkvZHJtL2Ry bV9mb3VyY2MuaCBiL2luY2x1ZGUvdWFwaS9kcm0vZHJtX2ZvdXJjYy5oCj4+ID4gaW5kZXggOWUx YmI3ZmFiY2RlLi40NTgxZTNkNDFlNWMgMTAwNjQ0Cj4+ID4gLS0tIGEvaW5jbHVkZS91YXBpL2Ry bS9kcm1fZm91cmNjLmgKPj4gPiArKysgYi9pbmNsdWRlL3VhcGkvZHJtL2RybV9mb3VyY2MuaAo+ PiA+IEBAIC0yMzAsNiArMjMwLDU1IEBAIGV4dGVybiAiQyIgewo+PiA+ICAjZGVmaW5lIEk5MTVf Rk9STUFUX01PRF9ZZl9USUxFRCBmb3VyY2NfbW9kX2NvZGUoSU5URUwsIDMpCj4+ID4KPj4gPiAg LyoKPj4gPiArICogSW50ZWwgY29sb3IgY29udHJvbCBzdXJmYWNlIChDQ1MpIGZvciByZW5kZXIg Y29tcHJlc3Npb24KPj4gPiArICoKPj4gPiArICogVGhlIGZyYW1lYnVmZmVyIGZvcm1hdCBtdXN0 IGJlIG9uZSBvZiB0aGUgODo4Ojg6OCBSR0IgZm9ybWF0cywKPj4gPiArICogdGhlIG1haW4gc3Vy ZmFjZSB3aWxsIGJlIHBsYW5lIGluZGV4IDAgYW5kIHdpbGwgYmUgWS9ZZi10aWxlZCwKPj4gPiAr ICogdGhlIENDUyB3aWxsIGJlIHBsYW5lIGluZGV4IDEuCj4+ID4gKyAqCj4+Cj4+IFRoZSBwYXJh Z3JhcGggYmVsb3cgaXMuLi4KPj4KPj4gPiArICogRWFjaCBieXRlIG9mIENDUyBjb250YWlucyA0 IHBhaXJzIG9mIGJpdHMsIHdpdGggZWFjaCBwYWlyIG9mIGJpdHMKPj4gPiArICogbWF0Y2hpbmcg YW4gYXJlYSBvZiA4eDQgcGl4ZWxzIG9mIHRoZSBtYWluIHN1cmZhY2UuIFdoaWNoIHdvdWxkIHNl ZW0KPj4gPiArICogdG8gbWF0Y2ggMiBjYWNoZWxpbmVzIGNvbnRhaW5pbmcgNHg0IHBpeGVscyBl YWNoLiBUaGUgcGFpcnMgYml0cyB3aXRoaW4KPj4gPiArICogdGhlIGJ5dGUgZm9ybSBhIDJ4MiBn cmlkLCB3aGljaCB0aHVzIG1hdGNoZXMgYSAxNng4IHBpeGVsIGFyZWEgb2YgdGhlCj4+ID4gKyAq IG1haW4gc3VyZmFjZS4gVGhpcyBpcyB0aGUgMngyIHBhdHRlcm4gdGhlIGJpdHMgZm9ybSAoMD1s c2IsIDc9bXNiKToKPj4gPiArICogLS0tLS0tLS0tLS0KPj4gPiArICogfCAwMSB8IDIzIHwKPj4g PiArICogIC0tLS0tLS0tLS0KPj4gPiArICogfCA0NSB8IDY3IHwKPj4gPiArICogLS0tLS0tLS0t LS0KPj4KPj4gLi4uYWxtb3N0IGNvcnJlY3QuIFRoZSBodyBkb2NzIHN0YXRlIHRoYXQgZWFjaCBi aXQtcGFpciBvZiB0aGUgQ0NTIG1hcHMKPj4gY2FjaGVsaW5lLXBhaXIsIGhvcml6b250YWxseSBh ZGphY2VudCBpbiB0aGUgWSB0aWxlLCBvZiB0aGUgcHJpbWFyeSBzdXJmYWNlLiBBcwo+PiBhIGNv bnNlcXVlbmNlLCB0aGUgcmVtYWluZGVyIG9mIHRoZSBhYm92ZSBwYXJhZ3JhcGggaXMgY29ycmVj dCBmb3IgMzItYml0Cj4+IGZvcm1hdHMsIGJ1dCBub3Qgb3RoZXJzLgo+Cj5XaGljaCBpcyB3aHkg dGhlIGNvbW1lbnQgc2F5cyBhdCB0aGUgdmVyeSB0b3AgdGhhdCB0aGUgZmIgbmVlZHMgdG8KPnVz ZSBhIDg6ODo4OjggZm9ybWF0LiBJSVJDIHRoYXQncyB0aGUgb25seSB0aGluZyB0aGUgaGFyZHdh cmUgc3VwcG9ydHMuCj4KCkl0IGlzLCBhbmQgaXQgaXMgZm9yIHRoZSBmb3Jlc2VlYWJsZSBmdXR1 cmUgdG9vLiBDaGFkLCBncmFudGVkIHlvdSBzYXkgdGhpcwppc24ndCBhIG5pdHBpY2sgYmVsb3cs IGJ1dCBpdCBpcyBiZWNhdXNlIFZpbGxlJ3MgcGF0Y2ggaXMgZm9yIHRoZSBLTVMgY2FzZSwgaXQn cwpub3QgZW50aXJlbHkgcmVsZXZhbnQgaGVyZS4KCgo+Pgo+PiBUaGlzIGlzIG5vdCBhIG5pdHBp Y2ssIGJlY2F1c2UgVnVsa2FuIGFuZCBFR0wgdXNlcnMgbWF5IHdhbnQgdG8gc2hhcmUKPj4gZG1h X2J1ZnMgd2l0aCBhIGZhdCBmb3JtYXQgbGlrZSBSMzJHMzJCMzJBMzJfVU5PUk0sIGFuZCB3YW50 IHRvIGhhdmUgQ0NTCj4+IGVuYWJsZWQgd2hlbiBwb3NzaWJsZS4gQXMgbG9uZyBhcyB0aGUgdXNl cnMgdXNlIHRoZSBkbWFfYnVmIG9ubHkgdGhlIDNECj4+IGVuZ2luZSwgYW5kIGRvbid0IHN1Ym1p dCBpdCB0byBLTVMsIGl0J3MgYWxsIHNhZmUuCj4+Cj4+IEZvciB0aG9zZSB1c2Vycywgd2Ugc2hv dWxkIGRvY3VtZW50IHRoZSBiaXQtcGFpci9jYWNoZWxpbmUtcGFpciByZWxhdGlvbnNoaXAKPj4g Y29ycmVjdGx5LiBBbmQgdGhlbiBwcmVmYWNlIHRoZSBmb2xsb3dpbmcgZGV0YWlsZWQgZXhwbGFu YXRpb24gYW5kIG5pY2UgYXNjaWkKPj4gZGlhZ3JhbXMgYnkgc2F5aW5nICJ0aGlzIGFwcGxpZXMg b25seSB0byB0aGUgMzItYml0IGZvcm1hdHMiLgo+Pgo+PiBIZXJlJ3MgdGhlIHJlbGV2YW50IFBS TSBxdW90ZToKPj4KPj4gICAgICBUaGUgQ29sb3IgQ29udHJvbCBTdXJmYWNlIChDQ1MpIGNvbnRh aW5zIHRoZSBjb21wcmVzc2lvbiBzdGF0dXMKPj4gICAgICBvZiB0aGUgY2FjaGUtbGluZSBwYWly cy4gVGhlIGNvbXByZXNzaW9uIHN0YXRlIG9mIHRoZSBjYWNoZS1saW5lCj4+ICAgICAgcGFpciBp cyBzcGVjaWZpZWQgYnkgMiBiaXRzIGluIHRoZSBDQ1MuICBFYWNoIENDUyBjYWNoZS1saW5lCj4+ ICAgICAgcmVwcmVzZW50cyBhbiBhcmVhIG9uIHRoZSBtYWluIHN1cmZhY2Ugb2YgMTZ4MTYgc2V0 cyBvZiAxMjggYnl0ZQo+PiAgICAgIFktdGlsZWQgY2FjaGUtbGluZS1wYWlycy4gQ0NTIGlzIGFs d2F5cyBZIHRpbGVkLgo+Pgo+PiBTZWUgdGhpcyBNZXNhIGNvbW1lbnQgZm9yIG1vcmUgZGV0YWls czoKPj4gaHR0cHM6Ly9jZ2l0LmZyZWVkZXNrdG9wLm9yZy9tZXNhL21lc2EvdHJlZS9zcmMvaW50 ZWwvaXNsL2lzbC5jP2g9MTcuMCNuMjExCj4+Cj4+ID4gKyAqIEFjdHVhbGx5IG9ubHkgdGhlIGxv d2VyIGJpdCBvZiB0aGUgcGFpciBzZWVtcyB0byBoYXZlIGFueSBlZmZlY3QuCj4+ID4gKyAqIE5v IGlkZWEgd2h5LiAwIGluIHRoZSBsb3dlciBiaXQgd291bGQgc2VlbSB0byBtZWFuIG5vdCBjb21w cmVzc2VkLAo+PiA+ICsgKiBhbmQgMSBpcyBjb21wcmVzc2VkLiAgVGhlIGludGVycHJlYXRpb24g b2YgdGhlIG1haW4gc3VyZmFjZSBkYXRhCj4+ID4gKyAqIHdoZW4gdGhlIGJsb2NrIGlzIG1hcmtl ZCBjb21wcmVzc2VkIGlzIHVua25vd24gYXMgb2Ygbm93Lgo+Pgo+PiBJZiBJIHJlY2FsbCBjb3Jy ZWN0bHkgKGl0J3MgYmVlbiBzZXZlcmFsIG1vbnRocyBzaW5jZSBJIGluc3BlY3RlZCB0aGUKPj4g Yml0cyksIHRoZSBoaWdoIGJpdCBpcyBhY3R1YWxseSBzaWduaWZpY2FudC4gQml0IHBhdHRlcm4g MTEgbWVhbnMgdGhhdAo+PiB0aGUgZGF0YSBpbiBwcmltYXJ5IHN1cmZhY2UncyBjYWNoZWxpbmUt cGFpciBpcyBpbnZhbGlkOyB0aGUgM0QgZW5naW5lCj4+IGludGVycHJldHMgdGhlIGNvbG9yIG9m IGFsbCBwaXhlbHMgaW4gdGhhdCBjYWNoZWxpbmUtcGFpciB0byBiZSB0aGUKPj4gY2xlYXIgY29s b3Igc3RvcmVkIGluIFJFTkRFUl9TVVJGQUNFX1NUQVRFLiBCZWZvcmUgdGhlIGRpc3BsYXkgZW5n aW5lCj4+IGNhbiBjb25zdW1lIHRoZSBzdXJmYWNlLCB1c2Vyc3BhY2UgaXMgcmVxdWlyZWQgdG8g ZG8gYSBwYXJ0aWFsIHJlc29sdmUsCj4+IGZsdXNoaW5nIHRoZSBjbGVhciBjb2xvciBpbnRvIHRo ZSBwcmltYXJ5IHN1cmZhY2UuIFNvIGl0IG1ha2VzIHNlbnNlCj4+IHRoYXQgdGhlIGtlcm5lbCB3 b3VsZCBuZXZlciBvYnNlcnZlIHRoYXQgYml0IHBhdHRlcm4gaW4gYW4gaW5jb21pbmcgY2NzCj4+ IHN1cmZhY2UsIGFzIGxvbmcgYXMgdXNlcnNwYWNlIGlzIGRvaW5nIGl0cyBqb2IgY29ycmVjdGx5 LiBBbmQgaXQgbWFrZXMKPj4gc2Vuc2UgdGhhdCB0aGUgZGlzcGxheSBlbmdpbmUgd291bGQgaWdu b3JlIHRoZSBoaWdoIGJpdCwgYmVjYXVzZSB0aGVyZSBpcwo+PiBubyB3YXkgdG8gcHJvdmlkZSB0 aGUgY2xlYXIgY29sb3IgdG8gdGhlIGRpc3BsYXkgZW5naW5lIChhdCBsZWFzdAo+PiBhY2NvcmRp bmcgbXkgcmVhZGluZyBvZiB0aGUgZG9jcykuCj4+Cj4+IEphc29uLCBkb2VzIHRoaXMgbWF0Y2gg eW91ciB1bmRlcnN0YW5kaW5nIG9mIHRoZSBoaWdoIGJpdD8KPj4KPj4gPiArICoKPj4gPiArICog Q0NTIHRpbGUgaXMgbGFpZCBvdXQgaW4gOCBieXRlIGhvcml6b250YWwgc3RyaXBzIGVhY2ggc3Ry aXAgdGh1cyBjb3JyZXNwb25kcwo+PiA+ICsgKiB0byBhIDEyOHg4IHBpeGVsIGFyZSBvZiB0aGUg bWFpbiBzdXJmYWNlLiBTbyBlYWNoIDh4OCBieXRlcyBvZiB0aGUgQ0NTCj4+ID4gKyAqICgxIGNh Y2hlbGluZSkgd2lsbCBtYXRjaCBhbiBhcmVhIG9mIDR4MiB0aWxlcyBvbiB0aGUgbWFpbiBzdXJm YWNlLgo+PiA+ICsgKgo+PiA+ICsgKiBIZXJlIGlzIHRoZSBsYXlvdXQgb2YgYSBmdWxsIENDUyB0 aWxlLCB3aXRoIHRoZSA4IGJ5dGUgc3RyaXBzIG51bWJlcmVkIDAtNTExOgo+PiA+ICsgKiAtLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0KPj4gPiArICogfCAgMCB8ICA2NCB8IC4uLiB8IDQ0OCB8Cj4+ ID4gKyAqIHwgIDEgfCAgNjUgfCAgICAgfCA0NDkgfAo+PiA+ICsgKiB8ICAyIHwgIDY2IHwgICAg IHwgNDUwIHwKPj4gPiArICogfCAgLiB8ICAgLiB8ICAgICB8ICAgLiB8Cj4+ID4gKyAqIHwgIC4g fCAgIC4gfCAgICAgfCAgIC4gfAo+PiA+ICsgKiB8ICAuIHwgICAuIHwgICAgIHwgICAuIHwKPj4g PiArICogfCA2MyB8IDEyNyB8ICAgICB8IDUxMSB8Cj4+ID4gKyAqIC0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLQo+PiA+ICsgKgo+PiA+ICsgKiBUaGlzIHdpbGwgbWF0Y2ggYW4gYXJlYSBvZiAxMDI0 eDUxMiBwaXhlbHMgb24gdGhlIG1haW4gc3VyZmFjZS4KPj4gPiArICoKPj4gPiArICogVGhlIEND UyBwbGFuZSBwaXRjaCBtdXN0IGJlIGEgbXVsdGlwbGUgb2YgdGhlIENDUyB0aWxlIHdpZHRoICg2 NCBieXRlcyksCj4+ID4gKyAqIGFuZCBmb3IgdGhlIHB1cnBvc2VzIG9mIHRoZSBDQ1MgcGxhbmUg b2Zmc2V0IHdlIGFzc3VtZSBjcHA9PTEuIEFzIGVhY2gKPj4gPiArICogYnl0ZSBtYXRjaGVzIGEg MTZ4OCBhcmVhIG9mIHRoZSBtYWluIHN1cmZhY2UsIHRoZSBkaW1lbnNpb25zIG9mIHRoZSBDQ1MK Pj4gPiArICogcGxhbmUgd2lsbCB0aHVzIGFwcGVhciB0byBiZSB3aWR0aC8xNiB4IGhlaWdodC84 LiBCb3RoIHBsYW5lcyBtdXN0IGJlCj4+ID4gKyAqIGNvbnRhaW5lZCB3aXRoaW4gdGhlIHNhbWUg Z2VtIG9iamVjdC4KPj4KPj4gQWdhaW4sIHRoZSBhYm92ZSBwYXJhZ3JhcGhzIHNob3VsZCBjbGFy aWZ5IHRoYXQgdGhleSBhcHBseSBvbmx5IHRvIDMyLWJpdCBmb3JtYXRzLgo+Pgo+PiA+ICsgKi8K Pj4gPiArI2RlZmluZSBJOTE1X0ZPUk1BVF9NT0RfWV9USUxFRF9DQ1MJZm91cmNjX21vZF9jb2Rl KElOVEVMLCA0KQo+PiA+ICsjZGVmaW5lIEk5MTVfRk9STUFUX01PRF9ZZl9USUxFRF9DQ1MJZm91 cmNjX21vZF9jb2RlKElOVEVMLCA1KQo+Cj4tLSAKPlZpbGxlIFN5cmrDpGzDpAo+SW50ZWwgT1RD Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdm eCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xp c3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=